GitLab

This CL componentizes ExternalNavigation{Delegate, Handler} for reuse
by WebLayer. After a long series of leadup CLs cleaning the files of
//chrome dependencies, the componentization is straightforward.

In this CL we avoid changing any names within the moved files to keep
the CL as targeted as possible. A followup CL will generalize
references to "Chrome" in names and comments within these files.
Followup work will also componentize ExternalNavigationHandlerTest.

This CL also tightens an overly-aggressive presubmit check that fired
here.

Bug: 1031465
Change-Id: Ic50518242c62690cf57249a613860332ef13e0f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096702Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749645}

Do not call BindCacheStorageInternal until we have a COEP reporter to
pass to RPH::BindCacheStorage.

Change-Id: I25fd317cbcd6fd84d924472ca73facc007b50c71
Bug: 1060980
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100056
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749644}

As a part of turning down Built-in Modules in Blink.

This CL also removes built-in modules/fallback support from
import maps.
After this CL, the non-virtual WPT tests will run against
import maps without built-in modules support, and thus
virtual/import-maps-without-builtin-modules tests are removed.

Bug: 829084, 848607
Change-Id: Ic57c9ee3aac77d882ef08ba6b02c288a371fe537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096165
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749643}

This base should be treated as an internal device.

Bug: b/150268720
Change-Id: Ib92a7532189a7fa0b23c10bd056e47776d786add
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100196
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749642}

This cl also
* adds show_in_launcher to SystemAppInfos
* reads show_in_launcher in extension_apps.cc
* adds tests to SystemWebAppManagerBrowserTest and MediaAppIntegrationBrowserTest

Bug: b/150831266, 877898, 1054195

Change-Id: Iff6128bf858071906cdc9e961cef717d91354854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097799
Commit-Queue: David Lei <dlei@google.com>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749641}

We'd like to use some SQLite features currently disabled in Chrome
in a developer trace-analyzing tool called trace_processor_shell.
As discussed on the thread [1], it's undesirable to enable them
Chrome-wide.

This CL adds an "sqlite_dev" build target and third_party/sqlite/dev
include directory with a separate sqlite library that has most of the
features enabled.

[1] https://groups.google.com/a/chromium.org/g/storage-dev/c/OkwAfpYWAa0

Bug: b/150127983, b/150125501
Change-Id: If328bb737679b6d352904bcb543bc6ed1c522b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082389Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#749640}

https://chromium.googlesource.com/angle/angle.git/+log/84780f7dc5e1..40c7a20f9bf9

git log 84780f7dc5e1..40c7a20f9bf9 --date=short --first-parent --format='%ad %ae %s'
2020-03-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 2ff8b6a6f4d5..be663d752e45 (8 commits)
2020-03-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src e2176c91b23c..9b620aa0c12d (2 commits)
2020-03-12 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 136207a63495..29adf277cb19 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@40c7a20f9bf9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jmadill@google.com
Change-Id: I0b3c9964f9607fb42d9b78d3f269b51dd0a0b6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099215Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749639}

Begin cookie settings redesign by replacing the two toggles with a
four-state preference, hidden behind a flag. Adjust tests to use the new
four-state preference.
https://screenshot.googleplex.com/r22q4q6hH7O.png

Bug: 1060118
Change-Id: I5f660b473112e8ab688b8ac5604f8bcceb7f35a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095124
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749638}

After the CL https://crrev.com/c/2096712 moved side-effect checking
for auto-complete suggestions completely to V8, we can
re-enable the corresponding web test again.

Please note that accessing iframe is currently considered
side-effecting by V8, so we don't get any auto-complete suggestions
when typing "iframeName.", thus, we need to update the tests
expectations.

R=petermarshall@chromium.org

Bug: chromium:1031243
Change-Id: I32b1fb391a0d49785bb2ad17c5d763a35e2a8282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098725Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749637}

If a main frame is COOP and a cross origin iframe tries to open a
popup, that popup will have the noopener attribute. When that's the
case, the popup should not have any name, and any parameter set during
its creation should be ignored.

Bug: 1060691
Change-Id: Ibb73a4b0fcf6b9d40041ed6534a8fafd8a90b499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098702
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749636}

With this CL, the error case "Too many passwords" will no longer offer
to check passwords in the account for users that are:
- not syncing
- syncing but use a passphrase.

If no check can be offered, always show the total count of found leaks.
screenshots can be found at https://crbug.com/1047726#c58

Translation screenshot for
IDS_SETTINGS_CHECK_PASSWORDS_ERROR_INTERRUPTED_TOO_MANY_PASSWORDS:
https://storage.cloud.google.com/chromium-translation-screenshots/cf5f1e0f138864731990c89272cb55030f2e380b

Bug: 1047726
Change-Id: I4142b1ef3912c15155484000ca305d488ded0dd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096708
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749635}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/55e6902b..ee72e718

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I20e20d6e46df67b8c39564c3386674bbe51d3477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100210Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749634}

This default-enable the TrustedDOMTypes feature, which so far required
either experimental web platform features support or an explicit enable.

Intent-to-ship w/ LGTM: https://groups.google.com/a/chromium.org/g/blink-dev/c/Il-wfnw9TAw

Bug: 739170
Change-Id: I02ab70dc2e98d8ca2f7aab1c3b8354e789d04f80
Soundtrack: youtu.be/IlN1pZqO8Zo
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095548Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749633}

...and make chromedriver part of the android build independent
of target_cpu since that should now work.

A target can be built with multiple toolchains. For example, in an Android
build, the host toolchain could be a 64-bit intel linux toolchain, while
the target toolchain could be a 32-bit arm android toolchain.

The openh264 build file used to check `is_linux || is_win` (which tests
the currently active toolchain for being linux or windows)
but `target_cpu == "x86"` (which tested the CPU of the target toolchain).

As a consequency, when building 32-bit intel android binaries with
a 64-bit intel host toolchain, openh264 used 32-bit intel assembly
for both the 32-bit target build (good) and for the 64-bit host
build (bad).

To fix, use current_cpu instead of target_cpu.

TBR=sprang (who lgtm'd on the review but doesn't have +1 permissions yet)

Bug: 1058550
Change-Id: Id7e46e2767cb0ae66f9438976bbfbc2161ce700b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097511Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749632}

This reverts commit d1549df6.

Reason for revert: First version broke some CredentialManagerBrowserTests on "Network Service Linux" due to a missing call to CertVerifierBrowserTest::SetUpInProcessBrowserTestFixture(); the reland fixes that.

Original change's description:
> Revert "Add a first integration test involving both Sync and PasswordManager"
>
> This reverts commit 546fc2fa.
>
> Reason for revert: [Sheriff] This causes failures https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/2304
>
> Original change's description:
> > Add a first integration test involving both Sync and PasswordManager
> >
> > The test sets up Sync-the-transport, has the user opt-in to the account
> > password storage, and makes sure that saves go to the correct store.
> >
> > This requires a few changes to password_manager_test_base.h/cc:
> > - Most notably: The password manager tests used to set up a
> >   MockPasswordFeatureManager (in order to make IsGenerationEnabled()
> >   return true), but the new combined tests require a real
> >   PasswordFeatureManager. So this CL removes the mock (which also lets
> >   us remove CustomPasswordManagerClient), and instead sets up a
> >   TestSyncService which claims "everything is active" and so also makes
> >   IsGenerationEnabled() true.
> > - Some simple refactorings to avoid duplicating test setup code:
> >   - Split the "GetNewTab" part out of SetUpOnMainThreadAndGetNewTab(),
> >     into a new static helper.
> >   - Exposed PasswordStoreResultsObserver (it used to be fully defined
> >     in the .cc).
> >   - Exposed a version of CheckThatCredentialsStored() that takes a
> >     PasswordStore parameter.
> >
> > Bug: 1058339
> > Change-Id: If9b040cbd56ee10ba6b6badd1b4b4d772603f13a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089825
> > Commit-Queue: Marc Treib <treib@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#749220}
>
> TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org
>
> Change-Id: Ifb6bdf160c9b53d2b1b50bdaef69389668376910
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1058339
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098705
> Reviewed-by: Kamila Hasanbega <hkamila@google.com>
> Commit-Queue: Kamila Hasanbega <hkamila@google.com>
> Cr-Commit-Position: refs/heads/master@{#749602}

Change-Id: Ic1070e16f13cd27597db9b4e5f9a28014fe9b9b2
Bug: 1058339, 1060968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098669
Commit-Queue: Marc Treib <treib@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749631}

This CL records a user action when the user clicks on save in the
encryption option in chrome://settings/syncSetup to encrypt data with a
custom passphrase. This metric is needed for sync setup friendly
settings.

Bug: 1050070
Change-Id: I3a8b0e5f9ca0e737172ef7b3206828533733e0f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096738Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749630}

This CL introduces new class for invalidation Topics, it's temporary
called TopicData, but will be renamed to Topic once legacy Topic alias
usages will be removed.

TopicData contains topic name and a boolean to identify whether topic
is public. It would allow us to simplify external API and clean up
internal usages of Topics - having TopicMetadata and Topics in some
places and Topic names and TopicSet in other places is confusing.

This CL modifies
InvalidatorRegistrarWithMemory::UpdateRegisteredTopics() to use the new
class. Internal usages in InvalidatorRegistrarWithMemory also updated,
but a bunch of methods exposes old Topics, because they are used
outside components/invalidation and it's better to update them on later
stages.

There is one potential behavioral change in case of existing bug in the
code: topics subscriptions were stored in prefs without |is_public|
field, before migration was introduced in
https://cr-rev.appspot.com/c/1570963. This migration assumes that all
previously stored topics are private and likely happened when there was
no public topics in launched projects. If this statement isn't
accurate, then there is a behavioral change:
Before: public topic subscription loaded from legacy prefs, the code
assumes it's a private topic until the same topic is passed into
UpdateInterestedTopics().
After: buggy version of public topic remains in "interesting" state,
once UpdateInterestedTopics() is called with correct TopicData there
are two version of this Topic (one is private (buggy) and one is public
(correct)).
It happens because |is_public| become a part of Topic identifier.

Bug: 1029698
Change-Id: I8febb82aa7f0294ccb4198467f5bd0f56bbd5798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091351
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749629}

Bug: 1045348
Change-Id: Iec6d4635a62e518c7b0f7b45df2440e2ba819f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098666Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749628}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a5e36d303614..9841983ed0df

git log a5e36d303614..9841983ed0df --date=short --first-parent --format='%ad %ae %s'
2020-03-12 szuend@chromium.org [network] Clicking on 'View Headers' actually opens the 'Headers' tab

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@9841983ed0df

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1060136
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I2dd928d2969a7002b0ed2d348aa4c7dc048cb796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099212Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749627}

https://webrtc.googlesource.com/src.git/+log/2896bf697b66..f092e4d0ff25

git log 2896bf697b66..f092e4d0ff25 --date=short --first-parent --format='%ad %ae %s'
2020-03-12 mbonadei@webrtc.org Reland "Whitespace change to kick bots."

Created with:
  gclient setdep -r src/third_party/webrtc@f092e4d0ff25

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I68889cbe655eae9940de9aabec5c562b6ae41139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099216Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749626}

Migrate all uses of ui::mojom::CursorType to
ui::mojom::blink::CursorType.

Bug: 1040499
Change-Id: Ia7ce830df3d86cb6a841bcb1b2e20080bd131eac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100307Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#749625}

Change welcome screen content for reauthentication flow.

Bug: 1043108
Change-Id: I31a9f3ed0fbe49353c8a983c3d366d2fd40fe7fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089779
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749624}

This CL adds tests to check the support of COEP reporting for requests
initiated by a dedicated worker. So far, Chrome has a bug that the
context url is the page's url where the dedicated worker is created.
This bug is going to be fixed once PlzDedicatedWorker is shipped (with
additional work for integration between PlzDedicatedWorker and COEP
reporting).

Bug: 1060837
Change-Id: I12291646c4d5a80d89c8894548acdb186f4a14be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100059
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749623}

This CL expands the Fetch API, when the runtime-enabled feature
"TrustTokens" is enabled, to include a new experimental parameter
`trustTokens` denoting a request to execute a Trust Tokens protocol step
(https://github.com/wicg/trust-token-api) alongside the fetch at hand,
by adding request headers and processing corresponding response
headers.

This is an experimental interface that will be used in an origin trial.
It only needs to support fetches from frames (i.e., it is OK from a
usability perspective for the origin trial if the parameter is not
populated when fetch is called from other settings).

The main parts of the CL are:
- as specified in the linked explainer, expand Fetch's RequestInit
dictionary with a new trustToken parameter, specifying a single Trust
Tokens protocol operation of token issuance, token redemption, or
request signing;
- add this data to blink::ResourceRequest and associated objects, so
that it gets copied to network::ResourceRequest in
blink::PopulateResourceRequest.

Test:
- Adds integration tests in //content to ensure that calling the API
results in the right ResourceRequest members being populated.

Change-Id: I5c5b0c0ed5450eeb80c19be856f62941e50ec0e1
Bug: 1043118
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036648Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749622}

The logic to execute a task on a timer, persisted across Chrome
restarts, already existed in account_fetcher_service.
This CL extracts it in a new class, and reuses it in ProfileInfoCache.

The metric is not loaded exactly at the same time it was before:
it used to be logged for each profile, but now it's logged per Chrome
run. This makes more sense given the nature of the metric.

Fixed: 1060096
Change-Id: I5b8c709f088709934b8ad54fa9a46fac091923cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096743
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749621}

Before this patch, Dev Tools logged only the |can_make_payment| field of
CanMakePaymentResponsePtr struct, making web developer's debugging
experience difficult.

This patch logs all of the fields of the CanMakePaymentResponsePtr
struct in Dev Tools, given that
chrome://flags/#enable-web-payments-minimal-ui flag is enabled.

After this patch, web developers can easily inspect the "canmakepayment"
response from a payment handler in Dev Tools.

Bug: 1005076
Change-Id: Ifa0456bc14c59c704baba1c6fe082972b15c7058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091648
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749620}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I642e5df90dca224fef3acf043b2de0a0fc79f674
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749619}

Pointers are only guaranteed to be castable to an integer of at least
the same size.

Bug: 1059231
Change-Id: Ie439b00343afb95b33d32dd247ff08bfeee91db7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098571
Auto-Submit: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749618}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/905a6de3705f..7e5def0b4eb6


Created with:
  gclient setdep -r src-internal@7e5def0b4eb6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I5a34001cce0a261a3be7d41b6110e75f52002e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100241Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749617}

CrossOriginIsolation was introduced to control the launch of COOP and COEP, and
both features were developed behind that flag. COEP has been approved to launch
in M82
(https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XBKAGb2_7uAi)
while COOP is still missing some approval. In order to ensure that COEP
launches in M82, this CL splits the flag into two: CrossOriginEmbedderPolicy
and CrossOriginOpenerPolicy. It also enables CrossOriginEmbedderPolicy by
default.

Bug: 922191, 887967
Change-Id: I26289cd1d84ebb6056afa6d56b99a6f7f38037ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096560Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749616}

As a part of turning down Built-in Modules in Blink.

Bug: 829084, 979108
Change-Id: Ie127cafa7c198447ca8548c5a1cb176081d728e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096068
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749615}

Bug: none
Test: tast run <DUT> CCAUI*
Change-Id: Iebc496e5d8b82b8b140a3b54221f5366cb479562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097782Reviewed-by: Wei Lee <wtlee@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>
Commit-Queue: Kuo Jen Wei <inker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749614}

Bug: 1034842
Change-Id: I531624ef20a3c03eb62c25b6bfc97f3864a45b09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100147
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749613}

This patch is initiated from the review comment[1].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1144587/13/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc@89

Bug: none
Change-Id: I2be17d7e83dd6afad1b2c3ca059460ba1bc6fe06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099685Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#749612}

This feature is approved for all channels starting with M81.

Launch Bug: crbug/1019997

Bug: b/148647596
Change-Id: I50c5f9f36144b3f4a778155e2bb82ceb77d08c82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098784Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749611}

Following bot results are included.
1693 1694

5 lines were removed and 0 lines were deflaked by consecutive
results since 1674.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: I8645e21d82d4fddcd4ffb6f7e93621c14273dc11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100169Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749610}

IDL attributes of type Nullable (e.g. "long?") are currently
implemented as:

  int32_t attrName(bool& is_null);
  void setAttrName(int32_t value, bool is_null);

however, the following APIs are preferable.

  base::Optional<int32_t> attrName();
  void setAttrName(base::Optional<int32_t> value);

In order to update bindings APIs of IDL attributes,
this patch adds the base::Optional version.

Once the bindings generator switches to the new APIs, the
old explicit is_null version will be removed.

Bug: 1060971, 839389
Change-Id: Iad728b1b9a7a289dcfa4f637cb84304ff48c4cf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059032Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749609}

This reverts commit 5a7d3fed.

Reason for revert: [Sheriff] Reverting for now, as I suspect the cl is causing failures in https://ci.chromium.org/p/chromium/builders/ci/Fuchsia%20x64/b8886078290056207296

Original change's description:
> [Fuchsia] Implement Frame/SetPermissionState()
> 
> Now WebEngine implements SetPermissionState() which allows to grant
> permissions for web features.
> 
> Bug: 922833
> Change-Id: I356e54646ad870bb7882a5b9a95bc87deccba453
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058086
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: David Dorwin <ddorwin@chromium.org>
> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749428}

TBR=ddorwin@chromium.org,wez@chromium.org,mlamouri@chromium.org,sergeyu@chromium.org

Change-Id: Ib7f824e173044474d281705b865ba8072becd8e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 922833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098787Reviewed-by: Kamila Hasanbega <hkamila@google.com>
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Cr-Commit-Position: refs/heads/master@{#749608}

This gets us off the hook from fixing failures in a build config which
is not well tested upstream, reduces the package build time, and
simplifies our build script.

It also make thinlto faster, due to lld now being built with PGO
(although we don't train on lld, it benefits from the training on clang).

Bug: 884608, 949626
Change-Id: I55859efbde9071da72c1057765d0d1900e069eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095544Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749607}

Before this patch, payment_app_provider_impl.cc cleared the
|ready_for_minimal_ui| and |account_balance| fields of
CanMakePaymentResponsePtr before forwarding the struct the service
worker payment app factories.

This patch validates the |account_balance| field of the
CanMakePaymentResponsePtr struct and forwards to the payment app
factories either the valid unchanged struct or a blank struct in case of
validation failure.

After this patch, the service worker payment app factories receive the
full validated CanMakePaymentResponsePtr struct from the renderer.

Bug: 1005076
Change-Id: I27c3b07e29804cce0b52ae7f137225007dfe4853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091647
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749606}