GitLab

Review URL: https://codereview.chromium.org/657493002

git-svn-id: svn://svn.chromium.org/blink/trunk@183793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=400937
R=eustas, pfeldman

Review URL: https://codereview.chromium.org/657873002

git-svn-id: svn://svn.chromium.org/blink/trunk@183790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=363099,371084
TBR=mkwst@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/659013002

git-svn-id: svn://svn.chromium.org/blink/trunk@183789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL more or less rewrites the parser with the goal of improving our
adherence to the spec. We now have reasonable error messages for parse
failures, and have tests for the individual components of the parser
(algorithms and digests). We also now correctly require 'ni:///' as the
URL prefix (we were previously ignoring the last '/').

BUG=355467

Review URL: https://codereview.chromium.org/656063002

git-svn-id: svn://svn.chromium.org/blink/trunk@183788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We started sending accessibility events to the frame client instead of
the view client, to prepare for site isolation. However, a single
AXObjectCache still spans all *local* frames, so accessibility events
should be fired on the axObjectCacheOwner's frame, not on the event
target's frame.

BUG=424046

Review URL: https://codereview.chromium.org/637223005

git-svn-id: svn://svn.chromium.org/blink/trunk@183787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bindings gyp files support but gn files are old and doesn't support binding modularization. e.g.
- create WindowCoreConstructors.idl and WindowModulesConstructors.idl instead of WindowConstructors.idl,
- ditto (SharedWorkderGlobalScope, DedicatedWorkerGlobalScope, ServiceWorkerGlobalScope).

BUG=358074

Review URL: https://codereview.chromium.org/633913002

git-svn-id: svn://svn.chromium.org/blink/trunk@183786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=424021
NOTRY=true

Review URL: https://codereview.chromium.org/658043002

git-svn-id: svn://svn.chromium.org/blink/trunk@183785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This uncheck causes crash when selecting inside HTMLTextFormElement and either start 
or end node element doesn't have a renderer.

BUG=404560

Review URL: https://codereview.chromium.org/610323003

git-svn-id: svn://svn.chromium.org/blink/trunk@183784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=machenbach@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/659933002

git-svn-id: svn://svn.chromium.org/blink/trunk@183783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=399090

Review URL: https://codereview.chromium.org/657243002

git-svn-id: svn://svn.chromium.org/blink/trunk@183782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To be compliant to the WHATWG Encoding spec (living standard), we should
treat ISO-8859-1 and windows-1252 synonymously. Moreover, windows-1252
is the canonical encoding name.

Update TextCodecLatin1 to list only aliases specified in the encoding
spec.

See https://codereview.chromium.org/598383002 (ICU update) and
    https://codereview.chromium.org/649413002 (roll ICU with necessary
    test/pref/UI changes in Chrome).

BUG=412053
TEST=fast/encoding/*
TEST=http/tests/misc/char*
R=jochen@chromium.org, jsbell@chromium.org

Review URL: https://codereview.chromium.org/655083002

git-svn-id: svn://svn.chromium.org/blink/trunk@183781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds an update scope and instruments call sites which require an up-to-date
current time or modify the play state. Tracing now displays spans for the pending
and running phases.

BUG=351446

Review URL: https://codereview.chromium.org/638313002

git-svn-id: svn://svn.chromium.org/blink/trunk@183780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=183777

BUG=422050
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/644323004

git-svn-id: svn://svn.chromium.org/blink/trunk@183779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In this CL https://codereview.chromium.org/652663003/ MeterRole is not added to
computeAccessibilityIgnored().
So, adding that change in this CL.

BUG=421376

Review URL: https://codereview.chromium.org/653283003

git-svn-id: svn://svn.chromium.org/blink/trunk@183778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test is reporting PASS on the Mac 10.6 try bot.

TBR=dstockwell@chromium.org
NOTRY=true
BUG=422050

Review URL: https://codereview.chromium.org/661643003

git-svn-id: svn://svn.chromium.org/blink/trunk@183777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The clients/callers of updateGraphicsContext(...) already independently
compute the same transform as computeResourceSpaceTransform(...). This
means that we can get rid of the latter in favor of the computations in the
callers - who just need to set up an AffineTransform and pass to
updateGraphicsContext(...).
This allows getting rid of the ApplyToTextMode resource-mode flag, and
doing so allows converting the RenderSVGResourceMode enum to a non-bitmask
such - and remove RenderSVGResourceModeFlags.

BUG=420022

Review URL: https://codereview.chromium.org/655263002

git-svn-id: svn://svn.chromium.org/blink/trunk@183776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=ojan@chromium.org, jparent@chromium.org, iannucci@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_gn_rel,linux_chromium_rel_swarming

Review URL: https://codereview.chromium.org/657233003

git-svn-id: svn://svn.chromium.org/blink/trunk@183775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For compositng mode that are known as "full canvas compositing modes",
i.e. modes that affect pixels outside of the primitive, we
need to draw to a temporary buffer, and composite it back to the
canvas.  In cases where shadows are being painted, it is important
to composite the shadow independently of the foreground to
produse spec-compliant behavior.

BUG=411316
TEST=layout test fast/canvas/canvas-shadow-source-in.html

Review URL: https://codereview.chromium.org/658603002

git-svn-id: svn://svn.chromium.org/blink/trunk@183774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Share a bit more code between LocalFrame and RemoteFrame, including moving the detach-time client notification down to FrameClient.

Move the max frame counter to FrameHost instead of Page.

Move detach logic from FrameLoader to LocalFrame, unless it manipulates FrameLoader members.

BUG=

Review URL: https://codereview.chromium.org/645623004

git-svn-id: svn://svn.chromium.org/blink/trunk@183773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Assorted tweaks:

* Both drawConvexPolygon() clients (ObjectPainter::drawSolidBoxSide
  & RenderThemeChromiumMac::paintMenuListButton) turn off stroking,
  so we're always in fill-only mode. Update the method to reflect
  this limited scope, and stop mutating the global stroke style.
* Take an explicit color param to avoid changing (and leaking in
  the case of drawSolidBoxSide) the global fill color.

(because of the above, drawSolidBoxSides no longer dirties the GC paint
state in the common case => reduced pressure for committing deferred
paint saves).

* All drawConvexPolygon & clipConvexPolygon callers except
  RenderThemeChromiumMac pass in four points (quads), and per comments
  in setPathFromConvexPoints we don't assume convexity in this common
  case => update the method names to reflect this reality.

R=schenney@chromium.org,senorblanco@chromium.org

Review URL: https://codereview.chromium.org/657023006

git-svn-id: svn://svn.chromium.org/blink/trunk@183772 bbb929c8-8fbe-4397-9dbb-9b2b20218538

m_destOrigin is only set at the very end of
BoxPainter::calculateBackgroundImageGeometry, and then always to
destRect().location(). m_destRect is not changed after this point.

m_destOrigin is only read in relativePhase(), which is only called after the
end of calculateBackgroundGeometry.

As a result, relativePhase() always returns m_phase, and we should be able to
safely remove both relativePhase and destOrigin. It's not entirely clear to me
what these were supposed to do, but at the moment they do nothing.

TEST=LayoutTests

Review URL: https://codereview.chromium.org/660523003

git-svn-id: svn://svn.chromium.org/blink/trunk@183771 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Bump s-o-m to version 2. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/657963002/)

Reason for revert:
don't use app.yaml revision

Original issue's description:
> Bump s-o-m to version 2.
> 
> TBR=ojan@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183768

TBR=ojan@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/660653002

git-svn-id: svn://svn.chromium.org/blink/trunk@183770 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/657963002

git-svn-id: svn://svn.chromium.org/blink/trunk@183768 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In preparation for dropping InvalidationSetMode [1], list all possible
selector components, either in an explicit black-list or white-listed in
an assert making sure that new selector component types are either black-
or white-listed when added.

The goal is to make the black-list really short as demonstrated in [1], but
getting rid of more of the unnecessarily black-listed ones should be
carefully done on a case-by-case basis. The intent of this patch is to
effectively keep the white-list unchanged.

[1] https://codereview.chromium.org/639433002

R=chrishtr@chromium.org,esprehn@chromium.org

Review URL: https://codereview.chromium.org/658813002

git-svn-id: svn://svn.chromium.org/blink/trunk@183767 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The bounding box needs to be the union of all the box's fragments.
There's one fragment for each column in which the box occurs.

In addition to being a union of all fragments, the bounding box needs to
be relative to the "root"/"ancestor" layer. If the root layer is also
inside the fragmentation context, we need to find the visual position of
the root layer as well (which may very well be in a different column than
the layer we're working on).

A lot was already almost correct in RenderLayer::fragmentsBoundingBox(),
while it was completely missing in RenderLayer::boundingBoxForCompositing().

Added a helper convertFromFlowThreadToVisualBoundingBoxInAncestor() to
deal with this piece of advanced technology in one place.

BUG=359877

Review URL: https://codereview.chromium.org/645023002

git-svn-id: svn://svn.chromium.org/blink/trunk@183766 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=338830
TEST=updated EME tests pass

Review URL: https://codereview.chromium.org/641433002

git-svn-id: svn://svn.chromium.org/blink/trunk@183765 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan@chromium.org

Review URL: https://codereview.chromium.org/659503003

git-svn-id: svn://svn.chromium.org/blink/trunk@183764 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously when the style of list item changes, we reset style of
the list marker, causing unnecessary change of margins (which are reset
to initial value) and unnecessary layout.

Let the new style use the original margins to avoid the unnecessary
change.

BUG=397956
TEST=fast/lists/list-color-change-no-layout.html

Review URL: https://codereview.chromium.org/644073002

git-svn-id: svn://svn.chromium.org/blink/trunk@183763 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add a run-time feature enableImageColorProfiles, default off, to be
plumbed from a Chromium-side commandline flag:

 https://codereview.chromium.org/658683003

BUG=423670, 369787

Review URL: https://codereview.chromium.org/646033003

git-svn-id: svn://svn.chromium.org/blink/trunk@183762 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In addChild(), beforeChild needs to be a descendant of the parent
that's attempting to insert a renderer.

Therefore, when inserting a something, and we decide to drill further
into the tree to find a suitable parent for the new renderer, we need
to update beforeChild as we go, to make sure that it remains a
descendant of the parent that's trying to do the insertion.

In this case it was the list item code that attempted to insert a list
item marker beside a RenderRubyRun (beforeChild). However,
RenderRubyAsBlock::addChild() doesn't want that, so it tells its
RenderRubyRun child to insert it instead. RenderRubyRun will in turn
do the same thing, redirect insertion to its RenderRubyBase child,
which finally is a suitable parent for the marker (and pretty much
anything else). Doing this without updating beforeChild as we go,
caused problems, since beforeChild suddenly was a parent of the
inserting parent.

BUG=395522

Review URL: https://codereview.chromium.org/563763002

git-svn-id: svn://svn.chromium.org/blink/trunk@183761 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As of today, double click on property name in ObjectPropertyTreeElement
results in editing of the property value. The patch changes the
behavior so that double click on property name just sets a selection,
and one has to double-click on property value to edit it.

BUG=423085
R=vsevik

Review URL: https://codereview.chromium.org/656123002

git-svn-id: svn://svn.chromium.org/blink/trunk@183760 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up for r183716, fixing style in stripTrailingSpace.

R=pdr@chromium.org

Review URL: https://codereview.chromium.org/654283002

git-svn-id: svn://svn.chromium.org/blink/trunk@183759 bbb929c8-8fbe-4397-9dbb-9b2b20218538

... so we can match the direction of code dependency (Layers panel currently
depends on Timeline panel to show shared layer views).

BUG=

Review URL: https://codereview.chromium.org/658793002

git-svn-id: svn://svn.chromium.org/blink/trunk@183758 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/639703003

git-svn-id: svn://svn.chromium.org/blink/trunk@183757 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow-up patch for https://codereview.chromium.org/448593002 to fix a crash.

The previous patch uses renderer.slowFirstChild() to get an child renderer in computeQuads(). 
However, this is not always correct. For example, suppose that <a><div></div></a> is given, the render tree would be:

  RenderBlock (anonymous) 0x6110004a6400
    RenderInline 0x60c00014e6c0 A       0x60d00006cf10
  RenderBlock (anonymous) 0x6110004a6180
    RenderBlock 0x6110004a62c0  DIV     0x60b00004d930 CLASS="_muf"

In this case, there is no child renderer for RenderInline object(0x60c00014e6c0).

Instead, LinkHighlight::computeQuads() should use a composed tree based traversal to compute quads correctly because we've already used a composed tree based traversal to get an parent object in the previous patch.

BUG=417191

Review URL: https://codereview.chromium.org/622253004

git-svn-id: svn://svn.chromium.org/blink/trunk@183756 bbb929c8-8fbe-4397-9dbb-9b2b20218538

On local runs of run-webkit-tests a dashboard is generated. Developer can re-run the failed tests from this dashboard directly.
These search filters allow the developer to search among the failed tests in the dashboard.

BUG=418580

Review URL: https://codereview.chromium.org/635413003

git-svn-id: svn://svn.chromium.org/blink/trunk@183755 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=306228
TBR=loislo@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/646783004

git-svn-id: svn://svn.chromium.org/blink/trunk@183754 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423738

Review URL: https://codereview.chromium.org/660523002

git-svn-id: svn://svn.chromium.org/blink/trunk@183753 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=423686
R= yurys@chromium.org

Review URL: https://codereview.chromium.org/653263004

git-svn-id: svn://svn.chromium.org/blink/trunk@183752 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=167285

Review URL: https://codereview.chromium.org/659433002

git-svn-id: svn://svn.chromium.org/blink/trunk@183751 bbb929c8-8fbe-4397-9dbb-9b2b20218538