- 07 Jun, 2019 40 commits
-
-
Kai Ninomiya authored
CString is being removed. Also, this was sort of relying on an implementation detail of CString, and this fixes that. Bug: 950077 Change-Id: I4fab8de0ef8f3202c0144dcea8eeedf89e90ce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648712Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#667238}
-
May Lippert authored
The suggestion to powerwash only shows up when there's a firmware update, which is relatively rare. Default to hide this line item. BUG=925279 Change-Id: I690010a7b68bd6cc108e6c2ad420d2b69d7f3dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646649 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#667237}
-
Raphael Kubo da Costa authored
IWYU after commit b8fdf46c ("Consolidate code to set device::Gamepad id field"), which also fixes the libstdc++ build: ../../device/gamepad/public/cpp/gamepad.cc:28:3: error: use of undeclared identifier 'memset'; did you mean 'wmemset'? memset(id, 0, sizeof(id)); Bug: 957519 Change-Id: I5b5a8d9d7bc0de6e5b32ddd29ce0c5c17c883ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649496 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#667236}
-
Etienne Bergeron authored
This CL is fixing a cause of flaky tests when re-ordering tests execution. SystemFont is keeping two static callbacks that modify metrics of the system fonts. Typically, these callbacks are set up before the SystemFont class is instantiated. A DCHECK was ensuring this. We are able to repro flaky test by changing tests order or by specifying test filters (see below). A DCHECK fails because it is possible in unittests to set the callbacks after the SystemFont is instantiated. The problem is that callbacks are static variables that keep states between two tests. I believe other fancy bugs may be hidden by this bug since system fonts may be scaled based on the callback left by a previous test. This CL is adding the required logic to reset the system fonts. R=robliao@chromium.org,asvitkine@chromium.org CC=benck@google.com Bug: 944227 C:\src\chromium\src>out\build\gfx_unittests --gtest_filter=FontListTest.Fonts_DeriveWithHeightUpperBound:RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs:SystemFontsWinTest.AdjustFontSize IMPORTANT DEBUGGING NOTE: batches of tests are run inside their own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with --single-process-tests. Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = FontListTest.Fonts_DeriveWithHeightUpperBound:RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs:SystemFontsWinTest.AdjustFontSize [==========] Running 3 tests from 3 test suites. [----------] Global test environment set-up. [----------] 1 test from FontListTest [ RUN ] FontListTest.Fonts_DeriveWithHeightUpperBound [ OK ] FontListTest.Fonts_DeriveWithHeightUpperBound (13 ms) [----------] 1 test from FontListTest (14 ms total) [----------] 1 test from RenderTextTest [ RUN ] RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs [ OK ] RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs (32 ms) [----------] 1 test from RenderTextTest (34 ms total) [----------] 1 test from SystemFontsWinTest [ RUN ] SystemFontsWinTest.AdjustFontSize [26180:21012:0605/182005.067:1151493921:FATAL:system_fonts_win.cc(100)] Check failed: !SystemFonts::IsInitialized(). base::debug::CollectStackTrace [0x00007FFB78F6D7E0+48] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x00007FFB78F6C950+80] (C:\src\chromium\src\base\debug\stack_trace.cc:206) base::debug::StackTrace::StackTrace [0x00007FFB78F6C8D8+40] (C:\src\chromium\src\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x00007FFB78FBC78F+143] (C:\src\chromium\src\base\logging.cc:613) gfx::win::`anonymous namespace'::SystemFonts::SetGetMinimumFontSizeCallback [0x00007FFB834E3E41+161] (C:\src\chromium\src\ui\gfx\system_fonts_win.cc:101) gfx::win::SetGetMinimumFontSizeCallback [0x00007FFB834E3D93+19] (C:\src\chromium\src\ui\gfx\system_fonts_win.cc:222) gfx::win::SystemFontsWinTest_AdjustFontSize_Test::TestBody [0x00007FF7F312886E+46] (C:\src\chromium\src\ui\gfx\system_fonts_win_unittest.cc:30) testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF7F31A50DF+79] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2507) testing::Test::Run [0x00007FF7F31A5049+185] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2529) testing::TestInfo::Run [0x00007FF7F31A5D11+225] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2701) testing::TestSuite::Run [0x00007FF7F31A69D6+278] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2827) testing::internal::UnitTestImpl::RunAllTests [0x00007FF7F31B0EE9+1113] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:5284) testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00007FF7F31B0A75+85] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2505) testing::UnitTest::Run [0x00007FF7F31B08BC+300] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:4873) RUN_ALL_TESTS [0x00007FF7F32463F1+17] (C:\src\chromium\src\third_party\googletest\src\googletest\include\gtest\gtest.h:2453) base::TestSuite::Run [0x00007FF7F32459D4+164] (C:\src\chromium\src\base\test\test_suite.cc:316) base::internal::FunctorTraits<int (base::TestSuite::*)(),void>::Invoke<int (base::TestSuite::*)(),(anonymous namespace)::GfxTestSuite *> [0x00007FF7F2E1516D+29] (C:\src\chromium\src\base\bind_internal.h:499) base::internal::InvokeHelper<0,int>::MakeItSo<int (base::TestSuite::*)(),(anonymous namespace)::GfxTestSuite *> [0x00007FF7F2E150E4+52] (C:\src\chromium\src\base\bind_internal.h:599) base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(),base::internal::UnretainedWrapper<(anonymous namespace)::GfxTestSuite> >,int ()>::RunImpl<int (base::TestSuite::*)(),std::__1::tuple<base::internal::UnretainedWrapper<(anonymous [0x00007FF7F2E15068+88] (C:\src\chromium\src\base\bind_internal.h:672) base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(),base::internal::UnretainedWrapper<(anonymous namespace)::GfxTestSuite> >,int ()>::RunOnce [0x00007FF7F2E14F3E+78] (C:\src\chromium\src\base\bind_internal.h:641) base::OnceCallback<int ()>::Run [0x00007FF7F324E611+97] (C:\src\chromium\src\base\callback.h:98) base::`anonymous namespace'::LaunchUnitTestsInternal [0x00007FF7F324BCE2+418] (C:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:158) base::LaunchUnitTests [0x00007FF7F324BAFD+253] (C:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:492) main [0x00007FF7F2E14AAA+138] (C:\src\chromium\src\ui\gfx\test\run_all_unittests.cc:81) invoke_main [0x00007FF7F33739E4+52] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79) __scrt_common_main_seh [0x00007FF7F3373B1E+302] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) __scrt_common_main [0x00007FF7F3373B9E+14] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331) mainCRTStartup [0x00007FF7F3373BB9+9] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x00007FFBB44837E4+20] Backtrace: Change-Id: I23109356db89c48c89c51b1db78cbb0c04367e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647192 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#667235}
-
Carlos Caballero authored
Use ScopedTaskEnvironment instead of MessageLoop in /ui/events/devices/mojo/device_struct_traits_unittest.cc MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=meacer@chromium.org Change-Id: I56dcf5a81b19ec45040fba583bd38112eef247c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649511 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#667234}
-
Carlos IL authored
Feature launched in M70, and has been default enabled since, this CL removes the flag from Chrome's code, and the switch from chrome://flags Bug: 936008 Change-Id: I57772ccc041b137255e39b220777e739d72c9789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644788 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#667233}
-
Daniel Hosseinian authored
This commit clarifies previously established ownership semantics of Profiles within ProfileManager through the use of unique pointers. Changes were made to the parameters of ProfileManager::RegisterTestingProfile() and ProfileManager::RegisterProfile() to take a std::unique_ptr instead of a raw pointer. A further change was made to the return type of ProfileManager::CreateProfileAsyncHelper() from a raw pointer to a unique pointer. All callers to the aforementioned functions (including unit tests) that made calls to the two functions are updated to pass in unique pointers. Bug: 968187 Change-Id: I05cab32d75fa8aad30359e8cc5b4a85efaaf9d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639183Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#667232}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c2c829bc9a63..f60a2d59c9f2 git log c2c829bc9a63..f60a2d59c9f2 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 sugoi@google.com Removed some dependencies on old threading class 2019-06-07 sugoi@google.com Replace sw::Resource with sw::WaitGroup 2019-06-07 swiftshader.regress@gmail.com Regres: Update test lists @ c2c829bc Created with: gclient setdep -r src/third_party/swiftshader@f60a2d59c9f2 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I5aba07eefad5deffab83d6f592200ec5f27ef93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667231}
-
dpapad authored
When a dialog's child element is focused and then becomes hidden the browser unfortunately moves the focus to <body> which in turn prevents any keydown/keypress listeners on <dialog> from firing. Also preventing an iron-select event from bubbling, since it ends up triggering unrelated code (although this is not required for the fix, it is safer). Bug: None Change-Id: Ifaad8070d6cab5b4db7167d461c35dfc5168d2d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648729Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#667230}
-
Vasilii Sukhanov authored
Remove dependency on FormFetcher and IsPasswordOverridden. Removing IsPasswordOverridden makes the Android UI similar to iOS. The combobox is always shown if there multiple passwords save and we decide to update. Bug: 845826 Change-Id: I7d5f90961017f7c6629d1a3c15e79d834bc69bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648174 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#667229}
-
Jose Dapena Paz authored
Compilation fails because we are declaring ParseValueForFuzzer as friend method, but we are declaring it is in anonymous namespace. Moving to global namespace still fails (in this case in Clang). So final solution is making it a public static method of FeaturePolicyParser. Bug: 819294 Change-Id: Iea307cb6faef675b748d6eb5da2175dcbb17fdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645223 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#667228}
-
Josh Nohle authored
The previously void methods AddDevice(), DeleteDevice(), and SetRegistry() now return a boolean, indicating whether or not the registry changed as a result of the call. Also, the pref will now only be updated when the registry changes. And, DeleteDevice() no longer DCHECKs that a device with the input |instance_id| is in the registry, instead returning false if such a device doesn't exist. The RemoteDeviceProvider needs to know when a DeviceSync updates the local device cache. The aforementioned changes to CryptAuthDeviceRegistry will help make that determination for v2 DeviceSyncs. Bug: 951969 Change-Id: I6ad98cadc659d02895da3b16eed90b0ba50773bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638386 Commit-Queue: Josh Nohle <nohle@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#667227}
-
Matthew Webb authored
This CL implements the fingerprint/biometric enrollment and a test utilizing a PIN-enabled virtual authenticator. Note that the current enrollment handler requires a PIN to be set on the device before enrolling. Once hooked into a UI, the PIN will be required to enroll a new fingerprint. Change-Id: Iffe71b00c0ba4e10f697b54d038d268d65a6f310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636723Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#667226}
-
Yi Su authored
This CL adds template args for CRWWKScriptMessageRouter._handlers to make it more readable. Bug: 956511 Change-Id: Iba9dfc5fb0068bb1e2966de5c40b667b1e53145e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649494Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#667225}
-
Kyle Horimoto authored
Before this CL the UI looked like this: When you connect your devices you agree that your Chromebook can: * Install apps on your Chromebook * ... This sounds a bit awkward, since "your Chromebook" is repeated twice. This CL changes the first bullet point to "Automatically install apps" instead. Bug: 950691 Change-Id: Ibbe2a203f7a2a921541c09eabe393c7b0ad1f615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650121 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#667224}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe18de506097..ac53c42b09f3 git log fe18de506097..ac53c42b09f3 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@ac53c42b09f3 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ia9cd9d8d92054d8da165e6c6ae35b3ec49d146d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649384Reviewed-by:
-
Adam Raine authored
In the input data structure passed to PaintWorkletProxyClient::Paint I added a structure to take the CSSStyleValueVector structure parsed_input_arguments_ from CSSPaintValue. The CSSStyleValues needed to be converted into a vector of CrossThreadStyleValue which is converted back to a CSSStyleValueVector. Bug: 946519 Change-Id: I0fd02b88e5f105afc5c3269088bd82c6f72b0eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645894 Commit-Queue: Adam Raine <asraine@google.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#667222}
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 8 of a multi-CL refactoring and does: - use PostTaskAndReplyWithResult in HistoryService::QueryMostVisitedURLs thus removing a naked "new" and the use of base::Unretained and base::Owned to pass the value to both callbacks - change QueryMostVisitedURLsCallback callback to be invoked with MostVisitedURLList passed by value instead as a const pointer thus allowing to remove an helper function - change QueryMostVisitedURLsCallback to a base::OnceCallback<...> - change HistoryBackend::QueryMostVisitedURLs to return the result by value instead of via an out parameter Bug: 812523, 714018 Change-Id: Ia020a8d780945c84b5ce674c239aff4da915925a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634872Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#667221}
-
Jenny Zhang authored
Bug: 963448 Change-Id: Ied98c28e35bca8bdd03f8ee2c328eb566590d8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648741Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#667220}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b407e1a0b5bf..ed65dc4302f8 git log b407e1a0b5bf..ed65dc4302f8 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 syoussefi@chromium.org Vulkan: implement glSampleCoverage Created with: gclient setdep -r src/third_party/angle@ed65dc4302f8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Change-Id: I2975f133b4d60557024a4eda1eb40052326c252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649665Reviewed-by:
-
shrekshao authored
By comparing OpenGL ES 3.0, 3.1, and 3.2 spec side by side, we could safely assert that floating-point is core in and only in GL ES 3.2. Thus we should advertise EXT_float_blend enable float 32 blending on GL ES 3.2 backend regardless of whether it is listed. * ES 3.0, section 4.1.7: Blending applies only if the color buffer has a fixed-point format. If the color buffer has an integer format, proceed to the next operation. * ES 3.1, section 15.1.5: Blending applies only if the color buffer has a fixed-point ~~or floating-point~~ (it’s striked through in the original source), format. If the color buffer has an integer format, proceed to the next operation. * ES 3.2, section 15.1.5: Blending applies only if the color buffer has a fixed-point or floating-point format. If the color buffer has an integer format, proceed to the next operation Bug: 964208, 970532 Change-Id: I7b7ec375f6b0ac34276d6cfec92c4956d7c1f6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649055 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#667218}
-
Kai Ninomiya authored
Deduplicating this string lifetime logic should make it much less error prone. Bug: 971819 Change-Id: I55361dc44aebb665ddace76a6602a71e0a7fc6b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648713Reviewed-by:
-
Oystein Eftevaag authored
First step towards migrating the profiler to Perfetto. R=ssid@chromium.org Bug: 967008 Change-Id: If714e13b2796728766b4f010593a223dd1f24c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629177Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#667216}
-
Erik Chen authored
This allows the macOS toolchain to avoid using xcrun to find the path for strip. Bug: 971452 Change-Id: I7d7b87462ee33201b57a75bfa58e5fbf8ddaee5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649187Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667215}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=afakhry@chromium.org Change-Id: I089353dab84610c892f13338e3de419caddf0b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649508 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#667214}
-
Etienne Pierre-doray authored
Change-Id: I87b3d1d7d5493115d8f305c4707ba0b1924c1132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648035 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#667213}
-
Sidney San Martín authored
In r661714, I changed -[RenderWidgetHostViewCocoa selectedRange] to account for the selection offset. But, it turns out that's already accounted for; I mis-interpreted some other behavior. This change effectively reverts that one (7b4466da) but keeps the new test case. Bug: 42434 Change-Id: I4c738abd5207d447260c98d6293a560f9694d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649143 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Erik Chen authored
Bug: 971452 Change-Id: If3c2939e0b4cc7c1f9b4b9b880e2a9288ba40fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649148Reviewed-by:
-
Erik Chen authored
Bug: 965663 Change-Id: Ib69070af18655d0cd94bc21a9f82c359d0db33e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649065Reviewed-by:
-
Alex Cooper authored
If a user suspends an OpenVR immersive session whether by dropping to a home environment (like the WMR home), or by pressing the "system" button on the controller to show the OpenVR/Vive menu, and then re-enters the session, the controllers would no longer be visualized. This appears to be occuring because while the controller stayed connected, the OpenVRRenderLoop was not able to query it's state, and therefore stopped reporting input information on the controller. When the controller re-connected, the RenderLoop would resume sending data about the controller back up, but did not send a new description because it thought it had been connected all along. In XRSession, when a new XRInputSource was created, it defaulted to being created as a "Gaze" source with no handedness. With no override from the description, it stayed that way; clicks would work on the gaze target, but no controllers/pointers would be rendered. The fix here is to simply mark the controller as inactive if it does not have state, thus ensuring that a new description is sent up when the controller is again tracked/has state. While updating this change, it was discovered that the tests report all devices as connected, and so connecting/disconnecting a controller on the test side would not prompt the device to be registered in product code as newly connected (where it's device type is updated), so it was always ignored if it was ever disconnected. This change modifies the WaitGetPoses method (where GetInputSources gets it's data), to properly report the connected state of controllers. Bug: 934355 Change-Id: Ia61c7568916cc9446366e085e74b55c413c5f6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648654Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#667209}
-
chrome://signin-internalsAlex Ilin authored
My previous CL https://crrev.com/c/1648164 used base::TimeFormatWithPattern() to get a date string in a fixed format. However, base::TimeFormatWithPattern() freely modifies the pattern to make it correspond to the system date format. This CL uses base::TimeToISO8601() for date formatting instead of base::TimeFormatWithPattern(). Bug: 852037 Change-Id: Id63cd5582d5a3259251c5f9d292378511545b662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649173 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#667208}
-
Wez authored
Bug: 971927 Change-Id: I7c3f8c3340bec731fae7cadb9e8a03cc9c2dc0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649029 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#667207}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: Ief71174e37070489b6a9c89b28a6950334bd0dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649539 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3ff3ecc72ae4..1faba755ff77 git log 3ff3ecc72ae4..1faba755ff77 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 tsepez@chromium.org Prevent CPDF_Type3Font from knowing that CPDF_Type3Char has a form. Created with: gclient setdep -r src/third_party/pdfium@1faba755ff77 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I16c4eb040107582e4471cbebdd8c5612307b25c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649383Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Updates in Tab-to-Grid transition animation: - Do not show the selected blue border in the grid when the tab resizes - Fade in the selected blue border along with the GTS final fading-in Bug: 971522 Change-Id: If788855ce4659226900759517cf7f8e9ab536e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648835 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667204}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/311b8025e35c..af0e045c2ee1 git log 311b8025e35c..af0e045c2ee1 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 saklein@chromium.org BinhostService: Refactor PrepareBinhostUploads and RegenBuildCache Created with: gclient setdep -r src/third_party/chromite@af0e045c2ee1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I880543ee4b810d7b5d231d763d229281e4f52c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649060Reviewed-by:
-
Mythri A authored
Bug: chromium:958441 Change-Id: I89a2d24a57d72c53844b39ed4eabe3198f394bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646791 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#667202}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=chili@chromium.org Change-Id: Id6421b96347e3bfac890f039bcda4aa8329f27b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649578 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#667201}
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //ui. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 970209 Change-Id: Ia41e90dc60687f1adb07f0552141e31a4dee83c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648189 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667200}
-
Lindsay Pasricha authored
CIPD packages: infra_internal/ios/xcode/mac 10e1001 infra_internal/ios/xcode/ios 10e1001 Bug: 971671 Change-Id: I64b42e4990a6b8a3a0ee45527a8a3e0deba7c2c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646666Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#667199}
-
