- 16 Mar, 2018 40 commits
-
-
Alexander Timin authored
Rename WebThreadCreationParams::SetThreadName to WebThreadCreationParams::SetThreadNameForTest to clarify that in non-test code thread name is inferred from thread type. R=kinuko@chromium.org,haraken@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I359cf449dba6cb2544f65a3624ecc6761c425f7f Reviewed-on: https://chromium-review.googlesource.com/964366Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543677}
-
Benoit Lize authored
Bug: 816837 Change-Id: Ic31994e78c18d35fec707746973658843851e759 Reviewed-on: https://chromium-review.googlesource.com/962783Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543676}
-
Chris Nardi authored
Since data URLs are same-origin, their CSSStyleSheet elements should be accessible without throwing a SecurityError. TaintsCanvas had an appropriate check for this, but was named incorrectly for this use case. Rename TaintsCanvas to CanAccessData, reversing the boolean condition, and use the new method in CSSStyleSheet::CanAccessRules. Bug: 813826 Change-Id: Ie49eecfca92af31f27a3584a64bf494083ef4742 Reviewed-on: https://chromium-review.googlesource.com/963401Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543675}
-
Sergey Poromov authored
After recent change, DeviceSettingsService is created before DBusThreadManager is initialized. Because of that, DeviceOffHoursController never gets information about system time synchronization and doesn't apply OffHours mode. This change swaps DeviceSettingsService and DBusThreadManager creation. Bug: 822227 Test: Trybots + manual test that OffHours are now applied. Change-Id: I8a00cbbc53add056da4296123e9bfadd461eca94 Reviewed-on: https://chromium-review.googlesource.com/964522 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543674}
-
Victor Costan authored
The iOS CookieStore implementations synchronize (to some degree) a CookieMonster with the system cookie store. Change detection is implemented by storing a snapshot of the system cookie store's last seen contents, and computing diffs between the current system store contents and the snapshot. This implementation has two major differences from the CookieMonsterChangeDispatcher implementation: 1) The ordering of changes observed between two snapshots cannot be known. However, the CookieStore tests expect changes to be observed in the exact order in which the corresponding commands were issued. 2) The current diffing implementation does not distinguish between deletion causes. The tests rely on a distinction between OVERWRITE and EXPLICIT. This CL introduces CookieStoreTestTraits members that account for the differences above, making it possible to run the change tests against the CookieStoreIOS implementation. CookieStoreIOSPersistent requires significant changes to pass the tests, so it will be addressed in a separate CL. Bug: 729800, 813931 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib959c4a2d05ef84ab154290ee91f975436a7ee64 Reviewed-on: https://chromium-review.googlesource.com/947844 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#543673}
-
Vaclav Brozek authored
The histogram name "PasswordManager.Android.PasswordSearchTriggered" is put in a String constant in SavePasswordsPreferences. There are two reasons to inline it instead: (1) Inlining allows better presubmit checks for undefined histogram names. (2) There is only one place where the String constant is used, anyway. This CL inlines the histogram name. Bug: 821823 Change-Id: I16d5ed0e23e3402d0307f537eb904ae7220a2c5b Reviewed-on: https://chromium-review.googlesource.com/964842Reviewed-by:Theresa <twellington@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543672}
-
Rob Buis authored
The property -webkit-app-region went through renames and other changes. It seems we can settle on none | drag | no-drag. The value none is used internally as default, make it explicit by allowing it to be specified in the style. Bug: 803699 Change-Id: I1ec96c9e436c7595ac7ab34d90bfbfdd9ea48672 Reviewed-on: https://chromium-review.googlesource.com/964381Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Rob Buis <rob.buis@samsung.com> Cr-Commit-Position: refs/heads/master@{#543671}
-
Raphael Kubo da Costa authored
When DCHECKs are disabled, these tests fail instead of passing; update the expectations added in ac22c9f7 ("Mark a few upcoming WPT tests as failing in virtual/incremental-shadow-dom") to [ Crash Failure ]. TBR=lukebjerring Bug: 822679 Change-Id: I049471ac3520e09251800de2afe17cd23078f0ff No-Try: True Reviewed-on: https://chromium-review.googlesource.com/966064Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#543670}
-
Juan Antonio Navarro Perez authored
We now provide the three tags Android_Go, Android_One (*), and Android_Svelte, to disable on individual kinds of low end devices; as well as Android_Low_End to disable if the platform matches any of them. (*) Android_One replaces the previously existing but more wordy Cherry_Mobile_Android_One. We also now disable gmail-background on low end devices only, as it was originally intended. Bug: 777355 Bug: 819577 Change-Id: I97824ca1f09677c8e80a5e06f5760bf153463748 Reviewed-on: https://chromium-review.googlesource.com/957025Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#543669}
-
arthursonzogni authored
This test is flaky with NavigationMojoResponse Temporarily disable it until the cause is found. TBR=benwells@chromium.org Bug: 822650 Change-Id: I5354ce829b0e5ecaa15b82399aceed8173250f63 Reviewed-on: https://chromium-review.googlesource.com/966203Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#543668}
-
Vadym Doroshenko authored
This reverts commit f35e389b. Reason for revert: This CL is suspicious in Android WebKit test failures: The first failure: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/75367 Error message: virtual/media-gpu-accelerated/external/wpt/media-source/mediasource-config-change-mp4-av-framesize.html failed unexpectedly (gpu crashed) Error log: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F75367%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout Original change's description: > media: Use BindOnce everywhere in GMBVFP. > > Changes the use of Bind and Closure to BindOnce and OnceClosure in > GpuMemoryBufferVideoFramePool. > > It additionally introduces a trampoline in MailboxHoldersReleased so > that if the callback is called on media_thread it can skip going trough > the message loop. > Previous the callback would be bound to the media_thread loop. > > Two DCHECKs have also be added to check thread expectations. > > Change-Id: Ie704f6f6bdc4b7d9b8dd0f5ffec4675cd060d5e2 > Reviewed-on: https://chromium-review.googlesource.com/959382 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543609} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org Change-Id: I600ddbf046ad44d4d80bf93ea81543e29dd8d46b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/966321Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#543667}
-
Raphael Kubo da Costa authored
The following tests are hitting a DCHECK and blocking WPT imports: * virtual/incremental-shadow-dom/external/wpt/css/css-scoping/shadow-fallback-dynamic-002.html * virtual/incremental-shadow-dom/external/wpt/css/css-scoping/shadow-fallback-dynamic-003.html * virtual/incremental-shadow-dom/external/wpt/css/css-scoping/shadow-fallback-dynamic-005.html Manually mark them as crashing to unblock imports. TBR=lukebjerring Bug: 822679 Change-Id: I74fb64731041757c2ea9e92aa3a0e66fd81ef166 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/966301Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6cacc46a..79b300af Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I7e62196c6ee3802a12cd656a5f3f2636fd0f523f Reviewed-on: https://chromium-review.googlesource.com/966001Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543665}
-
Chandan Padhi authored
Bug: 817769 Change-Id: I3f06b5f2360c570ff8c5b4bd800ca1014cc7d088 Reviewed-on: https://chromium-review.googlesource.com/956383 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#543664}
-
Colin Blundell authored
Moves this service into the canonical location for services within //components. A followup CL will rename the service from "unzip_service" to "unzip". TBR=dcheng@chromium.org NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I15366d2b9d256c03469f736d23e0252c6d9dd85f Reviewed-on: https://chromium-review.googlesource.com/955701Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#543663}
-
Ramin Halavati authored
Adds a local annotation for system proxy configuration. Bug: 656607 Change-Id: If4527e0d3de22db9546f9cbecfcdd00286da70e1 Reviewed-on: https://chromium-review.googlesource.com/960007 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Traffic annotation auditor's binaries for Linux and Windows are rolled. TBR=msramek Bug: 690323 Change-Id: Ib313528d8605805c05d09aa9fd17ad83f1e1220a Reviewed-on: https://chromium-review.googlesource.com/966182Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543661}
-
Bernhard Bauer authored
Also, get the correct child to update in CustomTabToolbar.updateCustomActionButton(). Bug: b/73160522, 822277 Change-Id: Ia77234d6023a1049d506684bda3aaaa7e96cd405 Reviewed-on: https://chromium-review.googlesource.com/964444 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#543660}
-
Adam Rice authored
Update WritableStream to match the standard version https://github.com/whatwg/streams/commit/7b8dffe8ec270bb918340e011349e2c1b5521a15. * Significant user-visible changes: Method lookups are now cached at construction time. Changing underlyingSink.write after construction will no longer do anything. This is https://github.com/whatwg/streams/pull/860. When abort(reason) is called, the stored error will now be set to |reason| instead of a TypeError. This is https://github.com/whatwg/streams/pull/903. * Significant internal changes: CreateWritableStream() operation is now exported. TransformStream will be modified to use this in a follow-up CL. This is https://github.com/whatwg/streams/pull/857. New common operations ValidateAndNormalizeQueuingStrategy, MakeSizeAlgorithmFromSizeFunction, CreateAlgorithmFromUnderlyingMethod and CreateAlgorithmFromUnderlyingMethodPassingController are implemented. Remove PromiseCallOrNoop0 and PromiseCallOrNoop2 as they are no longer used. Update external/wpt/streams test expectations for the massive reduction in failures. Also chromium simple-queue tests expected abort() to result in a TypeError, and needed updating. Also remove the expectation that external/wpt/streams/readable-streams general.html will Timeout, since none of the other tests using general.js are marked Timeout. Bug: 820246, 820387, 626703 Change-Id: Id1364921c37b03cdf3c89e201079292b13b9214c Reviewed-on: https://chromium-review.googlesource.com/961566 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#543659}
-
PhistucK authored
When you must disable the sandbox, you want to disable it for any content_shell run, including check-sys-deps runs, instead of using --nocheck-sys-deps. Bug: None Change-Id: I90be01ad4034e5c93335ca55430ba550c389380d Reviewed-on: https://chromium-review.googlesource.com/964741 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#543658}
-
Trent Apted authored
This is easily done with an override of View::OnThemeChanged() Less easily done is a test: themes are complex. Add a test for the selection highlight, which captures the current logic around theme color propagation. Bug: 801583, 819425, 704942 Change-Id: I86f3e4d9b5a30db66ad5a28d2ce7581aa9f7320b Reviewed-on: https://chromium-review.googlesource.com/952802 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#543657}
-
Christopher Cameron authored
This is an option now that aura::WindowTreeHost have been fixed Bug: 818085 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I074ade34758a5005862543549e4bbe69838301b9 Reviewed-on: https://chromium-review.googlesource.com/959550 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543656}
-
Matt Falkenhagen authored
And some minor refactoring. Bug: 789577 Change-Id: I365024a2e29b71e8aaa3cfecabe4f70eb31c8808 Reviewed-on: https://chromium-review.googlesource.com/965661Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#543655}
-
Rune Lillesveen authored
We created a StyleSheetList connected to the TreeScope which would create a second StyleSheetList for the scope-attached sheets which messed up the active stylesheets causing crashes. Bug: 819483 Change-Id: Ib24bee538a27a64b5a8206e32334d4324629d5af Reviewed-on: https://chromium-review.googlesource.com/964326 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543654}
-
junweifu authored
Add AsyncRequest class to submit an image analysis request for asynchronous execution on a dispatch queue with default priority. Link Mac 10.13 build bots [2] and Face Detection demo[3] here. Split original large CL[4] up in smaller subpatches including this CL. [1] https://cs.chromium.org/chromium/src/base/mac/sdk_forward_declarations.h?sq=package:chromium&dr=CSs&l=5 [2] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/ [3] https://codepen.io/miguelao/pen/PmJWro [4] https://chromium-review.googlesource.com/c/chromium/src/+/912780/2 BUG=799319 Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I993d9f94299db464a109fb284356213413396f37 Reviewed-on: https://chromium-review.googlesource.com/947818Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#543653}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I91295d33966eeccac4b4f095f13dd2ababd2596b Reviewed-on: https://chromium-review.googlesource.com/966003 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543652}
-
Hiroki Nakagawa authored
This CL renames WorkerScriptLoader to WorkerClassicScriptLoader for clarifying the loader is used for classic scripts, not for module scripts. Bug: 680046 Change-Id: I037de4772e8323e4176989427fa6c2529c7fdab0 Reviewed-on: https://chromium-review.googlesource.com/965662Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#543651}
-
Kunihiko Sakamoto authored
Bug: 803774 Change-Id: I3d2a71beed193949a0dd13e1ed347ff61df4dc76 Reviewed-on: https://chromium-review.googlesource.com/965725Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#543650}
-
Ramin Halavati authored
Network traffic annotation is passed from ProxyInfo to HttpProxyClientSocket for handshake and control. Bug: 656607 Change-Id: I74e3805b743de88ae604644629a05fe1cc738ec3 Reviewed-on: https://chromium-review.googlesource.com/960322Reviewed-by:
-
Colin Blundell authored
The presubmit tools choke if they need to process //ios/chrome/browser/unzip/OWNERS because "waffles" isn't in one of the expected formats. NOPRESUBMIT=true Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3dce39094d169418253dad154c0eb006201687b0 Reviewed-on: https://chromium-review.googlesource.com/955700 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
yusukes authored
Bug: None Change-Id: Id96dc2fb2cfc84ef1512690c24c1f000ef0cb01c Reviewed-on: https://chromium-review.googlesource.com/966002Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#543647}
-
Ramin Halavati authored
Network traffic annotation is passed from pac_file_fetcher to pac_file_fetcher_impl, and the local annotation is removed. Bug: 656607 Change-Id: I7446281e7b8f6c15bc21d49cc31c1ebcaa9ecba9 Reviewed-on: https://chromium-review.googlesource.com/964283Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543646}
-
Christopher Cameron authored
These classes override the UpdateRootWindowSizeInPixels method, and consequently fall vicitim to the race condition described in https://crrev.com/542948 Propagate the device scale factor change through the overridden UpdateRootWindowSizeInPixels methods. Add comments indicating inconsitent behavior in UpdateRootWindowSizeInPixels, as its interaction with other methods for updating bounds is unclear. Bug: 818085 Change-Id: I0fc43954a532f4a9eb269919685f5108b762ed2a Reviewed-on: https://chromium-review.googlesource.com/963487Reviewed-by:
-
Tetsui Ohkubo authored
A child label of BatteryView can change their visibility and size. Also, EnterpriseManagedView can change its visibility. We have to explicitly call Layout() in ChildPreferredSizeChanged() & ChildVisibilityChanged(). TEST=manual (connect/disconnect power cable while opening the tray) BUG=none Change-Id: Ia1c16669bcdce0740510b7c255642d7985763225 Reviewed-on: https://chromium-review.googlesource.com/959944Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#543644}
-
Xu Xing authored
Add mipmap_state_ in move constructor and the move assignment operator. BUG=817887 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I460f018ec73f791bb496c0b873dd2fb68ab58128 Reviewed-on: https://chromium-review.googlesource.com/965405Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#543643}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2973ea1..6cacc46a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I684d93231849e3d5cdeecca29afe9e43b2e6c54d Reviewed-on: https://chromium-review.googlesource.com/965591Reviewed-by:
-
Hajime Hoshi authored
We try to remove the default argument (task runner) of SimpleWatcher's constructor and use more appropriate task runners than base::SequencedTaskRunnerHandle::Get(), and this CL is the first steps. Our goal is to eliminate base::STRH::Get() usages in renderer since in most cases, sequenced-local task runner is not appropriate in renderers. For now, only FileReaderLoader and FetchDataLoaderAsDataPipe are the users of the default argument since base::STRH::Get() is not available there due to presubmit.py. This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id03c8dc750fe5696be3358de761af7f29f22e5e9 Reviewed-on: https://chromium-review.googlesource.com/959948 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#543641}
-
Tetsui Ohkubo authored
This CL adds a feature pod button for IME. By clicking on the button, it will show IME detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling Screenshot: http://screen/scc32RkykN2 TEST=manual BUG=821671 Change-Id: I156db2af966d13082079e639e2c46805b0453995 Reviewed-on: https://chromium-review.googlesource.com/961748 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
Holding an InterfacePtr makes the struct weirdly sequence bound. Also get rid of const casts that invalidate a const DataElement and replace them with cloning the DataPipeGetter. This is needed because the same ResourceRequestBody is sent to multiple mojo methods, and thus the param traits should not modify the DataElements. On of several changes towards making uploading blobs with network service work. Tested in a separate CL because multiple unrelated bugfixes are needed to make this all work and testable (https://chromium-review.googlesource.com/c/chromium/src/+/963008). Bug: 821878, 761117 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic1d63e6f0f7112cf37c75526c561c524a9c15201 Reviewed-on: https://chromium-review.googlesource.com/963085Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Xiaoqian Dai authored
Because of splitscreen, it's now possible to remove an overview window item to snap in splitscreen, or to add an overview window item from one of the snapped windows in splitscreen, we should update the overview items in these two cases. Otherwise in WindowSelector::Shutdown(), the DCHECK(num_items_ >= remaining_items) might fail and the UMA stat Ash.WindowSelector.OverviewClosedItems might not record the correct number. Bug: 822059 Change-Id: Ic60cd10a8e352bc6ea5c559b1d79f60dee7e81dd Reviewed-on: https://chromium-review.googlesource.com/963723 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543638}
-
