- 04 Mar, 2020 40 commits
-
-
Kamila authored
Cleaned up the separated Android field trial testing config for enabling the In Product help UI, and merged it into the QuietNotificationPrompts field trial, as both the features are being tested together, and there is currently no need for separate, per-platform configs (the IPH config is simply ignored on Desktop anyway). Bug: 1032202 Change-Id: I1bbbadc460bdc3b371941164f415ec06c1c78d7b TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061153 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#746754}
-
Tim van der Lippe authored
This test asserts behavior that is undesirable. Therefore, I propose to remove it alltogether. R=yangguo@chromium.org Bug: 1044632 Change-Id: Ibe0acd0010c6fead07c7b1847667f187f30f38ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085192 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#746753}
-
Side Yilmaz authored
PassphraseCreationDialogFragment. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates PassphraseCreationDialogFragment class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Ia9bc4d3dd37b3afed9dad99b6c52476b77810a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085254Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746752}
-
Christian Dullweber authored
Disable flaky tests. Tbr: crouleau@chromium.org Bug: 1056235 Change-Id: I515d91c39a8824fe3d439a30e9ef6628546aa612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087613Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#746751}
-
Clemens Arbesser authored
This is a reland of 8698d875 The test was failing on smaller screens due to a missing scrollToView(). Original change's description: > [Autofill Assistant] Hotfix for radio buttons in FormAction. > > Without this CL, UI and model can go out-of-sync when tapping the radio > button directly (see screenshots in linked bug). This is a hotfix for > this issue. A proper fix requires a refactoring of the FormAction to > make the selection state part of its model (same as was done for the > T&C selection state in the CollectUserDataModel). > > Bug: b/150201921 > Change-Id: Ifa0a2839c532a1862358bc68e6d0537dee93b49c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083489 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746539} Bug: b/150201921 Change-Id: I1a7d9008eb625be46dac9d9bc5f26728c9fcee51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087612Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#746750}
-
Christian Dullweber authored
Tbr: afakhry@chromium.org Bug: 1033651 Change-Id: I77d508ac49278c46a9bc0ee0ffa8e3c10a72c550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087814Reviewed-by:
-
Fredrik Söderquist authored
This moves the reference to the FilterData structure from being stored on the LayoutSVGResourceFilter to being stored on the data structure that is associated with the client (SVGElementResourceClient). This is in preparation for supporting the "full" syntax for the 'filter' property - which among other things means that multiple reference filters needs to be supported. It also ends up making the associated invalidation machinery a tad simpler (for instance no longer needing the kSkipAncestorInvalidation invalidation flag). Bug: 109224 Change-Id: I7718a90829bee608a4e0b2a9fcc813dea9233f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081819Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#746748}
-
Clemens Arbesser authored
Bug: b/150752324 Change-Id: Ida677ca8cd062856c053bcfc632b55da868ada1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087754 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Ben Joyce authored
Bug: 1052460 Change-Id: I1b72d3f0d6773dde050c79fac21807fae7d9b1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086813 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746746}
-
Christian Dullweber authored
ContextualSearchManagerTest#testTapCausesOneLowPriorityRequest and ContextualSearchManagerTest#testAllInternalStatesVisitedResolvingTap are flaky. Tbr: donnd@chromium.org Bug: 1058297 Change-Id: I88391ac0f3fabdfdd54fa894d966e6559c20afce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087582Reviewed-by:
-
Dominique Fauteux-Chapleau authored
Change-Id: I91b279054b959b6af3b202bb90e40228360093d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085295Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#746744}
-
Mathias Bynens authored
CDP’s Emulation#setEmulatedVisionDeficiency no longer accepts the empty string to clear the override. This patch updates InspectorEmulationAgent::disable accordingly. Bug: chromium:1003700 Change-Id: I3f08aafd4b2ff0ecdf119f1d6898a8960cc3eb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087672 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#746743}
-
Alice Wang authored
This CL replaces ChromeSigninController in payments/ui/PaymentRequestUI.java by IdentityManager. Bug: 1049630 Change-Id: Ia29bc0a51388bf33372effa5bff4c43b375150b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083184Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746742}
-
Andrey Zaytsev authored
Also implemented all of the states for the password check (matches the JS frontend ones) and added tests for the Observer logic. Bug: 1015841 Change-Id: Ie2485cdb406ea0ac44b79d4f3456bf0e7644bbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076477 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#746741}
-
Maksim Moskvitin authored
Deserialization methods were removed from Invalidation and SingleObjectInvalidationSet classes. They weren't used outside of the tests and requires changes due to Topic->ObjectID refactoring, so it's better to remove them. Bug: 1056669 Change-Id: Idaa577e53be599b70b756ff8b89ed7fed6b440c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087712 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/806369810527..4518a20e14ec git log 806369810527..4518a20e14ec --date=short --first-parent --format='%ad %ae %s' 2020-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b7f5172d..02cf6c70 (746590:746692) Created with: gclient setdep -r src/third_party/webrtc@4518a20e14ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I15b6238dd026b54ad8ba9f5112697e859ac8dabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087179Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746739}
-
S. Ganesh authored
Greg discovered that InstallServiceWorkItemTest.Do_ServiceName will create Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96} if it does not exist and then delete it. If the test is run on a development machine, it will corrupt the stable Chrome install. Bug: 1057233 Change-Id: I5e71c6ab9776f376dcffe0a415bfb084baec8e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086353 Auto-Submit: S. Ganesh <ganesh@chromium.org> Reviewed-by:Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#746738}
-
Kazuki Takise authored
Currently the following windows are not included as we use the same logic as building a list for the cycler: - PIP - Non-activatable windows - Windows with HIDE_IN_OVERVIEW key. In MAPIP, the PIP window is not included in the list returned by BuildWindowForCycleWithPipList as we don't want to show both the pip and original window in the cycler. The actual issue we are facing is, currently we use this list to query Chrome windows from Tast, but as PIP is not included in this list, Tast can't find the PIP window. BUG=b:145552924 BUG=b:141899229 TEST=tast --verbose run dut arc.PIP Change-Id: I16d67f14d8f3bf666e8c2b9a7c2ee99b6740a509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026911 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746737}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/56ff573a..579edae5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d5f4a9a5a6f7c5bba495cdf628854ad97c2875b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087771Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746736}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/c40c4bc38a76..c6a4c6d3d8b5 git log c40c4bc38a76..c6a4c6d3d8b5 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 johnkslang@users.noreply.github.com Improve formatting. Created with: gclient setdep -r src/third_party/glslang/src@c6a4c6d3d8b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: I37a984fa2e3a3232c7fa8ec0125547305642326d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087175Reviewed-by:
-
Mikel Astiz authored
This allows implementing web pages (server-side) that list user password URLs, even if the password itself is not decryptable. The blacklisted bit is needed because blacklisted passwords should not be displayed together with regular ones. Change-Id: I21ae248804dd7b43c7fda695dae7327fa30be054 Bug: 1053895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087211 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#746734}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/393efd6d94e4..66e045655d89 git log 393efd6d94e4..66e045655d89 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 jacktfranklin@chromium.org Migrate `replaceControlCharacters` to StringUtilities Created with: gclient setdep -r src/third_party/devtools-frontend/src@66e045655d89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I94c8e6d5fcc2a5181665dd5ec159684480a21f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087177Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/028a7a725cc6..d62881ce79c8 git log 028a7a725cc6..d62881ce79c8 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f32bf1c930c8..97484d689869 (16 commits) 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e1688b60caf7..a6d3a2dd41d4 (1 commits) 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 176f3a3dbbc9..126720bd2e57 (2 commits) 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 56364b6b6026..8985fc91089f (2 commits) Created with: gclient setdep -r src/third_party/angle@d62881ce79c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I0a3f11d98a5675b351b1324101b1ba259459253b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087178Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 1044038 Change-Id: Id4f53493068b51d3a42ea23ac626b3251554b687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083308Reviewed-by:
-
Michael Lippautz authored
Incremental steps may process ephemerons. When we are at a very deep stack there's a chance that the hang monitor interrupts us because InvokeEphemeronCallbacks is taking too long. Add deadline logic to InvokeEphemeronCallbacks to make the situation even more unlikely. Bug: 1058151 Change-Id: Ic0d455097284be83314c1e4dce6e29803bc33d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087391Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746730}
-
Hirokazu Honda authored
This is a reland of ed3b55f6 Original change's description: > media/gpu/test: Group ivf frames whose timestamps are same > > The served stream in webrtc can be dumped by the chrome > option [1]. When the stream structures spatial-layers, one > spatial layer is separately saved in one ivf in the dumped > ivf file. > > On the other hand, to play the ivf file properly, it is needed > to group the spatial layers, which have the same timestamp in > ivf frame header. IvfFileReader [2] in webrtc does so in fact. > > This applies the group logic to our own ivf parser used in > VDA test. This enables us to test SVC stream in VDA test. > > [1] --force-fieldtrials=WebRTC-DecoderDataDumpDirectory/;tmp; > [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/modules/video_coding/utility/ivf_file_reader.h > > Bug: 1044816 > Test: video.DecodeAccel.vp9_ksvc > Change-Id: I9a0bcfa9083dc71333ad3c727d6cbb6d902202bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032453 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740575} Bug: 1044816 Change-Id: Ic617db810b7d46e2065b6363d27ac1326b35abbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072341Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746729}
-
Tim van der Lippe authored
This test appears to be a noop and it is unclear what the original intention of the test was. R=aerotwist@chromium.org Change-Id: I9c398c0af9761f7ffdea8326c8be51f79dcd4f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083309 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f1fe4488c8cf..cbf6d8deb6c9 Created with: gclient setdep -r src-internal@cbf6d8deb6c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6f1b898e94f6d26038603418569e852424e78dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087176Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746727}
-
Jose Lopes authored
This is a repeating callback because SplitRange causes SourceBufferRange to return a new instance of that same class, and both instances share the callback: * https://cs.chromium.org/chromium/src/media/filters/source_buffer_range.cc?rcl=e501b7156b763939111552df391c615761c3c1bf&l=273 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007805 Change-Id: I9847d5ef4590bd86ec8b6c221884368d28181a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080477 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#746726}
-
Stepan Khapugin authored
Just moves ownership of BrowserViewWrangler to SceneController. It is still created by MainController. Bug: 1045658 Change-Id: Ie886cf0e54b236e66aa07ffe33be840fac327623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084993 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746725}
-
Keishi Hattori authored
Bug: 1044268 Change-Id: I00f1c5f368ba5f97b0507c1b24f6396d2bb8eb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087192Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746724}
-
Mohamed Amir Yosef authored
Before this patch: FindBestMatches deduplicate credentials using only the username. As a result, if two credentials with the same username exist in both stores, only one is returned. After this patch: FindBestMatches does the deduplication within account and profile store separately. Bug: 1057647 Change-Id: I0e4d321c907ee370ad6d3b42933b8aa7efd1158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084992Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#746723}
-
Stephen Nusko authored
When generating input events for fling updates, use the current animation time instead of the current clock ticks. This ensures latency measurements for fling animation frames are correctly aligned with BeginFrame timestamps. We've compared the computation of the deltas which are producer for the scrolls for various phones to ensure this is an improvement in animation smoothness. The thing to note when looking at these screenshots are the smoothness of the curve (ignoring the flat parts). For more details about how these are generated see internal bug: b/149825814 Nokia: https://drive.google.com/file/d/1Y2aPWatHg6ON98HosY9KYrgLM2SeGT_j/view?usp=sharing Pixel2: https://drive.google.com/file/d/1Va7ojVlQdk8NLdtCjdxntU5zjMUFlgbP/view?usp=sharing Pixel4: https://drive.google.com/file/d/1iazS1N1odhOqpGWTEjh_VRFi0VubZYwi/view?usp=sharing Change-Id: I7383539605f9588640c86b7342b4d93f0d65ccb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052174 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746722}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates SyncController class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I662b1b9ba4276d76c1ec2dc06cca36ae192c43ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085272 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds basic UI tests for the consent, empty credentials and stale credentials screens. Bug: 1045448, 1045452, 1045453 Change-Id: I1b103fb09f84ddc2c1b1e8dd27d718a92541d75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086232 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746720}
-
Christian Dullweber authored
SitePerProcessMouseWheelHitTestBrowserTest.MouseWheelEventPositionChange is flaky on multiple Linux bots. Tbr: alexmos@chromium.org Bug: 1033388 Change-Id: I395f75fbf7ec928df4803bef60d34fb5d5b68b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087392Reviewed-by:
-
Mohammed Abdon authored
Removing session activation observer for account id in case they exist Bug: NA Change-Id: Iac08d08f2b0dab1cc6eda922267c902b036822a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082925Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746718}
-
arthursonzogni authored
One comment was: ~~~ // This is nullptr when the worker is still starting up (until // CompleteStartWorkerPreparation() is called). ServiceWorkerVersion* running_hosted_version() const; ~~~ This is not true (anymore?). The pointer is constant and never null. Bug: 1031542 Change-Id: I44907a27c65a6ad228014f0ad4fbeded8bbab807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083456Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746717}
-
Rainhard Findling authored
* Safety check buttons are now either normal (white background) or action buttons (blue background). * This synchronizes the safety check UI with the latest UI mocks, which differentiate different levels of calls-to-action by their importance. Bug: 1015841 Change-Id: I5c4b4444033b041735656ed58eceb34cfb036942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080249Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746716}
-
Mathias Bynens authored
This patch makes it possible to emulate various vision deficiencies, including color vision deficiencies and blurry vision, in the Blink Renderer. The various deficiencies can be triggered by the new Emulation#setEmulatedVisionDeficiency command in the Chrome DevTools Protocol. Design doc: https://goo.gle/devtools-cvd Bug: chromium:1003700 Change-Id: Ie86d14b215b93aa219b91b0e7877898d2d47bc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063136 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#746715}
-
