- 16 Oct, 2018 40 commits
-
-
danakj authored
Previously the WebWidgets would each ask RenderWidget to initialize the compositor at different points in its initialization. WebPagePopup would do so after the widget was initialized, where as local root frames would do so before it was initialized (but importantly, after for_oopif_ was set - so really in the middle of initialization). WebView would do so before any initialization of RenderWidget. This made for 3 different ordering interactions of compositor initialization and RenderWidget initialization. Notably, compositor initialization goes through RenderWidget, and depends on that class. So using it before it's initialized is.. troublesome. This removes the WebWidgetClient::InitializeLayerTreeView() method, and has RenderWidget always initialize a compositor (since we always composite them now, thanks Always Forced Compositing Mode!). That allows RenderWidget to control the order of its initialization internally, so it is not used before it is initialized (or, at least not in this case.. there may be more to untangle). We add WebWidget::SetLayerTreeView() instead, which goes out to the WebWidget when the RenderWidget is being initialized, since the WebWidget is initialized first and passed to RenderWidget. This helps detangle the SimCompositor and FrameTestHelpers a bit, we no longer need 2 LayerTreeViews in SimTest - one in SimCompositor and one in TestWebViewClient. Instead we use the singular one in TestWebViewClient, and pass through the SimCompositor as the LayerTreeViewDelegate to it, so that it can implement callbacks from the compositor. Now the FrameTestHelpers must set the LayerTreeView on the various WebWidgets that it creates, either WebViewImpl or WebFrameWidgetImpls. R=ajwong@chromium.org, dcheng@chromium.org, jochen@chromium.org, piman@chromium.org Bug: 889759 Change-Id: I0e1b3ebf4132874d1151a6a770a02a1a40b650b1 Reviewed-on: https://chromium-review.googlesource.com/c/1271793Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#600165}
-
Lei Zhang authored
Change-Id: Id53aa30f876c5be1f770f22cfca375bbb74fea2b Reviewed-on: https://chromium-review.googlesource.com/c/1284209Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#600164}
-
gogerald authored
Bug: 806868 Change-Id: I4e3f2340929a68423bbc3c8153c9576d243cc032 Reviewed-on: https://chromium-review.googlesource.com/c/1284649 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600163}
-
Dominick Ng authored
The intent helper is versioned differently to Chrome. Explicitly check its version separately if the incoming WebAPK launch intent specifies the intent helper as its default browser. Fail out and launch as a tab always if the provided default browser isn't supported. BUG=893927 Change-Id: I2eb551042003eb6ca59062b86992428282ecad91 Reviewed-on: https://chromium-review.googlesource.com/c/1282143Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#600162}
-
Tom Anderson authored
After [1], dynamic refresh is the default MD mode on ChromeOS so the UI switches between touchable and non-touchable UI depending on the tablet mode state. Since the frame caption buttons are hidden when in tablet mode, there's no longer a need to change the tablet mode spacing depending on the tablet mode state: we just always use 0 spacing. This fixes an issue where a browser window gets created when in touchable UI mode (but the frame caption buttons are not shown) and then when the UI changes to non-touchable mode, the spacing between buttons is not updated to 0, but the buttons are shown. [1] https://chromium.googlesource.com/chromium/src/+/63bf489f5d0038b1208c2439a1140910d263e9dc BUG=881371 Change-Id: Ifa76428abe266aaddc2ba9c946a213060a630713 Reviewed-on: https://chromium-review.googlesource.com/c/1283942Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#600161}
-
Johannes Henkel authored
This is in preparation of referencing this type from the code generated by third_party/inspector_protocol/code_generator.py / headless/lib/browser/devtools_api/client_api_generator.py. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Change-Id: I1d053de59f0e6c07cfe42b29a3e09aaab91ac330 Reviewed-on: https://chromium-review.googlesource.com/c/1281166Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600160}
-
John Z Wu authored
Risk data is needed during credit card verification in order to communicate with payments API, and it can only be obtained by a 1st party app. Bug: 895694 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I79ee7cddf9618ee32e4050f0b3b4b61447e7ea1f Reviewed-on: https://chromium-review.googlesource.com/c/1282388 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#600159}
-
Khushal authored
Add an UMA metric which reports the accumulated time for a raster task including the time from raster worker thread and the GPU main thread. The GPU side timer takes care of only measuring time slices when the decoder is processing commands. TBR=holte@chromium.org, piman@chromium.org, sunnyps@chromium.org BUG: 894200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ed515daba4b5bdc701a20e5ff33dc770d170b2b Reviewed-on: https://chromium-review.googlesource.com/c/1283487 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#600158}
-
Xiaohui Chen authored
Bug: b/117793448 Test: histogram unit tests and manual test on device Change-Id: I3233920570752391a295da90de1f9b48d1f02924 Reviewed-on: https://chromium-review.googlesource.com/c/1285049Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#600157}
-
Chris Harrelson authored
Before this patch, ComputeVisualOverflow() was virtual, and so was AddVisualOverflowFromChildren(), which was called by ComputeVisualOverflow(). This pattern existed to share a bit more code with LayoutBlock other than the code to collect rects from children. This CL instead inlines the duplicated code in a few places and de-virtualizes AddVisualOverflowFromChildren. Bug: 894244 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic9e36c0271ac6d88ee660e9113e1a2b7db8e0148 Reviewed-on: https://chromium-review.googlesource.com/c/1281234Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600156}
-
Jia authored
Major changes in this cl are - We now use curves represented by MonotoneCubicSpline. - Other changes to trainer and modeller impl to pave the way for the next cl that will introduce an actual model for brightness. Bug: 881215 Change-Id: Ic180d7e764772b41f8f2a11a6eaaf3f0e4e72e28 Reviewed-on: https://chromium-review.googlesource.com/c/1278458 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600155}
-
Stephen Lanham authored
This #define has been error-prone in the past and now no longer matches the Widevine convention after which it was modeled. Convert to use the much-safer BUILDFLAG() macro. Update use_playready to enable_playready to match the Chromium GN conventions. BUG= Test: Cast CQ Change-Id: I5ac8a238051a6208d2960ee7ce957099b396e45a Reviewed-on: https://chromium-review.googlesource.com/c/1284065Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600154}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4edb5e25..b141a319 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: I7c0d0daa74c4813731c5ebcf8d73bd89f5b2cf52 Reviewed-on: https://chromium-review.googlesource.com/c/1283259Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600153}
-
Johannes Henkel authored
To be consistent with the other creation methods. See also: https://chromium-review.googlesource.com/c/chromium/src/+/1281166/4/headless/lib/browser/protocol/protocol_string.h Bug: chromium:891377 Change-Id: I4cf9a3ccd1dc91b428aa10e28ddbb49c56195622 Reviewed-on: https://chromium-review.googlesource.com/c/1284910Reviewed-by:
-
Kevin Strohbehn authored
Bug: 883032 Change-Id: Ib65bc5fb61f0526d9ccc688769f1f68284f3bfeb Reviewed-on: https://chromium-review.googlesource.com/c/1269860 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#600151}
-
Min Qin authored
Since feature list are not loaded before native library, this CL introduces a helper class to write the feature values to SharedPreferences, and loads them when needed. It allows download and other features to launch finch trials to start ServiceManager on startup. BUG=842245 Change-Id: I8dcc8a97ae16152e1bf33bbe7f7d7349cdffa0b4 Reviewed-on: https://chromium-review.googlesource.com/c/1271587Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600150}
-
Alexander Alekseev authored
This Cl prepares for bug 596743 and has fixes to clear for https://chromium-review.googlesource.com/c/chromium/src/+/1269235 landing. Bug: 892757 Change-Id: I9858ec633158310c805430f1f070b5cff730f94f Reviewed-on: https://chromium-review.googlesource.com/c/1282462 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#600149}
-
Brandon Wylie authored
Bug: 888712 Change-Id: I6f89d30906700b7b5f4fe283a749a09c5a6e59ce Reviewed-on: https://chromium-review.googlesource.com/c/1250061 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#600148}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88afab4ff0f0..b273e0cd217d git log 88afab4ff0f0..b273e0cd217d --date=short --no-merges --format='%ad %ae %s' 2018-10-16 lwsong@google.com Add aggregate graphs to visualization tool. 2018-10-16 perezju@chromium.org [telemetry] Fix typo in WebSocketException 2018-10-16 perezju@chromium.org [soundwave] Remove old comment Created with: gclient setdep -r src/third_party/catapult@b273e0cd217d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:876681 TBR=sullivan@chromium.org Change-Id: I5fdc43203e194660ce62571123e9f8003626dfc1 Reviewed-on: https://chromium-review.googlesource.com/c/1284569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600147}
-
rbpotter authored
crbug.com/804047 has been fixed, and the DCHECK referenced in the Print Preview JS no longer occurs. Remove the async(..., 1) workaround. Bug: None Change-Id: I0a8f38a697965e912265092d33ef7a2d0e58f85f Reviewed-on: https://chromium-review.googlesource.com/c/1281912Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600146}
-
Nate Fischer authored
No change to default behavior, because this logic is behind a flag. This blocks billing threats in WebView, and adds some tests for this functionality. This involves: * Add necessary resources to WebView's whitelist * Test Loud and Quiet interstitials * Test we use the correct threat type integer in onSafeBrowsingHit * Test that the Feature is disabled on trunk * Add hardcoded WebUI URL for billing interstitial (also for Chrome) R=changwan@chromium.org, vakh@chromium.org Feature enabled via commandline flag. This is necessary to stay consistent with Chrome. Bug: 887186 Test: run_webview_instrumentation_test_apk --gtest_filter=SafeBrowsingTest#*Billing* Test: Manual - load chrome://safe-browsing/match?type=billing with Binary-Size: Increase is due to added WebView strings for the new interstitials. Change-Id: I695c39ffdd79ef5e771027953bfffc327fc6864b Reviewed-on: https://chromium-review.googlesource.com/c/1270476Reviewed-by:Carlos IL <carlosil@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600145}
-
Vlad Tsyrklevich authored
Bug: 894423 Change-Id: I10e809b1b745f2c9d0fdcbf6bd1f958d1aec0103 Reviewed-on: https://chromium-review.googlesource.com/c/1283934Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#600144}
-
Scott Violet authored
This will be used to ensure events are properly updated based on whether the delegate handles the event or not. BUG=891489 TEST=none Change-Id: I94fd4f8b781dbf725b7c2c6ac0d540986c24c24f Reviewed-on: https://chromium-review.googlesource.com/c/1262404 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#600143}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1927dfafabc0..9b1d67982f26 git log 1927dfafabc0..9b1d67982f26 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 mbonadei@webrtc.org Remove 'iOS32 Sim Debug (iOS 9.0)' from client.webrtc. 2018-10-16 niklas.enbom@webrtc.org Revert "Remove the HighPassFilter interface" 2018-10-16 peah@webrtc.org Avoids creating empty call_order file when no call order data is written 2018-10-16 danilchap@webrtc.org Calculate max payload size for an rtp packet to fit full video frame 2018-10-16 srte@webrtc.org Don't send max allocation probe unless allocation changed. 2018-10-16 terelius@webrtc.org Update proto for new event log format. 2018-10-16 nisse@webrtc.org Delete wrappers for snprintf and vsnprintf 2018-10-16 magjed@webrtc.org Use color aligning in video quality analysis tool 2018-10-16 peah@webrtc.org AEC3: Changes to initial behavior and handling of saturated echo 2018-10-16 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 3). 2018-10-16 srte@webrtc.org Using more specific dependencies in rtc_base. 2018-10-16 danilchap@webrtc.org Always verify packet wasn't resend recently before resending it. 2018-10-16 brandtr@webrtc.org Remove |hw_encoder| and |hw_decoder| from VideoCodecTestFixture::Config. 2018-10-16 nisse@webrtc.org Delete unused code in rtc_base/stringutils.* 2018-10-16 artit@webrtc.org Add generate_ios_coverage_command.py script 2018-10-16 srte@webrtc.org Removing unnecessary dependencies on socket.h. 2018-10-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0cecb6ce..f8cad916 (599821:599923) 2018-10-16 saza@webrtc.org Remove AECM comfort noise setting from API 2018-10-16 saza@webrtc.org Remove the HighPassFilter interface 2018-10-16 peterhanspers@webrtc.org Adding support for logging severity LS_NONE. 2018-10-16 nisse@webrtc.org Implement test class LoopbackMediaTransport 2018-10-16 asapersson@webrtc.org Add test that verifies that VideoEncoderConfig max_framerate is reported to source. 2018-10-16 srte@webrtc.org Removes Clock instance from RoundRobinPacketQueue. Created with: gclient setdep -r src/third_party/webrtc@9b1d67982f26 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:894434,chromium:895435,chromium:895431,chromium:None,chromium:844647,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic49f27d148d1b629d7599b62fd91ba2a28e30935 Reviewed-on: https://chromium-review.googlesource.com/c/1284010Reviewed-by:
-
Hans Wennborg authored
New Clang versions started taking enumerations into account for the -Wshadow warning: ../../third_party/blink/renderer/platform/bindings/dom_wrapper_world.h:62:5: warning: declaration shadows a variable in namespace 'blink' [-Wshadow] kEmbedderWorldIdLimit = IsolatedWorldId::kEmbedderWorldIdLimit, ^ ../../third_party/blink/public/platform/web_isolated_world_ids.h:12:3: note: previous declaration is here kEmbedderWorldIdLimit = (1 << 29), ^ ../../third_party/blink/renderer/platform/bindings/dom_wrapper_world.h:63:5: warning: declaration shadows a variable in namespace 'blink' [-Wshadow] kIsolatedWorldIdLimit = IsolatedWorldId::kIsolatedWorldIdLimit, ^ ../../third_party/blink/public/platform/web_isolated_world_ids.h:16:3: note: previous declaration is here kIsolatedWorldIdLimit, ^ Bug: 895475 Change-Id: Idb37a14a6d7ca92b1e6bfa1d2fa3f42ffe64fe38 Reviewed-on: https://chromium-review.googlesource.com/c/1283024 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600141}
-
Jacob Dufault authored
Bug: 895995 Change-Id: Ibf2bc2ced1f502004b0ceac3830a2773ddac7ab9 Reviewed-on: https://chromium-review.googlesource.com/c/1284397Reviewed-by:
Quan Nguyen <qnnguyen@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#600140}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b708a096f473..0a3c5082ad50 git log b708a096f473..0a3c5082ad50 --date=short --no-merges --format='%ad %ae %s' 2018-10-16 chrome-bot@chromium.org Update config settings by config-updater. 2018-10-16 dgarrett@google.com chromeos_config: Remove nocturne / grunt firmwarebranch. Created with: gclient setdep -r src/third_party/chromite@0a3c5082ad50 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibf36c6e9ad43dcb93e16fc91f6421e4a1c69ce86 Reviewed-on: https://chromium-review.googlesource.com/c/1284011Reviewed-by:
-
David Bertoni authored
Add the "is_lazy," "is_for_service_workers," and "url" properties for event listeners. Bug: 891788 Change-Id: I8cabde8c8a8cf5935b448f1ec64aec25070f660e Reviewed-on: https://chromium-review.googlesource.com/c/1279197Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#600138}
-
Becky Zhou authored
On pre-N versions, the layout parameters can be ignored if we don't declare a root the inflated view. Updating the layout parameters only after view is attached to window. Bug: 895229 Change-Id: I671b83bbf6e72b9cbabb84e80636d68ba45c5dad Reviewed-on: https://chromium-review.googlesource.com/c/1282105 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600137}
-
Joel Einbinder authored
This prevents the user from accidentally hiding the frame view completely and being unable to figure out how to get it back. Bug: 895548 Change-Id: I39f503faa680bc136b14e6e521a1528ab594feff Reviewed-on: https://chromium-review.googlesource.com/c/1281873Reviewed-by:
-
Mustafa Emre Acer authored
This CL removes meacer@ and adds carlosil@ as an owner. Change-Id: Ic4ebf7b9b639ba7e23512cc80a73f29fd5f23b00 Reviewed-on: https://chromium-review.googlesource.com/c/1281241Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#600135}
-
Antonio Gomes authored
This is a follow up of mmenke's request in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1281643/3#37 BUG=879783 Change-Id: If7267a4be836a1e8adfca5f7377fa57b53ebcd49 Reviewed-on: https://chromium-review.googlesource.com/c/1284449 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#600134}
-
Antonio Gomes authored
In [1], DataReductionProxyConfigServiceClient [2] switched from using URLFetcher to SimpleURLLoader for making URL requests. During the discussion phase with tbansal and cduvall, it was mentioned that the URLRequestContext specialization used by DataReductionProxyConfigServiceClient was originally needed to obey two criterias: (i) Use of SPDY and QUIC protocols is explicitly disabled; (ii) Use of any proxies is also disabled. Today, (i) isn't needed and (ii) can be obtained with a specific load flag: net::LOAD_BYPASS_PROXY. Hence, the URLRequestContext specialization (namely BasicHTTPURLRequestContextGetter) became unneeded, since (ii) can be easily respected with the default network context. This CL removes the left over BasicHTTPURLRequestContextGetter and associated code. [1] https://crrev.com/c/1274405 [2] components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc Bug=879784 Change-Id: Ib46fecbbe03c57f0fc9375cb8986da62d77bb525 Reviewed-on: https://chromium-review.googlesource.com/c/1284169Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#600133}
-
Jao-ke Chin-Lee authored
BUG=790343,864817 Change-Id: Ia6bbae90334828022d5ec994d5ab82427c1cb66d Reviewed-on: https://chromium-review.googlesource.com/c/1284769 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600132}
-
Javier Ernesto Flores Robles authored
This CL enables presentation in iPads as a popover instead of above the keyboard. This follows the UX design for Manual Fallback. - Makes sure the accessory bar for iPad is always added when Manual Fallback is Enabled. - The responsibility of not showing the accessory bar when other UI is presenting the keyboard is now fully own by the input accessory bar view controller. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ife13cc44b4912084ccb10376ee9c53039dc00548 Reviewed-on: https://chromium-review.googlesource.com/c/1256793 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600131}
-
Jeremy Roman authored
Bug: 670615 Change-Id: I2a7592581cc251b9f1a21171416ea3492932e218 Reviewed-on: https://chromium-review.googlesource.com/c/1281047Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#600130}
-
wutao authored
This is UI side code to handle buttons in assistant notification. Bug: b/117295934 Test: manual. Change-Id: I61144f418ba7af127c09892707ba442e8c5f5e65 Reviewed-on: https://chromium-review.googlesource.com/c/1274826 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#600129}
-
Leo Liu authored
https://docs.google.com/document/d/1dzjfTfiTf_wVq_cwH85i2VQWDjKWt3ZsiqokZg21jjw/edit?usp=sharing Bug: b/117274233 Change-Id: I9ac16364a62cb8f55925dc8d5d04fdc5ce425ae9 Reviewed-on: https://chromium-review.googlesource.com/c/1277844Reviewed-by:
-
Chris Blume authored
This CL adds support for Vulkan on windows but disables it in builds. This makes it easy to enable and test. BUG=850724 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8396b2f59133df5d72d1086cf22e154dba0bb15e Reviewed-on: https://chromium-review.googlesource.com/c/1270098 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#600127}
-
Ella Ge authored
We used to have the touch adjustment range as 32dip in diameter (16dip in radius) for Android. After the zoom-for-dsf change, the pointerevent width & height became in physical pixel. It makes the actually range in dip much smaller on Android. This CL changes the adjustment range to be 32 CSS pixel, and apply the zoom_factor before compare with the pointerevent width&height. On Android, there is no ctrl +/- page zoom, so CSS pixel is dip. There is no change in behavior. On Desktop (aura), the adjustment upperbound is affected as it wasn't consider zooming before but now it does. Therefore, the bound will be affected by zoom_factor. On aura, there wasn't an upper bound for adjustment range before the unified touch adjustment change, which means the adjustment range is always the pointerevent width & height (physical pixel not changed). When we zoom in, the upper bound is increased, but the adjustment range will follow the finger size. So I think it's ok to make the bound changing with zooming as well on aura. Bug: 894961 Change-Id: I466d6b187359f13c82c62860086cb9eeef8cb2a5 Reviewed-on: https://chromium-review.googlesource.com/c/1279204 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600126}
-
