- 03 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/093915377ad7..6544c663aa7e 2020-12-03 bmeurer@chromium.org [debugger] Don't load sources from stale raw modules. 2020-12-03 jacktfranklin@chromium.org [DataGrid] add dark mode colors 2020-12-03 jacktfranklin@chromium.org Ban underscored methods and properties in TS files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1155067 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If743c284791703197f11f9aefd9271ab4b3dae7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570403Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833253}
-
Rakina Zata Amni authored
Introduces DidCommitSameDocumentNavigationParams, which currently only contains one field: is_history_api_navigation, to distinguish history API vs fragment change same-document navigations. This is needed to determine the "method" value for same-document navigations - the history API would override the method to "GET", while fragment navigations will reuse the method from the last navigation (for more details, see DocumentLoader::UpdateForSameDocumentNavigation). This CL also fixes code that either assumed all same-document navigations use GET (NavigationRequest::CreateForCommit), or all same-document navigations reuse last navigation's method (RenderFrameHostImpl::DidCommitNewDocument). See same-document navigation refactor doc: https: //docs.google.com/document/d/1a2rBxTR5vN6WD-LfJrF0FdEzMmFn_WVgeUS4I9z041k/edit?usp=sharing Bug: 1133115, 1131832 Change-Id: I85c5ab6b7ac75597a459a1faf9845000551e2314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556732 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833252}
-
Colin Blundell authored
This is a straightforward wrapper around //content's NavigationHandler#isExternalProtocol(), with the naming and semantics reversed to aid in clarity for external embedders. Bug: 1145983 Change-Id: Ie3c61e4436e4de1f5ff99c20a0435c19504b02e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554574 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#833251}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6e7167456b5e..c40073b687da 2020-12-03 philipp.hancke@googlemail.com doc: chrome://media-internals is useful for camera issues 2020-12-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a3682304..20fa2e0b (833048:833170) 2020-12-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6b50907e..a3682304 (832826:833048) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I293b4fabc5086dd8ebe0b40578f3a567ad453606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570402Reviewed-by:
-
Victor Hugo Vianna Silva authored
The associated render tests now use an online platform to check for the expected image (https://chrome-gold.skia.org/). All these hashed images are doing in the repository is confusing developers who are new to render tests, so let's remove them. Bug: 1103836 Change-Id: Iaa541f22e6ba9002fadaae99b99d9003e4b7f5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566796 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#833249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e7d45601101..062280eeaa96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC antoniosartori@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: antoniosartori@google.com Change-Id: I52fd90d214e0f190e9ae98b5d01100588072dd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570957Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833248}
-
Ivan Šandrk authored
That bug was fixed a long time ago https://github.com/Microsoft/vscode/issues/35901 TBR=isandrk@chromium.org Change-Id: I00131047782889786137dacb8f1f1b156453386b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571115Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Auto-Submit: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#833247}
-
Tim Volodine authored
MediaDevices.getDisplayMedia is not exposed on Android WebView. Update the not-webview-exposed.txt file and re- enable tests. BUG=1144241 Change-Id: Ic6167b0fa6ace6f9573306a773b52efa99d5b427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567162Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#833246}
-
Egor Pasko authored
=== API The current ModernLinker loading primitives look like: LoadLibraryCreateRelros(path, loadAddress, libInfo); LoadLibraryUseRelros(path, loadAddress, fd); This change replaces them with: LoadLibrary(path, loadAddress, libInfo, boolean spawnRelroRegion); UseRelros(libInfo); The UseRelros() can be called *while* the library code is running, atomically replacing the RELRO region with its version backed by shared memory, if all stars align. === Motivation The main motivation is to allow the App Zygote to provide the RELRO region on systems with App Zygote enabled, and use the usual mechanism when App Zygote is not available. === Implementation highlights With this change the ModernLinker still waits for mLibInfo to arrive from the browser process, as usual, but RELRO sharing already happens after the library is loaded. I believe, there is no code path to replace concurrently with execution. Semantically there are a few notable changes: 1. When spawned, the RELRO FD is sealed as PROT_READ, making it impossible to make it writable ever again even by privileged processes. This way we should not worry where the code runs, in the Browser process or in the App Zygote. 2. Library load ranges are explicitly including the range of PT_GNU_RELRO segment. It should not affect anything now, but can potentially eliminate hard to debug crashes in distant future. The main changes are in modern_linker_jni.cc where 'class NativeLibInfo' is introduced to hold basically the same information as the Java-side LibInfo, with the ability to perform the primitives described above, and import/export internally between Java-LibInfo and NativeLibInfo. Retrospectively the move into the class does *not* provide much useful encapsulation at the moment, but seems like a good direction if we later decide to use it for LegacyLinker, mock out parts for testing. The most part I dislike most is that the class behaves like two independent parts (LoadInfo and RelroInfo), some operations affect one, but not the other. I did not attempt to make the split, as things are still a bit coupled sometimes, maybe later. OK, this was long. Bug: 1154224 Change-Id: I88af048a298310b56b3205a2b2dd765e2c69759a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560308Reviewed-by:Benoit L <lizeb@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#833245}
-
Nohemi Fernandez authored
Bug: 1131027 Change-Id: I66fb4bd7e41798cca4f693b8dff01167462dc673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568277Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#833244}
-
David Roger authored
The profile customization UI displays the (unconsented) primary account information. However, if the account is not present in cookies, there is no primary account in Chrome. In this case, the UI displays a placeholder account without badge. There is logic to update the account image when it becomes available, but there was no logic to update the badge. This CL changes the "isManaged" bit to be dynamic instead of static, and updates it when the primary account information changes. Fixed: 1153307 Change-Id: Idb91d874d269078751f50ccbf4044a076ffc815c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568285 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833243}
-
Stepan Khapugin authored
Adds the blocking UI to the BVC. This required a move of the protocol registration to the BVWrangler. Bug: none Change-Id: I81d0a868989eee7fea7e8a5d53b03c380e42ee15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547700Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833242}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ae504d46b4c4..a45552c0f29d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If6f02f8c952a4be402811346e18975db2a58db88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570863Reviewed-by:
-
Alexander Hendrich authored
This CL removes the kLoginScreenExtensions pref and instead maps the DeviceLoginScreenExtensions policy into the user policy ExtensionInstallForcelist (pref=kExtensionInstallForcelist) for the sign-in profile. This is done with the canonical LoginProfilePolicyProvider, which is also used for similar device policies that should be applied to the sign-in profile. This serves two purposes: 1) Unclutter extension install force-list prefs (see crbug.com/1151389) 2) Preparation to remove feeding device policies into user profiles (see crbug.com/1151940) Force-installed extensions on the login screen are still treated differently compared to force-installed in-session extensions based on the ExternalProviders used for the sign-in profile (see SigninScreenExtensionsExternalLoader usage in external_provider_impl.cc). Bug: 1151389, 1151940 Change-Id: I7b1112a36e9796adc4eeba611f628c25bc7350f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561847Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#833240}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4be156e9f6d..093915377ad7 2020-12-03 alexrudenko@chromium.org Revert "[e2e]: Stabilizing Font Editor e2e test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154489 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2c1ab98dbdc9f5e6c96ca3782223a3115a3746cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570028Reviewed-by:
-
Nektarios Paisios authored
Not all accessibility trees support ignored nodes. Hence, this patch ensures that comments in AXPlatformNodeDelegate that refer to ignored nodes clarify that they only apply for accessibility trees that support them. AX-Relnotes: n/a. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I715284ba966b2b35b2f9f0c5f76069b320cb063c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570319 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#833238}
-
Corentin Wallez authored
This was forgetten when WebGPU was initially enabled on Linux. Bug: chromium:976495 Change-Id: I569436e5bb33bc17e52883490e7642596b4431b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566764 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#833237}
-
David Roger authored
A spinner has been added to the bubble, which makes the user experience much better while waiting. As a result, we can increase the timeout to allow cookies being injected correctly on the web. This change will also allow collecting more data about the actual time needed for the interception: with the current timeout, around 50% of the users are not able to complete the operation, which prevents even measuring any performance data or seeing any progress. Having a more reasonable timeout allowing most users to succeed will make it easier to track and measure the improvements. Bug: 1151313 Change-Id: Ia020bfcb5d36f06251abb26ac951ff9bc8ce7443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566946 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Ionel Popescu authored
This CL adds the missing dark mode background color for video/audio popup menus. The popup menus are: internal-media-controls-overflow-menu-list and internal-media-controls-text-track-list. The white flash was caused by their white background being visible until it was covered by the items that have the correct dark mode background color. Bug: 1148578 Change-Id: Ifa148ea039ecb3a3dca448adb9f3fda62225dd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565072Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#833235}
-
Alan Cutter authored
This reverts commit 9bdd1b02. Reason for revert: ../../chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc:164: Failure Expected equality of these values: kNumApps + kNumDefaultApps Which is: 8 service->GetNumSyncItemsForTest() Which is: 15 This test failure is fixed by a different revert: https://chromium-review.googlesource.com/c/chromium/src/+/2568995 This CL does not introduce any new app installations on start up to cause the app count to change. Original change's description: > Revert "Fix default web apps not appearing in app list/management/search on Chrome OS" > > This reverts commit 090a7e86. > > Reason for revert: Suspected it introduced sync_integration_tests failure in SingleClientAppListSyncTestWithVerifier.AppListSomeApps, see https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10364/overview > > Original change's description: > > Fix default web apps not appearing in app list/management/search on Chrome OS > > > > This CL updates Chrome OS default web apps to be deployed to Chrome OS's > > app surfaces (app list, app search and app management) while maintaining > > the "do not deploy to OS" logic for non-Chrome OS. > > > > This CL upstreams the "do not deploy to OS" logic in > > GetPreinstalledWebApps() up to > > ExternalWebAppManager::PostProcessConfigs() where it can apply to all > > preinstalled web app configs uniformally. > > > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478376&signed_aid=ic4Nc7r-RtFyMKtH3FYXtA==&inline=1 > > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478378&signed_aid=VMFIAzHdQv62wv7H0Cvz7Q==&inline=1 > > > > Bug: 1153233 > > Change-Id: Idcbb0d15fc8d3f333d1d59e27b8ff624fe7b1c64 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562625 > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#832686} > > TBR=alancutter@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org > > Change-Id: I291b2c2bb25ceb9a244382c4cee7ff190c36a493 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1153233 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566769 > Reviewed-by: Olga Sharonova <olka@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832739} TBR=alancutter@chromium.org,olka@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1153233 Change-Id: I9154508d3884fa9296369d8d3976196f19c8d279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569497Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833234}
-
Patrick Brosset authored
DevTools wants to be able to display the baseline when items are aligned on it. So this change adds the offset information to the output that's already sent to the overlay frontend. Note that the item's margin is also added to the baseline's offset because the frontend only knows about item's margin boxes, so it needs an offset that's relative to that. This CL changes the format of the data sent to the frontend, so to avoid breakages if this change landed before the corresponding frontend CL, I will make sure to land the frontend first, with compatibility code for both formats. Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567355/ Bug: 1139949 Change-Id: I8c922cd07265b9dee3edc43330210cf935bd06fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567643 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833233}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I776061a12b4c2bc3501fdee6350c06fa58d64059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569344Reviewed-by:
-
Christoph Schwering authored
Bug: 1121990 Change-Id: I6ce17cc938c1c62b53e647058c086d818322f64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569666Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#833231}
-
Alexander Hendrich authored
The increased task priority was added to improve login screen extension's start-up time. However, login screen extensions use a different caching mechanism now (see crbug.com/1012892) so this increased task priority is no longer needed. This CL is basically a revert of https://crrev.com/c/1670898. With that task priority change we can also get rid of the added ProfileHelper::SigninProfileHasLoginScreenExtensions() method. Bug: 1012892, 1030291 Change-Id: I31f7b89b6aa2badd125691417def18b4291c6c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562145Reviewed-by:
-
Alice Wang authored
This CL moves ProfileDownloader to signin.services target. Bug: 1153048 Change-Id: I124b84b3c6331ec8871a9b2f6f4a5090fbcef528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567223 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#833229}
-
Daniel Libby authored
For composited selection to work in CAP, we'll need to record the start and end of the selection at paint time. To facilitate this, we'll need to know whether the selection rect we compute in order to paint the selection background contains the start/end of the frame's selection. This CL adds a way to query this information for a given cursor position which will be consumed at paint time. There is a mechanism to understand the selection state relative to a layout object, which we use to determine which offsets are valid for comparison. The state returned will inform the caller of the intersection of the frame's selection. Bug: 1065049 Change-Id: I217f9e8859b0790543285ddd5de100adba1e5ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567021 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#833228}
-
Alice Wang authored
This CL moves DisplayableProfileData to signin.services target. Bug: 1153047 Change-Id: If992b97b7373e4d0e55e2aa10e9793479bf326f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567916Reviewed-by:
-
Heng-Ruey Hsu authored
Presubmit add a check for TimeDelta and TimeTicks. Bug: b:174443814 Test: Build pass Change-Id: Ice363456eb2207945d0eb3a27668a9a862b04053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557124 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#833226}
-
Shik Chen authored
Bug: b/172340451 Test: Manually with tsc and open CCA Change-Id: I7ded3f05c0f416e498bed3de35038494c851ff70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569565Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#833225}
-
Titouan Rigoudy authored
This extracts the computation of the response's address space to live next to its close cousin, CalculateClientAddressSpace(). This helps ensure that the two will co-evolve in the future. In particular, we will probably want to treat more schemes than `file:` as local by default (looking at you, `chrome-extension:`...). Bug: chromium:955213 Change-Id: Ic4794cc115b35e28702ff9e7a92e1df92ee0782a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461273 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#833224}
-
Peter E Conn authored
Change-Id: I5dc70d6a7cfa877f8c402339979d5143759e69c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556643Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#833223}
-
Norman Rosas authored
also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I6c2e03dc11f647717a08baf2c4825774c1499eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569814 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Thanh Nguyen authored
Add search metrics reporter for the new sandboxed Index. The logic is similar to what we have done with IndexSync. Design doc: go/lss-sandboxing Implementation plan: go/lss-sandboxing-impl Bug: 1137560 Change-Id: I4f54cf8eaa0f0f54db0e64b71749ea87c860d26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569563Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#833221}
-
Philip Jägenstedt authored
Bug: 1155036, 1154650 Change-Id: I612c1219698ae4602e213d894cad7f705c7ce4dc No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568287 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#833220}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bdcd87cfa31e..d4be156e9f6d 2020-12-03 michael.liao@microsoft.com [e2e]: Stabilizing Font Editor e2e test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154489 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2db4ae8d10bab447b0a2bdef22cb147367dee446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568509Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ibb2d9bdc15b0292d841273faa57719ade9b27a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570250Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833218}
-
Stephen Chenney authored
We were checking for the existence of p3 then using p4. Bug: 1150401 Change-Id: Ib7be08cd86f8962399c051b96ac837cda7934d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570128 Auto-Submit: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#833217}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ice6da20dbccc5a010b315f420e730959536a0302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569347Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff0c8040cec4..8e7d45601101 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I920c3ddcdd44968e30f78a88e08f580b325a917b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569348Reviewed-by:
-
Ramin Halavati authored
ProfileImpl::SetCorsOriginAccessListForOrigin is updated to cover all off-the-record profiles. Bug: 1060940 Change-Id: I70c6a5b80b9d15d1bdbf11a59ee18c42cafb6108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564761Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#833214}
-
