- 19 May, 2020 40 commits
-
-
Rakesh Soma authored
UploadDeviceDetails RPC. Bug: 1084333 Change-Id: I079c80db8e92c0696bf3b6dba13562e2abf37574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208181 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#770050}
-
Nohemi Fernandez authored
In response to b/149180809 an additional parameter was added to the cancel add account flow. Update service accordingly. Bug: 1078815 Change-Id: I34bd4aa9a68bd949ce78d366afcee0f7b3fc423f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207158 Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#770049}
-
Camille Lamy authored
This reverts commit 14dee393. Reason for revert: Tentative revert because the function introduced in this CL is showing up in uaf stack traces on many tests on the MSAN bots. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/23956 for example. Original change's description: > Invalidate tabstrip layout when the space available for tabs changes. > > Bug: 1075913 > Change-Id: I2d65a4dc4b4b112e367f216b4a71788bdf825bbe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185430 > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > Reviewed-by: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769803} TBR=tbergquist@chromium.org,dfried@chromium.org Change-Id: Ia39ea9e4d912c9d1c74186f22e545b27b79abe27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1075913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207320Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#770048}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ef93a2618066..fde94a72d1e4 git log ef93a2618066..fde94a72d1e4 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 tommi@webrtc.org Revert "RtpVideoStreamReceiver::RtcpFeedbackBuffer: remove lock recursions." Created with: gclient setdep -r src/third_party/webrtc@fde94a72d1e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4bb7cc84639316a1da12a7716bf2c3988d05308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208708Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770047}
-
Koji Ishii authored
This patch uses |NGFragmentItems::Span| instead of defining it in multiple places. This is to prepare for changing it to a vector of |NGFragmentItem|. This patch has no behavior changes. Bug: 982194 Change-Id: Ic0b929603bb4c031c93851fa6238cbb2f43a521a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206526 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770046}
-
Oleh Lamzin authored
Clarify that local time zone is used for DeviceAdvancedBatteryChargeModeDayConfig policy. Bug: b:154476021 BYPASS_POLICY_COMPATIBILITY_CHECK=clarify timezone behavior Change-Id: If0acfe4df982f1921bdac643f77abcad07810c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206798Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#770045}
-
Aya ElAttar authored
Changed relaunch notification icon to be kBusinessIcon if the notification style isn't the default value (set by a policy). This CL is a follow-up to this one crrev.com/c/1630468. Bug: 1065461 Change-Id: Ia410241ad13cfa2a644eeaf7c46565bc6bb28eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207311 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#770044}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/XbwoK.....wCYE7... Created with: gclient setdep -r src/third_party/aemu-linux-x64@wCYE7... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Ifae8b9334a6f620ebbef6c2c9331351f156acc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208706Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3d9f3b12043b..a7e5e973577c git log 3d9f3b12043b..a7e5e973577c --date=short --first-parent --format='%ad %ae %s' 2020-05-19 alexrudenko@chromium.org Improve update performance for styles pane Created with: gclient setdep -r src/third_party/devtools-frontend/src@a7e5e973577c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065380 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I627bd0ba2790edd25bd37e941977e4ac91bf40ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208705Reviewed-by:
-
Fredrik Söderqvist authored
When checking the 'orient' enumeration value the most common query is if is an <angle> value. Since SVGAngle::IsAngle() sounds a bit too tautological name it IsNumeric() instead. Change-Id: I8b5add56dd510fe05545264dd91da9bd89527971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207176 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#770041}
-
Philipp Hancke authored
follow-up on https://github.com/web-platform-tests/wpt/commit/e880d97b7cc36c5f3c7f794c7427b46b746e656a#diff-2878d90936c40c4a1eb3e3d833ee9155 BUG=chromium:1084006 Change-Id: I1bf03d1bab1cfaab0ca05191e04339cb3bbb9815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207220Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#770040}
-
Tomislav Grbin authored
Before this CL, caller account was compared to the account we use for auth tokens. Auth tokens account is not necessarily the logged in Chrome account, so this CL compares with the logged in Chrome account explicitly. Bug: 156732291 Change-Id: I133627217db8d1c5c35213e0abd1c3c8623c228e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205995 Commit-Queue: Tomislav Grbin <tommyg@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#770039}
-
Alex Rudenko authored
DevTools takes the resources from the document fetcher's cache on startup. The manifest fetcher was using a different fetcher instance so the cache was not available. This CL allows the manifest fetcher to re-use the document's fetcher and also loads the manifest for `Page.getResourceTree` so that DevTools learn about the manifest on startup. Fixed: 1027648 Change-Id: Ic50fe002374384578df573b5dd98d2d5d0f8f8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187619Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770038}
-
Colin Blundell authored
For testing that translate works in incognito mode I'll need a browsertest where the Profile is actually *in* incognito mode. This CL adds the ability to start the WebLayer shell and browsertests in incognito. There was a TODO that mentioned adding an incognito Profile to the regular Profile in WebLayer Shell, but this CL instead takes a more straightforward approach of just having the existing Profile be created in incognito mode if desired. That is sufficient for the upcoming use case. Bug: 1072334 Change-Id: Ib56c1177e2e6f6c953f6bb985d532961a2e01245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198970 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#770037}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fd030c0d06f..f0e7344726f6 Created with: gclient setdep -r src-internal@f0e7344726f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I7874ea61c8fca80110aba4cba62b2d9e9f5c60a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208698Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770036}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3dc33457905..503f81b8fe09 git log f3dc33457905..503f81b8fe09 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 abennetts@google.com Fix inconsistency between 'top 3' list and the assigned owner. Created with: gclient setdep -r src/third_party/catapult@503f81b8fe09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084382 Tbr: sadrul@google.com Change-Id: I5aed82381bc47a684378d73ea400477b09920336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208704Reviewed-by:
-
Victor Hugo Vianna Silva authored
This CL introduces removeSavedPasswords and removePasswordExceptions APIs to chrome.passwordsPrivate, which allow deleting batches of passwords/blacklists that are entirely restored upon call to undoRemoveSavedPasswordOrException. This is achieved by plumbing the APIs introduced in crrev.com/c/2193695. In order to minimize unnecessary function duplication, all the C++ intermediary APIs now take batches as arguments. Only JS still exposes APIs for individual deletion. In future CLs, the JS APIs will be used to allow simultaneously deleting versions of a same password stored in different PasswordStore's. Bug: 1049141 Change-Id: I5852b1c4375caef4ac3e167ccd0fa9c30eeef9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199148 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#770034}
-
Marc Treib authored
LoginDatabase::ReportMetrics was recently updated to properly support the account-scoped password store (in addition to the profile-scoped one). However, StoreMetricsReporter was only calling PasswordStore::ReportMetrics (which after a few indirections ends up in LoginDatabase) for the profile store. This CL adds a ReportMetrics call for the account store as well. Bug: 1063852 Change-Id: I6afaac99f5525accd542182614e29934dc8f6dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207239Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#770033}
-
sandromaggi authored
The improvements to the test(s) were supplied in crrev/c/2206673, the flakes seem to be older than this. Bug: 1084324 Change-Id: Ib709cdb010d657422c6fb7322ef20bcad7d38702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207198Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#770032}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. Incognito test in durable_storage_permission_context_unittest.cc is updated to use the new API, and a new test is added for non-primary OTR profiles. Bug: 1060940 Change-Id: Iaa55ded4a36f993bca833ea0f68afcc9908cf693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195961 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#770031}
-
Darwin Huang authored
Consistently nest more specific conditional statements under less specific conditional statements. This was previously inconsistent and sometimes confusing, since it wasn't always easy to quickly find which platforms included which files. Refactoring change. No functional changes. Change-Id: Ie746f4a28ad4d3cdfdca43938bbb41761a933604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205007 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/416580cd..d0f8881c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie29365f444cf93e4331ca4b8a4ce67ec122cc468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208631Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770029}
-
Dmitriy Khodyrev authored
Test sync_performance_tests uses the following resource files: - $root_out_dir/chrome_100_percent.pak - $root_out_dir/chrome_200_percent.pak - $root_out_dir/locales/en-US.pak - $root_out_dir/resources.pak But there were no any dependency in build.gn between tests and the resources. The resources were not regenerated during sync_performance_tests build. The change contains the fix of the resources generation used by sync_performance_tests. Change-Id: Id311bc25189ef5ec08fd4ea733a39c30b490bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207215Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#770028}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I0e798c56a4356a4d8a0cb3b9f7354bdff58d21f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208700Reviewed-by:
-
Matthias Körber authored
Besides formatting, this is a one line change. By adding word boundaries to "land" the reported unintended mismatching with "landgrid" should be solved. Bug: 1083446 Change-Id: I9ee538118699a9fc03ee64c593a3561d9676e4fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206834 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#770026}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d8c46579122..3d9f3b12043b git log 9d8c46579122..3d9f3b12043b --date=short --first-parent --format='%ad %ae %s' 2020-05-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@3d9f3b12043b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9d8182b3427b9198a8bdbb58bab4c9eb5b274334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208696Reviewed-by:
-
Mario Sanchez Prada authored
This CL replaces usage of the routing ID to identify a frame's contents when saving a page with using the frame token instead. This will be useful in the short term to help with the conversion of FrameMsg_GetSerializedHtmlWithLocalLinks to mojo, where we'd like to avoid having to pass routing IDs so that we can eventually have the browser process communicating directly with Blink (i.e. Onion Soup). Bug: 1044088 Change-Id: Ifc6d25b76800c96c29f8a7f03637c01dd512244b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167763Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#770024}
-
Leo Zhang authored
Previously when the IME service is launched in the ime sandbox, it will try to load a the final DSO as its main entry. Now we create a fake impl for testings only. This CL also renames the ime flag with a clearer name and add some straightforward desc. BUG=b:156897880, chromium:837156 TEST='Locally run browser_tests NativeInputMethodEngineTest.*' Change-Id: I26e8007950731f490d812fd1e3c3379f899154c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206855 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#770023}
-
Tsuyoshi Horo authored
Bug: 1084048 Change-Id: I9c4ca0ce38812f1d51f4bcf349c47925489b46cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206936Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#770022}
-
Alex Rudenko authored
Sets the color space for DevToolsEyeDropper's bitmap Bug: 884170, 1066415 Change-Id: I2436c326f06dd7d68671cac9ae041fa63c93a60d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207370Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#770021}
-
Leo Zhang authored
Bug: 837156,937152 Change-Id: I1b7a61f929e40ae20d32295505e00b19c04b067b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208519 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "block-with-positioned-lastchild.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ibf7e74bae974f3e0ed77ae7905e19b0510d77e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208317 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770019}
-
David Munro authored
In some cases the user could end up with a disk larger than we allow them to have. When that happens they can still go up to their current size instead of us erroring out. Bug: chromium:1083847 Test: Unit Change-Id: If55591bfbf8d7c81c1aea27db9dc06a54ea0988f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208157 Auto-Submit: David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#770018}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/41d405e9fe05..f3dc33457905 git log 41d405e9fe05..f3dc33457905 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 dberris@chromium.org auto-triage: File issues on specific projects Created with: gclient setdep -r src/third_party/catapult@f3dc33457905 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1082032 Tbr: oysteine@google.com Change-Id: I82d6e22538cc69c730f442735d749dfee1da39a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208694Reviewed-by:
-
Piotr Tworek authored
The class declared in this header uses both std::unique_ptr and std::vector. Unfortunately it fails to include header files declaring both types. This leads to build failures on Linux systems using libstdc++ instead of bundled libcxx. Change-Id: I60eeb8a0f06ea82c3e484eff37329e1fb263a696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206638Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#770016}
-
Piotr Tworek authored
The code in this file uses memset function, but does not include the header file declaring this type. This leads to build failure on Linux systems using recent glibc versions. Bug: 1074286 Change-Id: I6bb0b1ed1cd70ef872a9809a6fff1d78eeb8de3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206637Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Piotr Tworek <ptworek@vewd.com> Cr-Commit-Position: refs/heads/master@{#770015}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/763905cc6884..9b28b9695df9 git log 763905cc6884..9b28b9695df9 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 jophba@chromium.org Fix code coverage bot--blocking checkin Created with: gclient setdep -r src/third_party/openscreen/src@9b28b9695df9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I67beadac68a5ae681a34e4e210dd9f2936691d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208692Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7a960b632510..fabf74bda604 git log 7a960b632510..fabf74bda604 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 08a05bc2b9d1..0ab78114a9e1 (5 commits) 2020-05-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader c9625f1660da..b6e8c3f0f483 (7 commits) Created with: gclient setdep -r src/third_party/angle@fabf74bda604 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I4b39408a2673779106dc202c91918f64d7d15016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208461Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/de89a4a8e174..d077e6a3d013 git log de89a4a8e174..d077e6a3d013 --date=short --first-parent --format='%ad %ae %s' 2020-05-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 275a95c1dc64..949f1e45f1dc (4 commits) 2020-05-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 32d57fc3..2d0aebd8 (378 commits) Created with: gclient setdep -r src/third_party/skia@d077e6a3d013 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I64b005da77b9b1d198fd002f6641c10bd2a22a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208691Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41a8003c. With Chromium commits locally applied on WPT: f6984fd9 "De-flaky pointerlock/pointerevent_pointermove_in_pointerlock.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I3d79a865007ca08e16caea527e313b408e93d46f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208630Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770011}
-
