GitLab

BUG=385740

Review URL: https://codereview.chromium.org/540323002

Cr-Commit-Position: refs/heads/master@{#293736}

https://skia.googlesource.com/skia/+log/6dcccc476bddd4ccba69491f6a87eed68e581414..87c4138fae37ba6b7e4de7acc3fce19524d726ea

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/552653004

Cr-Commit-Position: refs/heads/master@{#293735}

BUG=398378

Review URL: https://codereview.chromium.org/548183002

Cr-Commit-Position: refs/heads/master@{#293734}

BUG=410848

Review URL: https://codereview.chromium.org/553923002

Cr-Commit-Position: refs/heads/master@{#293733}

Revert of Removing X11 native_event uses for key events. (patchset #7 id:180001 of https://codereview.chromium.org/479873002/)

Reason for revert:
Broke Android Tests (dbg)

C  427.575s Main  [FAIL] org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText:
C  427.575s Main  junit.framework.AssertionFailedError
C  427.575s Main  	at org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:694)
C  427.575s Main  	at org.chromium.content.browser.input.ImeTest.testKeyCodesWhileComposingText(ImeTest.java:410)
C  427.575s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  427.575s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  427.575s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  427.575s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  427.575s Main  	at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
C  427.575s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  427.575s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  427.575s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  427.575s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

Original issue's description:
> Removing uses of X11 native key events.
>
> BUG=380349
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822
>
> Committed: https://chromium.googlesource.com/chromium/src/+/13d90b146a400156427243d05159cadd8d72c0b9

TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,boliu@chromium.org,kpschoedel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380349

Review URL: https://codereview.chromium.org/548303003

Cr-Commit-Position: refs/heads/master@{#293732}

TBR=ulan@chromium.org

Summary of changes available at:
https://chromium.googlesource.com/external/v8/+log/1af4d9551ad4..42ed2fc449e8

BUG=

Review URL: https://codereview.chromium.org/554643002

Cr-Commit-Position: refs/heads/master@{#293731}

Revert of Adding Text Selection Action Bar Unit Test cases. (patchset #11 id:190001 of https://codereview.chromium.org/521583003/)

Reason for revert:
This is breaking on Android Tests (dbg)

Original issue's description:
> Adding Text Selection Action Bar Unit Test cases.
>
> Currently there is not enough unit test cases available to cover
> the functionality of Text Selection Action Bar. In this patch covering
> essentail unit test cases for the same.
>
> BUG=
>
> Committed: https://chromium.googlesource.com/chromium/src/+/7da8be70e45d91995fb4476713d7920ce77cb90f

TBR=jdduke@chromium.org,aurimas@chromium.org,ajith.v@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/549433004

Cr-Commit-Position: refs/heads/master@{#293730}

The default BrowserContextKeyedServiceFactory::GetBrowserContextToUse() returns NULL for guest mode profile, overriding it to redirect to original profile.

BUG=411763
TBR=finnur@chromium.org

Review URL: https://codereview.chromium.org/550053003

Cr-Commit-Position: refs/heads/master@{#293729}

page.

BUG=372607

Review URL: https://codereview.chromium.org/547433002

Cr-Commit-Position: refs/heads/master@{#293728}

BUG=148816

Review URL: https://codereview.chromium.org/516653002

Cr-Commit-Position: refs/heads/master@{#293727}

Revert of Forward input and compositing tasks to the Blink scheduler (patchset #21 id:400001 of https://codereview.chromium.org/363383002/)

Reason for revert:
13% regression on page load times.

BUG=411520

Original issue's description:
> Forward input and compositing tasks to the Blink scheduler
>
> Instead of posting input and compositor tasks directly to the
> main thread message loop, forward them to the Blink scheduler
> so they can be prioritized over other tasks.
>
> BUG=391005
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845
>
> Committed: https://chromium.googlesource.com/chromium/src/+/68bab3290b45a8610ad875d3c92530477c16a948

TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391005

Review URL: https://codereview.chromium.org/553483005

Cr-Commit-Position: refs/heads/master@{#293726}

I wrote two unittests which open  the device, wait for the data callback, then close the device, ran the tests in an infinite loop, after several hours, it hits NO_MIC_DATA on the input side. The problem is that sometimes the audio unit gets corrupted, and our input code does not correctly dispose the unit component, so the broken audio unit can be leaked and prevent the OS pumping audio callback to all auido units.

This patch fixes two problems:
1, AUAudioInputStream::Close() is not completely correct, we need to call AudioComponentInstanceDispose()
2, It seems that we should setup the input callback before setting the formats, which might not be correct (I am not really sure, but the tests show that I was able to restart the stream after changing it)

BUG=411869

Review URL: https://codereview.chromium.org/554523002

Cr-Commit-Position: refs/heads/master@{#293725}

Disable WebNotificationTrayTest.TouchFeedback and TouchFeedbackCancellation which are failing on ASAN machines.

TBR=skuhne@chromium.org
BUG=411881

Review URL: https://codereview.chromium.org/551833002

Cr-Commit-Position: refs/heads/master@{#293724}

This is mostly to prevent the high res avatars from being downloaded when not necessary, and will also prevent any other non-UI side effects which are undesired on non-desktop OSes.

BUG=404066, 411428

Committed: https://chromium.googlesource.com/chromium/src/+/8003a95bb88e1d25ad59251b5d7e8609d76e5669

Review URL: https://codereview.chromium.org/480453002

Cr-Commit-Position: refs/heads/master@{#293723}

Revert of Revert of Forward input and compositing tasks to the Blink scheduler (patchset #1 id:1 of https://codereview.chromium.org/548253002/)

Reason for revert:
this didn't reduce flakiness

Original issue's description:
> Revert of Forward input and compositing tasks to the Blink scheduler (patchset #21 id:400001 of https://codereview.chromium.org/363383002/)
>
> Reason for revert:
> suspecting it's causing the high rate of flakes in Instrumentation test ContentShellTest
>
> BUG=411756
>
> Original issue's description:
> > Forward input and compositing tasks to the Blink scheduler
> >
> > Instead of posting input and compositor tasks directly to the
> > main thread message loop, forward them to the Blink scheduler
> > so they can be prioritized over other tasks.
> >
> > BUG=391005
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845
> >
> > Committed: https://chromium.googlesource.com/chromium/src/+/68bab3290b45a8610ad875d3c92530477c16a948
>
> TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=391005
>
> Committed: https://chromium.googlesource.com/chromium/src/+/66f85d5405417e6ddd11e1b9be677062a2e3ae4f

TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411756

Review URL: https://codereview.chromium.org/548333002

Cr-Commit-Position: refs/heads/master@{#293722}

Changing command dispatch from a "switch" dispatch to table
based dispatch makes DoCommand about 2 times faster on
Android, and also seems to be reducing times in other
command_buffer code due to code size reduction.

BUG=394570

Review URL: https://codereview.chromium.org/540053004

Cr-Commit-Position: refs/heads/master@{#293721}

Please see https://codereview.chromium.org/510323002 for reference.

NOTRY=true

Review URL: https://codereview.chromium.org/552553002

Cr-Commit-Position: refs/heads/master@{#293720}

Add content_editable_extractor_test to the gyp file and make it pass.

BUG=371692

Review URL: https://codereview.chromium.org/548523002

Cr-Commit-Position: refs/heads/master@{#293719}

Revert of Add test for ChromeVox keyboard commands. (patchset #8 id:140001 of https://codereview.chromium.org/490443002/)

Reason for revert:
Broke Linux ChromiumOS Tests (dbg)(3)

http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1199

Original issue's description:
> Add test for ChromeVox keyboard commands.
>
> This is just a couple of quick sanity checks to prevent future regressions
> like the one in the linked bug. It tests both a Search+Shift shortcut and
> the corresponding Prefix Key shortcut.
>
> Adds support for sending the meta modifier key in
> aura/x11 tests.
>
> BUG=404470
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0
>
> Committed: https://chromium.googlesource.com/chromium/src/+/ad123c3ac76fadc625a9dff66960743d0df253ba

TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404470

Review URL: https://codereview.chromium.org/550183002

Cr-Commit-Position: refs/heads/master@{#293718}

Goal is to:

1) Reduce amount of log overhead for WebRTC clients;
2) Reduce risk for false-alarm for "no data" on initial short streams.

BUG=405449

Review URL: https://codereview.chromium.org/551763003

Cr-Commit-Position: refs/heads/master@{#293717}

BUG=410915
TEST=Start Chrome with --enable-new-avatar-menu. Sign in a profile. In
the avatar menu, the descenders in the "@gmail.com" string should not
be cut off.

Review URL: https://codereview.chromium.org/546053003

Cr-Commit-Position: refs/heads/master@{#293716}

BUG=407972

Review URL: https://codereview.chromium.org/544123003

Cr-Commit-Position: refs/heads/master@{#293715}

BUG=347425
TEST=unit_tests --gtest_filter="MetadataDatabase*"

Review URL: https://codereview.chromium.org/542233003

Cr-Commit-Position: refs/heads/master@{#293714}

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 id:1 of https://codereview.chromium.org/512693004/)

Reason for revert:
gyp change this depended on was reverted

Original issue's description:
> Changes exception for gyp files to only gyp files in build/
>
> I changed analyzer such that if a gyp file (or an included gypi file)
> changes all targets in the gyp file are marked as changed. This means
> I should no longer have to special case gyp files. I'm leaving the
> exception in place for any gyp files in build as any change to those
> really needs to recompile the world.
>
> BUG=109173
> TEST=none
> R=thakis@chromium.org
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b
>
> Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5c361bce306a985bcb65cd9db6060ccbe139f66d

TBR=thakis@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=109173

Review URL: https://codereview.chromium.org/553933002

Cr-Commit-Position: refs/heads/master@{#293713}

Cr-Commit-Position: refs/heads/master@{#293712}

Unit tests are now named *.unitjs instead of just *.js.
This is consistent with the e2e tests having a separate extension.
This avoids the files being read by the deps graph tools and avoids
regenerating/recompiling all tests when changing just one (because the
edpendency of the test_deps.js file on each test is now removed).

This also renames a test base class to use test_base.js to be consistent.

BUG=371692

Review URL: https://codereview.chromium.org/541403002

Cr-Commit-Position: refs/heads/master@{#293711}

Create HpackStaticTable singleton class, so that every HPACK context can share
a constant instance of the static table.

This lands server change 74862865 by bnc.

BUG=400336

Review URL: https://codereview.chromium.org/549583003

Cr-Commit-Position: refs/heads/master@{#293710}

BUG=330528
TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/548273002

Cr-Commit-Position: refs/heads/master@{#293709}

BUG=399533
TEST=n/a (no behavioral change)
NOTRY=true

Review URL: https://codereview.chromium.org/552693002

Cr-Commit-Position: refs/heads/master@{#293708}

BUG=410726
TEST=manual

Review URL: https://codereview.chromium.org/542643003

Cr-Commit-Position: refs/heads/master@{#293707}

BUG=None

Review URL: https://codereview.chromium.org/550903002

Cr-Commit-Position: refs/heads/master@{#293706}

BUG=405860
TEST=manual

Review URL: https://codereview.chromium.org/545233002

Cr-Commit-Position: refs/heads/master@{#293705}

- Removed the warning for the call of util.entriesToURLs.
- Made sure that all private-API call using entriesToURLs have TODO comments.
- Added issue ID for the TODO comments.

BUG=411790
TEST=manually confirmed

Review URL: https://codereview.chromium.org/546413002

Cr-Commit-Position: refs/heads/master@{#293704}

This adds API to convert handle to and from int to allow interaction
with native code.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/544103002

Cr-Commit-Position: refs/heads/master@{#293703}

This CL provides touch-operation users with feedback earlier.
Menu items will be colored blue on touchstart.
Scrollable items (in directory tree and file list) will be colored gray on touchstart.
We don't use blue for them because touching them doesn't mean selecting them. (Users may have started scrolling)

BUG=404540
TEST=manually

Review URL: https://codereview.chromium.org/540873002

Cr-Commit-Position: refs/heads/master@{#293702}

TBR=blundell@chromium.org

Review URL: https://codereview.chromium.org/549123002

Cr-Commit-Position: refs/heads/master@{#293701}

BUG=374321

Committed: https://chromium.googlesource.com/chromium/src/+/77daf4022522fd889f31fe8cb6abb33c45a54857

Review URL: https://codereview.chromium.org/517193003

Cr-Commit-Position: refs/heads/master@{#293700}

The corresponding Blink side change is
https://codereview.chromium.org/531693002/.

BUG=

Review URL: https://codereview.chromium.org/531713002

Cr-Commit-Position: refs/heads/master@{#293699}

On some window managers the Maximize hints are not respected when they
are set on an unmapped window. There was an existing workaround for this
in the code, but the workaround failed whenever ShowWindowWithState
didn't happen to be called with the parameters needed to activate the
workaround. This meant that if a window was first made visible and later
activated, it would not get maximized at all.

This fix saves whether the maximize hints need to be sent to the window,
and makes sure it gets done after mapping the window.

BUG=

Review URL: https://codereview.chromium.org/543663003

Cr-Commit-Position: refs/heads/master@{#293698}

This is work around to avoid hijacking CORS preflight.
In current implementation, CORS preflight request is also sent to the ServiceWorker.
This is a bug in the implementation of HTTP fetch in DocumentThreadableLoader.
But it takes time to fix this.
So I want to introduce this work around because this is a security bug.

BUG=409454

Review URL: https://codereview.chromium.org/548773002

Cr-Commit-Position: refs/heads/master@{#293697}