GitLab

https://skia.googlesource.com/skia.git/+log/17096c763c24..882115da6b31

git log 17096c763c24..882115da6b31 --date=short --first-parent --format='%ad %ae %s'
2019-11-26 borenet@google.com [infra] Make CheckGeneratedFiles use Clang
2019-11-26 robertphillips@google.com Stop using GrPixelConfig in Metal & Dawn's GrProgramDesc creation
2019-11-26 reed@google.com Revert "Revert "switch to new filltype for SkPath""

Created with:
  gclient setdep -r src/third_party/skia@882115da6b31

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bungeman@google.com
Change-Id: I6a591ff520b33c1c32d0cfac7105a36c9fcd9a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936906Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719283}

Updates the expires_after attribute for 224 histograms that show
frequent access in the past 90 days.  These are the 80% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-05-24.

Change-Id: I8910fb8b2afe1c4c654b8b3c34dd3c28a9fd5a50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937207
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719282}

- Updated the wording on the switch comment
- Split 'GetOrCreateWindowRootAccessible' into UIA and MSAA
  versions. This is only used in test code, so I think it
  makes sense for the test to decide which version it wants
  to use.
- Added ProviderOptions_HasNativeIAccessible flag to
  provider options
- Removed MSAA Event disablement when the UIA flag is
  enabled. This means we will be firing events for both UIA
  and MSAA when the flag is on.
- ViewAXPlatformNodeDelegateWin will can no longer return
  an AXFragmentRoot. This case is handled in
  AXPlatformNodeWin::Navigate.

Note:
Windows will "translate" some IA2 events to UIA, and it is not
possible to turn this feature off, therefore, we will receive
duplicates for Focus and menu events.

Bug: 928811
Change-Id: I758b34264ddf9daeaa30674e1e207709e7e252fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906896
Commit-Queue: Jacques Newman <janewman@microsoft.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#719281}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=mpawlowski@opera.com

Bug: 1023677
Change-Id: I76203f21c6974634ca44651e792dd1b732f32fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926792
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719280}

When I rebased crrev.com/c/1921655 I accidentally reverted this
part of crrev.com/c/1918655.

Bug: 976352
Change-Id: I6d74e6d21f0b91fd41a9ba007a88c566c3e7bc6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935491Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719279}

Using wpt-import in Chromium fa91fcd5.
With Chromium commits locally applied on WPT:
e83dd93c "Limit backtracking on regexp called from blink."
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."
a2a91a99 "Allow another touch start happen when there are active touch points"
8a0ae33c "Add `Sec-Fetch-Dest: empty` header for application cache."
85b61e6b "[resource-timing] Ensure workerStart is protected by TAO"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I5b35f001300a1f6dc834216355d1c48bd7fe087f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937227Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719278}

This feature was never meant for a full launch, and thus probably
shouldn't have been in the fieldtrial testing config in the first
place. It certainly makes no sense to enable it in browser tests and
developer builds.

Bug: 1009999
Change-Id: I3cf0eab118f8fff65cfe0f2ea99222fbe32344a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936311
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719277}

This adds infobars on Desktop and Android for showing the known
monitoring disclosure.

The infobar is shown once every 7 days. The last dismissal time is
tracked in a pref on Android (to carry over across sessions) and
in-memory on Desktop (since sessions are longer -- this means on
Desktop we will always show on startup).

These currently link to chrome://monitoring (implemented in
crrev.com/c/1913715), and are triggered on visiting
https://badssl.com/test/monitoring-disclosure/ (to be replaced by
checking for the new monitoring CertStatus based on CRLSets).

Screenshots
- Desktop: https://drive.google.com/file/d/1AF2uCGfYfrQHJbLGjIX132xR0n8GqG5R/view
- Android: https://drive.google.com/file/d/1FeDSEQNasHfPdc6bbkprm_wOaMZcCDQl/view

Bug: 1014711
Change-Id: I31e9d5be6da7d87dfda2f5c739f1b94df1c8a0f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918188Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719276}

This change adds metrics to measure why the SmsService has been destroyed.

Included changes:
- SmsService destroyed because of navigation to new page
  (possibly moving onto the next step w/o using the API)
- SmsService destroyed because of navigation to same page
  (reload by clicking enter on omni box on same page)
- SmsService destroyed because of navigation to existing page
  (includes using back/forth buttons and pulling down for reload)

Does not include:
- SmsService destroyed on tab close
  - This change affects multiple files that may cause difficulty to cherry-pick
- Renaming timeout response to be "NavigatedAway"
  - This change also affects multiple files that spreads from files for
    browser process to renderer process, but will make a separate CL that
    will not be cherry-picked
  - This change will not give us more info than we have now. We can change
    metrics to show NavigateAway instead of Timeout for now w/o cherry-pick
    risk

Change-Id: I5100298ebff91fab0ce7ea57134f0daf2d149a7d
Bug: 976332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906325
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719275}

This is an unchanged reland of 0c8f0867.

See the associated bug for reasons why this work is happening.

Refactor the version number generator script to be more explicit, and do
away with the hack that was in place to support multiple version numbers
in 64-bit config.

Also, add the new pure 32-bit Mono and Trichrome numbers, as well as an
alias 32_64 version number, which is equivalent to the ambiguous
"Monochrome" version.

TBR=agrieve@chromium.org

Bug: 1027573
Change-Id: Ib1d32b02c9db6e57eba49fba602486503071fce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936890Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719274}

Bug: 1020267
Change-Id: Idb1651019f9034f9c1b00dc1ca70411724ca1120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929092
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719273}

The test suite already instantiates a FieldTrialList as per
https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so
it's no longer necessary to do so explicitly in tests.

This patch addresses unit tests under:
/components/feedback

This CL was uploaded by git cl split.

R=bsimonnet@chromium.org

Bug: 1018667
Change-Id: I7a69248b11bda233894700f6d9a39a167e7322c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917510Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719272}

Looking at chrome and android webview, looks like cache dir is used for
http cache and code cache. Use these in weblayer as well. Note before
these, neither disk cache are enabled, so there is no need to consider
any migration issue.

Bug: 1027627
Change-Id: Ib6e615e975a9cd8f7e456c6f5af1c0fac4bceea7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937087
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719271}

Some FileUtilTest tests fail if run on a Windows file system that is
being compressed. This CL filters the compressed file attribute away
before testing the file attributes.

Change-Id: I015ebc633920fe35902f2195452a26993c26c293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917216
Commit-Queue: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719270}

Bug:1025820
Change-Id: Ib6c9cae33be5befb60e5c91e5bafd3d4b04f1c8a

TBR=holte@chromium.org

Change-Id: Ib6c9cae33be5befb60e5c91e5bafd3d4b04f1c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935172Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719269}

TBR=pkotwicz@chromium.org

Bug: 1028636
Change-Id: Ib43142773bc7ae526d8e45149384bee16f1a7663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935370Reviewed-by: Ender <ender@google.com>
Auto-Submit: Ender <ender@google.com>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#719268}

Bug:1025880
Change-Id: Id8419e7417556c454b916a52fc3187f9cd43236e

TBR=holte@chromium.org

Change-Id: Id8419e7417556c454b916a52fc3187f9cd43236e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935547Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719267}

remote_viewport_intersection_ was subsumed by
IntersectionObservationState and is no longer referenced. This is just
a cleanup.

Change-Id: I326b1199172d7dc4d38bb4783d78350aa35ebca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937133
Commit-Queue: Philip Rogers <pdr@chromium.org>
Auto-Submit: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719266}

This change persists the model and host model features received from a
fetch to the remote Optimization Guide Service by places them within
the store owned by the PredictionManager.

A future change will add browser tests and metrics to confirm expected
behavior of prediction manager, fetcher, and models.

Bug: 1001194
Change-Id: I705785d32560160b14f69f846f0148d3ef6abc43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934827Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719265}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5a069fea..c92a0fa4

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I90ccb314d5553d6f971b53aa3ce5baed70e47dfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937228Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719264}

During print preview user can choose a custom page range for printing.
This can easily be less than the entire document.  The recent change
for concurrent PDF composition [1] erroneously always expected the
full document to be collected, which fails with a hung preview if the
user selects a custom page range.

Correct this by updating the PrintRenderFrameHelper to pass along only
the number of pages rendered for the page selection.

[1] https://crrev.com/c/1917685

Bug: 1028104
Change-Id: Ic6ecbc09d09a8c7f30bc959b0a3808d66f1274ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935724Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719263}

Issue: When "Add period with double-space" is turned on in System
Preferences, typing two spaces after a word inserted a space, a period,
then a second space. The period should replace the first space instead.

It turned out that, since a key event is being handled at the time of
the replacement, insertText:replacementRange: took a path that didn't
consider replacementRange, and the period just got appended before the
second space. The fix avoids the key press path when a replacement range
is specified.

Bug: 752640
Change-Id: Ia051e04f87345cd12bbd3438cf351cdc649149c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933408Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719262}

As part of converting to Once/Repeating variants of base::Callback.

This CL also converts away from gmock action templates, which don't
support move-only types.

Bug: 1007685, 1007763
Change-Id: I5386a16ba2cbb6339aae2e00c2d1f49d7ec9d959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935294
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719261}

 - Moving no-var and prefer-const to the top-level .eslintrc.js file.
 - Enable prefer-const in a few folders that were only using no-var
   previously.
 - Explicitly turn off no-var and prefer-const on folders that still
   have plenty of violations, for example chrome/test/data/extensions.

Bug: 720034
Change-Id: I927fff375b04cd8f1326082c99ceef6f8e01e133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885181Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719260}

Update template expressions replacement to use the new HTML template
start and end markers instead of looking for _template: html` and `,.
This allows some simplification of the logic and will enable i18n
replacements in JS files using class based Polymer 3 syntax, since
the autogeneration code adds these markers to the start and end of
HTML templates at build time regardless of syntax.

Also modifying some existing tests to use class based syntax, and
adding more tests for less common cases and for mixed class/legacy
syntax.

Bug: 1023841
Change-Id: I764ee18621bc526f259b7b970e6008e0de220711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935609Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719259}

Two semantic changes here:
1. ChromeTabUtils.java had a milliseconds vs seconds mismatch
   in a timeout (passing ms to function that took seconds).
2. Disables errorprone in custom_tabs_client_shared_java since
   it contains an unused import in a sub-repository.

Fixes failures for:
* BinderIdentityRestoredDangerously
* EmptyIf
* EqualsBrokenForNull
* InvalidThrows
* LongLiteralLowerCaseSuffix
* RedundantOverride
* RemoveUnusedImports
* StaticQualifiedUsingExpression
* StringEquality
* TimeUnitMismatch
* UnnecessaryStaticImport
* UseBinds
* WildcardImport

Will enable these checks in a subsequent CL.

TBR=agrieve  # lint fixes

Bug: 894616
Change-Id: Iee4b8bd187d68af93fcff042e58e87bb7faf46db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935889
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719258}

This utility function and corresponding handler are only used by the
history UI, so move them to history specific files/folders.

Bug: 1022212
Change-Id: I12c1cd4758980ca36888922f289674f1b79637ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928160
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719257}

This actually tightens a very broad RetryOnFailure suppression that was
done on Win/NVIDIA/Vulkan/Passthrough when only three different tests
were flaky. Tags these as failure instead because they are very flaky.

BUG=chromium:1017162
BUG=chromium:1028639
TBR=ynovikov@chromium.org

Change-Id: I1be168722e0ffecd4cd8d9b4ba1aefcb9d37ba15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937072Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719256}

This CL makes three small tweaks to how mixed content download
blocking handles cases where initiator origins are unknown in an
attempt to better understand/track down those cases:

1. It infers an initiator when there is no explicitly set initiator by
   looking at the tab URL. This is 'correct' in the case of a
   context-menu-initiated download.
2. It updates metrics to disambiguate these inferred initiators from
   'true' initiators.
3. It dumps without crashing in cases when initiators aren't as expected.
   We expect these cases to be rare, and this portion of the change is
   temporary. Until we understand these edge cases, it would be useful to
   have the full callstack, otherwise we'd just add another histogram.

We make use of download source to achieve this, so I've moved
DownloadItemImpl::download_source() to DownloadItem::GetDownloadSource()
so that we can determine download source without a downcast.

#1 is user-visible only if they have enabled the
#treat-unsafe-downloads-as-active-content flag. #2 and #3 are not
user-visible.

Bug: 1028179
Change-Id: I1ea38170eb62554a93d2f2f394efb9b006581ba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934246
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719255}

With this roll, tweak the dependency from inspector to a public_deps.
It's needed because Serializable is exported from CRDTP now.

Upstream review (already merged):
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1931280

Change-Id: I33c4aee3397ed4e746fc8605ce5911a2efc4c2ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927577Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719254}

EnrollmentErrorConsumerAccountWithPackagedLicense
ManualEnrollmentWithMultipleLicenses are disabled due to flaky

Bug: 1028650
Tbr: poromov@chromium.org
Change-Id: I7240fb19e577f07b9bec5ebce82ddcedbecc9161
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935372Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719253}

Bug: 1007656
Change-Id: Ie1e65006e62d17843b716a0e860b74a2f26d506c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925697
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719252}

The targets adjusted here should never have existed on 32-bit build
configurations.

Additionally, be more explicit about the various configurations in
64-bit targets.  Currently, the extra arguments may not be used, but in
follow-on changes, they will be.

Bug: 1027573
Change-Id: I42efc07618a7bfa64a04dd8d1b6c5ccc79076ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934837Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719251}

While I was developing TRACE_EVENT_BEGIN and TRACE_EVENT_END these
macros were added to the perfetto client library. Add mirrors of them in
Chromium so we have access as well.

TRACE_EVENT will allow people to conveniently emit trace events tied to
a scope and TRACE_EVENT_INSTANT for things that have no duration.

Change-Id: I474901a0ca53521b00199e32da5e21143d6781c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935113
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719250}

The PRESUBMIT.py rule checking for base::Bind and base::Callback usage
was not working, so new usage crept into places that were previously
marked clean.

This CL updates the list in PRESUBMIT.py. A lot of places listed in the
list are now clean or no longer exist. For places that were previously
clean and now violate the rule, we mostly convert them over.

3 exceptions that we add to the PRESUBMIT.py list are:
  //jingle
  //media/blink
  //weblayer

R=sky@chromium.org

Bug: 1028284
Change-Id: I2e34f57879265c4894be1d1c4d132bf17fb973a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934767
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719249}

The password check switch can only be toggled when the Safe Browsing
toggle is enabled.

The subtitle is displayed when the user is signed out and safe browsing
is enabled, since that is the moment when leak detection will be enabled
when signing in.

Note that disabling the Safe Browsing toggle only disabled the switch in
the UI and doesn't change the pref. The code which prevents the leak
detection logic to be run if safe browsing is disabled is on the
native side in https://crrev.com/c/1937175.

Bug: 1028095
Change-Id: I84ff30b8245417e8255024cea2e7679437a98636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932785
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719248}

git cl lint wants the WeakPtrFactory to be the last element in the class.
However, DISALLOW_COPY_AND_ASSIGN is also supposed to be last.  To fix
this, remove the use of the macro.

Bug: None
Change-Id: Id617ab238d1a7929017fe8c28be2689e4d3df404
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937137
Commit-Queue: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Auto-Submit: Sean Kau <skau@chromium.org>
Reviewed-by: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719247}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/978d58b7ae4d..c959541ab602


Created with:
  gclient setdep -r src-internal@c959541ab602

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:None,chromium:None
Tbr: jbudorick@google.com
Change-Id: I3c9102191a4a505e4f85316c6027e11993516f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936192Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719246}

* Make buttons stick
* Content scrollable together with the title
* Buttons not go under shelf
* Tweak eula paddings

Bug: 1019879
Change-Id: I9722316531eafcee7b496cd394b6768192184966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928703
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719245}

https://dawn.googlesource.com/dawn.git/+log/e9356045a4e0..20c014cee7c3

git log e9356045a4e0..20c014cee7c3 --date=short --first-parent --format='%ad %ae %s'
2019-11-26 cwallez@chromium.org Fix typo in the name of wgpuGetProcAddress

Created with:
  gclient setdep -r src/third_party/dawn@20c014cee7c3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Iac01f43bc9f4a3bf7b8a3443089b3006aab4169b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936904Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#719244}