GitLab

Pulls in change: https://gerrit.chromium.org/gerrit/#/c/69477/

BUG=354405,346626

Review URL: https://codereview.chromium.org/231283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262899 0039d316-1c4b-4281-b951-d872f2087c98

Removes AtomicRefCount checks from SincResampler and AudioOutputController
which never caught any issues.

BUG=295278, 349651
TEST=none

Review URL: https://codereview.chromium.org/231623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361127

Review URL: https://codereview.chromium.org/231173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262896 0039d316-1c4b-4281-b951-d872f2087c98

mod3 is the short name for ISO Level 5 shift, which is used by CA multilingual and German Neo2 keyboard layouts to allow support for a 4th shift state in addition to normal, shift, and AltGr.

BUG=335368

Review URL: https://codereview.chromium.org/227893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262895 0039d316-1c4b-4281-b951-d872f2087c98

We would like to use more than 1 thread for encoding to improve
performance. We do this only on a higher end system. The criteria is to
have at least 3 logical processors. This has worked well for WebRTC and
the same condition is applied here.

BUG=360966

Review URL: https://codereview.chromium.org/228313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262894 0039d316-1c4b-4281-b951-d872f2087c98

Create an ExtensionErrorController to be in charge of ExtensionErrorUI so that
ExtensionService doens't have to know as much about it.
And, of course, add a few tests for otherwise untested behavior.

BUG=351891

Review URL: https://codereview.chromium.org/227373007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122071

Review URL: https://codereview.chromium.org/224093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353034
TEST=None

Review URL: https://codereview.chromium.org/230873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262891 0039d316-1c4b-4281-b951-d872f2087c98

This addresses two bugs:
* Updates from the Model should be ignored while an item is being added.
* Folder deletions from the Model should be ignored since the model
  may not contain items that are not installed on the device, and we
  check for empty folders on item removal already.

BUG=361671, 361721

Review URL: https://codereview.chromium.org/229233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262890 0039d316-1c4b-4281-b951-d872f2087c98

Along the way, add DCHECKs to verify that user actions are always posted from
the UI thread.

BUG=360271
TEST=none
R=asvitkine@chromium.org, avi@chromium.org

Review URL: https://codereview.chromium.org/229873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/231833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262884 0039d316-1c4b-4281-b951-d872f2087c98

It was on by default anyway, and I don't see a reason to keep this flag around any more.

BUG=none
R=isherman@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/197333008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262883 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345417
TBR=raymes

Review URL: https://codereview.chromium.org/231643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262882 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357663

Review URL: https://codereview.chromium.org/216333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262881 0039d316-1c4b-4281-b951-d872f2087c98

This lets us also remove LayerTreeHost::AcquireLayerTextures and related
scheduler things.

BUG=337922

Review URL: https://codereview.chromium.org/227413011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262878 0039d316-1c4b-4281-b951-d872f2087c98

When launching chrome, allow new privileges so that chrome's setuid sandbox can run properly. This was recently set to false by default, and is causing problems with the Linux64/Linux32 chromedriver waterfall.

https://src.chromium.org/viewvc/chrome?revision=262786&view=revision

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/231813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262877 0039d316-1c4b-4281-b951-d872f2087c98

We should not try to change folder view's UI state if it is hidden for reparenting. The crash happens due to the |activated_view_| in top level grid view is removed since the associated folder item is removed, but the |activated_view_| is not reset to NULL. To completely prevent the similar issue, we should also integrate calamity's r261571.

BUG=360887

Review URL: https://codereview.chromium.org/231233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354143

Review URL: https://codereview.chromium.org/230443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262875 0039d316-1c4b-4281-b951-d872f2087c98

In GN it's possible to have targets with the same short name as long as the files in the root dir don't collide. This is easiest to get with source_sets, where there is no output file and you don't have to worry about naming at all.

But currently Ninja will complain about duplicate rules since we write "short" phony rules for each target. This patch skips the phony rule shortcuts for targets with duplicate names. The places where I was seeing the collision problems was in the "test_support" type target where there is little reason to use the short name anyway.

Review URL: https://codereview.chromium.org/232063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262874 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Mirror Android] Temporarily remove the Mirror flag. (https://codereview.chromium.org/231983003/)

Reason for revert:
r262868 was droved to M-35 branch as r262870.
Now we need to re-enable Mirror on trunk.

Original issue's description:
> [Mirror Android] Temporarily remove the Mirror flag.
> 
> Once in trunk this needs to be picked up to M35 beta branch.
> Once picked up, this needs to be reverted on trunk.
> 
> BUG=361827
> NOTRY=True
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262868

TBR=rogerta@chromium.org,aruslan@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361827

Review URL: https://codereview.chromium.org/232183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262872 0039d316-1c4b-4281-b951-d872f2087c98

This CL,
- Removes chrome::FindBrowser...() function calls from search_tab_helper.cc.	
- Creates a SearchTabHelperDelegate interface and have the Browser object implement that interface to provide the necessary functionality to SearchTabHelper.

BUG=272583
TEST=none

Review URL: https://codereview.chromium.org/222923007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262871 0039d316-1c4b-4281-b951-d872f2087c98

Basically dismiss the Autofill popup on changes to widget focus and unhandled
mouse presses on the current non-client view (the highest view in the origin
other than the root view).

This removes a lot of code and more closely emulates web Autofill.

BUG=259529
R=sky@chromium.org

Review URL: https://codereview.chromium.org/227713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262869 0039d316-1c4b-4281-b951-d872f2087c98

Once in trunk this needs to be picked up to M35 beta branch.
Once picked up, this needs to be reverted on trunk.

BUG=361827
NOTRY=True

Review URL: https://codereview.chromium.org/231983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262868 0039d316-1c4b-4281-b951-d872f2087c98

Ensures TopSitesImpl::MergeCachedForcedURLs doesn't keep forced URLs if they are part of the redirect list of an entry in non-forced URLs.

BUG=360894

Review URL: https://codereview.chromium.org/226543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262866 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361761
TEST=no change

Review URL: https://codereview.chromium.org/231903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262864 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171171&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/231713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262863 0039d316-1c4b-4281-b951-d872f2087c98

To simplify DesktopBackgroundController and allow customized default wallpapers,
we need to move all "default" wallpaper loading to WallpaperManager.

BUG=348136
TEST=unittests

Review URL: https://codereview.chromium.org/215293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262862 0039d316-1c4b-4281-b951-d872f2087c98

Having it enabled for all extensions leads to too much noise. Let's only have
it for unpacked extensions for now.

We have the backend implementation to turn it on or off for only particular
extensions (and error severity), but we don't have the UI for it yet. In the
interim, let's do this.

BUG=360459
TBR=finnur@chromium.org (for small changes to extension_settings_handler.cc)

Review URL: https://codereview.chromium.org/231523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262861 0039d316-1c4b-4281-b951-d872f2087c98

Note that this CL doesn't actually make the tests *pass*, but now they report actual
problems in the cast library rather than just fail immediately. Making the tests pass
will be a problem for the next CL.

Also, add tests for what happens when the sender/receiver clocks are off.

Review URL: https://codereview.chromium.org/229503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262860 0039d316-1c4b-4281-b951-d872f2087c98

This is currently unused and will complicate some in-progress
re-factoring of Browser::Type and SessionService.

BUG=360750

Review URL: https://codereview.chromium.org/225303016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359679

Review URL: https://codereview.chromium.org/229023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262858 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/227693008/.

BUG=108012

Review URL: https://codereview.chromium.org/229483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/231623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354946
TEST=ExtensionNetworkingPrivateApiTest.*
R=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262736

Review URL: https://codereview.chromium.org/225413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262855 0039d316-1c4b-4281-b951-d872f2087c98

HistoryQuick provider can provide what-you-typed scores (i.e., things
that are allowed to be the default match despite
prevent_inline_autocomplete being true) that is higher than
HistoryURL provider's what-you-typed score.

BUG=

Review URL: https://codereview.chromium.org/231023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262854 0039d316-1c4b-4281-b951-d872f2087c98

There's a small race in the libevent code: it tests whether the monotonic clock
works and, if so, uses it and skips time-warp detection. However, the flag is a
static and thus causes a race.

We don't want to lose the ability to skip time-warp detection when the system
has a monotonic clock because we expect the vast majority of systems to have
it. But I'm not quite confident enough to remove support for systems without it
yet.

Thus this patch moves the race so that it only triggers on old systems that
don't have a monotonic clock. It's still there because we don't have easy
access to a "once" object this far down and we don't want to add a static init
function. But it will stop triggering the detectors and only arise on very old
systems.

BUG=360449
R=jln@chromium.org

Review URL: https://codereview.chromium.org/231493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262853 0039d316-1c4b-4281-b951-d872f2087c98

net::NetworkInterface.

This CL doesn't attempt to find network interface type, all are initialized
to UNKNOWN type. Subsequence CL's will have platform specific code
which will gather network interface type information.

BUG=
R=agl@chromium.org
TBR=gene@chromium.org, justinlin@chromium.org

Review URL: https://codereview.chromium.org/231973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262851 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/212813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262850 0039d316-1c4b-4281-b951-d872f2087c98

Turns out the application code (specifically openssh does
this) is allows to pass incomplete fd_set structs as long
as they can store at least nfds worth of information.
This means that we can't call FD_ZERO on the pointers
given to use since FD_ZERO assumes a full fd_set.

This fixed a long standing memory corruption issue with
openssh.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/229863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262849 0039d316-1c4b-4281-b951-d872f2087c98