- 23 Jul, 2018 40 commits
- 
- 
Robert Ma authoredas another test in the same directory. Blink test runner isn't able to handle such duplicate basenames because it relies on filename mangling extensively. Bug: 866520 Change-Id: I0c9671e83dcf9c61bc20f16a43dcace827145024 Reviewed-on: https://chromium-review.googlesource.com/1146989Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#577297} 
- 
Ehsan Karamad authoredMacOSX scrollWheel event already provides the correct behavior. If the event (physical) source has precise deltas and comes from a trackpad or apple mouse then it has bidirectional deltas already and pressing shift key should not swap the axis. If the source of the event is an ordinary single-axis mouse, then the NSEvent already packs |delta_x| instead of |delta_y| (for shift-scroll). Also, it turns out that rails mode should only be used for trackpad. The logic in MosueWheelRailsFilter uses an auto-regressive filter to smooth out rails latching. This state is reset for a kPhaseScrollBegan. However, apple mice would always have a phase of kPhaseNone. Since it never resets it might lead to a large value in one axis (i.e., in y-axis after a vertical scroll phase) and when scrolling in the other direction occurs, the rails mode is set incorrectly. The side effects of this are zero scroll deltas which also fires a DCHECK in mouse_wheel_event_queue.cc: DCHECK(needs_update). To repro use an apple mouse and scroll vertically and then horizontally using the bidirectional wheel. Bug: 862661 Change-Id: I4e5210454fe7352ab0230b312f44e1a374f22f0c Reviewed-on: https://chromium-review.googlesource.com/1134434Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577296} 
- 
Dan Elphick authoredString::Utf8Length and StackTrace::GetFrame should now be called with an Isolate, which means gin::V8ToString now needs an Isolate hence the cascade of changes. Change-Id: I03f3bb91a2e985626bfa62dc1b4cd0874d00630d Reviewed-on: https://chromium-review.googlesource.com/1146651Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577295} 
- 
Justin Novosad authoredThis reverts commit 56151bcd. This reland fixes the MSAN error from the original CL by making sure the filter_quality field of CanvasResource is always initialized TBR=zmo@chromium.org Bug: 788439 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7dd29f123cbfd75598005532fc5b2135e6bfebc9 Reviewed-on: https://chromium-review.googlesource.com/1147317 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577294} 
- 
Avi Drissman authoredThe shadow around the omnibox results popup eats mouse events. Manually forward events occurring in the shadow area to the underlying widget to fix the tab strip. BUG=864963, 838667 Change-Id: I5c6499f5d024863dad611f8670fb12e1a01ff073 Reviewed-on: https://chromium-review.googlesource.com/1144225 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577293} 
- 
Dan Elphick authoredThis convert one ToString to use the Isolate form in v8_script_runner.cc rather than ToString(Context), as the no-argument form is the more immediate problem. Change-Id: I0d79f29fd937458cbaf8bb0342b8c4efa8b5ee1c Reviewed-on: https://chromium-review.googlesource.com/1146805Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577292} 
- 
Tommy Steimel authoredThis CL re-adds media type UMA metrics to the MediaLauncherActivity. In order to prevent the native initialization issues from the previous CL, this CL uses CachedMetrics to only record once native is initialized. Bug: 861954 Change-Id: I424dc1c6d8d65a031c573375f3cf1686ec1f6614 Reviewed-on: https://chromium-review.googlesource.com/1138978 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577291} 
- 
catapult-chromium-autoroll authoredhttps://chromium.googlesource.com/catapult.git/+log/9e8a0b2b37d9..1381813c377d git log 9e8a0b2b37d9..1381813c377d --date=short --no-merges --format='%ad %ae %s' 2018-07-23 nednguyen@google.com Increase default timeout limit of setting tsproxy's traffic settings to 20 seconds 2018-07-23 nednguyen@google.com Add '--story-shard-begin-index' and '--story-shard-end-index' flags 2018-07-23 nednguyen@google.com Fix PRESUBMIT errors in catapult Created with: gclient setdep -r src/third_party/catapult@1381813c377d The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865250,chromium:866095,chromium:866260 TBR=sullivan@chromium.org Change-Id: I0f4b0a06fa6b8e5312fbbd6f6385910004841801 Reviewed-on: https://chromium-review.googlesource.com/1147060Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577290} 
- 
Victor Costan authoredThis CL is extracted from https://crrev.com/c/1137851 because that CL may uncover brokenness and get reverted. Landing these changes separately minimizes the impact of a potential revert. Bug: 863724 Change-Id: I9b8888faf7a736f086ca5e496f85a78e0754a0c5 Reviewed-on: https://chromium-review.googlesource.com/1145837Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577289} 
- 
webrtc-chromium-autoroll authoredhttps://webrtc.googlesource.com/src.git/+log/94ef424b3160..a76af0ca2e8c git log 94ef424b3160..a76af0ca2e8c --date=short --no-merges --format='%ad %ae %s' 2018-07-23 titovartem@webrtc.org Move base64.h to the proper location. 2018-07-23 titovartem@webrtc.org Fixing py lint errors 2018-07-23 saza@webrtc.org Revert "Add one-stop-shop for built-in AEC toggling in APM" 2018-07-23 saza@webrtc.org Add one-stop-shop for built-in AEC toggling in APM 2018-07-23 buildbot@webrtc.org Roll chromium_revision 5e7b1029..0aff707f (577041:577150) 2018-07-23 peah@webrtc.org AEC3: Added dumping to wav files for the filter outputs 2018-07-23 oprypin@webrtc.org Fix paths that were trying to go above the root by using too many "../.." 2018-07-23 sakal@webrtc.org Remove dead code from videoframe.cc. 2018-07-23 oprypin@webrtc.org Add `is_android` guard to all Android rule usages. 2018-07-23 mbonadei@webrtc.org Fixing -Wsign-compare errors. Created with: gclient setdep -r src/third_party/webrtc@a76af0ca2e8c The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0cb33a4564e1a989eba594282c3599353bb8fbd Reviewed-on: https://chromium-review.googlesource.com/1147063Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577288} 
- 
Dmitry Gozman authoredInline StartLoad and ShouldContinueForNavigationPolicy into StartNavigation and CommitNavigation, dropping the parts which are not relevant. Bug: 789577 Change-Id: I5d580bdffed64340fc2396f7a6a274d8242fd96f Reviewed-on: https://chromium-review.googlesource.com/1107211 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577287} 
- 
skia-chromium-autoroll authoredhttps://skia.googlesource.com/skia.git/+log/df795638b9bd..1c4668d00232 git log df795638b9bd..1c4668d00232 --date=short --no-merges --format='%ad %ae %s' 2018-07-23 benjaminwagner@google.com Blacklist failing test for ANGLE IntelIris6100. 2018-07-23 csmartdalton@google.com ccpr: Blacklist Bay Trail and Sandybridge on Mesa 2018-07-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-23 jcgregorio@google.com Add continuous deploy for skottie and debugger. 2018-07-23 timliang@google.com implemented copy surface as blit for metal gpu backend 2018-07-23 jvanverth@google.com Restrict radial step count 2018-07-23 ethannicholas@google.com fixed a bug with SPIR-V ternaries 2018-07-23 jvanverth@google.com Reland "Reland "Add some optimizations to PolyUtils"" 2018-07-23 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ba365939b90c..94c91a95358b (1 commits) 2018-07-23 halcanary@google.com SkPDF: only draw text with SkglyphRuns 2018-07-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@1c4668d00232 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I4fca2a61cbc4906a8718a5323f6ebcdd2cc303b4 Reviewed-on: https://chromium-review.googlesource.com/1147064Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577286} 
- 
Aaron Leventhal authoredFor get_characterExtents(): - The x,y position should be unclipped (allowed to be negative or larger than the screen width/height). - The width/height should not be changed to 1 for offscreen objects. TBR=dmazzoni@chromium.org Bug: 864195 Change-Id: Ib8a57bee7f3b70f46c1c6791ea4c5a294c5ccfe5 Reviewed-on: https://chromium-review.googlesource.com/1146877Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577285} 
- 
Scott Chen authoredThis CL changes imports from iron-icons.html to iron-icon.html (without S), as well as moving element imports to where it's used. Bug: 855205 Change-Id: Ibe22c21ec9270258efafd1e06fed73de1d226f2d Reviewed-on: https://chromium-review.googlesource.com/1145598 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#577284} 
- 
Jenny Zhang authoredTBR=xiyuan@chromium.org Bug: 854238 Change-Id: I0268b4fbe9e6bc813fe2e7e5d4dfea72084f4102 Reviewed-on: https://chromium-review.googlesource.com/1145761 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#577283} 
- 
Philip Rogers authoredThis test is now passing with BGPT and does not need a failing expectation: fast/canvas/synchronous-create-pattern.html Bug: 853947 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id5bdba3ce5de2b6bb8d10d3a9d9d23bf1095a5dc Reviewed-on: https://chromium-review.googlesource.com/1146778Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577282} 
- 
Jun Mukai authoredIt seems Gtk+3 apps are calling this request, which is currently ignored silently and causes an issue like crbug.com/866189. Bug: 866189 Test: manually on device (see the bug for the reproducible steps) Change-Id: I89f24da5a5bced1459b65cc1ff94f63debca90d2 Reviewed-on: https://chromium-review.googlesource.com/1147255Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#577281} 
- 
depot-tools-chromium-autoroll authoredhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e3c67f2c332..5ba1e9caeecb git log 7e3c67f2c332..5ba1e9caeecb --date=short --no-merges --format='%ad %ae %s' 2018-07-23 ehmaldonado@chromium.org git cl: Start reporting metrics. 2018-07-23 jbarboza@ca.ibm.com fix fetch on aix 2018-07-23 jdoerrie@chromium.org [my_activity] Fix Filtering of Gerrit Reviews Created with: gclient setdep -r src/third_party/depot_tools@5ba1e9caeecb The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:832386,chromium:NONE TBR=agable@chromium.org Change-Id: Ibd4f5b58f3b63120cb31a6e1850f60be8287a871 Reviewed-on: https://chromium-review.googlesource.com/1147065Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577280} 
- 
Adrienne Walker authoredThis is the GpuImageDecodeCache equivalent of this change: https://chromium-review.googlesource.com/c/chromium/src/+/1147102 Bug: 866434 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59da18646c0817f011a464b7571a9b6abf7b8455 Reviewed-on: https://chromium-review.googlesource.com/1147243Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577279} 
- 
Zach Helfinstein authoredThis change is in preparation for creating the Switch Access context menu, which will behave similarly to the ChromeVox Panel. This is a pure refactor with no functional changes. Bug: 864796 Change-Id: I53c34722b97acca482514132c84894c89171c2a2 Reviewed-on: https://chromium-review.googlesource.com/1144308 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577278} 
- 
Weidong Guo authored1. Request 48px arc icon instead of 64px because the latter is not supported. 2. Override OnMetadataChanged() in SearchResultSuggestionChipView to update suggestion chip icon when metadata is updated. Bug: 865532 Change-Id: I24628a60fa93e4b434e9fcf70f703df0ec62785c Reviewed-on: https://chromium-review.googlesource.com/1144649 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#577277} 
- 
Mounir Lamouri authoredBug: 862358 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I69053e71606a26a0ee7b517768456edbb75120a0 Reviewed-on: https://chromium-review.googlesource.com/1146905Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577276} 
- 
Findit authoredThis reverts commit f7206154. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 577271 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Y3MjA2MTU0ZmI0OTcwZjQzZWY3YjQ4NTM0OGNkZjMyYzg4ZDkyNjYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/70091 Sample Failed Step: compile Original change's description: > [Background Fetch] Delete the unused FetchedEvent files. > > TBR=jbroman@chromium.org > > Bug: 822765 > Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b > Reviewed-on: https://chromium-review.googlesource.com/1142154 > Commit-Queue: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577271} Change-Id: Ic3771c3853efcdcc742d5aadcbfdf8377b73c7d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822765 Reviewed-on: https://chromium-review.googlesource.com/1146941 Cr-Commit-Position: refs/heads/master@{#577275} 
- 
Samuel Huang authoredThis CL refactors Supersize to prepare for bcanalyzer.py integration. Details: - Variable and function renames. - Split _BulkObjectFileAnalyzerWorker.AnalyzePaths(): - _ClassifyPaths(): Explicitly store .a files and .o files. For LTO we'll split .o into ELF and BC buckets. - _MakeBatches(): Reusable later for ELF and BC separately. - _DoBulkFork(): Reusable. - _RunNm(): Absorbs nm-specific code, will add alternative. - Split _BulkObjectFileAnalyzerWorker.AnalyzeStringLiterals() - _ReadElfStringData(): Separation of concern. - _GetEncodedRangesFromStringAddresses(): ELF-specific code. Will add alternative. - Restructure how results are merged, with more comments. - Split ResolveStringPiecesIndirect() (was ResolveStringPieces()): - _AnnotateStringData(): Reusable. - Will add alternative: ResolveStringPieces(). Bug: 723798 Change-Id: Ib8e0e1785ae11652a17d060c9629e3986df0f93a Reviewed-on: https://chromium-review.googlesource.com/1146775 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577274} 
- 
James Wallace-Lee authoredMove the code for chrome://accessibility out of content/. Bug: 865733 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4169a666cbf73f5ea9c3383d7aca44577b24193b Reviewed-on: https://chromium-review.googlesource.com/1144187 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#577273} 
- 
Rayan Kanso authoredBundle up the icon and the title since they will be accessed/modified together in the updateUI call. It also makes sense to move the icon from the metadata proto since that will speed up getting the registration info. TBR=avi@chromium.org Bug: 865063 Change-Id: I661062f19fddfa6b9c3bf11b5e146d5289a02593 Reviewed-on: https://chromium-review.googlesource.com/1146650 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577272} 
- 
Rayan Kanso authoredTBR=jbroman@chromium.org Bug: 822765 Change-Id: I03fa9efc6fa80814f252593a0582ff25b633580b Reviewed-on: https://chromium-review.googlesource.com/1142154 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#577271} 
- 
Ian Vollick authoredWith this change, it should be possible to support enabling ARCore integration on arm64. I've added a secondary abi analog to loadable_modules and fixed a typo in the __secondary_abi__runtime_deps target that was preventing monochrome_public_test_ar_apk from fulfilling its dependencies. Bug: 841389 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I48182a861e779417a610c20be45cdbe0c52e5b82 Reviewed-on: https://chromium-review.googlesource.com/1145470Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577270} 
- 
Mugdha Lakhani authoredTwo capabilities have been added to the GetSettledFetches task: 1. Support CacheQueryOptions, while fetching responses for completed fetches from the Cache Storage. 2. Support for filtering responses corresponding to a specific request from completed fetches. Both will be useful to support match() and matchAll() methods on BackgroundFetchSettledEvent. Bug: 863016 Change-Id: Icababdd71cd1687644cacc9460550de89bdfc4d5 Reviewed-on: https://chromium-review.googlesource.com/1140324Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#577269} 
- 
Chris Mumford authoredExtensionThrottleEntryInterface was never strictly necessary. Now that ExtensionThrottleManager does not expose the ExtensionThrottleEntry to any caller (excluding tests) it no longer needs to be a reference counted object. Also, removed the back reference to the ExtensionThrottleManager in the ExtensionThrottleEntry as that was not necessary. Bug: none Change-Id: I5188f7a024304b9159879a9d0763a075c8bfba3c Reviewed-on: https://chromium-review.googlesource.com/1132353 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577268} 
- 
Jungshik Shin authoredFor actual changes, see https://chromium-review.googlesource.com/1145582 TBR=manojgupta@chromium.org BUG=chromium:865100 TEST=locally built chrome os image works. Change-Id: Ifeaa0092937977fbb942741b1f348845c1e4596f Reviewed-on: https://chromium-review.googlesource.com/1147108Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577267} 
- 
Victor Costan authoredThe V2 schema was introduced in WebKit on 2011-07-15, in https://bugs.webkit.org/show_bug.cgi?id=58762. Removing support for the V1 schema allows us to remove the plumbing for a SQLite feature that no other part of the codebase uses. This CL does mean that a hypothetical user who hasn't upgraded Chrome for 7 years and suddenly upgrades will have their DOM storage reset. We generally support database schemas up to 2 years old, so this hypothetical user will most likely start with a clean slate anyways. Change-Id: I8e21c525a114ed1da856af5c393d62a0ad8cfb1c Reviewed-on: https://chromium-review.googlesource.com/1146280Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#577266} 
- 
Victor Costan authoredThe default value for SQLITE_DEFAULT_FILE_FORMAT has been 4 for a while. Besides, the option has a typo in our build file, so it wasn't really used. SQLITE_ENABLE_FTS3_BACKWARDS defines fts1 and fts2 as aliases for fts3. They are not actually used in Chrome. Change-Id: I1bca922862fcff665e614b098cd17e74f908b60d Reviewed-on: https://chromium-review.googlesource.com/1146158Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577265} 
- 
Khushal authoredR=ericrk@chromium.org Bug: 866434 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6c47cf25c2f15c668b50622896170886e23e6658 Reviewed-on: https://chromium-review.googlesource.com/1147253Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577264} 
- 
Becky Zhou authoredBug: 860048 Change-Id: Ib8a0daa87d8015f6c13db52484cee59dda22d0cd Reviewed-on: https://chromium-review.googlesource.com/1145822Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577263} 
- 
Nick Carter authoredJsReplace(script, args...) works by replacing $1, $2, $3, etc in |script| with JS literal values constructed from |args|, similar to base::ReplaceStringPlaceholders, except that args can be a variadic mix of strings, ints, base::Values, GURLs and more. Unlike StringPrintf or manual concatenation, this utility will properly escape string content, even if it contains slashes or quotation marks. Example 1: GURL page_url("http://example.com"); EXPECT_TRUE(ExecuteScript( shell(), JsReplace("window.open($1, '_blank');", page_url))); $1 is replaced with a double-quoted JS string literal: "http://example.com". Note that quotes around $1 are not required. Example 2: bool forced_reload = true; EXPECT_TRUE(ExecuteScript( shell(), JsReplace("window.location.reload($1);", forced_reload))); This becomes "window.location.reload(true);" -- because bool values are supported by base::Value. Numbers, lists, and dicts also work. Change-Id: I11041b6d2db299949266290b940e2d855522f2ea Reviewed-on: https://chromium-review.googlesource.com/1125098 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#577262} 
- 
Javier Ernesto Flores Robles authoredCq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7605dd087b272397bfc028fd7c2de735033d4ea3 Reviewed-on: https://chromium-review.googlesource.com/1141954 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577261} 
- 
Victor Costan authoredThe MemoryDumpProvider API uses 64-bit integers. For consistency, use SQLite's 64-bit API (sqlite_status64) to obtain memory usage statistics from SQLite. This CL also documents the SQLite build configuration setting assumed by the memory usage reporting code. The value needed by the memory reporting code is (currently) the default. However, the SQLite docs [1] recommend a different value, so documenting our needs makes it less likely that we'll accidentally end up with an incorrect configuration. Change-Id: I15217e11bce8d167dce65db345ddf78d21148144 Reviewed-on: https://chromium-review.googlesource.com/1146293Reviewed-by: Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#577260} 
- 
akaba authoredThis CL add a method to SurfaceId that allows for checking if the surfaceId is Inside some SurfaceRange. Bug: 857575 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I7b083c82f84e47dc08b9dd2f2ddf8179889ba26e Reviewed-on: https://chromium-review.googlesource.com/1145628 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by: Saman Sami <samans@chromium.org> Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577259} 
- 
Oksana Zhuravlova authoredThis change removes StartListening() and StopListening() methods from Platform and RendererBlinkPlatformImpl since they are not called anymore. Bug: 855308 Change-Id: I8f240737ca7d37abc1eb3267701f76854742d83d Reviewed-on: https://chromium-review.googlesource.com/1144224Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#577258} 
 
-