GitLab

Also renames existing CreateSession to GenerateRequest to better match
the purpose of the promise.

BUG=351501
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/878633004

Cr-Commit-Position: refs/heads/master@{#313609}

1. Use auto to improve readability.
2. Rename methods to remove "Extension" prefix.
3. Use const where possible.
4. Use using content::* to improve readability.

BUG=none

Review URL: https://codereview.chromium.org/880343002

Cr-Commit-Position: refs/heads/master@{#313608}

NOTRY=True

Review URL: https://codereview.chromium.org/873313010

Cr-Commit-Position: refs/heads/master@{#313607}

Java layer needs an exact way to determine whether a URL uses an external
protocol or not.
is_external_protocol will be true if a URL can't be handled by Chrome's
internal protocol handlers.

BUG=426751

Review URL: https://codereview.chromium.org/884473004

Cr-Commit-Position: refs/heads/master@{#313606}

When chrome.usb.closeDevice is called the device is explicitly closed in
the extension function implementation and then closed again when the
UsbDeviceResource object is destroyed. Only the latter is necessary as
that covers other ways in which the resource can be released.

Review URL: https://codereview.chromium.org/881363004

Cr-Commit-Position: refs/heads/master@{#313605}

This change merges the initial call to SetCommState/tcsetattr with
the call to ConfigurePort so that parameters such as baud rate are
configured immediately when the port is opened. Default values for
these parameters are now always applied.

This works around an issue with some serial adapter drivers on Windows
that report an invalid baud rate through GetCommState. Having the
intended baud rate available for the first call to SetCommState allows
an application to provide a valid value so that Chrome does not have
to guess.

BUG=448407

Review URL: https://codereview.chromium.org/873903002

Cr-Commit-Position: refs/heads/master@{#313604}

This is in conformance with the CA/Browser Forum Baseline Requirements for
certificate issuance.

This CL is adapted from a diff provided by sigbjorn@opera.com. Thanks!

BUG=119211
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/724543002

Cr-Commit-Position: refs/heads/master@{#313603}

I've noticed that the localization of the strings are done differently, so
it's better to use the same string for both.

BUG=

Review URL: https://codereview.chromium.org/881973002

Cr-Commit-Position: refs/heads/master@{#313602}

Add a GetDisplayColorProfile variant on Mac to return the display
color profile associated with a native window (NSWindow).

Add unit tests for on-screen, partially-on-screen, off-screen and
empty and null windows.

Note an sRGB color profile is a common case, especially on win32,
so GetDisplayColorProfile returns true and an empty color profile
in that case. Add a header file comment about that.

TEST=gfx_unittests --gtest_filter="ColorProfileTest*Window"
BUG=368694

Review URL: https://codereview.chromium.org/849523003

Cr-Commit-Position: refs/heads/master@{#313601}

Picked up changes:
56f7579 Rewrite SimilarSiblingContentExpansion
2fda06e Fix printing of logged non-ascii characters
8f4713b Only strip one stack frame from JS exceptions
efa4dce Remove unnecessary indent from code generation.
6134342 Fix TerminatingBlocksFinderTest
1f237e8 Make TerminatingBlocksFinder use a RegExp
80a34cf Change LogUtil.LOG_BUILDER to a String
9b2cdb2 Move most tests from test/ to jstest/
169cb83 Add JavaScript.parseFloat and parseInt
22cebe8 Change how TextBlock nodes are tracked
9be60c8 Add correct imports for generated JsTestEntryImpl
6b17bca Convert uses of emulated Pattern/Matcher to RegExp
c6bbc1e Add StringUtil.countWords and simplify TextBlockBuilder
7e2865e Simplify TextBlockBuilder
c73a770 Split the handling of TextNodes out of BHTMLCH
8fad736 Make test debugging more better
3e1e81e Handle equally scored candidate lead images.
a7ec3c8 Make JsTestEntry report correct success result
d2213f3 Remove unused TextBlock statistics
755df35 Add some more fancy gwt flags
6380f5c Add ElementAction that simplifies TagAction+labelStack
870b65e Move ignoring elements into FilteringDomVisitor.
48aaaa2 Use JUnit-style null assertions in OpenGraphProtocolParserTest
4ba963b querySelectorAll usage in parseMetaTags is covered in jstests
6bb3e26 Add DomDistillerJsTestCase
3f5efb3 Flesh out jstest environment
ef708c4 Use bash in install-build-deps.sh
9ef7a04 Add protobuf and xvfb packages to build deps.
33b9a04 Implement rest of the Assert interface
d75ad6b Correct function name
1d72a60 Scope repeated value for JSON converter.
e482386 Fix install-build-deps.sh for missed package
da40e84 Make jstests not fail the build
0d6b80e Add automated driver for jstests
92ae3ba Add better stack traces for jstests
a97c624 Modular heuristics for images
3bf867e Add framework for running tests in Chrome
cea631f Add .clang-format file to enable git cl format
fc23a51 Make image source absolute.
486fd14 Use java 7 and closure compiler
0dbffc4 Fix TextDocumentConstruction expectations
05c76c0 Remove gwt-2.5.1 and gwt_exporter
ed4df25 Roll gwt to 2.7.0 (from 2.5.1)
6dc14d3 Optimize SchemaOrgParser.parse for speed
d7c6805 Optimize OpenGraphProtocolParser.parseMetaTags for speed
64df32e Add fine-grained speed profiling inside MarkupParser
cd97d4f Remove a bunch of unused stuff
bf5347c Refactor handling of labels and tagactions
03cbda8 Rewrite DomWalker.walk
ee46df0 Create a simple reader mode extension

BUG=431067,435264,435371,440102,440977

Review URL: https://codereview.chromium.org/803963004

Cr-Commit-Position: refs/heads/master@{#313600}

BUG=453037

Review URL: https://codereview.chromium.org/886633002

Cr-Commit-Position: refs/heads/master@{#313599}

So that changes to this file do not need approval from
chromeos/OWNERS

BUG=none

Review URL: https://codereview.chromium.org/882903003

Cr-Commit-Position: refs/heads/master@{#313598}

So that changes in build files don't need approval from
google_apis/OWNERS.

BUG=none

Review URL: https://codereview.chromium.org/882923002

Cr-Commit-Position: refs/heads/master@{#313597}

R=spang

Review URL: https://codereview.chromium.org/880283003

Cr-Commit-Position: refs/heads/master@{#313596}

BUG=0

Review URL: https://codereview.chromium.org/883043002

Cr-Commit-Position: refs/heads/master@{#313595}

Revert of Tweak output of (memcheck|drmemory)_analyze.py. (patchset #1 id:1 of https://codereview.chromium.org/884813002/)

Reason for revert:
broke tree. don't use NOTRY=true again http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38252

Original issue's description:
> Tweak output of (memcheck|drmemory)_analyze.py.
>
> Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
> to extract them with GTestLogParser and use them as snippets.
>
> BUG=453020
> R=thestig@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/9794e18ce8653e49c1b9f6da0033276a79f88579
> Cr-Commit-Position: refs/heads/master@{#313572}

TBR=thestig@chromium.org,earthdok@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453020

Review URL: https://codereview.chromium.org/883073006

Cr-Commit-Position: refs/heads/master@{#313594}

With the new profiles UI and the high res avatar downloading code, we are sending out
waaaay too many OnProfileAvatarChanged notifications. This is particularly terrible on
Windows, where basically on every Chrome startup we refresh all the icons.

Most importantly, we need to stop downloading the avatar files every time profiles get
loaded in the ProfileInfoCache. We did this originally because the avatar files were pretty
volatile, but it's safe to assume they've stopped changing.

Secondly, the only things that care about the high res avatar files are the UserManager
and the profile switcher, so they should get a special notification that this particular
file is ready, rather that annoy all the other listeners who only care about the tiny avatars.

BUG=449569

Review URL: https://codereview.chromium.org/861053004

Cr-Commit-Position: refs/heads/master@{#313593}

This is the first patch to separate JNI registration with initialization, currently, we have JNI_OnLoad defined multiple places which has a lot of
duplicated code and JNI registration and initialization are mixed;

This patch
- Added JNIOnLoadDelegate class for each component  specific initialization.
- Added base::android::OnJNIOnLoad() to call a list of delegates
- Migrate testing, content_shell, chrome_shell.

BUG=447393
TBR=thakis

Review URL: https://codereview.chromium.org/864563002

Cr-Commit-Position: refs/heads/master@{#313592}

Fix a crash which occurs due to a CHECK firing in the HWNDMessageHandler::OnKeyEvent code path on Windows.

This crash occurs when the LegacyRenderWidgetHostHWND instance sends WM_CHAR/WM_SYSCHAR messages via the
WindowEventTarget::HandleKeyboardMessage function.

The HWNDMessageHandler class handles these messages via the OnImeMessages handler in the normal case.

The CHECK fires in the KeyEvent ctor where we validate that the KeyEvent instance has a valid event type.
In this case the WM_CHAR/WM_SYSCHAR messages are processed via the OnKeyEvent handler which leads to the problem.

Fix is to add a check for WM_CHAR/WM_SYSCHAR messages in the HWNDMessageHandler::HandleKeyboardMessage function
and call the OnImeMessages handler there. The alternative would be to add a new method to the WindowEventTarget
interface and change the LegacyRenderWidgetHostHWND class to handle these messages separately and call the new
method. I think that change would be a touch big for this case.

I also added WM_SYSDEADCHAR to the list of messages processed by the EventTypeFromNative function. We set the
type as ET_KEY_RELEASED on the same lines as WM_DEADCHAR.

BUG=451797
TEST=Covered by views_unittest WidgetTest.CharMessagesAsKeyboardMessagesDoesNotCrash

Review URL: https://codereview.chromium.org/881163002

Cr-Commit-Position: refs/heads/master@{#313591}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/073720e..52f401e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/884253002

Cr-Commit-Position: refs/heads/master@{#313590}

BUG=369661
TEST=tests stay green

Committed: https://crrev.com/66f3ec8e5ee6c3b528b5a6054cdca85ac0b29699
Reverted: https://crrev.com/96545af0f94ec1ac19a57c86806c95834de5d33c

Review URL: https://codereview.chromium.org/839413004

Cr-Commit-Position: refs/heads/master@{#313589}

With throttled, async touch dispatch, an uncancelable touchmove is sent
as soon as the touch sequence exceeds an arbitrarily defined
application slop region, separate from the platform slop region. The
intent in doing so was to allow web apps to clear any tap/press-related
state after a scroll has begun. However, the sending of this touchmove
at the start of a scroll sequence can be problematic; the early part of
a scroll sequence is often sensitive to minor bottlenecks, and the
dispatch of an additional touchmove can conceivably push the app into
high latency mode by delaying frame production.

Stop sending this slop-exceeding touchmove, instead relying on the
existing timer-based async touchmove dispatch.

Note that while this may regress touch behavior on certain sites (e.g.,
causing faulty tap interpretation), it's likely that behavior on such
sites was already racy and fragile, subject to the arbitrary value of
the fixed "application" slop region.

BUG=449275

Review URL: https://codereview.chromium.org/872633005

Cr-Commit-Position: refs/heads/master@{#313588}

This pulls in the following Native Client changes:

58c9abe: (dschuff@chromium.org) Update revision for PNaCl
fd92de8: (teravest@chromium.org) Revert "Output depfile from build_nexe."
fb70836: (dschuff@chromium.org) PNaCl: Update libc++abi revision in pnacl/COMPONENT_REVISIONS
939a13a: (teravest@chromium.org) Provide an irt_core_lib GN target.
dbf2af4: (sbc@chromium.org) Remove include of build_config.h from nacl_exception.h
e205317: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
7c8a96b: (jfb@chromium.org) Update revision for PNaCl
3d00a54: (jfb@chromium.org) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
1de8ba8: (mseaborn@chromium.org) Update codereview.settings following the switch from SVN to Git
7a6cf46: (jfb@chromium.org) Update revision for PNaCl
bc28c0b: (jvoung@chromium.org) Fix the native_client URL in the PNaCl REV file.
f8aa9dc: (bradnelson@google.com) Adding le32-nacl build of pnacl tools.
cfda521: (teravest@chromium.org) Explicitly include build_config.h.
61b7ba9: (teravest@chromium.org) Output depfile from build_nexe.
2d65c23: (jfb@chromium.org) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
5f5cd88: (sbc@chromium.org) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
1baa204: (jvoung@chromium.org) Remove some more dead code and variables from pnacl/build.sh.
f116471: (dschuff@chromium.org) Update revision for PNaCl
01f3d97: (teravest@chromium.org) Always define product_dir in build_nexe.
8a5a846: (mseaborn@chromium.org) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
c14b58a: (mseaborn@chromium.org) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
c5d8394: (bradnelson@google.com) Change driver bash scripts to work in devenv.
490e554: (dschuff@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
2a7391a: (sbc@chromium.org) Fix several issues with update_pnacl_tool_revisions.py
fbc3b5c: (dschuff@chromium.org) Support filenames with spaces in the PNaCl driver scripts.
4f726e8: (sbc@chromium.org) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
28a1341: (dschuff@chromium.org) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
9f9d773: (sbc@chromium.org) Update GCC revision in tools/REVISIONS
29ae54a: (jfb@chromium.org) Update revision for PNaCl

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk

Review URL: https://codereview.chromium.org/883073002

Cr-Commit-Position: refs/heads/master@{#313587}

This will make it have the same behaviour as the User Manager, vs. navigating to
chrome://settings/createProfile.

BUG=452125
TEST=Choose Add Person from the OS menu bar. This should create a profile and
switch to it immediately.

Review URL: https://codereview.chromium.org/870203003

Cr-Commit-Position: refs/heads/master@{#313586}

net: fix typo and add ustr.gov to HSTS preloaded list.
Cr-Commit-Position: refs/heads/master@{#313585}

screen readers know which human language to read a page in.

R=dmazzoni@chromium.org
TBR=sky@chromium.org,asanka@chromium.org
BUG=438704

Review URL: https://codereview.chromium.org/880313002

Cr-Commit-Position: refs/heads/master@{#313584}

On Mac, the --show-app-list flag causes the AppLauncher to start loading before the Profile is loaded. For this, the profile_path is sent to AppListService::InitAll(), so that this load can be aborted if it would point to a Locked Profile.

The AppListService will no longer permit loading a locked profile, and will direct to the UserManager instead. StartupBrowserCreator has a similar flow.

BUG=421308
TEST=Try to load the App Launcher for a locked profile in any possible way the Launcher can be launched ;) It should always direct to the UserManager, upon Profile Selection which then directs to the AppLauncher. Opening the AppLauncher for a non-locked profile should always work smoothly.

Review URL: https://codereview.chromium.org/856733004

Cr-Commit-Position: refs/heads/master@{#313583}

This makes the naming consistent with other use cases, e.g. CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER, ProtectedMediaIdentifierPermissionContext etc.

BUG=446263
TEST=Renaming only.

Review URL: https://codereview.chromium.org/881023002

Cr-Commit-Position: refs/heads/master@{#313582}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/884823002

Cr-Commit-Position: refs/heads/master@{#313581}

Review URL: https://codereview.chromium.org/868473002

Cr-Commit-Position: refs/heads/master@{#313580}

For MediaSourcePlayer, we can use this flag to reduce the browser seek when codec is recreated.
Will implement the logic to reduce browser seek in a follow up CL.

BUG=304234

Review URL: https://codereview.chromium.org/872253008

Cr-Commit-Position: refs/heads/master@{#313579}

This actually represents a pretty huge milestone - no more usage of
{Unmanaged} NetworkConnectionHandler from InternetOptionsHandler!
Everything is now using setProperties which uses MNCH.

BUG=430113

Review URL: https://codereview.chromium.org/700383008

Cr-Commit-Position: refs/heads/master@{#313578}

This patch changes where we do the ready to draw or ready to activate
check. Previously, this was done in the layers. Tile manager got all
of the picture layers, and asked them if they were ready. How, it
just builds a queue of an appropriate type to get this information.

R=reveman, danakj

Review URL: https://codereview.chromium.org/868803002

Cr-Commit-Position: refs/heads/master@{#313577}

When an app/extension places a ZoomController in manual mode, it is
reasonable to expect that navigating the main frame should reset that
mode, since the app/extension will be reloaded in the process.

The root cause of this bug was the sending of a ZoomChangeEvent that
contained stale information (the old, manually managed, zoom level),
which in turn caused the zoom bubble to be displayed.

BUG=450909

Review URL: https://codereview.chromium.org/884063004

Cr-Commit-Position: refs/heads/master@{#313576}

And don't break presubmit!
Basically, the change I put in previously that kind of fixed extensions redirects
actually meant presubmit would fail.
So I've gone and put in a real fix.

I also updated the redirects.json files in these GitHub repos for this to work: devtools, multi-device, and store.

Thanks, Ben, for your help.

Review URL: https://codereview.chromium.org/883963002

Cr-Commit-Position: refs/heads/master@{#313575}

This code significantly simplies the logic for matching.

Indeed, the old logic was buggy because multiple prefix matches could
results in explosive growth of the list of matches (even if only one
bookmark matches).  Reviewer, I would avoid reading and trying to
understand what CombineMatches() and the code that calls it is currently
broken.  See the second test case I added.  Before this
change, that test never terminates (in the time I waited) and explodes
the machine's memory.  Luckily this was rare; there are few reports on
crbug.

It's possible this new code is slower or faster than before (when the
old code behaved correctly).  I plan to look at the
Omnibox.Providertime.Bookmarks numbers before and after this change.

TBR=sky for owners stamp; review it if you feel like

BUG=450850,434604

Review URL: https://codereview.chromium.org/882823004

Cr-Commit-Position: refs/heads/master@{#313574}

PrefsTabHelper was watching > 1K prefs so that it could update the renderer side data structures when they change. When session restore was used and it had 50 tabs, this would take almost a second on a Z620. Switch this to watching these prefs once per profile instead.

BUG=452693

Review URL: https://codereview.chromium.org/878363002

Cr-Commit-Position: refs/heads/master@{#313573}

Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.

BUG=453020
R=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/884813002

Cr-Commit-Position: refs/heads/master@{#313572}

BUG=420680
TEST=browser_test: FileManagerJsTest.*

Review URL: https://codereview.chromium.org/876203003

Cr-Commit-Position: refs/heads/master@{#313571}

BUG=368321

Review URL: https://codereview.chromium.org/867463006

Cr-Commit-Position: refs/heads/master@{#313570}