- 26 Jul, 2018 40 commits
-
-
Yoichi Osato authored
TBR: khachatryan@chromium.org Bug: 865842 Change-Id: I33180c2c852a8da94cf735a1437eac3748203153 Reviewed-on: https://chromium-review.googlesource.com/1151027Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578210}
-
Mounir Lamouri authored
Updating the views visibility overrides the layer's visibility. This makes sure the layer is set back to the correct visibility when the views' one is updated in order to avoid the pause button to show up in cases such as a playlist. Bug: 863497 Change-Id: I0d9ce10b1219ea3af492269e228988f51c54b3e2 Reviewed-on: https://chromium-review.googlesource.com/1149507Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578209}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ad463c9517e3..254538b955bd git log ad463c9517e3..254538b955bd --date=short --no-merges --format='%ad %ae %s' 2018-07-26 wangqing-hf@loongson.cn MIPS64: Add support for depot_tools on mips64. Created with: gclient setdep -r src/third_party/depot_tools@254538b955bd The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:865294 TBR=agable@chromium.org Change-Id: I90194548f018ed6061c2fb24e9840d88992c006f Reviewed-on: https://chromium-review.googlesource.com/1150375Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578208}
-
Yoichi Osato authored
This reverts commit 7a20ffc4. Reason for revert: Still flaky https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhFeGlzdGluZ1VzZXJDb250cm9sbGVyQWN0aXZlRGlyZWN0b3J5VGVzdC5Qb2xpY3lDaGFuZ2VUcmlnZ2Vyc0ZpbGVVcGRhdGUM Original change's description: > Chromad: Fix kerberos files tests > > Modify KerberosFilesChangeWaiter to be more robust callbacks called > several times > > BUG=chromium:865206 > > Change-Id: I0c5f22fb26871607257d3b29ad3bd88d5b505c7c > Reviewed-on: https://chromium-review.googlesource.com/1145074 > Commit-Queue: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576941} TBR=alemate@chromium.org,rsorokin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 865206, 867386 Change-Id: I97bc01ed73dcd0dcc7c0fa3735f40548edc92a81 Reviewed-on: https://chromium-review.googlesource.com/1150061 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578207}
-
Alexey Khoroshilov authored
Bug: 849582 Change-Id: Idb681d282fd6754033779fb36c879cb72b0abf88 Reviewed-on: https://chromium-review.googlesource.com/1142765 Commit-Queue: Alexey Khoroshilov <sense@yandex-team.ru> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578206}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c829a63538ba..42016a47fa2b git log c829a63538ba..42016a47fa2b --date=short --no-merges --format='%ad %ae %s' 2018-07-26 nednguyen@google.com Add LogSymbolizedUnsymbolizedMinidumps to fake browser 2018-07-26 dtu@chromium.org [pinpoint] Add android-pixel2_webview-perf to list of Pinpoint bots. 2018-07-26 nednguyen@google.com Add more logging for debugging browser startup failure 2018-07-25 dtu@chromium.org [pinpoint] Case-insensitive sort for bot list. Created with: gclient setdep -r src/third_party/catapult@42016a47fa2b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865895,chromium:867592,chromium:865895 TBR=sullivan@chromium.org Change-Id: I0440cad159a1b1301e7dbf3c7d103fd92064080b Reviewed-on: https://chromium-review.googlesource.com/1150376Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578205}
-
Patti authored
Currently, if the user chooses an item in the all sites list and is taken to the Site Details page, they will be returned to the top of the all sites page upon pressing the back button. This isn't the best user experience if their all sites page is very long, as they may need to scroll back down to find the site they were originally looking at. To fix, remember the site-entry the user last clicked on and scroll back to that site-entry when returning to all sites. Bug: 835712 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I552c659408b78698c942fcef71be33783dab6578 Reviewed-on: https://chromium-review.googlesource.com/1136252 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#578204}
-
tzik authored
Change-Id: Ibc9b18bcae568d7c7d56bb9b0a16a1a96062a1c0 Reviewed-on: https://chromium-review.googlesource.com/1149768Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578203}
-
Lei Zhang authored
Change-Id: I23852629fc7c76a73aa70aa85ac1331c4e468296 Reviewed-on: https://chromium-review.googlesource.com/1150801Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#578202}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/91b8302dec04..893e730d5c4d git log 91b8302dec04..893e730d5c4d --date=short --no-merges --format='%ad %ae %s' 2018-07-25 hinoka@google.com Add vpython file 2018-07-25 tsepez@chromium.org Remove some ASSERT (and cast) in favor of checked cases. Created with: gclient setdep -r src/third_party/pdfium@893e730d5c4d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860896 TBR=dsinclair@chromium.org Change-Id: I09e78fa7575dd641ae3bd603efd7cfc160afcec9 Reviewed-on: https://chromium-review.googlesource.com/1150374Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578201}
-
Yoichi Osato authored
TBR: media-capture-and-streams@grotations.appspotmail.com Bug: 867397 Change-Id: Iebb8c62a455d2051ecf9beeb58bebaad79fd0be7 Reviewed-on: https://chromium-review.googlesource.com/1150954Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578200}
-
Matt Falkenhagen authored
This further reduces weird combination possiblities and matches the spec's concept of "using a registration": "When a service worker client is controlled by an active worker, it is considered that the service worker client is using the active worker’s containing service worker registration." https://w3c.github.io/ServiceWorker/#dfn-use Bug: 866353 Change-Id: I37a668db3696d092384deaafee6cdcbd4923e18e Reviewed-on: https://chromium-review.googlesource.com/1149765Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#578199}
-
Sara Kato authored
Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/1144581 Bug: 860093 Change-Id: I0b243881c2f2ae49f6c4ab31edeffcaf84bf32a0 Reviewed-on: https://chromium-review.googlesource.com/1150951Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#578198}
-
Noel Gordon authored
Call it getUnzippedFileRowEntries for less confusion. Bug: 867738 Change-Id: I0e38e8c41ec0cfc599aaa24b369738ffea3c2f0a Reviewed-on: https://chromium-review.googlesource.com/1150953Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578197}
-
Yuzu Saijo authored
This CL adds a new UI for NearOOM intervention v1. The code that actually shows this infobar will be added in the next CL with v1 implementation. Bug: 867353 Change-Id: I7e0914b76626dc1dbd91dd2098f7864b98e691fd Reviewed-on: https://chromium-review.googlesource.com/1084144 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#578196}
-
Peter Collingbourne authored
With this change we start building Chromium with ThinLTO when targeting Android. In 64-bit Monochrome builds, the 32-bit binary is also built with ThinLTO. This change is expected to reduce code size significantly (in local measurements it reduced the size of MonochromePublic.apk by 2.3MB) and is a prerequisite for enabling control flow integrity in official builds. Note that although this change enables ThinLTO, it does not enable the cross-TU optimizations normally associated with LTO. Enabling cross-TU optimizations is a separate project. On my local machine (a Lenovo P920) libmonochrome.so link times increase as follows: before after (first link) after (incremental links) 32-bit 18s 140s 50s 64-bit 13s 107s 41s All known blockers have now been fixed. This CL is likely to uncover unknown blockers. Bug: 469376 Change-Id: I8981e17abd50bc5ca00440e0d74dda878c911749 Reviewed-on: https://chromium-review.googlesource.com/1150870 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#578195}
-
Koji Ishii authored
Following bot results are included. 8293 8303 8306 8311 8316 8322 8331 8335 1 lines were removed and 3 lines were deflaked by consecutive results since 8272. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7959f8c83cde28a9306df50391518d8898d98896 Reviewed-on: https://chromium-review.googlesource.com/1149667 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578194}
-
Artur Khachatryan authored
Bug:chromedriver:2515 was blocked by chromium:866606, which is now fixed. Re-enabling affected tests on Mac, but disabling them for Chrome m69 because the fix for chromium:866606 is not included in the Chrome m69 build used on the waterfall. Bug: chromedriver:2515 Change-Id: I62025961187f184bdea6d0130c482cfb1a5ce411 Reviewed-on: https://chromium-review.googlesource.com/1150968Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578193}
-
Gyuyoung Kim authored
This reverts commit a49d91b6. The original commit made SessionRestoreTest.MemoryPressureLoadsNotAllTabs crash. According to my investigation, it was caused by calling SingleThreadProxy::OnCanDrawStateChanged on the main thread. To avoid it, this CL makes LayerTreeHostImpl::OnMemoryPressure call OnPurgeMemory on the impl thread through the Proxy. Bug: 839687, 860090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifaef5bcb4029da8645f393d85313be4637aea994 Reviewed-on: https://chromium-review.googlesource.com/1130567 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578192}
-
Tetsui Ohkubo authored
By design, Bluetooth settings change is disabled on a secondary user. Previous SystemTray implementation indicated that by showing dimmed Bluetooth row, but UnifiedSystemTray didn't have feedback on that. TEST=manual BUG=858973 Change-Id: I65ac3ccdcf103b91f6403453ef6ac7f0b51d60d3 Reviewed-on: https://chromium-review.googlesource.com/1146536Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#578191}
-
Peter Kasting authored
Refresh makes tabs taller, and some themes don't provide a background image of sufficient height. Tiling by repeating risks looking bad for themes that e.g. put a line across the top of tabs. Mirroring can look bad in a lot of cases too, but it's better than tiling or doing nothing. Most of this patch is plumbing to expose per-axis tiling modes. Bug: 866668 Change-Id: Ia6e00a15146e3eb32cda3c8362de4e83e67a8b7f Reviewed-on: https://chromium-review.googlesource.com/1147740 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#578190}
-
Donn Denman authored
This adds a second JavaScript API entry point to the Contextual Search Overlay Panel that can be called from the panel content. The new API allows changing the Overlay position from one open state to another, or to close it, but not to open it. BUG=834864 Change-Id: I4fe222edfcf030cfb086ddbb3ecec5071b5448f4 Reviewed-on: https://chromium-review.googlesource.com/1045178Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#578189}
-
Haruka Matsumura authored
This reverts commit 49874bf7. Reason for revert: caused a crash crbug.com/867359 Original change's description: > Oilpan: Change slots registration in HeapCompaction > > This CL changes the system of slots registration in HeapCompaction. > As preparing for HeapCompaction with IncrementalMarking, we change a timing of the registration on HashMap that related to slots, from during tracing to during atomic pause. > So, we add HashSet that registeres traced slots. > > Bug: 864425 > Change-Id: Ia63c36abbf160dfea115ebd6c6953c499d895770 > Reviewed-on: https://chromium-review.googlesource.com/1145144 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Haruka Matsumura <harukamt@google.com> > Cr-Commit-Position: refs/heads/master@{#577469} TBR=tasak@google.com,haraken@chromium.org,keishi@chromium.org,harukamt@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864425 Change-Id: Ia60c4361ef2a50c5451e3696b41020ce018e7e7a Reviewed-on: https://chromium-review.googlesource.com/1150007Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Haruka Matsumura <harukamt@google.com> Cr-Commit-Position: refs/heads/master@{#578188}
-
Chris Lu authored
This prevents multiple button action methods from being triggered at the same time. Bug: 863007 Change-Id: Ic39f6270fc604eff6aa0fed3c7103123e539b193 Reviewed-on: https://chromium-review.googlesource.com/1150634Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#578187}
-
tzik authored
SSLPrivateKeyInternal owns mojom::SSLPrivateKey, and mojom::SSLPrivateKey has a reference to SSLPrivateKeyInternal. That keeps both of them alive until a connection error happens. This CL removes the reference from mojom::SSLPK to SSLPKI to remove the cycle. Bug: 866456 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iab0a8bcd16663520873b6b7b29d9326755d93600 Reviewed-on: https://chromium-review.googlesource.com/1148095Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#578186}
-
David Black authored
This is prep work to support animations in which the pending query will animate from the bottom of its parent to the top of its parent on commit. Previously, we used two distinct views to represent a pending query and a committed query, respectively. Now, the same view will be used for a query thoughout its lifecycle. This will allow us to animate it when committed. This CL does NOT animate the view, just prepares for animating in a follow up CL. Bug: b:110228421 Change-Id: I119db0d4be48960bc13db04caeee4529d240e41d Reviewed-on: https://chromium-review.googlesource.com/1149002 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#578185}
-
Nick Harper authored
Bug: 853863 Change-Id: I15224eb329160dba1c558bc0a89f97c203f9f05f Reviewed-on: https://chromium-review.googlesource.com/1140737 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#578184}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/68936b1f34e6..625efe6dfe5b git log 68936b1f34e6..625efe6dfe5b --date=short --no-merges --format='%ad %ae %s' 2018-07-25 qingsi@google.com Use also the related address in redundancy detection for candidates from 2018-07-25 buildbot@webrtc.org Roll chromium_revision 17efa884..d6ce677a (577964:578078) Created with: gclient setdep -r src/third_party/webrtc@625efe6dfe5b The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8043ba67f3cd9fd74a2e9bef889637b248e8b66c Reviewed-on: https://chromium-review.googlesource.com/1150371Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578183}
-
Noel Gordon authored
Add tests cases for unzipping a zip archive from Downloads, Drive, and a removable volume (USB). Test: browser_tests --gtest_filter="ZipFiles/FilesApp*" Bug: 864256,865197,867738 Change-Id: Iea2d2a8537798d7eb4eab7370862fe27a4054a7e Reviewed-on: https://chromium-review.googlesource.com/1150008Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#578182}
-
Yoichi Osato authored
This reverts commit 556813c9. Reason for revert: LeakSanitizer detected memory leaks https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8940004334055018640/+/steps/content_unittests__with_patch_/0/logs/VideoTrackRecorderTest.HandlesOnError/0 Original change's description: > [Media Recorder] Fix video freeze on short recording. Fix tab crash on initialize. > > Fixes an issue where VideoTrackRecorder when used in combination with > VEAEncoder and very short recording durations (just 1 frame) would > occasionally hold on to video frames forever, causing frame buffers > from the buffer pool to become permanently blocked, eventually leading > to video capture freezing. > > The cause was a circular ownership that would happen if only 1 frame > is recorded. > > This CL additionally fixes a crash that could happen on initialization > of VEAEncoder. This issue was revealed during testing of the above fix. > Since it is not 100% if this crash was masked by the other issue, and > would only start occurring with the above fix, I am making a fix for that > part of this CL as well. > > The cause for the crash issue was that class VEAEncoder, which uses > RefCountedThreadSafe<>, would post an asynchronous task from its > constructor. If this task would finish executing before the newly > constructed instance was assigned to a scoped_refptr<> by however > called the constructor, the instance would destroy itself, because > of the AddRef() and subsequent Release() done by the posting and > running of the asynchronous task. > > The fix for this is to use a new method Initialize() instead of > posting a task from the constructor. > > Bug: 859610 > Change-Id: I6645aebfaa7659ab0ced0a20fae57eedfb9d84ab > Reviewed-on: https://chromium-review.googlesource.com/1145877 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577735} TBR=emircan@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859610,867625 Change-Id: If3fed5676c76da0d6b6ef6a041d74c782e87ebf3 Reviewed-on: https://chromium-review.googlesource.com/1150947Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578181}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I851db72337e40a9496d9bb421bd7d1b4c8916a32 Reviewed-on: https://chromium-review.googlesource.com/1150890Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578180}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee658ba8..1e6d83a2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2b4e30b5c9c7f5d83b62cf40064b51ea8c843325 Reviewed-on: https://chromium-review.googlesource.com/1150867Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578179}
-
Xiaocheng Hu authored
The hit test "point" is not really a point, but a pixel with 1px width and height. Ignoring this leads to off-by-one errors when converting a physical point into logical in vertical-rl writing mode. This patch fixes the issue by using 1px width and height in the conversion, instead of 0. Note: This patch contains an all-pass NG baseline because the legacy baseline contains a failure line. Bug: 811502 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie3f01469b4902c3c9647d40be92ccb9c26467f0d Reviewed-on: https://chromium-review.googlesource.com/1150814 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#578178}
-
Yuichiro Hanada authored
to prevent crash when enabling ARC IMEs. Bug: 845079 Change-Id: If927b31d1ebb2d27ba4a50dc33a96ca6b4979a0d Reviewed-on: https://chromium-review.googlesource.com/1150005Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#578177}
-
John Abd-El-Malek authored
This change moves it to a more generic name, RendererUpdater, in preparation for sending a few more pref updates. The only behavior change is to fix sending signin-notifications to renderers that share the same Profile as where the notification is coming from. Bug: 841313 Change-Id: I3d408cca35cdc89e1fc0cf8d9b0a43c9e172e739 Reviewed-on: https://chromium-review.googlesource.com/1150825Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#578176}
-
Owen Min authored
Extension might be uninstalled before install so the assoicated policies are unregistered before registered. For example, a policy forced extension is removed from forced list during launch due to policy update. Remove the DCHECK for this situation because it does not break anything. Bug: 864630, 734523 Change-Id: I71968c6930e3f72cd532c8a067e6019f0202300a Reviewed-on: https://chromium-review.googlesource.com/1147469 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#578175}
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 857464 Change-Id: I14a530854764fb07c875a5b1a19ce35359a662fb Reviewed-on: https://chromium-review.googlesource.com/1150838Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#578174}
-
Rob Schonberger authored
Change-Id: Icf2ca10fcd3a04543b7ec28426678dbb9b437e83 Reviewed-on: https://chromium-review.googlesource.com/1149435Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#578173}
-
Victor Vasiliev authored
R=rch@chromium.org Change-Id: I93d8c963e2d40a409aab5985625659e39f3ffb87 Reviewed-on: https://chromium-review.googlesource.com/1150883Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#578172}
-
Matt Wolenetz authored
This is a reland of 61697367, which had been reverted in 9a4096be as part of reverting 568cc6a9 which had broken some builders. That CL has now been fixed and relanded (a9b7a993). This reland is the same as the original. Original change's description: > MSE: Log when MP4 keyframe-ness mismatches the compressed media > > Logs to chrome://media-internals when the container's keyframe metadata > for a frame mismatches the contents of that frame (if the latter was > determined by the respective bitstream converter's Analyze() > implementation, of whom only AVC currently does any keyframe analysis). > > BUG=860420,584384 > TEST=Repro crbug 860420 shows logs, new MP4StreamParserTest.AVC_Key* and media > > Change-Id: Ic87eab8726ad76b36b569df08ab2212b267008c2 > Reviewed-on: https://chromium-review.googlesource.com/1149153 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577751} TBR=sandersd@chromium.org Bug: 860420, 584384 Change-Id: I5a00819883e71ca9fd8c1a211956bdca66047b54 Reviewed-on: https://chromium-review.googlesource.com/1150541Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#578171}
-