GitLab

Regarding Chromium issues 73355, 95129, 95732, 97285, 103957 and Chromium-os issue 18437, 22372, we suspect the channel handles passed to the renderer have invalid file descriptors (fd). This is supported by the fact that using a channel handle with a valid name but an invalid fd will produce crashes with exactly the same stack trace as reported in these issues. Running out of fd in either the renderer, browser or the other process (GPU, broker, etc) could cause this to happen, but we are not sure if that's the real cause.

Adding check for the fd in various places to help investigate these issues further. We will be able to tell if invalid fd is passed in and if yes, which process generates it. Browser side check is only added for the broker case to limit the scale of bad user experience, while providing enough cases for investigation.

BUG=none
TEST=passed unit tests

Review URL: http://codereview.chromium.org/8735015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102714
TEST=none
R=ben@chromium.org


Review URL: http://codereview.chromium.org/8776025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99524
TEST=compositor_unittests, views_unittests, aura_unittests...


Review URL: http://codereview.chromium.org/8565019

TBR=piman@chromium.org
Review URL: http://codereview.chromium.org/8775045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112645 0039d316-1c4b-4281-b951-d872f2087c98

src/content should not depend on src/views.
 
BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8770029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112644 0039d316-1c4b-4281-b951-d872f2087c98

Removing as it's not necessary and simplifies code to make it easier to ultimately rid ProfileSyncService of cros_user,
and ultimately convert it to a ProfileKeyedService.

Before this change the two values only differ 1) on chrome os, where kGoogleServicesUsername doesn't seem to be set today (and in some cases we use cros_user as a crutch), and 2) when kGoogleServicesUsername is cleared, but that only happens on DisableForUser.  In the future I'd imagine this value to be allowed to outlive that call as well, which would be OK.

BUG=88109,93922
TEST=bits of UI that show usernames continue to show usernames


Review URL: http://codereview.chromium.org/8665011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112643 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TEST=none


Review URL: http://codereview.chromium.org/8773029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112642 0039d316-1c4b-4281-b951-d872f2087c98

BUG=99524
TEST=compositor_unittests, views_unittests, aura_unittests...


Review URL: http://codereview.chromium.org/8565019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112641 0039d316-1c4b-4281-b951-d872f2087c98

This is bryeung CL from http://codereview.chromium.org/8748013/
which was approved by sky and failed on the commit-bot. It also improves the logic of one of my later CL in the same area.

TBR=sky@chromium.org
BUG=105046
TEST=grep *.ninja for relevant files in a large variety of configurations


Review URL: http://codereview.chromium.org/8776034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112640 0039d316-1c4b-4281-b951-d872f2087c98

The WebUI form-repost warning dialog wasn't getting closed
when you reloaded the page or navigated away from it.
bauerb pointed out that this was because the dialog's
ConstrainedWindow wasn't getting registered in the
RepostFormWarningController.

This change also updates
RepostFormWarningTest.TestDoubleReload from ui_tests to
check that we don't open multiple dialogs and that we close
the dialog when navigating away.

BUG=105546
TEST=manual: checked that old dialogs are closed on reload and when hitting the back button


Review URL: http://codereview.chromium.org/8771017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112639 0039d316-1c4b-4281-b951-d872f2087c98

BUG=79050


Review URL: http://codereview.chromium.org/8760023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87310
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_InvalidConnect'; git try -b win_shared

Review URL: http://codereview.chromium.org/8764022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112637 0039d316-1c4b-4281-b951-d872f2087c98

On OS X, when accessing a certificate field (subject, issuer, extension, etc), rather than parsing the entire certificate and converting all known fields to their CSSM equivalents, just parse the desired field.

Additionally, when parsing multiple fields, instead of parsing the certificate multiple times, parse it once and cache the internal parse results. While the cached handle cannot reliably be used across threads, it can reduce the amount of parsing for the common case, where constructing an X509Certificate on OS X requires parsing three fields.

BUG=101231
TEST=net_unittests passes on OS X 10.5, 10.6, and 10.7


Review URL: http://codereview.chromium.org/8470012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112636 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=groby@chromium.org

Review URL: http://codereview.chromium.org/8769024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105708
TEST=ui_tests --gtest_filter='PPAPITest.WebSocket*'

Review URL: http://codereview.chromium.org/8771002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112634 0039d316-1c4b-4281-b951-d872f2087c98

Bubbles previously using this code now use ui/views/bubble.
This code is now dead and can be removed; yay!

BUG=97248,98312,98322,98323
TEST=none


Review URL: http://codereview.chromium.org/8761012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112633 0039d316-1c4b-4281-b951-d872f2087c98

This used to be in gpu/command_buffer/client/gles2_demo_cc.cc
but was accidentally deleted in r101545. You can view it here
http://src.chromium.org/viewvc/chrome/trunk/src/gpu/command_buffer/client/gles2_demo_cc.cc?view=log&pathrev=101544

I need this for testing compressed texture support in ANGLE

TEST=none
BUG=none

R=jbates@chromium.org


Review URL: http://codereview.chromium.org/8764010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112632 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/8771023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=GYP_DEFINES=clang_add_plugin=foo build/gyp_chromium adds a parameter


Review URL: http://codereview.chromium.org/8772034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112630 0039d316-1c4b-4281-b951-d872f2087c98

Fix incorrect number in pyauto tests that caused them to fail with stricter versions of the phonenumber library.
BUG=none
TEST=pyauto

Review URL: http://codereview.chromium.org/8774026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104772
TEST=gpu waterfall
TBR=kbr
Review URL: http://codereview.chromium.org/8775043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102408
TEST=More data in OnTempCrashWithData dumps.


Review URL: http://codereview.chromium.org/8776017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=groby

Review URL: http://codereview.chromium.org/8775034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8776024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112622 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105446
TEST=popups look normal


Review URL: http://codereview.chromium.org/8734018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112621 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106144
TEST=none
TBR=mkwst@chromium.org

Review URL: http://codereview.chromium.org/8771029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112620 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112619 0039d316-1c4b-4281-b951-d872f2087c98

r8: No longer replace the string "\n" with a new line in messages.

BUG=105985


Review URL: http://codereview.chromium.org/8775030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112618 0039d316-1c4b-4281-b951-d872f2087c98

Fixing ProfileManagerTest to use the TestingProfile instead of a real profile. This will allow easier testing of ProfileManager-specific functionality as well as not creating problems in the future when changes to Profile are made that should not affect the testing of ProfileManager.

BUG=101434
TEST=Passes all existing ProfileManager tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112124
reverted (r112155)

Review URL: http://codereview.chromium.org/8565032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran try


Review URL: http://codereview.chromium.org/8762015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112616 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scr@chromium.org
BUG=105952
TEST=none


Review URL: http://codereview.chromium.org/8774021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TEST=none
TBR=kinuko

Review URL: http://codereview.chromium.org/8775031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112614 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=104396
TEST=none


Review URL: http://codereview.chromium.org/8771016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112613 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88782
TEST=win_shared

Review URL: http://codereview.chromium.org/8776019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112611 0039d316-1c4b-4281-b951-d872f2087c98

Add PluginInstaller to encapsulate information about a missing plug-in, and add a separate help URL for each plug-in.


TBR=arv@chromium.org
BUG=62079,102987
TEST=none


Review URL: http://codereview.chromium.org/8664027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112610 0039d316-1c4b-4281-b951-d872f2087c98

and private interfaces are currently not shimmed for pnacl.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=2413
TEST= none


Review URL: http://codereview.chromium.org/8775028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102714 
TEST=none
R=erg@chromium.org


Review URL: http://codereview.chromium.org/8775029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112608 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112607 0039d316-1c4b-4281-b951-d872f2087c98

With this change, only downloads that match a whitelisted URL or certificate will be exempt from the download protection pingback.  The certificate whitelist format allows matching on the certificate issuer along with the CN, O, or OU attributes of the certificate.

BUG=102540
TEST=DownloadProtectionServiceTest


Review URL: http://codereview.chromium.org/8762007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105682
TEST=covered by unit test, but not easy to manually test right now


Review URL: http://codereview.chromium.org/8774011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112603 0039d316-1c4b-4281-b951-d872f2087c98