GitLab

The class has not references left in content/, and can move
moved out of the Blink exposed API as long as forward refenrences
are used in processed_local_audio_source.h.

BUG=704136,919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I6d9d9370aa8c0ea3aa6b23923919896de12d9d9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715664
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681275}

This is a follow up of [1].

[1] https://crrev.com/c/1710237

BUG=704136,923394
R=guidou@chromium.org

Change-Id: I34829b50b263f47cd8d4b6fc9b41df60b57ede0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715164
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681274}

This removes the global defines

    FULL_SAFE_BROWSING
    SAFE_BROWSING_CSD
    SAFE_BROWSING_DB_LOCAL
    SAFE_BROWSING_DB_REMOTE

and moves them to the buildflag system instead. They live in the
new (generated) buildflag header components/safe_browsing/buildflags.h
which is generated by //components/safe_browsing:buildflags.

No behavior change.

Bug: 961767
Change-Id: Ifdc78c21ef4c2e2ab8fc9f48461734a559794333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719289Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681273}

This CL makes sure that the Kerberos system daemon is not started
unnecessarily if there are no Kerberos accounts.

BUG=chromium:963824
TEST=Log into Chromebook with enabled KerberosEnabled policy, but no
     existing accounts (neither through KerberosAccounts policy nor
     added manually). Open ssh console (e.g. CTRL + ALT + -->), verify
     that 'ps -A | grep kerberos' does not show a Kerberos process.

Change-Id: I6b8b4cfd1f50a6b9abc97b8b72fa322fdb83cfc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720770Reviewed-by: A Olsen <olsen@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681272}

This CL is large because it moves various files in
content/renderer/media/{stream,webrtc} to blink.
These files are being moved in one step here because it'd not
be easy to do it incrementally, as of other prior steps.

The following files got moved:

  - content/renderer/media/stream/audio_service_audio_processor_proxy.h
  - content/renderer/media/stream/media_stream_audio_processor.h =>
    third_party/blink/public/platform/modules/mediastream/

  - content/renderer/media/stream/media_stream_constraints_util_audio.h
  - content/renderer/media/stream/processed_local_audio_source.h =>
    third_party/blink/public/web/modules/mediastream/

  - content/renderer/media/webrtc_audio_device_impl.h
  - content/renderer/media/webrtc_audio_device_not_impl.h =>
    third_party/blink/public/web/modules/webrtc/

  - content/renderer/media/stream/media_stream_constraints_util_audio.cc
  - content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
  - content/renderer/media/stream/processed_local_audio_source.cc =>
    third_party/blink/renderer/modules/mediastream/

  - content/renderer/media/webrtc_audio_device_impl.cc
  - content/renderer/media/webrtc_audio_device_not_impl.cc =>
    third_party/blink/renderer/modules/webrtc/

  - content/renderer/media/stream/aec_dump_agent_impl.cc
  - content/renderer/media/stream/aec_dump_agent_impl.h =>
    third_party/blink/renderer/platform/mediastream/

  - content/renderer/media/stream/audio_service_audio_processor_proxy.cc
  - content/renderer/media/stream/media_stream_audio_processor.cc =>
    third_party/blink/renderer/platform/exported/mediastream/

Remarks:

1) Most of the changes in this CL are straightforward, eg namespace or path inclusion
  adaptation, add/replacing "bridge" blink::Platform methods, etc. However, one change
  might deserve some reasoning.

  aec_dump_agent_impl.cc|h: The class AecDumpAgentImpl inherits from mojom::AecDumpAgent.
  However, in order to do this, we would need to include aec_dump.mojom.h, which is not
  allowed for Blink API headers - instead aec_dump.mojom-shared.h is enforced.

  To avoid including aec_dump.mojom.h from a (temporary) blink API headers, the CL factors
  out the "Delegate" inner class out of AecDumpAgentImpl into its own header, and make it
  part of the blink API (aec_dump_agent_impl_delegate.h).
  aec_dump_agent_impl.cc|h got moved to blink/renderer/platform, and include
  aec_dump.mojom-blink.h without problems.

2) The following tests got blink::TestingPlatform derived classes
  added locally, in order to implement the needed factories:

  - content/renderer/media/webrtc/rtc_peer_connection_handler_unittest.cc
  - content/renderer/media/stream/processed_local_audio_source_unittest.cc
  - third_party/blink/renderer/modules/mediastrea/media_stream_constraints_util_audio_test.cc

  By the time the first two files above get moved to Blink, the files should
  share the same derived blink::TestingPlatform implementation, factored out into a helper.
  TODO added.

3) Data types and APIs that are not allowed in Blink, eg base::Bind{Once,Repeating}.
  std::vector and std::string were forcibly allowed at this stage, and will be remove
  in a follow up.
  TODO added.

4) Most of the APIs added as public blink APIs here will eventually get moved again to
  blink/renderer/platform or blink/renderer/modules. It is just a matter of its existing
  clients in //content get Onion souped.
  TODOs added.

BUG=704136

Change-Id: I7799c94a441c49ade6f19518879b1ee0e5d37882
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710237
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681271}

Using wpt-import in Chromium 8d139660.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
f050694a "Restrict Shape Detection API to Secure Contexts"
14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-writing-modes

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id455468aad80c389018c4d62aa90aff902db6723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719113Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681270}

This reverts commit 6df45451.

Reason for revert: Reverting the revert might "fix" the test now that the failures are expected after a new wpt roll:
https://crrev.com/219a669145c403c99e3d7f441abbaad0e5d23a90/third_party/blink/web_tests/platform/win7/virtual/scalefactor200withoutzoom/external/wpt/largest-contentful-paint/observe-after-untrusted-scroll-expected.txt

Original change's description:
> Revert "[LargestContentfulPaint] Set startTime"
> 
> This reverts commit 58051e42.
> 
> Reason for revert: Most suspicious CL for failing paint-related test
> failures as mentioned in the linked bug.
> 
> Bug: 987915
> 
> Original change's description:
> > [LargestContentfulPaint] Set startTime
> > 
> > Currently startTime is 0, which is a problem because getEntries()
> > methods all sort by startTime. To help with this problem, we set the
> > startTime to renderTime, if available, or to loadTime, if renderTime is
> > nt available.
> > 
> > Bug: 965505
> > Change-Id: Ie70b69269f7ce4be0fdc94f33a44a84e062d3ba5
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719379
> > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#681147}
> 
> TBR=npm@chromium.org,yoavweiss@chromium.org
> 
> Change-Id: Ie810b8a3ac88369ab73a66670865f462f590e1ec
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 965505
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719351
> Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681224}

TBR=npm@chromium.org,fhorschig@chromium.org,yoavweiss@chromium.org

Change-Id: I02478f0c560c64268593c3a9df158b4e505f4667
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 987915, 965505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720811Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681269}

It can happen that the fallback cursor mode DCHECK
can trip during tests. With this CL, we simply
early out if we attempt to toggle when the feature
is not enabled.

TBR=bokan

Bug: 987353
Change-Id: I6ebbcfa56e36c03f6d23b4d07cd1412821800605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720150Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681268}

While this does rename some symbols and APIs, it
does not change externally-exposed values (e.g. preferences
or policies), which may require coordination with Enterprise
to avoid breaking anyone.

Adopt more inclusive language in //net, by deprecating the
terms whitelist and blacklist into more descriptive terms,
such as allowlist and blocklist.

TBR=torne@chromium.org, dgozman@chromium.org, bnc@chromium.org

Bug: 987648, 981129
Change-Id: Id558d29e0049af7e110dbb0528ac9d511e4620ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718348Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681267}

This CL renames mojo to mojom and *_struct_traits.* to
*_mojom_traits.* in //ui/gfx/geometry.

*_struct_traits.* => *_mojom_traits.*
ui/gfx/geometry/mojo => ui/gfx/geometry/mojom

Bug: 806965
Change-Id: I288f4019f88815ac92fc2f038676e7459ea01bd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717541
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681266}

From now on every policy needs an owner that is either a list of emails.
Preferably two or more or a OWNERS file reference.

BUG=976215
TEST=Presumbit checks pass.

Change-Id: I8af34ae50f79f0854714ab161844b87dab6010dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713516
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681265}

Adds documentation about the Chrome OS Active Directory integration
as well as the SAML flow during Chrome OS sign-in.

TBR=rsorokin@chromium.org, antrim@chromium.org

BUG=None
TEST=None

Change-Id: I54ba5ff0eac4de0aa687949b7567824a98089edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615025
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681264}

Change-Id: If6d6c9d897243e89124dad942d655b690f5b840d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720243
Auto-Submit: Max Morin <maxmorin@chromium.org>
Reviewed-by: Oskar Sundbom <ossu@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681263}

When a Window Agent is created it will create a unique token. This token
will be shared with workers and worklets that will be in the same agent
cluster. ie. The Agent Cluster is represented as the Agents having the
same UnguessableToken.

BUG=798572

Change-Id: Iccc50113865a2bddd983ce4044852646cbbc658d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718790Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681262}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/180f6291f9c9..424fc331f3be


Created with:
  gclient setdep -r src-internal@424fc331f3be

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: I9ef024b1374d6d27fe1abfc24af12559934ea10f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720304Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681261}

In some cases we want Skia to believe that we have GL Version different
from what is returned by glGetString(GL_VERSION). This CL removes
inconsistencies (which lead to failure to allocate GrContext) between
version stored in GLVersionInfo and version strings we pass to Skia.
One such case was when the "disable_es3_gl_context_for_testing" flag
is being used (see crrev.com/c/1419340 for details about flag).

Bug: 984110

Change-Id: Ie15680237a63e58e8e0fdbddf11698a5fd4adf36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716063
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681260}

Updates the copy for the sync help text if there are no devices to
choose from.

Bug: 987596
Change-Id: I96b0224d7a29fe2598e44c16ee512a91bd848b23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719012Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681259}

https://dawn.googlesource.com/dawn.git/+log/9d2ccaf65c2a..506ce9bba43b


git log 9d2ccaf65c2a..506ce9bba43b --date=short --no-merges --format='%ad %ae %s'
2019-07-26 bryan.bernhart@intel.com Fix MSVC builder failure with NextPowerOfTwo.


Created with:
  gclient setdep -r src/third_party/dawn@506ce9bba43b

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel

TBR=cwallez@google.com

Bug: None
Change-Id: I4774cd8bac39f8253a2a2490fe8e8c3c5e3cd7f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720305Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681258}

Test started failing on Linux debug bots, see bug for details.

No-try: true
No-presubmit: true
Bug: 874866
Change-Id: Ide689fbeacd0ad75e22610fb31b26934fb8673c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720749
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681257}

Change-Id: Ic0f15fff1e273fd93dc8ebbd808e72e0e1729603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718804Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Darius Mercadier <dmercadier@google.com>
Cr-Commit-Position: refs/heads/master@{#681256}

This doesn't affect anything yet, but makes the name more readable for
launching using feature launch.

Change-Id: I6946e9e797d0c5927ddd1b079acba52b041b226c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717777Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681255}

WritableStreamNative::CreateWithCountQueueingStrategy() used the V8
Extras implementation of CountQueuingStrategy. Change it to use the
native implementation instead.

BUG=982550

Change-Id: I8d407d10259b26d30b3ae6262dca31889d557d89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700101
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681254}

crrev.com/c/1717584 removed some expectations but didn't quite reset to the
state prior to crrev.com/c/1715311 as some tests likely need to still be marked
flaky.
This restores to the prior state, effectively reverting crrev.com/c/1716122 and
crrev.com/c/1715311

Bug: 987228
Tbr: ynovikov@chromium.org
Change-Id: I86cd1ee662f10332ba23ebc38a4e370d134544db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719989
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Auto-Submit: Antoine Labour <piman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681253}

This reverts commit e36db9d8.

Reason for revert: This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/1719859 , which is causing a symptom of a P-0 beta blocker.

Original change's description:
> cros: Enable partial swap on Mali
> 
> After crrev.com/c/1685909 we won't be reading from a buffer
> while scanning it out. We can re-enable partial swap on Mali.
> 
> Bug: 457511
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Id61c7f4794bcefc5794a32320efd8792624d136f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1168260
> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#676738}

TBR=kbr@chromium.org,dcastagna@chromium.org,andrescj@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 457511
Change-Id: I5f6b5eb5828790347b2274094ee4b9470030e1da
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719860Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681252}

https://webrtc.googlesource.com/src.git/+log/67f88a0d305e..d7ab56d4c20c


git log 67f88a0d305e..d7ab56d4c20c --date=short --no-merges --format='%ad %ae %s'
2019-07-26 mbonadei@webrtc.org Finish migrating rtc_tools/testing to python3.


Created with:
  gclient setdep -r src/third_party/webrtc@d7ab56d4c20c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I9b227c6d083f264c3c0956fed6e88b938a582fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720303Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681251}

The flakes are common and we have seen it on Windows and ChromeOS
already. Interestingly, it times out often on Linux Tests (dbg) [1] and
causes several retries ASan but still works on msan and rel builds. I'll
disable it Linux to calm the bots down.

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WebRtcGetDisplayMediaBrowserTestWithPicker.GetDisplayMediaVideoAndAudio

TBR=guidou@chromium.org

Bug: 986033
Change-Id: I6dc8c8febdeede7c394475c731cf10f56a275540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718950
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681250}

Test is a Flakey CRASH in DEBUG builds.

No-try: true
No-presubmit: true
Bug: 835943
Change-Id: Ic8dc0a56d6409344db076948fa1dcaf97cad87e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720242Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681249}

https://chromium.googlesource.com/angle/angle.git/+log/fab397e5acde..f002a637743f


git log fab397e5acde..f002a637743f --date=short --no-merges --format='%ad %ae %s'
2019-07-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 9f2236e58ed0..42f813401bdf (6 commits)
2019-07-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 3855447d93eb..f54b8653dd9d (9 commits)


Created with:
  gclient setdep -r src/third_party/angle@f002a637743f

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

TBR=jmadill@chromium.org,jmadill@google.com

Bug: chromium:None,chromium:None
Change-Id: I20ac515e931b60b6fbabdf047c10a56dc1ae38e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720302Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681248}

nacl is using an old toolchain and it seem there are constructs
in the current code it cannot handle. Rather than chasing those
down, just disable jumbo for everything built with the nacl
toolchain.

Example error:

In file included from newlib_pnacl_nonsfi/gen/ipc/ipc_jumbo_1.cc:7:
In file included from ./../../ipc/ipc_channel_common.cc:6:
In file included from ../../ipc/ipc_channel.h:14:
In file included from ../../base/bind.h:10:
In file included from ../../base/bind_internal.h:17:
../../base/memory/raw_scoped_refptr_mismatch_checker.h:30:61: error: 'AddRef' is a private member of 'scoped_refptr<IPC::ChannelProxy::Context>'
                        void_t<decltype(std::declval<T*>()->AddRef()),
                                                            ^
../../base/bind_internal.h:905:11: note: in instantiation of template class 'base::internal::IsRefCountedType<IPC::SyncChannel::ReceivedSyncMsgQueue, void>' requested here
          IsRefCountedType<std::remove_pointer_t<DecayedReceiver>>::value,
          ^
../../base/bind_internal.h:922:1: note: in instantiation of template class 'base::internal::MakeBindStateTypeImpl<true, void (IPC::SyncChannel::ReceivedSyncMsgQueue::*)(IPC::SyncChannel::SyncContext *), IPC::SyncChannel::ReceivedSyncMsgQueue *, base::internal::RetainedRefWrapper<IPC::SyncChannel::SyncContext> >' requested here
using MakeBindStateType =
^
../../base/bind.h:247:31: note: in instantiation of template type alias 'MakeBindStateType' requested here
  using BindState = internal::MakeBindStateType<Functor, Args...>;
                              ^
../../base/bind.h:270:16: note: in instantiation of function template specialization 'base::BindRepeating<void (IPC::SyncChannel::ReceivedSyncMsgQueue::*)(IPC::SyncChannel::SyncContext *), IPC::SyncChannel::ReceivedSyncMsgQueue *, base::internal::RetainedRefWrapper<IPC::SyncChannel::SyncContext> >' requested here
  return base::BindRepeating(std::forward<Functor>(functor),
               ^
./../../ipc/ipc_sync_channel.cc:175:28: note: in instantiation of function template specialization 'base::Bind<void (IPC::SyncChannel::ReceivedSyncMsgQueue::*)(IPC::SyncChannel::SyncContext *), IPC::SyncChannel::ReceivedSyncMsgQueue *, base::internal::RetainedRefWrapper<IPC::SyncChannel::SyncContext> >' requested here
          FROM_HERE, base::Bind(&ReceivedSyncMsgQueue::DispatchMessagesTask,
                           ^
../../base/memory/scoped_refptr.h:277:15: note: declared private here
  static void AddRef(T* ptr);
              ^

Change-Id: I82a13431a74c743cc3ad20c6d4308e2986d88a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474947
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681247}

This reverts commit a2cb14b2.

Reason for revert: Apparently breaks CrOS builds, see comments on review.

Original change's description:
> Fix android generate_linker_map check.
> 
> This change fixes gn refusing to build when `generate_linker_map` is
> true for android targets from a linux host.
> 
> Bug: 986842
> Change-Id: Ieb5e4d236ca54c87cf5f09fe26ce82a9bfe3191f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715024
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Nina Satragno <nsatragno@chromium.org>
> Auto-Submit: Nina Satragno <nsatragno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#681105}

TBR=dpranke@chromium.org,nsatragno@chromium.org

Change-Id: I9b0a81fe63a79fe5be29cfb1a08be953ce704c7a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720125Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681246}

Whenever possible, we replace use of EXPECT_CALL macro with use of
ON_CALL in the constructor of the fixture to make the expectations
of each test clearer.

Change-Id: I86a509898e3e2d9893166e46114d94d79274e207
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660865Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/master@{#681245}

The migration has been completed and the feature is no longer used.

Bug: 950269
Change-Id: I91f79f33ccda95e75d2b6156ade5d44f2e27c0ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719008Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681244}

This reverts commit 506aea91.

Reason for revert: It's possible that this patch has caused the renderer
process to crash on Android so let's revert it for now and I will investigate
a better patch if needed once I'm back from OoO, in August 5th. 

Original change's description:
> Move implementation of Mojo method GetTextSurroundingSelection() to Blink
> 
> Move this method from the content.mojom.Frame Mojo interface into Blink,
> as part of a new blink.mojom.SurroundingText Mojo interface, and add a new
> class there to implement such interface (i.e. blink::SurroundingTextImpl),
> to replace usages of content.mojom.Frame's GetTextSurroundingSelection()
> from the browser process.
> 
> Note that this SurroundingTextImpl class still relies on WebSurroundingText
> and WebLocalFrame to keep the change smaller, but this is a temporary step
> that will be corrected once WebSurroundingText has been moved out of the
> public API and into renderer/core, which will happen on a follow-up CL.
> 
> Bug: 980151
> Change-Id: I62fb2d5b24a98773c1acddbe1c58217c1a2d53e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696968
> Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#679981}

TBR=dcheng@chromium.org,kenrb@chromium.org,haraken@chromium.org,dominickn@chromium.org,mkwst@chromium.org,mario@igalia.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 980151
Change-Id: Ic3869e4d6fad9ca06d8d730d5202112b01cc47e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719489Reviewed-by: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681243}

Original CL: https://crrev.com/c/1692414

I've disabled the culprit flaky test LoadingSubframeDoesNotPreventCaching.
Flakiness can be investigated separately from this CL (tracking bug:
https://crbug.com/986742).

This reverts commit 381033f4.

Bug: 986742,976697
Change-Id: I6ea4b9543e6bc1d732be704a824c129b6044d329
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718244Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681242}

This is a reland of 129650cb with
fixing the reverted reason that CCA video playback couldn't work
after 2nd video recording on ChromeOS.

The original CL removed WeakPtrFactory in MediaRecorderHandler class
and the encoding callback was fired consistently even after
MediaRecorderHandler::Stop was called, so this CL calls Pause function
in MediaRecorderHandler::Stop to stop the encoding callback.

Original change's description:
> Remove WeakPtrFactory from MediaRecorderHandler
>
> This CL removes WeakPtrFactory from MediaRecorderHandler class that
> is garbage collected and replaces the weak pointer with
> WeakPersistent references.
>
> Bug: 981572
> Change-Id: I5dbfc268177cac290b85246ec029833e6baf64ce
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688966
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#675183}

Bug: 981572
Change-Id: I81938a2751564a6c38301b918f5ed72f6db4a019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718474Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Cr-Commit-Position: refs/heads/master@{#681241}

Using the newly added parameter to chrome://favicon2, we now plumb the
icon url associated with a remote history entry to the FaviconSource
level, so that it can be used by HistoryUiFaviconRequestHandler to
collect more reliable grouping metrics for chrome://history/*. The data
plumbed comes from Footprints for chrome://history and from Sessions
Sync for chrome://history/syncedTabs.

Bug: 973192
Change-Id: I81b47cd96d96392f99fb1c0357a5976d1489b4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702408
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681240}

To ensure that <details open> fires the toggle event in case of setting
the open attribute from either HTML parser or XML parser.

We introduce a UseCounter for 'toggle' event handler execution. Also we
define and capture whether toggle is happening during parsing or not in
Document.h and DispatchPendingEvent(). We count the new UseCounter if
the event is toggle and happens during parsing.

Bug: 960252
Change-Id: Iefa0d79a5a8866bfd830ecea0bc053350b04b537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717571
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681239}

Using wpt-import in Chromium dabc0b61.
With Chromium commits locally applied on WPT:
250461b3 "Worker: Register a service worker just once for worker subresource interception tests"
bf4ad57e "Experimental CookieStore API: some additional browser-side validation"
f050694a "Restrict Shape Detection API to Secure Contexts"
14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: If55046d84679c465b8c8227cffcfd58d9c285885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718601Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681238}

Change-Id: I8060d8f89c65bb45552c9f5f2da8d67c1414174d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718372
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#681237}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3a6f61256488..f86d0ece2ee1


git log 3a6f61256488..f86d0ece2ee1 --date=short --no-merges --format='%ad %ae %s'
2019-07-26 linben@google.com Land Android Variant determine code for bertha for workspace.
2019-07-26 jwerner@chromium.org image_signing: Update kern_b_hash logic to support SHA256


Created with:
  gclient setdep -r src/third_party/chromite@f86d0ece2ee1

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel

TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I9645e453af12eae9c4d16a165d8f67366f3227d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720001Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#681236}