GitLab

This is accessed by native and must not be renamed by proguard.
BUG=905960

Change-Id: I99f74affe95c2e9356f66303eb921fa8a5eb1125
Reviewed-on: https://chromium-review.googlesource.com/c/1340366Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608883}

Currently when the script reads multiple results it outputs the
last value read as well as a zero placehold for standard deviation.

According to benjhayden@ we can return all results in an array.
This change does just that and adds a test. It also updates the
expected unit test output.

Bug: 900677
Change-Id: Icc38808ea83caddbdf6b8582e2ddc34db4f8cdf0
Reviewed-on: https://chromium-review.googlesource.com/c/1338468Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608882}

The "ablation" variant of the Simplifid NTP was launched, so the
shortcuts are no longer needed. We can also remove the feature flag and
clean up some test code.

Future CLs will do more clean-ups to remove support for
bookmarks/downloads sections on the Chrome for Android NTP.

BUG=865216

Change-Id: Ia0bd851c300f5a16d0a9d417eebb3cc37652e79e
Reviewed-on: https://chromium-review.googlesource.com/c/1333107
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608881}

In https://crrev.com/f9cbcfa426bdf0cb830cd7d1ce7cc80845184d3e I landed
a fix to https://crbug.com/898757. This fix was needed ASAP since it
needed to be merged. I landed a fix without a test at the time. This CL
adds a test.

Bug: 901083,898757
Change-Id: I0b3dc44a7e94e33f5897f7d9f19159523807dc56
Reviewed-on: https://chromium-review.googlesource.com/c/1336786Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608880}

This CL uses CachedMetric to record the histogram for number of queued
messages instead of using RecordHistogram directly.

RecordHistogram call native directly and hence falsifies the whole
purpose of queuing FCM messages (to avoid calling the native code)

In order to test the behavior, ShadowRecordHistogram had to implement
the method recordCustomCountHistogram() of RecordHistogram.
The reason is CachedMetric is internally using this method directly
instead of the proxy methods such as recordCount100Histogram().

Bug: 882887
Change-Id: I15e9e77ab96cf65084242443a1a134c5df00f7fd
Reviewed-on: https://chromium-review.googlesource.com/c/1340000Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608879}

Bug: 874296
Tbr: hbos@chromium.org
Change-Id: Id2905574237fe9221d49a1e772c9ba0f3e7957e1
Reviewed-on: https://chromium-review.googlesource.com/c/1289436
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608878}

Zoom animations [1] use LayerTreeImpl::ScrollableSize. ScrollableSize
was incorrect if there was not an outer container layer, which is the
case for Blink Gen Property Trees (BGPT) where we use property tree
nodes for the outer container data.

This patch makes LayerTreeImpl::ScrollableSize work using property tree
nodes. To do this, ScrollTree::scroll_bounds has been introduced which
is used by both ScrollTree::MaxScrollOffset and
LayerTreeImpl::ScrollableSize.

A common function for setting up browser controls and virtual viewport
layers has been added:
LayerTestCommon::SetupBrowserControlsAndScrollLayerWithVirtualViewport

[1] Zoom animations are triggered on android via two codepaths:
* Double tapping _anywhere_ on a non-mobile (i.e. desktop) page
* Focusing (single tapping) on any editable
These can also be triggered on desktop in some configurations, such as
two-finger tapping a touchpad on MacOS.

Bug: 899702
Change-Id: I022974df18c410f5a513aad1bce3dfcd30a902da
Reviewed-on: https://chromium-review.googlesource.com/c/1338109
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608877}

[TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /chrome/browser/ui/webui/chromeos/login

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=jdufault@chromium.org

Bug: 903957
Change-Id: I884ec06bef124aef5b587bff4027e9014962c163
Reviewed-on: https://chromium-review.googlesource.com/c/1338487Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608876}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6a7b164f0c0e..d7cd1203a42b


git log 6a7b164f0c0e..d7cd1203a42b --date=short --no-merges --format='%ad %ae %s'
2018-11-16 zoddicus@users.noreply.github.com Ensure for OpVariable that result type and storage class operand agree (#2052)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@d7cd1203a42b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Icb13cda81738459913597a2274ff0667099d5816
Reviewed-on: https://chromium-review.googlesource.com/c/1340385Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608875}

This reverts commit 6aac2af3.

Reason for revert: Caused breakage of mash test. See https://crbug.com/902870.

Original change's description:
> MojoVideoDecoder: Add histogram to track initialization and error.
> 
> The autotest video_ChromeHWDecodeUsed verifies Chrome used the HW
> decoding when playing a video stream by checking the histogram value,
> which is reported from GpuVideoDecoder.
> In order to keep the test pass during switching from GpuVideoDecoder
> to MojoVideoDecoder, we have to report the same histogram value
> temporarily from MojoVideoDecoder.
> 
> With this CL, we can enable MojoVideoDecoder at ChromeOS platform.
> 
> BUG=chromium:902968
> TEST=Pass video_ChromeHWDecodeUsed autotest on Eve
> TEST=Play video at Youtube on Eve and confirm the successfull option
>      of Media.GpuVideoDecoderInitializeStatus are increased.
> 
> Change-Id: I26fc53704843e9b153bbee304e8f60ab3a7b0417
> Reviewed-on: https://chromium-review.googlesource.com/c/1328634
> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607890}

TBR=posciak@chromium.org,sandersd@chromium.org,akahuang@chromium.org,hiroh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:902968
Change-Id: I3b74c752b6cc34dcbcba203eeb39707f4921d405
Reviewed-on: https://chromium-review.googlesource.com/c/1340378Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608874}

TBR=dimich@chromium.org

Bug: 906093
Change-Id: Ica264f2a26dc52b1e44c12520b627a3032cbccf2
Reviewed-on: https://chromium-review.googlesource.com/c/1340779Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608873}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b2c3373106d2..8b33404f0931


git log b2c3373106d2..8b33404f0931 --date=short --no-merges --format='%ad %ae %s'
2018-11-16 stevenjb@chromium.org Support full version in Simple Chrome


Created with:
  gclient setdep -r src/third_party/chromite@8b33404f0931

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I4daa8d937381a9159abb855f924e883ae9e6f3d9
Reviewed-on: https://chromium-review.googlesource.com/c/1340384Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608872}

Looks like it's failing due to expecting a zip file that's not present
in the earlier package but is in the later:
https://chromium-swarm.appspot.com/task?id=4126fb1a456d4710

Bug: 880623
Change-Id: I586160da125e2743cfaf65d81bd556c1c6d88300
Reviewed-on: https://chromium-review.googlesource.com/c/1334336
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608871}

crbug.com/783246 is the fixed bug tracking it.

Change-Id: I873b1eda8d3e43abd191779e6e503df5e31157d6
Reviewed-on: https://chromium-review.googlesource.com/c/1338729Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Jered Gray <jegray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608870}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=torne@chromium.org

Bug: 903957
Change-Id: Iaf80012bf6f5c5f7852031c21f68c75e11957ca1
Reviewed-on: https://chromium-review.googlesource.com/c/1338481Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608869}

Unified system tray has been launched and web notification has been moved
to the top of the system tray. The old system tray logic has been removed.
This cl removes the logic that swiping up on the status area tray to open
the corresponding bubble and swiping down on the tray bubble to close it.

cl that landed the feature:
https://codereview.chromium.org/2961313003/
cl that disabled the feature:
https://chromium-review.googlesource.com/c/chromium/src/+/674527/

Bug: 767679
Change-Id: Id81091360ee47c9763d2f716f246146b940ac1e2
Reviewed-on: https://chromium-review.googlesource.com/c/1334932Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608868}

Currently unsupported url schemes like "foo://some/resource" hit a
NOTREACHED() and crash in the NS code path. Also, the current code
path does not invoke any webview specific callbacks.

This patch ensures that the unsupported url scheme cases are handled
correctly and the appropriate error callback is invoked when we hit an
unsupported scheme case (aka ERR_UNKNOWN_URL_SCHEME).

This patch also adds some additional parameters (i.e. method and
headers) to the ContentBrowserClient:: HandleExternalProtocol()
method, in order to provide all the data required to execute the
callback. The HandleExternalProtocol() method is invoked in two
places:
1. navigation_url_loader_impl.cc
2. resource_dispatcher_host_impl
For case 1 the additional data is obtained from the
network::ResourceRequest and for case 2 from net::URLRequest.

Tests fixed by this patch:
- ClientOnReceivedError2Test.testOnInvalidScheme
- ClientOnReceivedErrorTest.testOnReceivedErrorOnInvalidScheme
- AwContentsClientShouldOverrideUrlLoadingTest.testCalledForIframeUnsupportedSchemeNavigations
- AwContentsClientShouldOverrideUrlLoadingTest.testWindowOpenCustomSchemeUrlInPopup

BUG=896223,893567,893573,893574,841556

Change-Id: I7053b66a489c0f49eaa1428a8ee2466380710b26
Reviewed-on: https://chromium-review.googlesource.com/c/1318976
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608867}

base::AssertBlockingAllowedDeprecated is deprecated in favor of
ScopedBlockingCall, which serves as a precise annotation of
the scope that may/will block.

Please make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().
  - Calls to blocking //base APIs don't need to be annotated
    with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read,
    base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their
    own internal annotations.

Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1338391

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=henrika@chromium.org

Bug: 903957
Change-Id: Id9a9bb29d5d9beb2f680472602badc3a1ac1f6e3
Reviewed-on: https://chromium-review.googlesource.com/c/1338126Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608866}

The omnibox was accepting raw text from drag data when such text
was left empty by stripping Javascript schemas and whitespace.
This allowed invalid omnibox edit text content, containing e.g.
newline characters which would then render with confusing glyphs.
This CL fixes the issue by using the sanitized text even if empty.

Bug: 904380
Change-Id: Ia43a9429d200261a929e858681cb771e6b8bc91c
Reviewed-on: https://chromium-review.googlesource.com/c/1334558Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608865}

* Add a feature to control this, default off
* Move audio_input_impl to its own file since it grows big
* Introduce hotword_state_manager that controls DSP input device
  state.  For DSP device, it works as follows:
    - Open input device with HOTWORD effect
    - Input device won't forward audio data until OKG is detected
    - Once OKG is detected, input device behaves like a regular input
      device and constantly streams audio data, note that the preamble
      of OKG itself is included in the initial audio data
    - When a conversation is finished, we need to destroy and recreated
      the audio input to arm DSP again.

Bug: b/77916222
Test: locally build and run on eve
Change-Id: I4ce17fba21fbc584cde9178c2aca53a6ed410fe9
Reviewed-on: https://chromium-review.googlesource.com/c/1334566Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608864}

This CL adds security check for redirect in network service code path
for download system.

Bug: 883387
Change-Id: Icd5f9eac09a1197bffc72fbf3196b96a8c88ac4c
Reviewed-on: https://chromium-review.googlesource.com/c/1330063Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608863}

R=csharp@chromium.org

Bug: 830892
Change-Id: I6c3a17c2761545f58e18d9058bf2dedc31acf39e
Reviewed-on: https://chromium-review.googlesource.com/c/1338566Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#608862}

Bug: 906135

Change-Id: Ibdf7195d93a8dc340e6ce9cdd3ab11b4917bdd1e
Reviewed-on: https://chromium-review.googlesource.com/c/1340659Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608861}

 - Several "rm" commands are unnecessary because of rsync_exclude.txt.
 - Audited code that was replacing NBSP in polymer-mini.html (added in
   r332329). Seems to have no effect (no diff exists after running
   the command). Removed related TODO for Polymer 2.
 - Remove unused files from third_party/web-animations-js/. These files
   are not included in the build anyway.

Bug: 738611
Change-Id: I372143a9bc1fd3f18d5aa6fb7fe735fdbdb82015
Reviewed-on: https://chromium-review.googlesource.com/c/1338334
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608860}

After r606352, default URLLoaderFactory does not make any CORB
exceptions for extensions and/or apps.  Separate URLLoaderFactories
(relaxing CORB) need to be created for content scripts.

One scenario, where separate URLLoaderFactories should be created, is
content scripts injected into <webview> tag.  Such scripts execute
fetches with |request_initiator| set to the origin of the <webview>
embedder and so permissions of the embedder need to be taken into
account (e.g. a Chrome App might be able to make cross-origin requests).

This CL adds a regression test for this scenario (without product code
changes the new test fails with --enable-features=NetworkService flag)
and fixes the product code to trigger creation of separate
URLLoaderFactory when needed.

For an overview of separate URLLoaderFactories for extensions, see
https://docs.google.com/document/d/1fuBUmLZj1H319jMkK8waUbf5WdQS0N95J_mWXVzbP7A

Bug: 846346
Change-Id: I6ac0f42df7562a01c14cbe6740417b6d94b51810
Reviewed-on: https://chromium-review.googlesource.com/c/1337822
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608859}

Fix fuzzer crash by deleting fuzzer.  ;)

This fuzzer attempts to do a convoluted series of deserializing and
reserializing to try to make sure that serializing an op ends up in the
same op that is deserialized.  However, over time, a number of changes
to serialization have been added that modify what is being serialized,
e.g. scaling paint records, adding clips and scales to serialized
PaintRecords, scaling paint records, etc.

I think this fuzzer was useful in early oopr releasing to build
confidence about the number of serialization bugs, but it never caught
any issues that the paint_op_buffer_fuzzer wouldn't have caught.
However, it's no longer that useful.

Bug: 904211
Change-Id: Ie62e296c9a5246ab74478755d738820e02bf7cc1
Reviewed-on: https://chromium-review.googlesource.com/c/1337817
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608858}

Change-Id: I312159dd7287413e0421ce8cc7a064a4efa6041f
Reviewed-on: https://chromium-review.googlesource.com/c/1319034Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608857}

If the transfer buffer is resized, pointers returned by GetResultAs are
invalidated. This changes GetResultAs to return a smart pointer class
that allows us to detect if a result pointer is still in use when the
buffer is resized and safely crash.

Bug: 905889, 905890
Change-Id: I67b243a779f1a2996e7c13740c5ebdcfda16d0d3
Reviewed-on: https://chromium-review.googlesource.com/c/1336753
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608856}

This patch changes Range::expand() to call VP-free version of word and
sentence start/end functions, by hoisting the creation of VP from
the functions into itself. In this way we reduce the usage of functions
relying on VP.

Bug: 657237
Change-Id: I56ea3cb88972144887eba7701cfdc3628bdbf67b
Reviewed-on: https://chromium-review.googlesource.com/c/1338719
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608855}

This patch changes DocumentMarkerController to use VisiblePosition-
free versions of Start/EndOfWord, to reduce usage of VisiblePosition.

Bug: 657237
Change-Id: I344c98c9163ddc06f338e309a6b3e372d5fc2dda
Reviewed-on: https://chromium-review.googlesource.com/c/1330747
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608854}

Please first check the attached bug for context.

The fix is to listen on AccountTrackerService and not AccountManager
for account removals.

We cannot listen on AccountTrackerService for account updates because
AccountTrackerService does not notify its observers when an account's
LST changes.

Bug: 904978
Test: browser_tests --gtest_filter="ArcAuthServiceTest.AccountRemovalsArePropagated"
Change-Id: I75aeda8dd280734e58e509f5a34a4b1e27b09498
Reviewed-on: https://chromium-review.googlesource.com/c/1334368Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608853}

One lives in ash, the other in the browser. The one in ash is responsible
for the actual window management and animations, the one in the browser for
forwarding to the one in ash and caching state. I'm happy to rename these
classes in the future.

BUG=756085,875111
TEST=covered by test

Change-Id: Ida90f51a6b7efff82021a29e8a0185949a3e494a
Reviewed-on: https://chromium-review.googlesource.com/c/1338161Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608852}

WebappActivity#getActivityDirectory() never returns null.

Change-Id: Ie6b131677e6a69a49b8c72713235dc0891f5dbe2
Reviewed-on: https://chromium-review.googlesource.com/c/1340371Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608851}

This patch stops EndOfSentence from crossing block boundaries, since
block boundaries are also sentence boundaries.

Bug: 778507
Change-Id: I19ec97de1bbaac50db4c55b38ffb158339003993
Reviewed-on: https://chromium-review.googlesource.com/c/1337432Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608850}

This patch stops the two functions from using VisiblePosition by switch
to the VP-free versions of Start/EndOfSentence(). Hence, this patch
reduces the usage of legacy VisiblePosition.

Bug: 657237
Change-Id: I933a020f9bd6643ba1b2cd5111b8be18b2f49086
Reviewed-on: https://chromium-review.googlesource.com/c/1337816Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608849}

The draw-webgl-to-canvas-2d-repeatedly.html WebGL test is failing on
Linux/Amd/Passthrough. Suppress this.

BUG=906066
TBR=kbr@chromium.org
NOTRY=true

Change-Id: I93d75e75ecfac5bc94b272a6c0089c486122ef23
Reviewed-on: https://chromium-review.googlesource.com/c/1340367
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608848}

Change-Id: I05f3f73c8337bd2bfc07e420cdafccaf1bb04370
Reviewed-on: https://chromium-review.googlesource.com/c/1338408Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608847}

There is no logic change.

By refactoring the offset change into a separate class, we can make it
much easier to reason about and add new tests. For example,
https://chromium-review.googlesource.com/c/chromium/src/+/980513
can use this test.

Bug: 825858
Change-Id: I3465057c8b7fed637f61a2a02a03d5048be8c387
Reviewed-on: https://chromium-review.googlesource.com/c/1335273
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608846}

BUG=905919

Change-Id: I6024a41113845bd6e6b50d829a0ea2b4ab3e5efb
Reviewed-on: https://chromium-review.googlesource.com/c/1336527Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608845}

This CL creates an UI integration test that tests that the
page info view gets automatically dismissed on device rotation.

Change-Id: I02611cc2fab5a214b74af01d15cd8d12e19eff6e
Reviewed-on: https://chromium-review.googlesource.com/c/1338561
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608844}