GitLab

Conversion performed automatically using '2to3 -w -f has_key .'.
This is backwards compatible with Python 2.

Bug: 941669
Change-Id: I566bdb8b3bc522ffba87e9159f20062a192bf492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817602
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698909}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f278de18..246cf2b1

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I6ecc17483aa390650e87df489791a2fa39f2aecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819407Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698908}

Speculative fix because I couldn't reproduce it.

Crashes occurring since M75 show seg faults in the method
AutofillKeyboardAccessoryAdapter::AcceptSuggestion. It uses exactly one
pointer (controller_) and this pointer is never set to null. If compared
with the old AutofillPopupViewAndroid, it shows that the adapter for the
accessory view doesn't reset the controller after |ViewDestroyed()|.

This methods does this exactly like the AutofillPopupViewAndroid which
is not perfect [1] but risk-free to merge to M77.


[1] An ideal solution would use unique_ptr instead of raw pointer and
have the controller delete the views instead of them self-destructing.
Besides the merge, it makes more sense to clean this up when we remove
the old popup code entirely.

Bug: 1006311
Change-Id: I6766504c1ed7fffd0befb872d1e4a745dfdb45ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819441Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698907}

Bug: 964948
Change-Id: Ib47f8d7fcdd5700322bd227326b3df7740c75b5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816554
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698906}

Bug: 82078
Change-Id: I00bb47e46d3d78283a61da88fb34d549d0ff3873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818646Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698905}

Because of the custom view used for the password manager modal dialogs
(leak detection, onboarding) the ModalDialogProperties.TITLE property is
null and TalkBack doesn't speak the title of the dialog automatically
when it appears. This CL implements a one-line fix setting the
CONTENT_DESCRIPTION property to be read out when the dialog appears.

Bug: 1006773
Change-Id: I0308d716f631c1006b553d72289e380f9e0d653d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819312Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Cr-Commit-Position: refs/heads/master@{#698904}

https://chromium.googlesource.com/catapult.git/+log/c48d43717c32..0df60d76f437

git log c48d43717c32..0df60d76f437 --date=short --no-merges --format='%ad %ae %s'
2019-09-23 khokhlov@google.com [Telemetry] Save shared diagnostics in intermediate results

Created with:
  gclient setdep -r src/third_party/catapult@0df60d76f437

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC simonhatch@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=simonhatch@google.com

Bug: chromium:981349
Change-Id: I6bd82c5d5f5178864dfc6f19bafae9233352ec19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818723Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698903}

Create new component for Paint Previews (Internal Link: go/fdt-design).
The reasoning for creating this component is outlined in the README.

Adds some basic file IO interfaces for working with Skia data streams.

Design Doc [Internal]: go/fdt-design

Part of landing:
https://chromium-review.googlesource.com/c/chromium/src/+/1786583

Bug: 1005949
Change-Id: I6e09aaa840766806527e5baab2224d2ccfc5945a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814875Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698902}

This reverts commit cf88a217.

Reason for revert: Logs confirm our current suspicion. There is no need to have these logs anymore.

Original change's description:
> [signin] Add logs to investigate why there is a mismatch in the list of accounts.
> 
> This CL adds the logs necessary to debug on Canary why there is a mismatch
> in the list of accounts that leads to the Signin modal dialog being presented
> on every start-up.
> 
> Bug: 1006717
> 
> Change-Id: Ic326d2166ef473a4f9922d8f1ee9221634fdbef2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817884
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#698871}

TBR=rohitrao@chromium.org,msarda@chromium.org,justincohen@chromium.org,jlebel@chromium.org

Change-Id: Iae7c4e79798d4369f100a4fbd7913a65b7009b9b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1006717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814824Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698901}

This was marked as flaky on Linux only but is also flaking on Mac and Windows:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=RestoreOnStartupPolicyTestInstance%2FRestoreOnStartupPolicyTest.RunTest%2F2

TBR=thomasanderson@chromium.org

Bug: 701023
Change-Id: I5018441e068aa3ea968290eace5537bf7361d6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816654Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698900}

v2 ignored pointer-events: none for X-origin iframes which made oopif in
a portal hit testable. crrev.com/c/1797092 has addressed this issue.

Bug: 1002228
Change-Id: I6128530c9f0e78462f555b91f3785f1c56fec4f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818865
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698899}

This reverts commit 885f3782.

Reason for revert: Failed build with this revert in it:
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/14503

Original change's description:
> Revert "[Sheriff] Disable many PolicyDeviceDisplayResolution tests."
> 
> This reverts commit 7f37ccd8.
> 
> Reason for revert: I have menually tested the previously failing tests
> on linux-chromeos-os builders. Tests no longer fail, enabling them back.
> 
> Original change's description:
> > [Sheriff] Disable many PolicyDeviceDisplayResolution tests.
> >
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/0
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/1
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/2
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/0
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/1
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/2
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ConnectExternalDisplay/0
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/0
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/2
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/0
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/1
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/2
> > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.SetAndUnsetPolicy/0
> > PolicyDeviceDisplayResolution/DisplayResolutionBootTest.Reboot/0
> >
> > TBR=antrim@chromium.org
> >
> > Bug: 1000694
> > Change-Id: I58373a317fc917f79ff440ec14c62dc9d84cda6b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800409
> > Reviewed-by: vitaliii <vitaliii@chromium.org>
> > Commit-Queue: vitaliii <vitaliii@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#696000}
> 
> TBR=antrim@chromium.org,vitaliii@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1000694
> Change-Id: I179ddcf31fe0ac425ce6f5d8c99d2ed35420d962
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813345
> Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#698854}

TBR=antrim@chromium.org,vitaliii@chromium.org,apotapchuk@chromium.org

Change-Id: Ifd5b92256da79436abc93e73df02a849919de4f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1000694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816128Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698898}

Bug: 964948
Change-Id: I5a6f751ebdde9a33fe2a5d61881626da9c9256a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790112Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698897}

Change-Id: Ifac41db781e6e0e9d8e131044fe1ec307ed3f3d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801987
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698896}

This is a second attempt of crrev.com/c/1777025, as the previous
attempt led to a performance regression.

As CSSLengthArray cannot represent all lengths, and in particular,
cannot represent lengths where min/max() are present, this patch
augments InterpolableLength with a CSSMathExpressionNode representation,
so that all lengths can be interpolated and animated.

Bug: 991672, 1002177
Change-Id: Ic8af313872b900eac2587531c56a8eca65d55a5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805718Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698895}

Convert the implementation and all users of the
content::mojom::PowerMonitorTest interface.

Bug: 955171
Change-Id: If6fd5af9f155de275ba3ed1a136f4605605faf63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800753
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698894}

Conversion performed automatically using '2to3 -w -f has_key .'.
This is backwards compatible with Python 2.

Bug: 941669
Change-Id: I0fa85094d653173d14d8b7a63e3d5120397fd5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814927
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698893}

Change-Id: Idecb1fe3d962557ee30fac7bec103ca57a45edc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814880
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698892}

This patch adds url and path as available columns to
the network log view and allows the name to be removed
because it is not needed if the user decides to show
the path or the whole url.

Bug: chromium:993366
Change-Id: Ib4600d1631bd436cb3c8b8e79b3709dddc38b166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809161Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698891}

Bug: 1006787
Change-Id: I1882b04323570828ac9dcea7a72dcc2c9843b5fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819256Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#698890}

Apparently, we can get raw locations with a `null` content provider.
This CL filters them until we can prevent their generation altogether.

Bug: chromium:1005789
Change-Id: I02ababe8c3f3e355e9bc48622f15aa7c0d5f18b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819300Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698889}

Bug: 1005979
Change-Id: I72bf91be86d4c800050dd5e4ec4b21ef1f0cc241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815655
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698888}

This makes local Chromium builds 11% faster on Windows. Builds using
goma will not see the same speed-up, but it reduces the server load.

(This is already done on Linux and Mac since https://crrrev.com/671262)

Bug: 966403
Change-Id: I33c91893e2921f88922e2dae825da10f788d8774
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807241Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698887}

Conversion performed automatically using '2to3 -w -f has_key .'.
This is backwards compatible with Python 2.

Bug: 941669
Change-Id: I05c814fa07bbf1bb5d74d60989d6f292a54f2eda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817879
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698886}

As a step to remove all uses of WebLocalizedString::kFooBar,
this CL replaces below ones with matched IDS_FOO.

  - WebLocalizedString::kAXCalendarShowDatePicker
  - WebLocalizedString::kAXCalendarShowMonthSelector
  - WebLocalizedString::kAXCalendarShowNextMonth
  - WebLocalizedString::kAXCalendarShowPreviousMonth
  - WebLocalizedString::kAXCalendarWeekDescription

Bug: 995644
Change-Id: Ie938fc951ce25aeac5156b7b434789d26090d323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818005Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#698885}

This CL converts AnnotatorRequest in services and chrome to the new
Mojo type.

Bug: 955171
Change-Id: Ie65e0860b456a5d7f6d3554a5b2ead09c785988e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809291
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698884}

The WPT test trusted-types-eval-reporting was flaky, usually failing on the
first run, but succeeding on the second. This was a real (and potentially
serious) bug, where the CSP logic would rely on the V8 eval callback being
called, but other parts would blanket-allow eval (and hence suppress the
callback) because they didn't check for 'trusted types' condition.

Also, minor cleanups for the test.

Bug: 739170
Change-Id: I00699b115f0be474c2b6d231dcc8b884868248b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807218
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698883}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/aabc44df..f278de18

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I3e0b381ff425c65e7211650b2f3546b592e28370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819274Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698882}

Bug: none
Change-Id: Icf12cda5b4266e04397a56507a6dd1a1f55837c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819080
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Auto-Submit: Fergus Dall <sidereal@google.com>
Cr-Commit-Position: refs/heads/master@{#698881}

"Manage your Google Account" opens the mobile web version
of My Google via link instead of opening the Android native
version by intent. This cl changes the direct link to a smart link
which will open the native MyGoogle experience on Android.

Bug: 1000664
Change-Id: I47a1e3b5affacba73143f56e3b998a8b587b9a6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807250
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698880}

RefreshAccountShowsToast was broken since waiting for the toast to open
was not implemented correctly. The test was waiting for a call to the
proxy's 'addAccount' method, but that doesn't trigger the toast.
Instead, the 'close' event on addDialog triggers it. 'addAccount' does
trigger 'close' somewhere down the pipe, but in a high load situation
the execution flow seems to get skewed so that the test is executed
before the 'close' event happens. This CL fixes this by waiting for the
'close' event instead.

BUG=chromium:1005995
TEST=testing/xvfb.py out/Release/browser_tests --gtest_filter=*Settings* --test-launcher-jobs=200
     succeeds multiple times (well, other tests fail, but the Kerberos
     one doesn't)

Change-Id: If543c2f00c0112811beb7f2d1a2c94dbd3d265a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815118
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Auto-Submit: Lutz Justen <ljusten@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698879}

Closure was unhappy with the `Object.assign` solution. Instead, use
individual assignments and add the relevant comments, so that Closure
can understand what is going on.

Sample output:

```
/*Legacy exported object*/
self.UI = self.UI || {};

/*Legacy exported object*/
UI = UI || {};

//TODO(http://crbug.com/1006759): Add type information if necessary
UI.TextEditor = TextEditor;

//TODO(http://crbug.com/1006759): Add type information if necessary
UI.TextEditor.prototype = prototype;

/** @enum {symbol} */
UI.TextEditor.Events = Events;
```

Bug: 1006759
Change-Id: Ib0e571cc027f544b316a3e3ccf8c3d606273d887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819248Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698878}

Conversion performed automatically using '2to3 -w -f has_key .'.
This is backwards compatible with Python 2.

Example error:
Traceback (most recent call last):
  File "../../components/policy/tools/generate_policy_source.py", line 1647, in <module>
    sys.exit(main())
  File "../../components/policy/tools/generate_policy_source.py", line 349, in main
    policy_details = [
  File "../../components/policy/tools/generate_policy_source.py", line 350, in <listcomp>
    PolicyDetails(policy, chrome_major_version, target_platform,
  File "../../components/policy/tools/generate_policy_source.py", line 128, in __init__
    if not PolicyDetails.TYPE_MAP.has_key(policy['type']):
AttributeError: 'dict' object has no attribute 'has_key'

Bug: 941669
Change-Id: I5c089388812bbbb55ce3be4ce2081b34ed20959f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816413
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Yann Dago <ydago@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#698877}

This CL applies pending_receiver to CreatePushSubscription function
in VideoSource interface

Bug: 955171
Change-Id: Ia34e42305a466b306f0a80bf147fa85e55070550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804704Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#698876}

Make sure to cache the GetAllowFileAccess setting on the native side
and on update, so that it can be retrieved efficiently inside the
AwContentBrowserClient class. In particular in the
RegisterNonNetworkSubresourceURLLoaderFactories() method which is
executed on page and subresource loads.

BUG=949590

Change-Id: I55ab035530b2b342285ed42dfd55cc2c7d9a9940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814777
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698875}

This CL was created automatically with tools/perf/update_wpr script

R=perezju@chromium.org

Change-Id: Ib29f3bf0ea6a4a8a387c888304e02bd9e0c64578
Bug: 878390
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816461
Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698874}

BUG=1006711

Change-Id: I16e839f2ac419d051a0f2ca1b40f7ad1c8362966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819241Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698873}

This CL adds a switch to selectively enable GpuMemoryBuffer-based video
capture buffer. Devices supporting GMB-based video capture buffers can
achieve zero-copy for camera preview and reduce the power consumption on
various use cases significantly.

Design doc: go/cros-camera:dd:zero-copy

      /etc/chrome_dev.conf on Nocturne, and verify everything works.

Bug: 982201
Test: Manually add "--video-capture-use-gpu-memory-buffer" into
Change-Id: I178e00b0400e01f32ff8605de60c6dc2364dd384
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692155Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698872}

This CL adds the logs necessary to debug on Canary why there is a mismatch
in the list of accounts that leads to the Signin modal dialog being presented
on every start-up.

Bug: 1006717

Change-Id: Ic326d2166ef473a4f9922d8f1ee9221634fdbef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817884Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#698871}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db3a63384629..b22117bdb5c3


Created with:
  gclient setdep -r src-internal@b22117bdb5c3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: If6afa11387e6e4f43c51df95e025e679558dce60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819326Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#698870}