- 25 Apr, 2018 40 commits
-
-
sunxd authored
RenderWidgetHostInputEventRouter sends all pinch gesture event to root frame, but this might be a problem when the subframe has touch action restrictions. To avoid allowing pinch zoom when the target element in the subframe has touch-action:none property, this CL makes RWHIER checks the target frame and drop the event if touch action filter rejects the pinch. Bug: 827182 Change-Id: Ifa566446e8c695d934aad4bcaaef49af0cde76e2 Reviewed-on: https://chromium-review.googlesource.com/1007892Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#553778}
-
Fredrik Söderquist authored
unitlessZeroFeature -> unitless_zero_feature negativeSize -> negative_size threeValuePosition -> three_value_position Change-Id: Id42906e518e6780bfa601031d8ad00430b2f48b4 Reviewed-on: https://chromium-review.googlesource.com/1027878 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#553777}
-
Hans Wennborg authored
This is a reland of be8138a4 The issues with the previous attempt were addressed in the latest Clang roll (#553415). Original change's description: > win: Link with lld instead of MSVC's link.exe by default > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > link.exe, but it's significantly faster and it can also handle LLVM's > internal representation, which will enable us to do link-time > optimization and control-flow integraty checks with Clang. > > While lld is much faster at linking, it doesn't support incremental > links, meaning builds that only touch a few files and re-link a large > executable may become slower. > > This is the first attempt at switching everything over, with the > purpose of gathering data and finding unknown unknowns. It's likely > temporary until something breaks. > > is_win_fastlink is implicitly ignored when using lld, as lld without > fastlink is faster than link.exe with it. > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > link.exe to make sure that configuration keeps working. > > Bug: 792131 > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d > Reviewed-on: https://chromium-review.googlesource.com/983632 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551367} Bug: 792131 Change-Id: I3b76cd015ef18bb3e2ac7a3efa4352c4f04e560b Reviewed-on: https://chromium-review.googlesource.com/1028374Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#553776}
-
Michael Thiessen authored
Some apps roll their own intent dispatching code, and their intent dispatching code is incorrect, so they end up erroneously firing 2D intents explicitly to the VR launcher. If either the intent doesn't have the Daydream category, or the system isn't in a VR session (meaning launchInVr definitely wasn't used), retarget the intent back to the 2D launcher. Tested on a local Chrome dev build, verified it fixes b/78239314 too. Bug: 836209 Change-Id: I779c7bf3820ddd50650eb6752d720246a86d24b1 Reviewed-on: https://chromium-review.googlesource.com/1028572 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#553775}
-
Luke Zielinski authored
Bug: 817377 Change-Id: I5eb7768bdd8e20b5841de3cf56f6f8ed47ec6922 Reviewed-on: https://chromium-review.googlesource.com/1020062Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553774}
-
Andres Calderon Jaramillo authored
This CL adds two metrics in drm_util.cc: - DrmUtil.CreateDisplaySnapshot.HasEdidBlob (boolean): to detect whether an EDID blob is detected in the CreateDisplaySnapshot function. There are no existing unit tests for this function, so no tests are added for this metric. - DrmUtil.GetColorSpaceFromEdid.ChecksOutcome (histogram): to detect whether the sanity checks pass in the GetColorSpaceFromEdid function (or which one fails). Existing unit tests are modified to test this metric. Also, some unused includes are removed from drm_util_unittest.cc. Bug: 829506 Change-Id: Ib1cfc14577630e6649640da9b0a0b663a36296d5 Reviewed-on: https://chromium-review.googlesource.com/1014522 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#553773}
-
Oksana Zhuravlova authored
This change also converts the minimum necessary amount of C++ code to pass objects of base::Value by value instead of std::unique_ptr. Bug: 646113,799482 Change-Id: Iebebef972fc8e503c030639c8aefa0909bfcdbf9 Reviewed-on: https://chromium-review.googlesource.com/1024286 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553772}
-
Joy Ming authored
Include in-product help to let users know that there is the option to change download storage location through the download settings option in downloads home. Screenshot: https://drive.google.com/file/d/1EcJkOUnKa0W3DldtmMPgugG6rGIdNqd8/view Bug: 792775 Change-Id: I90932e6c647e2d46a24a13e80d71fc30df8a4da1 Reviewed-on: https://chromium-review.googlesource.com/1020458 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#553771}
-
James Hawkins authored
The state is 'Enabled' if the user has enabled the feature, 'Disabled' if the user has disabled the feature, and 'Unset' if the user has never enabled the feature. R=asvitkine@chromium.org, hansberry@chromium.org Bug: 831371 Test: none Change-Id: Id7f6207d2763d259cbb117457bc0e968fa6fcd3b Reviewed-on: https://chromium-review.googlesource.com/1026936Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#553770}
-
Daniel Cheng authored
WebContentsImpl now tracks the last time it received an input event that could be considered user interaction. When the browser process receives a WebUI message that requires a user gesture, it checks the WebContents hosting the WebUI to make sure that the user recently interacted with it. This also cleans up a few incidental bits of code: - RenderWidgetHost no longer prefilters events before notifying the delegate. This exposed some broken event filtering, tracked at https://crbug.com/827659. - Since the delegate method no longer prefilters input events, RenderWidgetHostDelegate::OnUserInteraction() is now named RenderWidgetHostDelegate::DidReceiveInputEvent(). TBR=isherman@chromium.org Bug: 823864 Change-Id: I9237052dbd325d8e578bfa904a8779533b63b2f9 Reviewed-on: https://chromium-review.googlesource.com/1028484Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553769}
-
Jinsuk Kim authored
This CL handles key events (onKeyUp, dispatchKeyEvent) by forwarding them to native first like the others. They are consumed by content components such as ImeAdapter, TapDisambiguator, etc. Introduced a couple of new classes for this flow to work: KeyEventAndroid: New object for Android key event, used to let it through the ViewAndroid tree and hit testing logic like other types of events. Hit testing is not necessary for key events since they don't have location information, but devised to process them in the same pattern. First EventHandlerAndroid (which is WCVA) is regarded to have the focus, and always expected to consume it. ContentUiAndroid: Bridges native and Java for the new events. Used to pass them back up to Java layer from EventHandlerAndroid(WCVA). Bug: 622847 Change-Id: I991274f9ecb49b739ab0f798390d7918a7e4bb37 Reviewed-on: https://chromium-review.googlesource.com/1018682Reviewed-by:Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#553768}
-
Ryan Daum authored
New interface (with default stub implementations) with the following: * Pass the event location rather than the underlying event (so that touch events or other data sources can be used instead of gesture events) * Method to query the handler whether it can handle a given event origin so we can avoid detecting (or blocking) margin events unnecessarily. * Adds a method for continuation/drag events. Bug: internal b/78462154 Bug: internal b/78461207 Change-Id: I1bba715e98b6458bf079cacd71b4ef3403ae7260 Tested: manual test Reviewed-on: https://chromium-review.googlesource.com/1028656 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#553767}
-
Minh X. Nguyen authored
Change-Id: I8476314132a3c8f48a8043f620658bc48276f2aa Reviewed-on: https://chromium-review.googlesource.com/1026704Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553766}
-
Daniel Murphy authored
Bug: 716490 Change-Id: Ie4ace578d7076c515d9ed1ef3dbb1494eeb3a550 Reviewed-on: https://chromium-review.googlesource.com/1028717 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#553765}
-
Min Qin authored
Chrome annotates downloads with the source URL to allow platform security features to treat downloads with appropriate suspicion. If the download was conducted in off-the-record mode, we should not annotate the download with the real URL to avoid a privacy leak. On Windows, using an empty URL results in marking the download as originating from "about:internet", a generic Internet-zone URL. BUG=813764 Change-Id: I1dfe652051d43a0c4f3ee2742882b1affa946c57 Reviewed-on: https://chromium-review.googlesource.com/1026455Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553764}
-
Daniel Cheng authored
The type isn't super obvious from the context, so just write it out. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1781ddea2b744141c6fc2c4e9bb5b9788cb25333 Reviewed-on: https://chromium-review.googlesource.com/1028567Reviewed-by:
-
Artur Khachatryan authored
Test ObjectStateAssumptionsTest.testinitializedWebDriverDoesNotThrowNPE is flaky on Android Chromium build bot. Disabling test for now. Bug: chromedriver:2401 Change-Id: Ib7038e3de7108eceb8c5092400ae9b4a6747b60e Reviewed-on: https://chromium-review.googlesource.com/1028762Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#553762}
-
Charlie Harrison authored
These metrics are not tracked, and the code is not really being maintained. Bug: None Change-Id: I030919ac8a2cf4e744ed120cdbcab282dcc6aea1 Reviewed-on: https://chromium-review.googlesource.com/1027800 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#553761}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=dominickn@chromium.org Bug: 825327 Change-Id: I5c912f4262563d87f0043f3a8eff0e7792751256 Reviewed-on: https://chromium-review.googlesource.com/1024431Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#553760}
-
Fredrik Hubinette authored
On X11, primary monitor is often set to an inactive output. However, nvidia-control-panel and other tools will still show that one of the active montiors is the primary one. While I'm not sure how this works, the list of monitors returned by xrandr --listmonitors should always have the primary monitor first, so let's fall back on the order of the monitors if available. Change-Id: I9f06754d95130957338a8dfcc4541ef350794b49 Reviewed-on: https://chromium-review.googlesource.com/1020150Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#553759}
-
https://skia.googlesource.com/skia.git/+log/27988f76b25e..25af671a3d7d $ git log 27988f76b..25af671a3 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 egdaniel Add GrCap check for whether we can do a copy or not, and implement in Vk backend 2018-04-25 borenet [infra] Run presubmit like a normal bot 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms a893aa3..2c9b55f (1 commits) 2018-04-25 enne Add CheckGeneratedFiles recipe check for gpu workarounds 2018-04-25 bungeman Clean up xfermodes3 gm. 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 509a65e..a893aa3 (1 commits) 2018-04-25 liyuqian Snap bitmap for SkThreadedBMPDevice::drawBitmapRect 2018-04-25 bsalomon Revert "Revert "Add arcs as a specialized geometry to GrShape."" 2018-04-25 kjlubick Move Baytrail to stretch 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 48c6ca0..509a65e (1 commits) 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 9e351c0..48c6ca0 (1 commits) 2018-04-25 angle-skia-autoroll Roll third_party/externals/angle2/ 023371b3a..f827123d9 (5 commits) 2018-04-25 brianosman Don't 'require' external image extensions, 'enable' them 2018-04-25 reed Experiment to track coverage in a layer 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms f3a576b..9e351c0 (1 commits) 2018-04-24 ethannicholas cache SkSL headers 2018-04-24 benjaminwagner Upgrade Win Radeon driver. 2018-04-25 robertphillips Fix GrRRectBlurEffect.fp 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 40a5028..f3a576b (1 commits) 2018-04-25 skcms-skia-autoroll Roll skia/third_party/skcms 86807d3..40a5028 (1 commits) 2018-04-25 kjlubick Migrate ShuttleA bots to Debian9 stretch Created with: roll-dep src/third_party/skia BUG=chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I573306e5aee3463fe005e9f9ae679ee0fa7bdf95 Reviewed-on: https://chromium-review.googlesource.com/1028625 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553758}
-
Esmael El-Moslimany authored
Bug: 781703 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If6fda4644b20764c0561d03a826c97e561f80337 Reviewed-on: https://chromium-review.googlesource.com/1024967 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#553757}
-
https://pdfium.googlesource.com/pdfium.git/+log/d9da586dd3db..7132ee35925f $ git log d9da586dd..7132ee359 --date=short --no-merges --format='%ad %ae %s' 2018-04-25 thestig Clean up CCodec_FlateScanlineDecoder. 2018-04-25 tsepez Introduce ScopedFPDF types in public/cpp/fpdf_scopers.h 2018-04-25 rharrison Allow failing to build CFXA_FWLTheme if unable to load fonts 2018-04-25 thestig Remove unused PNGEncode() code. 2018-04-25 thestig Roll third_party/googletest/src/ a325ad2db..4bd8c4638 (125 commits) 2018-04-25 thestig Use WindowsPrintMode in more places in place of ints. 2018-04-25 hnakashima Fix behavior of Delete key in XFA edit. 2018-04-25 tsepez Fix slight type inconsistencies discovered with strict FPDF API types. 2018-04-25 thestig Remove CDWriteExt. Created with: roll-dep src/third_party/pdfium BUG=chromium:835608,chromium:820104 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib3baadc56b41581755208c483b861b5587ef7953 Reviewed-on: https://chromium-review.googlesource.com/1028661 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553756}
-
Ken MacKay authored
Add a new content type with no per-type volume control (only per-stream). Bug: internal b/78533406 Change-Id: If0d7280c54ba95fd583e7292814e476862d52335 Reviewed-on: https://chromium-review.googlesource.com/1026452 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#553755}
-
Jun Choi authored
Implement anonymous set of functions that extract U2F request commands from WebAuthN style Ctap{MakeCredential GetAssertion} Request. Bug: 798573 Change-Id: I3431b0769db20b39a2e590d5a7d4136a3a920fe8 Reviewed-on: https://chromium-review.googlesource.com/1018739 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#553754}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. TBR=sadrul@chromium.org Bug: 825327 Change-Id: Id090f93a7156fcef4c60defd5fb6bc2682e732af Reviewed-on: https://chromium-review.googlesource.com/1024650Reviewed-by:
-
Majid Valipour authored
Make WorkletAnimation implement AnimationEffectOwner interface which enables it to attach to its effect and update its inherited time. For now, we use "0" as inherited time of the effect but follow up patches will instead use local time values that will be plumbed from animation worklet instead. TODO: - Plumb the time values from worklet and use that - WorkletAnimation should allow its effect to cancel and restart it. Bug: 814851 Change-Id: I8f0b9ff914130cdf73d0e9df41dec13ccc03bcf9 Reviewed-on: https://chromium-review.googlesource.com/902725Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#553752}
-
Rahul Chaturvedi authored
Adding myself to OWNERS for chromeos so I can unblock folks when needed. R=alemate@chromium.org, stevenjb@chromium.org Bug: None Change-Id: Ibed17c33a099ccf08e99ba8b45f3aa863d786d5a Reviewed-on: https://chromium-review.googlesource.com/1028612Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Cr-Commit-Position: refs/heads/master@{#553751}
-
Theresa authored
BUG=818754 Change-Id: I66c89c85f79d6599837abec757e89116c3de53eb Reviewed-on: https://chromium-review.googlesource.com/1028226Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#553750}
-
Devlin Cronin authored
Update ExtensionServiceTestBase and all derived tests to use manifest v2 extensions. Update old .crx files, Preferences files, and dynamically-created extensions. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: Ib07447a9cde9017f250d8100d3e55a9fd790d48c Reviewed-on: https://chromium-review.googlesource.com/1024642Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
danakj authored
This removes a bunch of complexity around formats that is superfluous, and removes format selection from the LayerTreeResourceProvider, eliminating a use of the ContextProvider from it. This might help with implmenting 826886, or just be a cleanup that I found while trying it out. The RasterBufferProvider impls were using a format specified in the LayerTreeSettings if it was supported, based on the opacity of the content. However the only possible format that the settings would specify other than the default was RGBA_4444 which is always supported if specified. And opacity doesn't actually play into any decisions made anymore. So stop passing around opacity, and ask viz::PlatformColor for a format to use in the RasterBufferProvider impls, with the caveat that RGBA_4444 should be preferred (for gpu compositing) if specified by the settings. R=kylechar@chromium.org TBR=piman Bug: 826886 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I74200eb54bef57fa663eede861661c876a87a408 Reviewed-on: https://chromium-review.googlesource.com/1024703 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#553748}
-
Fady Samuel authored
ResizeParams is a misnomer. VisualProperties is better although perhaps confusing because changing the LocalSurfaceId can cause a new CompositorFrame to be generated without any change in visuals. I can't really think of a better name and VisualProperties can also be interpreted as properties that affect the visuals (compositing) system so it still works. It's definitely an improvement from ResizeParams which is totally wrong. Change-Id: Ie8e1f5e8c354851e4efdf3aa5d975f1edfe77f5d Bug: 836367, 672962 TBR: tsepez@chromium.org for IPC rename. Reviewed-on: https://chromium-review.googlesource.com/1028460 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553747}
-
Aleks Totic authored
Many existing rebaselined tests had to be rebaselined again because borders looked different. Bug: 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia4114b66e322550b1a8dc5fc96568071d50a951e Reviewed-on: https://chromium-review.googlesource.com/1027073 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#553746}
-
Matt Menke authored
When downloading to a file, if code deleted the SimpleURLLoader on completion, and then tried to access the FilePath object passed to them by the SimpleURLLoader, they're run into a use-after-free. This CL fixes that. Bug: 835963 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8b840544be743aa979145bf46c8d35de4b25c12c Reviewed-on: https://chromium-review.googlesource.com/1024694 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#553745}
-
Ella Ge authored
This CL adds input event predictor in main thread event queue under a flag kResampleInputEvents. It is the basic structure for resample events, without only an empty predictor. The input predictor handled events before the event is dispatched. And apply current time to the event. design doc: https://docs.google.com/document/d/1DLfibi2NkV85p7AfEtNkvy24d283VRBSd3hz1Qh24Jw/edit?usp=sharing Bug: 836352 Change-Id: I7c17a33b2e0e5e9a51920e54a9b8ce795537f4ef Reviewed-on: https://chromium-review.googlesource.com/860429Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#553744}
-
Yafei Duan authored
As dewittj@ pointed out, in StartupMaintenanceTask some raw pointers to the objects on UI thread are being used in background thread, which is unsafe. This CL fixes the issue by making copy of objects on UI thread and bind them before hopping to background thread. Fortunately other tasks didn't have the wrong implementation. Bug: 832232 Change-Id: Ia8913ba6036b9c2ce357d53857f968fe1629c03d Reviewed-on: https://chromium-review.googlesource.com/1027130 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#553743}
-
John Abd-El-Malek authored
There have been many fixes in the network service path since this was disabled, and running locally (100x) doesn't show any flakes. TBR=cmumford@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I80466b2696bd58dc35ae254e47908bad99c1c5ac Reviewed-on: https://chromium-review.googlesource.com/1028753 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#553742}
-
Dan Harrington authored
See https://groups.google.com/a/chromium.org/d/msg/storage-dev/7LPVIl2dx_M/-rQaqjCTDAAJ for some data and discussion. Bug: 793109 Change-Id: I342af261c094fbf26a934737b56960fb2c244011 Reviewed-on: https://chromium-review.googlesource.com/1026164Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This method is needed for positioning the find bar in Views browser mode. Bug: 834754 Change-Id: Id984e5281bf970c0c99af8696a6cebbb8ca4c2a3 Reviewed-on: https://chromium-review.googlesource.com/1028450Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#553740}
-
Varun Khaneja authored
Bug: 833716 Change-Id: I7295b8db2b0904ee30f78f3bc452236fefd4f3f0 Reviewed-on: https://chromium-review.googlesource.com/1026558 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#553739}
-
