GitLab

NOPRESUBMIT=true

Bug: 
Change-Id: I5c5b274bb7f520ef55081f3779922c5d0955e12a
Reviewed-on: https://chromium-review.googlesource.com/540289
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481007}

This CL:

* Introduces the RemotingResourceFactory class for providing different resources
  depending on whether it's an external or internal build.
* Adds an AppInitializer for initializing common resources.

BUG=731851

Review-Url: https://codereview.chromium.org/2937733003
Cr-Commit-Position: refs/heads/master@{#481006}

Add qiangchen@ as owner of c/b/ui/views/desktop_capture/.

Bug: None
Change-Id: I0e0ca093f1224abcd7ce7accf9400b11f1eab7cb
Reviewed-on: https://chromium-review.googlesource.com/540822
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481005}

Currently content download only supports upper case guid. This CL
limits guid in download service to be upper case ascii chars.

In the future, we should consider the two guid approach to decouple
from content layer guid details.



Bug: 734818
Change-Id: Id03a234c0edb14c9ee7a66d5bb486cb1503e1840
Reviewed-on: https://chromium-review.googlesource.com/540679Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481004}

Revert of Skip missing translations when generating JSON resources. (patchset #2 id:60001 of https://codereview.chromium.org/1676793002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 480994 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyZjUzYmUxNjFiMDFhNGNmMDRkZmEzODdiNjZiZGE3MTBmNjAxYzAM

Original issue's description:
> Skip missing translations when generating JSON resources.
>
> It doesn't make sense to replace missing translations with english
> strings because Chrome can do this automatically when getting
> resources.
>
> BUG=369572
>
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Commit-Position: refs/heads/master@{#480994}
> Committed: https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66bda710f601c0

TBR=thakis@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369572

Review-Url: https://codereview.chromium.org/2948893002
Cr-Commit-Position: refs/heads/master@{#481003}

Prep CL for https://codereview.chromium.org/2882063002

BUG=721395
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2903213004
Cr-Commit-Position: refs/heads/master@{#481002}

In general, if a try job is successful, there
are no interesting new baselines or expectations to add.

If the tests were run, this just saves us one request;
if the tests were not run because the change doesn't
affect some platform, then this prevents us from printing
a warning message.

Change-Id: I937f4686bdf8911f10ba5f19d401ac088a3975eb
Reviewed-on: https://chromium-review.googlesource.com/526253
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481001}

https://pdfium.googlesource.com/pdfium.git/+log/d5a13afe9265..e10509a3d2a1

$ git log d5a13afe9..e10509a3d --date=short --no-merges --format='%ad %ae %s'
2017-06-20 janeliulwq Wrapper class for annotation dictionary + CPDF_Form

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I97324f780352e85c7fb7b53620f2b2de8c6bba34
Reviewed-on: https://chromium-review.googlesource.com/541795
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481000}

The drivers for several devices on Windows appear to not properly handle
querying for controls used in the context of Image Capture. These cases lead to
video capture being broken and users seeing only a blank image.

This CL adds a feature flag kImageCaptureControls Image Capture on Windows. 
For now, we disable this feature by default. The feature can be enabled by 
adding --enable-features=ImageCaptureControls to the command-line.

Bug: 722038
Test: Manual tested on Windows using iSpy virtual device.
Change-Id: I654ff72772af10c2d5356d5131ed7ed98e300c1f
Reviewed-on: https://chromium-review.googlesource.com/530076Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480999}

This logic matches the surface creation logic on Wayland.

BUG=angleproject:1651

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icca63e3778d2f4c327da44758b09b9328d02adee
Reviewed-on: https://chromium-review.googlesource.com/537967Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480998}

Zucchini is a patching tool inspired by Courgette, for delta compression of archives containing common exexecutable formats.
This is the first step of integrating Zucchini in Chrome Installer.

BUG=729154

Review-Url: https://codereview.chromium.org/2922273002
Cr-Commit-Position: refs/heads/master@{#480997}

It didn't previously have a way of handling experimental options which
don't translate to settings on the URLRequestContextBuilder. This change
allows it to directly change settings on the URLRequestContextConfig so
those settings can be used outside of the builder.

This struct shouldn't really be a struct anymore, but it already
shouldn't really have been a struct. This CL is the minimum change
needed to unblock an upcoming feature plus some closely related cleanup.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2952653002
Cr-Commit-Position: refs/heads/master@{#480996}

Use logical offsets as much as we can, and have legacy layout convert
it for us when storing physical offsets in FloatingObject. Use
SetLogicalLeftForFloat() and SetLogicalTopForFloat() in
LayoutBlockFlow for this. They actually take inline and block offsets.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iffd4aa759cb520f03a7642f15c1e40279e48c2b9
Reviewed-on: https://chromium-review.googlesource.com/541363Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#480995}

It doesn't make sense to replace missing translations with english
strings because Chrome can do this automatically when getting
resources.

BUG=369572

Review-Url: https://codereview.chromium.org/1676793002
Cr-Commit-Position: refs/heads/master@{#480994}

Currently, the flex-direction property is a 'storage_only' field, so
it has no generated public getters/setters.

This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the EFlexDirection enum and
use the generated CSSValueID <-> EFlexDirection mappings.

Diff: https://gist.github.com/297d38d32b4b097536e73f7c1bd1b3d7/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2942393002
Cr-Original-Commit-Position: refs/heads/master@{#480688}
Committed: https://chromium.googlesource.com/chromium/src/+/d6df17438f4c6ae0a69e5650f63d0cd6c8d72a00
Review-Url: https://codereview.chromium.org/2942393002
Cr-Commit-Position: refs/heads/master@{#480993}

Memory estimate is collected from Directory for directory based datatypes and
from SharedModelTypeProcessor for USS datatypes. It is triggered right after
configuration when all sync data is loaded into memory.

BUG=706214
R=pnoland@chromium.org

Review-Url: https://codereview.chromium.org/2950583003
Cr-Commit-Position: refs/heads/master@{#480992}

The directory is not used on iOS at all.

Review-Url: https://codereview.chromium.org/2944973002
Cr-Commit-Position: refs/heads/master@{#480991}

R=thestig@chromium.org
CC=gab@chromium.org,peter@chromium.org,hashimoto@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2928513003
Cr-Commit-Position: refs/heads/master@{#480990}

Adds the border and shadow to the narrow-mode dropdown in Mac.

This does not implement the rounded corners yet, as that will be a lot
more work. That's still forthcoming.

BUG=728844

Review-Url: https://codereview.chromium.org/2934873002
Cr-Commit-Position: refs/heads/master@{#480989}

network traffic to the task manager for tracking network usage.

There are a number of naming changes to help distinguish between what
is and isn't a "rate" and what is sent vs read vs transferred. Read being
incoming bytes, sent being outgoing bytes and transfered being either
read or sent bytes.

The "rates" are not calculated based on what is live on the network.
It is instead based on when requests are completed so large uploads
will all be registered in one refresh.

This update changes the struct BytesReadParam to BytesTrasferedParam
and stores both bytes read and bytes sent. It updates how the struct is
processed to handle the additional tracking of sent bytes.

Tasks have been changed to store the cumulative_bytes_read_ and
cumulative_bytes_sent_ which are stored on Refresh() to the
last_refresh_cumulative_bytes_sent_ and
last_refresh_cumulative_bytes_read_ . These are used to calculate
network_sent_rate_ and network_read_rate_ which are summed for the
network_usage_rate_.

Tasks no longer store a network usage of -1 to signify that they have
not had any network traffic, the utility of that flag no longer appears
to be used so it was removed. Because of this ReportsNetworkUsage() has been removed.

Tasks and Task Groups can now report their cumulative network usage.

BUG=720773

Review-Url: https://codereview.chromium.org/2905403002
Cr-Commit-Position: refs/heads/master@{#480988}

culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFhZWE3ODM3YTMxZDI1ZmI1ZTc0MjJjOTNhMmVmYmQxYTRiOGMzODgM

TBR=dpapad@chromium.org,jochen@chromium.org,nyquist@chromium.org,mathp@chromium.org,gogerald@chromium.org,anthonyvd@chromium.org,pkasting@chromium.org,zea@chromium.org

Change-Id: Ieb0fa227b6d22a3ff95cdc78f71de429a5baac15
Reviewed-on: https://chromium-review.googlesource.com/540793
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480987}

TBR=smut

Review-Url: https://codereview.chromium.org/2952733002
Cr-Commit-Position: refs/heads/master@{#480986}

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2949853002
Cr-Commit-Position: refs/heads/master@{#480985}

redirectSource was always a chain that linked to the previous redirect
and could walk the chain from request to request. NetworkManager was
setting "redirects" on the request and it was used in a few parts of the
code but NetworkRequest never exposed it for use. Since redirects is not
needed except when appending a new redirect to the chain I removed it
and walked the chain instead for those cases.

R=dgozman,pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2921053002
Cr-Commit-Position: refs/heads/master@{#480984}

This change causes the trybot to:
- use ThinLTO
- produce detailed diagnostics
- produce symbolized stack traces.
The goal is to reduce cycle times on the bot, as well as provide more
details when it fails so that its results are more actionable.

Tested by patching a bad cast into one of the base_unittests and
sending a swarming job as described here:
http://dev.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Run-a-test-built-locally-on-Swarming

BUG=732652
R=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2938383004
Cr-Commit-Position: refs/heads/master@{#480983}

The |mime_type| argument is used only to determine ContentType, and
set to a constant except when called from TextResourceDecoderBuilder.

This CL makes Create() to take ContentType directly as an argument
and moves DetermineContentType() to TextResourceDecoderBuilder.cpp.

Bug: 725654, 732893
Change-Id: I582727705351a49d10ecffdfdd9c1578114b6321
Reviewed-on: https://chromium-review.googlesource.com/539957
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480982}

Fuchsia doesn't implement readdir_r(), so it needed to use readdir().

However, readdir_r() is expected to be deprecated (see
https://www.gnu.org/software/libc/manual/html_node/Reading_002fClosing-Directory.html),
should be re-entrant anywhere we'd care about, and doesn't have the
allocation-size limitation of readdir_r on the size of dirent for the
file path. So, switch to readdir() on all POSIX.

Ref:
https://fuchsia.googlesource.com/magenta/+/master/system/ulib/mxio/unistd.c#1579
and the "de" structure it allocates.

Fixes some of FileUtilTest.* on Fuchsia.

Bug: 706592
Change-Id: I95e6d156c23ab11b1ac50053aa273c89c97a8449
Reviewed-on: https://chromium-review.googlesource.com/541619
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480981}

BUG=734219

Review-Url: https://codereview.chromium.org/2945563003
Cr-Commit-Position: refs/heads/master@{#480980}

This reverts commit f6e429ff.

Reason for revert: This CL broke a variety of external url
tests on ipad 32-bit configs.

Original change's description:
> Remove custom resizing hooks in GoogleLandingVC
> 
> GoogleLandingViewController used to have custom hooks to detect resizing events
> or orientation changes. This CL removes them and only use the generic
> UIViewController hooks.
> It also change the NTP constraints for the logo and the omnibox: the constraint
> and positioning is the same in landscape and portrait. The omnibox and doodle
> are now higher in portrait.
> 
> TEST= This CL refactors the NTP. Some regression testing should be done, in particular on rotations.
> Issues for which specific fixes have been removed: crbug.com/491131
> On iPad and in fullscreen, the collection view's inset is very large. When Chrome enters slide over mode,
> the previously set inset is larger than the newly set collection view's width, which makes the collection view throw an exception.
> 
> Bug: 733166
> Change-Id: I2f6faf2468196cdd0a2faa191634b4da51254079
> Reviewed-on: https://chromium-review.googlesource.com/536915
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480453}

TBR=justincohen@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 733166
Change-Id: I2aebc9327489d4a89861507ae9dedb166054cf4b
Reviewed-on: https://chromium-review.googlesource.com/541761Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480979}

This roll includes 2 revisions [1] and should be a no-op on all bots.

[1] https://chromium.googlesource.com/chromium/buildtools/+log/9a65473..b92ff91

R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2948863002
Cr-Commit-Position: refs/heads/master@{#480978}

WindowEventDispatcher does the dispatch to InputMethod.

BUG=NONE

Review-Url: https://codereview.chromium.org/2943973003
Cr-Commit-Position: refs/heads/master@{#480977}

In https://codereview.chromium.org/2868473002, we create
CompositorFrameSink from aura::Window, and the CompositorFrameSink
controls when to allocate a new cc::Surface, and exo doesn't explicitly
create new cc::Surface anymore. So some methods related to creating new
surface are not useful anymore, so remove them.


Bug: 731742
Change-Id: If8ce2eda0143a7ce394c95d4d87fefbeebe2ebf1
Reviewed-on: https://chromium-review.googlesource.com/541456Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480976}

Recently added in https://codereview.chromium.org/2920223002/. This test
was trying to test for failure in writing to "bad/../path", which in
FilePath terms is "/path". On most POSIX OS's, this fails because /
tends to not be writable, however Fuchsia's root is virtual so apps (at
least currently) can successfully write there. Change the test path to
"bad/../non_existent/path" so that the non-existence of /non_existent
causes the file creation to fail.

Bug: 706592
Change-Id: I5f8f22e59a0b157a9ec7f8309cc1175e4d9d0a79
Reviewed-on: https://chromium-review.googlesource.com/541677Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480975}

TBR=bpastene@chromium.org

Bug: 670879
Change-Id: I4d254dc45b466276815e5e3e2b460ba056db1354
Reviewed-on: https://chromium-review.googlesource.com/540673Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480974}

This is internal refactoring only, protocol does not expose
an ability to connect multiple sessions yet.

BUG=590878

Review-Url: https://codereview.chromium.org/2951833002
Cr-Commit-Position: refs/heads/master@{#480973}

Use new parameterized BinderRegistry.

R=rockot@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I9f7e5cdf6802d45bdec83069e116cd99e0371022
Reviewed-on: https://chromium-review.googlesource.com/538998
Commit-Queue: Ben Goodger <ben@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480972}

This still shares code with StyleBuilderConverter and FontBuilder.
For that, we create a StyleBuilderConverterBase that is independent of
ComputedStyle.

Bug: 730692
Change-Id: I7792ef340a5f95782f57a94e093c3c7d73ad11b1
Reviewed-on: https://chromium-review.googlesource.com/531655
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480971}

This reverts commit e8f9d07d.

Reason for revert: Causing breakages -- https://build.chromium.org/p/chromium/builders/Android/builds/73527

Original change's description:
> Remove Remoting API Key
> 
> Chromoting host no longer needs API Key, so the key can be removed.
> 
> Change-Id: I0960660ce2ddd5f4352ab691468d7c3881530d8d
> Reviewed-on: https://chromium-review.googlesource.com/540035
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480940}

TBR=rogerta@chromium.org,sergeyu@chromium.org,joedow@chromium.org

Change-Id: Ibc4df105f77ad41a859663cbef76b73baa208a63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/541763Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480970}

This CL fixes chrome UI hang with --enable-drm-atomic on IA. When hang, the
following error message is reported.
[17889:17901:0619/140657.974833:ERROR:hardware_display_plane_manager_atomic.cc(78)] Failed to commit properties: Invalid argument

It's because drmModeAtomicAddProperty() expects one of DRM_ROTATE_XXX as plane
rotation value. ARM and Rockchip generously accept the invaild variable 0, but
Intel doesn't.

In addition, correct the local definition of DRM_ROTATE_XXX to match to the
upstream kernel.
https://chromium.googlesource.com/chromiumos/third_party/kernel/+/intel-graphics/syncfence_ams_npf_mst_607_r2/include/drm/drm_blend.h#37

TEST=run chromeos reef image using cros kernel intel-graphics/syncfence_ams_npf_mst_607_r2 branch
BUG=b/36752417

Change-Id: I8abab16450cf79769692bd40de03a6005f5a024a
Reviewed-on: https://chromium-review.googlesource.com/540656Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Cr-Commit-Position: refs/heads/master@{#480969}

Prior to this change, DidStartLoading/DidStopLoading is fired for
same document navigations based on a heuristic similar to (but not
exactly the same as) the heuristic that changes the Frame loading bit.
There's no reason to have multiple different definitions, and this
should prevent a situation in which we have interleaved start/stop
notifications (or 2 starts but only 1 stop).

BUG=

Review-Url: https://codereview.chromium.org/2943523002
Cr-Commit-Position: refs/heads/master@{#480968}