- 05 Mar, 2018 40 commits
-
-
Chris Nardi authored
According to https://drafts.csswg.org/css-syntax/#serializing-anb, if a is 1 or -1 the number should be omitted. We did not follow this, causing us to fail parts of external/wpt/css/cssom/selectorSerialize.html. Change our behavior to match the spec and the test. Bug: 818475 Change-Id: Ie0f44e2a3fb51069aad492096138020b67359982 Reviewed-on: https://chromium-review.googlesource.com/948066Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#540827}
-
Bence Béky authored
This change is fairly mechanical and purely cosmetic. Use make_unique instead of creating an object with new and passing that into a unique_ptr constructor. (This often changes local variable type, but when passed as an argument an implicitly cast takes care of this). Use MakeRefCounted instead of creating an object with new and passing that into a scoped_refptr constructor. (This never changes variable type in this CL). Do these in constructor initializer lists as well. Remove unnecessary namespace qualifiers in a few places (where unique_ptr template parameter has it but new statement does not in the same line). Use assignment operator instead of reset() method of unique_ptr. Use std::move instead of two-step WrapUnique(unique_ptr.release()). Where object needs to be constructed with new statement and raw pointer is already available, use WrapUnique instead of passing the raw pointer to a unique_ptr constructor. Use auto where appropriate. Replace NULL by nullptr in one line which is touched anyway. Make sure to include memory for new, unique_ptr. Include scoped_refptr.h for scoped_refptr and MakeRefCounted. Delete unnecessary ref_counted.h include (only needed for RefCounted* base classes). Delete unnecessary memory include where corresponding header file already included it. Change-Id: I6fa58780e5ae89e2684aabdd21452b76be52a4f8 Reviewed-on: https://chromium-review.googlesource.com/946053 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540826}
-
Peter E Conn authored
Constructing origins manually and storing them in Urls is error-prone (eg the port could be missed out) and there are discrepancies in how the origin could be formed (eg GURLUtils has a trailing '/' while current manually formed origins don't). This is especially important as origins are critical to security. This CL creats an Origin class that offloads all the heavy lifting to the well tested native origin class and allows the type system to prevent the errors listed above. Bug: 800422 Change-Id: I87759ea12a87f2b57bbdf40994d35ec468a43cff Reviewed-on: https://chromium-review.googlesource.com/934289 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540825}
-
https://skia.googlesource.com/skia.git/+log/9e8a59490531..4be123fb6c04 $ git log 9e8a59490..4be123fb6 --date=short --no-merges --format='%ad %ae %s' 2018-03-04 update-skps Update SKP version 2018-03-02 bungeman IWYU for test files starting with 'A'. 2018-03-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 437664b4b..b27b03a2c (10 commits) 2018-03-02 bryct dm: support printing specific page of mskp to SVG 2018-03-02 brianosman Blacklist image sources with 1010102 configs 2018-03-02 egdaniel Remove blacklist of dual source blending on AMD vulkan 2018-03-02 brianosman Revert "Revert "Add 1010102 support to Ganesh"" 2018-03-02 robertphillips Fix creation of extra GrContextThreadSafeProxies in DDL world 2018-03-02 egdaniel Update Flush and Invalidate Memory calls in vulkan to take offset and size 2018-03-02 halcanary SkQP: Host APK list on cloud; no more commits 2018-03-02 halcanary SkQP/Doc: two more APKs 2018-03-02 jvanverth Various fixes for scaled emojis 2018-03-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b7d145861..437664b4b (1 commit) 2018-03-01 robertphillips Make use of the buffer data null hint a GrContextOption 2018-03-02 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d6fef528f..b7d145861 (1 commit) 2018-03-01 egdaniel Add ctor to GrVkAlloc 2018-03-01 halcanary SkString: remove externally unused ::setUTF16() from API 2018-03-01 scroggo Fix fuschia roll 2018-03-01 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 98e6a5f7b..d6fef528f (1 commit) 2018-03-01 ethannicholas Fixed SkSL use-after-free fuzzer bug and added defensive code to catch such problems in the future. 2018-03-01 benjaminwagner Omit path_text_clipped_uncached for RadeonHD7770. 2018-03-01 egdaniel Move workaround for fSRGBsupport before config table init in GrVkCaps 2018-03-01 brianosman Revert "Add 1010102 support to Ganesh" 2018-03-01 robertphillips sk_sp-ify GrGlyphCache 2018-02-28 benjaminwagner Upgrade Windows Skolo NVIDIA GPU drivers. 2018-03-01 robertphillips Move atlas manager creation to GrContext derived classes (take 2) 2018-03-01 kjlubick [skpbench] experiment with not disabling services 2018-03-01 egdaniel Move the rest of Vulkan driver workarounds into helper function in GrVkCaps 2018-03-01 halcanary SkQP: new apk 2018-03-01 robertphillips Fission GrAtlasGlyphCache in two (take 2) 2018-03-01 halcanary SkString: fix ::setUTF16 2018-03-01 brianosman Add 1010102 support to Ganesh 2018-03-01 benjaminwagner Omit longpathdash on Chorizo to avoid OOM. 2018-03-01 halcanary SkQP/Doc: new apks 2018-03-01 egdaniel Add unit test the explicit tests create a GrVkCopyPipeline 2018-03-01 robertphillips Clean up GrDrawOpAtlas (take 2) 2018-03-01 robertphillips Separate creation time & flush time behavior in GrDrawOpAtlas (take 3) 2018-02-28 liyuqian Fix a tiny typo 2018-03-01 kjlubick Change force_quarantine to use bot id 2018-02-28 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 2f3a0dc5c..98e6a5f7b (2 commits) Created with: roll-dep src/third_party/skia BUG=none The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I5a15c63d9df6b698d861c846f98e8de8dc946a04 Reviewed-on: https://chromium-review.googlesource.com/947895Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540824}
-
Fan Yang authored
In QUIC, incrementally calculate newly acked packets. Protected by FLAGS_quic_reloadable_flag_quic_use_incremental_ack_processing2. Merge internal change: 187526927 R=rch@chromium.org Change-Id: Iae1d28a17d693d11331b6cf7e9e5f741084ffd9e Reviewed-on: https://chromium-review.googlesource.com/946329 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#540823}
-
Christian Dullweber authored
It is possible that tabs on Android have no web_contents. Check for this case to avoid crashing. Bug: 818265 Change-Id: I803569fedd23510103923e03d6ba9e79457c57f9 Reviewed-on: https://chromium-review.googlesource.com/948488 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#540822}
-
Julian Pastarmov authored
BUG=816346 Change-Id: Ic4dc4b63cc9254683e5f2c5072030beeaab0c686 Reviewed-on: https://chromium-review.googlesource.com/945988 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#540821}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get() in content/renderer because it usually is not the right task runner to use, as a per-frame runner should be used instead. In this case, it doesn't really matter since frames are not involved, but we still want to remove the calls for the bigger benefit of banning it in content/renderer. Bug: 786332 Change-Id: I96a5c6657c029bd685e2302a778316b69b3af683 Reviewed-on: https://chromium-review.googlesource.com/942287 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#540820}
-
Greg Thompson authored
This reverts commit cc4be1cb. Reason for revert: speculative revert for test crashes deep in ShelfWidget::Shutdown; see https://crbug.com/818603. BUG=818603 Original change's description: > cros: Cleanup ShelfWidget::DelegateView shutdown > > Make it use DeleteDelegate() to be more consistent with > StatusAreaWidgetDelegate. Defer closing the widget until all the > top-level windows are closed. > > Bug: 628655 > Test: ash_unittests > Change-Id: I066b45dab9c848b8f990f7fb51f0170e5e66a861 > Reviewed-on: https://chromium-review.googlesource.com/907390 > Commit-Queue: James Cook <jamescook@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540550} TBR=jamescook@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 628655 Change-Id: Ia3eb845627c77761bb15e94f9bbc9b3f1643f584 Reviewed-on: https://chromium-review.googlesource.com/948494Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540819}
-
Emily Hanley authored
NOTRY=true TBR=ashleymarie@chromium.org Change-Id: I871b9fff3689356ba636c559ff86a50f8d1552e6 Reviewed-on: https://chromium-review.googlesource.com/948799Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#540818}
-
Robert Ma authored
(and hopefully the last ones, for real...) The process is the same as previous: rebaseline-cl --builders=<all mac ports...> <list of failures> Two changes in TestExpectations: 1. fast/encoding/denormalised-voiced-japanese-chars.html also fails on Mac 10.13, which seems to be expected considering it fails on all previous Mac versions the same way. 2. editing/caret/caret-color.html isn't in SmokeTests anymore (i.e. the test doesn't run on Android). Bug: 774301, 545140, 595483 Change-Id: Ie37cc7f6b3837ad520807c52ebce56b4b464938c Reviewed-on: https://chromium-review.googlesource.com/947803Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#540817}
-
Koji Ishii authored
These tests test HIRAGANA/KATANAKA small letters have the [NS] Nonstarter line break property based on Unicode 5.1.0. These code points are changed to [CJ] Conditional Japanese Starter property in Unicode 6.1.0 (UAX#14 revision 28.) The same code points are tested as [CJ] in following tests, and that these tests are not needed. css3-text-line-break-jazh-[0-2]{01..24}.html [CJ]: http://unicode.org/reports/tr14/#CJ [NS]: http://unicode.org/reports/tr14/#NS Bug: 817778 Change-Id: Icffcdfdb1ef41bc4f929913217c051047a340fca Reviewed-on: https://chromium-review.googlesource.com/948662Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#540816}
-
Jose Dapena Paz authored
In GCC 7.2/7.3, base::Optional<T> fails to compile, if T has still only been forward declared, as it cannot properly resolve the is_trivially_* declarations. In this case it is needed to include the full declaration of the type, and not only the forward declaration. Change-Id: I63e5c6307394c6c2eda6af108c80395152bfc04f Reviewed-on: https://chromium-review.googlesource.com/944401 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540815}
-
https://webrtc.googlesource.com/src.git/+log/3ba7a57f8fff..3f693b9e75fc $ git log 3ba7a57f8..3f693b9e7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1e6e4b7b99b7cc1f9352156b377a1b242b96474c Reviewed-on: https://chromium-review.googlesource.com/948071Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540814}
-
Bence Béky authored
Change-Id: I1f0d494f0a1d83cde0c632aec642fadecbe7b9b3 Reviewed-on: https://chromium-review.googlesource.com/946628Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#540813}
-
Marina Ciocea authored
Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idb284c691eec3b6c468431c2a16ae2a7977211cf Reviewed-on: https://chromium-review.googlesource.com/921281Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540812}
-
Alexander Timin authored
WorkQueue class has work_queue_ field, which is confusing. Rename it to tasks_. R=alexclarke@chromium.org,skyostil@chromium.org Change-Id: Ibdf4c69cf29a9ffbd48205fac1cd9b20c92f7a13 Reviewed-on: https://chromium-review.googlesource.com/897525 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#540811}
-
Alexander Timin authored
Follow-up for comments in 939469. R=haraken@chromium.org Change-Id: I7ff56c9ef77a7174c8e6cc2e3a9a91faebff2ed2 Reviewed-on: https://chromium-review.googlesource.com/941327Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540810}
-
Greg Thompson authored
6.7.1 and newer are failing CFI builds. BUG=818611 TBR=grt@chromium.org Change-Id: Ie0439da3fd330a8814daee9f3da3e2c412fbbf6f Reviewed-on: https://chromium-review.googlesource.com/948485Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540809}
-
Kent Tamura authored
This reverts commit 5c7dc5f2. Reason for revert: Broke Linux x64 clobber build. Original change's description: > Apply snake_case to generated files in gen/blink/core/css/properties/*/. > > Generated files in these directories are often identical to other > checked-in files. It's difficult to make move_blink_source.py workable > in such situation. So, this CL renames these generated files beforehand. > > This CL has no behavior changes. > > Bug: 770603 > Change-Id: I3bf2312b7a238fe605e33a9217959d84d43ffb4f > Reviewed-on: https://chromium-review.googlesource.com/947546 > Reviewed-by: nainar <nainar@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#540796} TBR=tkent@chromium.org,nainar@chromium.org Change-Id: I5203839d03f67e7b28098c051803769ed3fa817a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770603 Reviewed-on: https://chromium-review.googlesource.com/948643Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#540808}
-
François Beaufort authored
This CL makes sure document.pictureInPictureEnabled always returns false and video.requestPictureInPicture() rejects if PictureInPicture and UseSurfaceLayerForVideo features are not enabled. Bug: 806249 Change-Id: Icc91903aa0f44dde577ce479a8d5d453952e6575 Reviewed-on: https://chromium-review.googlesource.com/937301 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#540807}
-
Greg Thompson authored
This is a tentative care to silence all flaky tests. We have found all the tests using the test mount point info are flaky affecting the trybot runs every time. So we'll disable all the affected test before fixing the root cause. TBR=yamaguchi@chromium.org Bug: 804413 Change-Id: I7f711446accc61a8bedf00f52c328a1037a11791 Reviewed-on: https://chromium-review.googlesource.com/948483Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540806}
-
François Beaufort authored
The "media.autoplay_allowed" preference can be set to allow autoplay as a Chrome Policy. It is meant to be used for internal websites that may be broken by the change described at chromium.org/audio-video/autoplay. Bug: 779087 Change-Id: I6a2b5a13e80adfc72056536bc9cf425e30f50e6a Reviewed-on: https://chromium-review.googlesource.com/941956 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#540805}
-
Alex Clarke authored
This optionally sets initial_virtual_time and beginFrameControl. Change-Id: I6a0d6237137dbda57578a92b5abb4f160049ac20 Reviewed-on: https://chromium-review.googlesource.com/937402 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540804}
-
Eric Seckler authored
crbug.com/817364 is fixed, so we don't need to take double screenshots anymore. Bug: 817364 Change-Id: Ie5e467d21858dcec1f8fb52d4ff52df7c2edd472 Reviewed-on: https://chromium-review.googlesource.com/948484Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#540803}
-
Marc Treib authored
This CL removess the two features CaptureThumbnailDependingOnTransitionType and CaptureThumbnailOnNavigatingAway and updates all the places that checked them. Bug: 765588 Change-Id: Iaf4756410093d7ffb9caef7a9a221ebd9c62efe4 Reviewed-on: https://chromium-review.googlesource.com/943042Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#540802}
-
Greg Thompson authored
BUG=818603 TBR=jamescook@chromium.org Change-Id: Icaa17e76bfa8067091870ddb818b89210866ce30 Reviewed-on: https://chromium-review.googlesource.com/947975Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#540801}
-
Gustav Sennton authored
We need to keep the names of all boundary interface classes and methods used by the support library and chromium to ensure their names are the same in the support library as in the WebView APK. However, utility classes in the boundary interface package can be obfuscated just fine since they are not part of the boundary interface API. Ideally then, we will put everything that is part of the boundary interface API in one specific package, and keep utility methods in a sub-package, to allow for simple proguard rules (and avoid bugs where we incorrectly keep/remove new boundary interfaces). Bug: 809471 Change-Id: I7a700fcc50998d83bf3bfa799196477289bedb3e Reviewed-on: https://chromium-review.googlesource.com/943504Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#540800}
-
Marina Ciocea authored
Following discussion from [1], I updated DebugRecordingFileProvider interface to take stream type and ID instead of FilePath suffix as input, and build file suffix in interface implementation. This CL introduces duplicate code in media/audio/audio_debug_recording_session_impl.cc, that will be removed after switching to mojo implementation [2]. [1] https://crrev.com/c/810809/40/services/audio/public/mojom/debug_recording.mojom#18 [2] https://crrev.com/c/921281 Bug: 788657 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2e656797be3ca4663eb9393e74df7a73785e02a2 Reviewed-on: https://chromium-review.googlesource.com/941949 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#540799}
-
Christopher Cameron authored
It used to be a valid assumption that ui::Compositors would be destroyed before BrowserCompositorMac::DisableRecyclingForShutdown was called, but changes to NSWindows' lifetimes have made that assumption no longer valid. Destroy all BrowserCompositorMac instances at that call. Make relevant methods on RenderWidgetHostViewCocoa and RenderWidgetHostViewMac early-out when the BrowserCompositorMac is gone. Bug: 805726 Change-Id: I429b6b546344a23cd93e64dae4a004065328d5a6 Reviewed-on: https://chromium-review.googlesource.com/947813 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#540798}
-
Alex Clarke authored
Change-Id: I17932c9db2e9c42ca0cef4eccd063cb61b9ff123 Reviewed-on: https://chromium-review.googlesource.com/947943Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#540797}
-
Kent Tamura authored
Generated files in these directories are often identical to other checked-in files. It's difficult to make move_blink_source.py workable in such situation. So, this CL renames these generated files beforehand. This CL has no behavior changes. Bug: 770603 Change-Id: I3bf2312b7a238fe605e33a9217959d84d43ffb4f Reviewed-on: https://chromium-review.googlesource.com/947546Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#540796}
-
Yutaka Hirano authored
TBR=grt@chromium.org Bug: 818167 Change-Id: I2b32ad5308e51f4da39947d1f3b631587b2fe2d3 Reviewed-on: https://chromium-review.googlesource.com/948402Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#540795}
-
https://webrtc.googlesource.com/src.git/+log/12c8110e8c71..3ba7a57f8fff $ git log 12c8110e8..3ba7a57f8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib2e051f77dad5c01e99f97abf8d3212d09419f21 Reviewed-on: https://chromium-review.googlesource.com/948269 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#540794}
-
Bence Béky authored
Change-Id: I2c14a7c94d55b38b303a6b827fd5d1d06a8feca4 Reviewed-on: https://chromium-review.googlesource.com/946151 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#540793}
-
Max Morin authored
fuchsia_audio_manager_free should be called, I think. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I58bc4b9fb00fcd1d9d074752ddc8d59777911d6a Reviewed-on: https://chromium-review.googlesource.com/945913Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540792}
-
Tien-Ren Chen authored
The paint rect for background in scrolling content layer should be expanded to the full scrollable rect, i.e. layout overflow rect. This CL fixes a bug in BoxPainter and BoxPaintInvalidator that we forgot to convert LayoutBox::LayoutOverflowRect() from flipped coordinates to physical coordinates for painting and invalidation. BUG=787666 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4b4c45e910ea1d860e61eece6005263d0a8c708e Reviewed-on: https://chromium-review.googlesource.com/942485 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#540791}
-
Mikel Astiz authored
Trivial change, no behavioral differences. Bug: 681921 Change-Id: Id512b11a574afcf902d35553bb10a1a85cbcdea7 Reviewed-on: https://chromium-review.googlesource.com/940134Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#540790}
-
Yutaka Hirano authored
The test has succeeded unexpectedly, so this CL also adds an expectation file. Bug: 812667 Change-Id: I649a7663c54f83ccb951c5a4bf075b588908b088 Reviewed-on: https://chromium-review.googlesource.com/948184 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#540789}
-
Ned Nguyen authored
Owners no longer use this benchmark Change-Id: Ic544da522fb68ffe85da5cd777da2dc314f82fc8 Reviewed-on: https://chromium-review.googlesource.com/948245Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#540788}
-