- 16 Mar, 2018 33 commits
-
-
Adam Parker authored
Launch bug: crbug.com/721802 Finch config: cl/187885128, cl/189269157 Change-Id: I47a5c66de97b312ed5931ec83f94a2c62f8d850d Reviewed-on: https://chromium-review.googlesource.com/965388Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#543591}
-
Nate Fischer authored
No change to behavior, this removes no-longer used code paths. The android_webview/ code only existed to support the old code path. This removes BrowserSideNavigationPolicy now that isBrowserSideNavigationEnabled() is guaranteed to return true. Bug: 822124 Test: N/A Change-Id: I8d1fb406f572b1fefaac70853140dad64bc5883f Reviewed-on: https://chromium-review.googlesource.com/963649Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543590}
-
David Tseng authored
- when firing an active descendant change event on a content editable, we were serializing line breaks which took approximately ~600MS. The line break calculation was not only slow, but wrong (got stuck and put repeated new lines at the same offset). Unfortunately, <textarea> still needs line break information, so keeping for the !richlyEditable but editable case. - Sheets sends empty strings through the ChromeVox Classic speak api. This should never be allowed. It causes ChromeVox output to be flushed and stopped. - value changes get fired on root web area. Root web areas usually have '' as their values. This also caused output to be prematurely cut off. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ide73784a23db7bc92aef51de917801dab439dbba Reviewed-on: https://chromium-review.googlesource.com/964781Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543589}
-
Pedro Amaral authored
Removing velocity metrics for opening the sheet since Chrome Home is deprecated. Bug: 814528 Change-Id: I45b173844f1efdbbbe6380c8f928dbe502a0840b Reviewed-on: https://chromium-review.googlesource.com/964988Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#543588}
-
James Cook authored
In chromeos-specific code that bans ash via !ash, make sure there is a comment explaining why and a +ash/public. Bug: none Change-Id: I5ab13065090aead649fff6e54ebde95b30053d01 Reviewed-on: https://chromium-review.googlesource.com/965027Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543587}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: If3267b58e12f9ad945f714f53d8deb189d96abab Reviewed-on: https://chromium-review.googlesource.com/964111Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#543586}
-
Ryan Tseng authored
Bug: 731434, 731552, 790138, 790140 Change-Id: Id529fbfc7e0224c1887e70da734d67d857402b7d Reviewed-on: https://chromium-review.googlesource.com/964625Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#543585}
-
Tien-Ren Chen authored
The caller of PaintLayerClipper expects the returned clip rect to be in the scrolled space of LayoutView, while the computed clip rect for a fixed-pos layer is in the unscrolled space prior to compensation. The fixed-pos compensation has been done for non-RLS mode, this CL adds the RLS counterpart. BUG=821279 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I48a92d0614d97c745fe66b1265dce0613514ffc4 Reviewed-on: https://chromium-review.googlesource.com/961643Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543584}
-
Stephen Martinis authored
Found another place this needed to change Bug: 818832 Change-Id: I110c53c197804ed130ca82539d8ba54a3c1baf81 Reviewed-on: https://chromium-review.googlesource.com/965449Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#543583}
-
John Z Wu authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5a0254977d3bcfeb6256adaab7d4b8dbb8bace04 Reviewed-on: https://chromium-review.googlesource.com/965262Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#543582}
-
https://chromium.googlesource.com/catapult.git/+log/36d08eec1a07..cd370cc841d0 $ git log 36d08eec1..cd370cc84 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 dtu [pinpoint] Remove old alias to JobState. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I51326e4fb7aa1cfa989dbfd8798ae17c69b46513 Reviewed-on: https://chromium-review.googlesource.com/965424Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543581}
-
Doug Turner authored
In a follow up to bug 821653, we should never let this throttle work if there is a null blacklist service. Bug: 821653 Change-Id: Iaed8ba2d222e4e8a11727befee9d4c0f3ad3d9ac Reviewed-on: https://chromium-review.googlesource.com/963385 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543580}
-
James Darpinian authored
Bug: 820639 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iafd87125bbe83e59b0425fcfaf9b6c8f1c14988a Reviewed-on: https://chromium-review.googlesource.com/963620 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#543579}
-
Elly Fong-Jones authored
This change: 1) Adds a bubble_anchor_util helper for getting the extension installed bubble's anchor point in a Cocoa browser window; 2) Uses it in the existing Cocoa implementation and in the Views implementation when appropriate. This fixes many of the Webstore browser tests. Bug: 817408 Change-Id: I761bb51aede351a8203d4dd08de6f2fd44e25095 Reviewed-on: https://chromium-review.googlesource.com/960802Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#543578}
-
Mitsuru Oshima authored
CrossOver wants to control where the resize operation starts. I'm just updating the start_resize because it's not used yet. Bug: b/74241712 Change-Id: I727bc2589be95912ca3830eff059fca20e660bb2 Reviewed-on: https://chromium-review.googlesource.com/957550 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543577}
-
Thomas Guilbert authored
Currently, there are two ways of creating a MojoRenderer within the renderer process: via the media::mojom::InterfaceFactory, and via a service directly registered in the RenderFrameHostImpl. These path both create a MojoRendererService, but each of them gives a different media::Renderer type to the MRS. This change gets rid of the interface provider that is directly registered in the RFHI. It also introduces the HostedRendererType, which allows the MojoRendererFactory to specify which media::Renderer type should be given to the MRS. NOTE: The process in which the final MRS is instantiated might be different based off of which HostedRendererType is requested. Change-Id: I4961dca5ae51738bbdbd1b313ffff27ec9056282 Reviewed-on: https://chromium-review.googlesource.com/879610 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#543576}
-
Sergey Berezin authored
BUG=814491 R=tommycli@chromium.org Change-Id: Ia82dc488bfb0cadc627d823eb22abaaaaab1051d Reviewed-on: https://chromium-review.googlesource.com/963610Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543575}
-
https://skia.googlesource.com/skia.git/+log/af18f22da6c5..8402542dac9e $ git log af18f22da..8402542da --date=short --no-merges --format='%ad %ae %s' 2018-03-15 benjaminwagner Fix GPU dimension for Win2k8 QuadroP400 jobs. 2018-03-15 robertphillips Handle GrContext creation failure in DDL Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ic57c00d3249f6c25f3156cfd976c27bf0f2f6d51 Reviewed-on: https://chromium-review.googlesource.com/965253 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543574}
-
Djordje Golubovic authored
R=thomasanderson@chromium.org Bug: 822411 Change-Id: Ib82849f24695049fb62c85f59a7326fb334332d4 Reviewed-on: https://chromium-review.googlesource.com/963592Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#543573}
-
Dominick Ng authored
This CL changes the string for the installable ambient badge to use the app name that will be installed or opened. The string now reads "Add <appname> to Home screen", or "Open <appname>" in the case of an installed app. BUG=782120 Change-Id: Icd3f727cd583930c8a1c43a504823ae4cf4d43f2 Reviewed-on: https://chromium-review.googlesource.com/963862Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#543572}
-
https://pdfium.googlesource.com/pdfium.git/+log/35841fa4e3db..7d75650672a8 $ git log 35841fa4e..7d7565067 --date=short --no-merges --format='%ad %ae %s' 2018-03-15 thestig Add a CFX_PathData::AppendRect() variant. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I06a36144c4cc4190e641ebde77f207357042959d Reviewed-on: https://chromium-review.googlesource.com/965107Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543571}
-
danakj authored
This moves the ResourceUtil methods and the SharedBitmap methods to determine bytes from sizes to viz/common so they can be used in viz code. R=kylechar@chromium.org Bug: 730660 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1c12896a3f87f8f577fb4aaf32239aa5a1baecb0 Reviewed-on: https://chromium-review.googlesource.com/954229 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#543570}
-
Alan Cutter authored
This CL adds a menu button highlight animation to run along side the origin title bar text animation for hosted apps added in: https://chromium-review.googlesource.com/c/chromium/src/+/942722 Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=327708&signed_aid=U4VyDkrKmEzMN56O5woqsw==&inline=1 Bug: 809794 Change-Id: I7ed8a7c9ccbf2c020bd9c76fb04f2a3123f265de Reviewed-on: https://chromium-review.googlesource.com/958899Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#543569}
-
Tom Anderson authored
BUG=787020 R=dpranke@chromium.org,derat@chromium.org CC=drott@chromium.org,sergeyu@chromium.org TBR=dpranke@chromium.org Change-Id: If78501622d71743c101b77464bd9edbadd2ad654 Reviewed-on: https://chromium-review.googlesource.com/933096Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#543568}
-
Sammie Quon authored
New UI bypasses some animations when in tablet mode. Old UI relied on animation ended to stack windows properly. After this patch lands, the enable new overview UI patch should be able to reland safely. Test: ash_unittests WindowSelectorTest.OverviewWidgetStackingOrder Bug: 821999, 822049 Change-Id: I4028b9c045b0bfc93207d2d0bc6343e634eb6c89 Reviewed-on: https://chromium-review.googlesource.com/963693Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#543567}
-
Shubhie Panicker authored
Bug: 816454 Change-Id: Ic1199c44b6e30d0118c9f3843364359bf63a42f5 Reviewed-on: https://chromium-review.googlesource.com/953244 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Cr-Commit-Position: refs/heads/master@{#543566}
-
https://webrtc.googlesource.com/src.git/+log/895ae9a0cdff..24c220c178f9 $ git log 895ae9a0c..24c220c17 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I341975f377ffea9b426a16ffe446076930885cf6 Reviewed-on: https://chromium-review.googlesource.com/965031Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543565}
-
Joel Hockey authored
Converted integration_tests/delete.js to test/js/delete.js Copied the parts of integration_tests/test_util.js required for delete.js to test/js/test_util.js and got TestEntryInfo integrated with MockVolumeManager. Added extra API implementations required: - chrome.i18n - chrome.mediaGalleries - window.domAutomationController Added webui_resource_test.js and test_util.js to create script. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie6704f98f8d8c2116c72c2d7a2c22cda246eb0a0 Reviewed-on: https://chromium-review.googlesource.com/961986 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#543564}
-
Matthew Jones authored
This change both adds a new hidden state for the bottom sheet and allows it to scroll off-screen, synchronized with the top controls, when in the peeking state. With this patch, if the sheet is hidden, it will not reappear until Chrome is restarted. BUG=813373, 821568 Change-Id: I78b36c19fab6acb0d5ad07d843426eeae4537d10 Reviewed-on: https://chromium-review.googlesource.com/961268Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#543563}
-
Maks Orlovich authored
use that in place of ChromeHttpUserAgentSettings. As for User-Agent, CreateDefaultNetworkContextParams() was already filling in the correct thing, so nothing needed to be done with that, though a redundant setting of it in IOThread::ConstructSystemRequestContext() also got removed. This required a patch from mmenke@ for StoragePartitionImpl::GetNetworkContext() to avoid creating redundant NetworkContext's in some cases, so we don't lose track of the ones that have HttpUserAgentSettings kept track of. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iee38daea39e60138abe90289bf9c4382c1da64ac Reviewed-on: https://chromium-review.googlesource.com/956028 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543562}
-
Takashi Toyoshima authored
Field study indicates that the bg_limit_3_1 group shows the best result. This patch adopt the same configuration for perftests to see if there is a overlooked regressed scenario with the configuration. Bug: 729954 Change-Id: Ied7a28851e4ebc86e65916c757dbf336a72863ff Reviewed-on: https://chromium-review.googlesource.com/964036 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543561}
-
Benjamin Pastene authored
Bug: 817779 Change-Id: I49f8b897014877b152d6790d41aad25e450433a3 Reviewed-on: https://chromium-review.googlesource.com/963091Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#543560}
-
Hongchan Choi authored
In BaseAudioContext::PerformCleanupOnMainThread, a vector is created for active source nodes and then its internal storage is swapped after the inactive source nodes are removed. This speculative fix clamps the capacity of the vector into the range between 0 and the current total active source nodes counts. My guess is in some cases the subtraction of these two unsigned values can be wrapped around to a huge number causing a crash with OOM. Bug: 814108 Change-Id: Id69979119a7d2f44de1be35fc0b27e7b39a6ed06 Reviewed-on: https://chromium-review.googlesource.com/963483 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#543559}
-
- 15 Mar, 2018 7 commits
-
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c0983fe0bd562bb0d27ffd723a17fd2a0a5d6f6 Reviewed-on: https://chromium-review.googlesource.com/965271Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#543558}
-
Jinsuk Kim authored
Another case SelectionPopupController gets a native->Java flow handed over from ContentViewCore. The feature is relevant to selection controller, which is now is fully capable of taking care of it without relying on ContentViewCore thanks to https://crbug.com/c/956786. Not related, but did some clean up in content_view_core.h for method declarations left unused. Bug: 598880 Change-Id: I5010644a67021632b1e2625167e02c3c4ab947d8 Reviewed-on: https://chromium-review.googlesource.com/963155Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#543557}
-
Weidong Guo authored
Bug: 812828 Change-Id: I41b5880225b500cebcbf1581c18538e686f9d9c0 Reviewed-on: https://chromium-review.googlesource.com/933109 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543556}
-
Dave Schuyler authored
This CL resets the filter_ member in the site data handler (c++) so that the filter will be reapplied when revisiting the page. Bug: 820816 Change-Id: Id710d8f6b9ec35f8ee69088dbbd8d8d9b3691c38 Reviewed-on: https://chromium-review.googlesource.com/964986Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#543555}
-
Malay Keshav authored
ARC++ gets its device scale factor from the default ManagedDisplayMode. When display zoom is enabled, we only have 1 display mode for the internal display. This display mode was not set as the default until now, causing ARC++ to get an invalid device scale factor. Bug: 790723 Change-Id: Ia86a3c22edb21ea3d0ced63f31992cca3e700ad6 Component: Managed Display Mode, Device scale factor, display zoom Reviewed-on: https://chromium-review.googlesource.com/964795Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#543554}
-
Siddhartha authored
The summary and background mode use the same set of MDPs now. So, remove duplicate list. BUG=730783 Change-Id: I3568d797d5bab3d36df658feb22df28d8ea786a4 Reviewed-on: https://chromium-review.googlesource.com/961554 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543553}
-
Alexei Svitkine authored
Previously, it would only take effect when a single feature was enabled on the study. The new logic would associate with all the features. Bug: 816696 Change-Id: Ide5ace721ade5e78f8743b11a96998d3b08ded46 Reviewed-on: https://chromium-review.googlesource.com/963087 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543552}
-