- 10 Aug, 2013 37 commits
-
-
dalecurtis@chromium.org authored
- Moves webkit/renderer/media/crypto/ppapi/ to media/cdm/ppapi/ - Moves webkit/.../ppapi/cdm/ to media/cdm/ppapi/api/ - Moves everything in webkit_media to media namespace - Fixes broken builds with use_fake_video_decoder=1 or use_libvpx=1 - Deletes webkit/renderer/media folder (\o/) BUG=251306 TEST=Chrome builds with mentioned flags, plus branding=Chrome. TBR=rsleevi Review URL: https://chromiumcodereview.appspot.com/22362007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216826 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
these strings are still not final, but they are (probably) better than what we have. BUG=260379 Review URL: https://chromiumcodereview.appspot.com/22342006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216825 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
Follow up to https://codereview.chromium.org/21046008/ to: * Treat invalid 'share' parameter as a configuration failure * Show error notifications for configuration failures * Eliminate NetworkStateNotifier::NetworkConnectionStateChanged which watched for connect failures triggered by NetworkLibrary connection attempts. This is now redundant and could result in duplicate notifications (one would replace the other). BUG=270936 Review URL: https://chromiumcodereview.appspot.com/22340006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216824 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Broke a variety of Linux, CrOS, and Android bots: ninja: error: 'gen/repack/chrome.pak', needed by 'chrome.pak', missing and no known rule to make it > Remove chrome.pak references, build resources into resources.pak > > This puts resources that used to be in chrome.pak and/or compiled in to > chrome.dll into resources.pak. resources.pak is already loaded at startup > on all platforms so having some resources in a separate pak file isn't > beneficial. > > R=tony > TBR=sky > > BUG=52609 > > Review URL: https://chromiumcodereview.appspot.com/22339020 TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/22557005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216823 0039d316-1c4b-4281-b951-d872f2087c98
-
jamesr@chromium.org authored
This puts resources that used to be in chrome.pak and/or compiled in to chrome.dll into resources.pak. resources.pak is already loaded at startup on all platforms so having some resources in a separate pak file isn't beneficial. R=tony TBR=sky BUG=52609 Review URL: https://chromiumcodereview.appspot.com/22339020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216822 0039d316-1c4b-4281-b951-d872f2087c98
-
sivachandra@chromium.org authored
BUG=178363 NOTRY=True Review URL: https://chromiumcodereview.appspot.com/22623006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216821 0039d316-1c4b-4281-b951-d872f2087c98
-
aruslan@chromium.org authored
BUG=259089 TBR=battre@chromium.org Review URL: https://chromiumcodereview.appspot.com/22623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216820 0039d316-1c4b-4281-b951-d872f2087c98
-
etienneb@chromium.org authored
This issue was found by a linter. R=kaiwang@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/22339009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216819 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
The primary motivation for this change was to remove the unnecessary include of kernel_wrap.h from nacl_io.h. In doing this is realised that we shouldn't be declaring the mount(2) function in nacl_io.h but instread relying on <sys/mount.h> for this. The doxygen comment that was previously attached to the mount(2) declaration was merged with nacl_io_init. R=binji@chromium.org Review URL: https://codereview.chromium.org/22642016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216818 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
GPU microbenchmarking framework is being deleted. BUG=168460 Review URL: https://chromiumcodereview.appspot.com/22320018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216817 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@chromium.org authored
BUG=270976 Review URL: https://chromiumcodereview.appspot.com/22303004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216816 0039d316-1c4b-4281-b951-d872f2087c98
-
simonjam@chromium.org authored
If a test adds its own command line options, we need to make sure those are included in the options variable. Previously, AddCommandLineOptions wasn't even called. Now we grab the defaults from it and then add those to |options| as long as |options| hasn't already set them. BUG=None Review URL: https://chromiumcodereview.appspot.com/22268006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216815 0039d316-1c4b-4281-b951-d872f2087c98
-
fdoray@chromium.org authored
Unwanted sign in to Chrome occurred when the user signed in to another service (Gmail, crbug.com...) from a tab that previously showed the Chrome sign in flow. This CL clears the state of the OneClickSigninHelper associated with a web contents when it's detected that the sign in process has been aborted (i.e. a navigation to a page which is not part of the web-based sign in is triggered by something else than the web contents). It's necessary to maintain the state when a navigation to an unknown page is triggered from the web contents in order to support SAML. TEST= 1.Launch Chrome and create new user ('Welcome to Chrome' page will appear). 2.Type 'crbug.com' in omnibox and hit 'Enter' key. ('Omnibox' of the same tab that showed the Chrome sign in page). 3.Click on the 'Sign in' link of 'crbug.com' 4.Login with valid account credentials. Expected result: You are not signed in to Chrome and no message related to sync appears. BUG=269421 Review URL: https://chromiumcodereview.appspot.com/22253010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216814 0039d316-1c4b-4281-b951-d872f2087c98
-
rockot@chromium.org authored
Certain prefs will now elicit stat tracking whenever they are changed locally and pushed to sync, or when changes from sync server are pulled down to update the local pref store. New histogram names take the form: Settings.$prefname.Changed{FromSync,Local} The logged value is the new pref value imposed by the change. BUG=265627 Review URL: https://chromiumcodereview.appspot.com/21580002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216813 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremycho@chromium.org authored
BUG=261834 Review URL: https://chromiumcodereview.appspot.com/21042013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216812 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
Adapts the WebContentsDelegate::RunFileChooser into a java embedding callback. BUG=Internal b/6930981 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/20666003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216811 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
These had some failures on the Mac bots a few weeks ago, but that was presumably due to a bad build of Chromium. The tests are passing fine on the trybots now. BUG=261724 TEST=Mac trybot Review URL: https://chromiumcodereview.appspot.com/20577003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216810 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216809 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Lots of tree breakages on Windows bots. > Adding check for OS support to AVX > > AVX support requires OS level support, this patch adds the relevant > checks to ensure AVX is truly supported on a given cpu. > > It also fixes a missing initializer for has_avx_. > > This is a takeover of https://codereview.chromium.org/12511002/ from > whunt@ who no longer works on the Chrome team. > > BUG=171824 > TEST=none > TBR=brettw,apatrick_chromium,whunt > > Review URL: https://chromiumcodereview.appspot.com/22354004 TBR=dalecurtis@chromium.org Review URL: https://codereview.chromium.org/22604007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216807 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216803 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
content should not be of poking around the internal structure of Blink, instead it should just use things exposed through public. This is necessary because DumpRenderTree is going away soon. R=jochen@chromium.org Review URL: https://codereview.chromium.org/22432006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216801 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=270431 R=dewittj@chromium.org Review URL: https://chromiumcodereview.appspot.com/22375008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216800 0039d316-1c4b-4281-b951-d872f2087c98
-
kkimlabs@chromium.org authored
TBR=isherman@chromium.org NOTRY=true BUG=267638 Review URL: https://chromiumcodereview.appspot.com/22602004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216799 0039d316-1c4b-4281-b951-d872f2087c98
-
dschuff@chromium.org authored
This will help debug any flake in the unit tests. R=jvoung@chromium.org BUG=none TEST= unit_tests --gtest_filter=Pnacl* Review URL: https://chromiumcodereview.appspot.com/22608005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216798 0039d316-1c4b-4281-b951-d872f2087c98
-
ibraaaa@chromium.org authored
Profiles info is being passed to JS in |BrowserOptionsHandler::GetLocalizedValues| which gets called only once when the settings page is opened but not on page reload. When a user edits in the profiles list (adds or deletes a profile) and then reload the settings page we end up populating the profiles list with old cached data. Accordingly, we request the profiles info in BrowserOptions.initializePage to get a fresh list of the profiles info every time the page is loaded. BUG=269942 Review URL: https://chromiumcodereview.appspot.com/22642011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216797 0039d316-1c4b-4281-b951-d872f2087c98
-
dmikurube@chromium.org authored
BUG=259206 NOTRY=True Review URL: https://chromiumcodereview.appspot.com/22352005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216796 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
AVX support requires OS level support, this patch adds the relevant checks to ensure AVX is truly supported on a given cpu. It also fixes a missing initializer for has_avx_. This is a takeover of https://codereview.chromium.org/12511002/ from whunt@ who no longer works on the Chrome team. BUG=171824 TEST=none TBR=brettw,apatrick_chromium,whunt Review URL: https://chromiumcodereview.appspot.com/22354004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216795 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
R=eliben@chromium.org Review URL: https://codereview.chromium.org/22686004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216794 0039d316-1c4b-4281-b951-d872f2087c98
-
ikarienator@chromium.org authored
We were simply close the device handle and left all the flying transfers hanging. libusb guarantees that the transfer callbacks will be called even if canceled. But it was not freed because during the libusb_close the user_data of the transfer is reset, so our handler will not be relaid to. This change is to wait for all the transfers to be canceled before we really close the platform handle. BUG=223817 BUG=261695 BUG=269048 Review URL: https://chromiumcodereview.appspot.com/22492003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216793 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
This change brings in a new version of naclports which is needed to fix the current breakage due to pnacl-translate no longer working on non-finalized executables. The new version of naclports, among other things, will always finalize before translating during build. TEST=build_sdk.py --build-ports R=binji@chromium.org Review URL: https://codereview.chromium.org/22674012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216792 0039d316-1c4b-4281-b951-d872f2087c98
-
wangxianzhu@chromium.org authored
1. Move category_group_enabled checking out of lock. 2. Move thread_name checking out of lock. Lock on thread_name changes to check and update thread_names_ map. 3. Check if thread_id is the id of the current thread before checking thread name change. 4. Move TraceEvent construction out of lock. 5. Put code ECHO_TO_CONSOLE code together and under lock. 6. Add a missing lock in TraceLog::RemoveProcessLabel(). This is the first step for bug 264667. Next step is thread-local event buffer. BUG=264667 Review URL: https://chromiumcodereview.appspot.com/22294006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216791 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
Once http://crrev.com/22652003 lands, and Blink rolls, this is the Chromium side that will allow the use of <webview> as a custom element. The actual changes to webview to use the custom element API will come in a separate patch. BUG=178663 Review URL: https://chromiumcodereview.appspot.com/22709003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216790 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
TrackedCallback handles re-entry into the Plugin. Add a way to insert a task into this process so resources can perform any completion work on the proper thread without having to duplicate this re-entry work. BUG= R=dmichael@chromium.org, yzshen@chromium.org Review URL: https://codereview.chromium.org/22606005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216789 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
Also fixed PYTHONPATH so that old generated *.pyc in chromedriver/ won't be picked up unexpectedly after the *.py were moved from chromedriver/ to chromedriver/test/. TBR=kkania@chromium.org BUG=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/22601006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216788 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=268984 TEST=no change TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/22632004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216787 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
For HLS, seekTo() can cause media player to stuck in a error state. Since the returned duration < 0 for HLS, we can ignore all seek positions that are negative BUG=265460 Review URL: https://chromiumcodereview.appspot.com/22605013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216786 0039d316-1c4b-4281-b951-d872f2087c98
-
skuhne@chromium.org authored
BUG=263983 TEST=visual Review URL: https://chromiumcodereview.appspot.com/22375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216785 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Aug, 2013 3 commits
-
-
zork@chromium.org authored
BUG=254738 R=dpolukhin@chromium.org, zelidrag@chromium.org Review URL: https://codereview.chromium.org/22329008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216783 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
This adds AddValue support to FrameData, RenderPass, *DrawQuad, FilterOperations, etc. It also adds an optional 'frame' field to the LTHI state which is the frame being produced at this point, with everything mentioned above. BUG=None R=danakj@chromium.org, nduca@chromium.org, vmpstr@chromium.org Review URL: https://codereview.chromium.org/20667002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216782 0039d316-1c4b-4281-b951-d872f2087c98
-
dewittj@chromium.org authored
This matches an updated spec. Now, the menu for profile switching has a checkbox next to the currently selected profile. Additionally, the leftmost edges of all the visible controls are now lined up. R=jianli@chromium.org BUG=269757 Review URL: https://chromiumcodereview.appspot.com/22720004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216781 0039d316-1c4b-4281-b951-d872f2087c98
-