- 16 Oct, 2020 40 commits
-
-
Dominic Mazzoni authored
Follow-up to http://crrev.com/c/2459008 Bug: 1135103 Change-Id: Ie1df234e82abea4105cec672f128661043df8a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459232Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#817792}
-
Howard Chung authored
When DeviceAllowBluetooth is set to False, users can still use crosh > bt_console to scan/pair etc. This patch power off the bluetooth adapter when DeviceAllowBluetooth is applied. Since crosh > bt_console launches bluetoothctl in restricted mode, which disallow any power operations, users will no longer be able to bypass enterprise policy in this way. BUG=b:158568520 TEST=set DeviceAllowBluetooth to False and verify the above method won't work. Change-Id: Ic02be25a19f2b73033c4c83e78fc3c707f86e48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467637 Commit-Queue: Yun-Hao Chung <howardchung@google.com> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#817791}
-
Keishi Hattori authored
Node::next needs to be excluded because Node is constructed using constexpr in kHklmSoftwareSubtree and kClassesSubtree. ScopedFunctionHelper::function_ needs to be excluded because the template makes it difficult for the rewriter to detect that it is a function pointer Bug: 1080832 Change-Id: Ic6414747019d2f9a6d682e47966a6bd74e1b8bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467300 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#817790}
-
Tal Pressman authored
Fuzzer found cases where the |agent_scheduling_group_| reference (which is used to send an IPC message) is no longer valid when RenderFrameImpl::PepperInstanceDeleted is called. While it is not clear to me yet how this situation happens, this CL "reverts" that specific message to be sent directly via RenderThread, without going through the AgentSchedulingGroup reference, in order to unblock the Beta release. Bug: 1137580 Change-Id: Ie2bc9ba12e56a1527e462352438a58d8baabc3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470060Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#817789}
-
Alex Gough authored
These are opened readonly and there is no reason for the network process to be able to write these files. e.g.: https://source.chromium.org/chromium/chromium/src/+/master:content/browser/network_context_client_base_impl.cc;drc=0e22286ee95d2bd711f81d73f1178343fbacc890;l=33 Bug: 1130762 Change-Id: Ife99f494308f2a21286012cdbdfdd45e2b9de5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464071 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#817788}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I4a7fff675f64f0a817e78fd99c13d45669c188dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476840Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817787}
-
Kartik Hegde authored
Add the DnsResolverPresent routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied DnsResolverPresent changes and successfully ran the DnsResolverPresent routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=dns_resolver_prsent). Change-Id: Iad19c4ab6eb9391bcc4a9410288e90f838446073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344807Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#817786}
-
spdonghao authored
Showing start surface toolbar is busy with its fade-in animation. Please see demos: https://drive.google.com/file/d/12wbd0iA0IGlZGjqMWIaVTUvhCBfX19yF/view?usp=sharing The animations are kept only when calling setToolbarVisibility(). Otherwise, when setStartSurfaceMode() is called, which means showing or hiding toolbar from start up or other pages, the animations are removed. Bug: 1131608 Change-Id: I6f6e368580ba7e367abb425689e127b46897166b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451269Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#817785}
-
Hiroki Nakagawa authored
Bug: 1093693 Change-Id: I6f6f08fcbf1ae2de006fbb2b8c15a89989c30ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462982 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#817784}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602784677-a93fbaee821e881bb685f33a6370b1d8843d7235.profdata to chrome-linux-master-1602806244-847cfe69512e3379b52d02969a5612ceb443a7a9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8dc8a3bc02d94a4554a735b06e8f91e56de7e368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817783}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4241fb9b. With Chromium commits locally applied on WPT: 7262d4d6 "Migrate credential-management WPTs to JS modules" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ic27af1067a7da345400a5b6c20a768414d982fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476589Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817782}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602784677-cb2da9a5056db49e979dc05760b0abb885837837.profdata to chrome-mac-master-1602806244-163ee8de1307bdf1621dd4ed7097ab91c883e0cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic274d6a9e8965c0acb7fdc2ce65db4bab575899f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477887Reviewed-by:
-
Takuto Ikuta authored
This reverts commit f60101d3. Reason for revert: Error: file "Client.cpp" is not expected to have static initializers in binary "chrome" https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8866332587065352912/+/steps/check_static_initializers__with_patch_/0/stdout Original change's description: > Roll Dawn from a7278454b28b to cb055303b5e0 (6 revisions) > > https://dawn.googlesource.com/dawn.git/+log/a7278454b28b..cb055303b5e0 > > 2020-10-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 481ecff293db to 95dc655bf8a6 (1 revision) > 2020-10-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 53380f9ed76f to 481ecff293db (1 revision) > 2020-10-15 cwallez@chromium.org Fix a small typo in Format.cpp alwaus -> always > 2020-10-15 brandon1.jones@intel.com Change Device::Tick To Return Bool > 2020-10-15 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from ff267ca60e14 to 53380f9ed76f (1 revision) > 2020-10-15 enga@chromium.org Replace the wire serializer with a no-op impl on disconnect > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/dawn-chromium-autoroll > Please CC enga@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel > Bug: chromium:951558 > Tbr: enga@google.com > Change-Id: Id52eaff3a4938c8407d968f5c7e5fe7c3933213b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477290 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#817733} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,enga@google.com Change-Id: I1752d10375103eca674497be8d84da42ab3c8d78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:951558 Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477138Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#817780}
-
Tal Pressman authored
This reverts commit 85ecd948. Reason for revert: A handful of V8ContextTracker unittests are failing on win-asan, and this seems like the most likely culprit. Sample failing run: ci.chromium.org/p/chromium/builders/ci/win-asan/15075 Original change's description: > [PM] Implement V8ContextTracker business logic. > > BUG=1080672 > > Change-Id: I10d0f001f00f1f7eb566843b9e9647297569abb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466152 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817764} TBR=chrisha@chromium.org,joenotcharles@chromium.org Change-Id: I026ceeeb3a8bd69f7460ea265b426ff60fe7de09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477697Reviewed-by:
Tal Pressman <talp@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#817779}
-
Findit authored
This reverts commit 6ddff235. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 817773 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZkZGZmMjM1MjJhMzllZTNlNmJhMDVkYzU2MWQ0OTliYWViYjc4ZjQM Sample Failed Build: https://ci.chromium.org/b/8866324530061890320 Sample Failed Step: compile Original change's description: > Use blink::mojom::ColorScheme instead of blink::ColorScheme > > This CL replaces the existing uses of native ColorScheme > with ColorScheme Mojo enum type defined in frame_owner_properties.mojom > in order to remove unnecessary type conversion. > > Bug: 919392 > Change-Id: Iebc2cf4a2094293027a07c643e75e57d75651e91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473739 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#817773} Change-Id: Ia71d30a8f132e59a91e70538302a78df885caf86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477091 Cr-Commit-Position: refs/heads/master@{#817778}
-
John Abd-El-Malek authored
This moves AwWebResourceResponse.java and aw_web_resource_response.*. Bug: 1117626 Change-Id: I46e74902570ac1b1f3a6fb2a90887966384c0912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477659Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#817777}
-
evliu authored
Bug: 1107940 Change-Id: I10b1790f120af7470086bf47709c145e788acbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477477Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#817776}
-
Mei Liang authored
This CL adds the LayoutType identifier to each Layout via the Layout#getLayoutType. This is not use anywhere yet. The potential caller of this API should be the LayoutManager, then LayoutManager pass the identifier to features that are observing the Layouts. Features then can use this identifier to determine what to react with a specific type of Layout being shown and hidden. Change-Id: Ie5e38c5f0c6edf5fdc8949fd20ad1c20e1e3832f Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419851 Auto-Submit: Mei Liang <meiliang@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#817775}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Iaf0b3cd37f8e9c21e48b06387d3581d7653dec41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477606Reviewed-by:
-
Gyuyoung Kim authored
This CL replaces the existing uses of native ColorScheme with ColorScheme Mojo enum type defined in frame_owner_properties.mojom in order to remove unnecessary type conversion. Bug: 919392 Change-Id: Iebc2cf4a2094293027a07c643e75e57d75651e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473739Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Joao Victor Almeida authored
The test is currently using waitFor and becomes flaky for its short timeout (200 frames). Running this test in a scenario where animation curves are impulse curves instead of ease-in-out curves makes it fail too. The goal of this CL is to make this webtest more reliable. Change-Id: Iaf6bcedd9a5f556dd6569dd46c699d69f672864a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417103 Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#817772}
-
Mugdha Lakhani authored
This reverts commit a55089af. crbug.com/1122182 is blocking minidump analysis for now. Bug: 1132770, 1123715 Change-Id: I15910a86667d242d3da419e4ed9a274e2a82fea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474854Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/browser_ui. Bug: 1113033 Change-Id: I1607d44812d3ab5c1eb512ca0ef2ef0f74c3d851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472497Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#817770}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a394b3f..6b326d83 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I66b021a63cbfb6365eb3e21a011568078d908d10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476587Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817769}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1f1e7dd3608..f1b53836b705 2020-10-15 jmbetancourt@google.com handle updateAnimationSurface in SkottieView through GL thread 2020-10-15 tdenniston@google.com Revert "Add subset of W3C test suite to SVG corpus" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I42e3b4b02d366f0981adaae28dd22a0f3c91fff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476157Reviewed-by:
-
Piotr Bialecki authored
In order to allow us to move ArCoreJavaUtils (Java & C++ implementation) and ArImmersiveOverlay to components/webxr, we need to introduce an interface that allows underlying layers to call into chrome/'s compositor (required for DOM overlay to work properly). Changes: - add ArCompositorDelegate & ArCompositorDelegateProvider along with their implementations for chrome/ - ArCoreJavaUtils now accepts an instance of ArCompositorDelegateProvider that will be used when creating the delegate (which, in turn, is fed into ArImmersiveOverlay) Bug: 843374 Change-Id: I4665d8a110941164dbb626c77e18364f4ff1e4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469397 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#817767}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and a follow up will remove warning exemption. Bug: 999886 Test: no errors building Change-Id: Idbca68c2a930810beedeefc2f2d1b894194c0f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468314Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#817766}
-
Alexander Cooper authored
VRSessionVideoTime* and VRSessionVideoCount* histograms were scheduled to expire within the next month. This change extends them for a further six months beyond that date. In addition, the other VR histograms are updated to this same expiration date, so that they can all be reviewed together at that time. Fixed: 1138407,1138408,1138411 Change-Id: Ifd4af4ba42f56b6553ab99ffcd171ffc611b0ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476893 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#817765}
-
Chris Hamilton authored
BUG=1080672 Change-Id: I10d0f001f00f1f7eb566843b9e9647297569abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466152Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#817764}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c166b7033fc3..205a62903130 2020-10-15 changhaohan@chromium.org Fix missing settings/ModuleUIStrings.js in build config 2020-10-15 brgoddar@microsoft.com Force FilterBar to update auto-complete suggestions after a completion 2020-10-15 vidorteg@microsoft.com Localization: Migrating Settings Folder If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1138624 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2a987cf55909f8af6930282bda3750d025e769d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477601Reviewed-by:
-
Lukasz Anforowicz authored
This CL removes the following crash keys: - request_load_flags (added in r803353) - url_loader_factory_debug_tag (added in r803843) Because they have already helped fix the main issue that was contributing to https://crbug.com/1056949 - these crash keys are focused on investigation of a single, specific bug and shouldn't be needed going forward. This CL retains the following crash key (added in r803353): - request_resource_type Because 1) it is still useful for tracking the source of the remaining kIncorrectLock cases (most of them seem to happen for kPluginResource and 2) it seems useful in general for narrowing down the scenario leading to a particular crash report. Bug: 1056949 Change-Id: I0f2bfb3c40c8c87097064e9537913004faa1d1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465516Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Starts ignoring the following sets of tags: 1. android-webview/android-not-webview, as we only use android-webview-instrumentation for specifying that an expectation applies to Webview. 2. Device-specific GPUs, instead using the device name. Bug: 1011107, 1111876 Change-Id: Ib110725307d5831de3c5e62665aec6ed867a97a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477285Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#817761}
-
Mila Green authored
Bug: 1138014 Change-Id: I7e9e73bc1c0d8ce1361ac5469f8e68ae31a4b90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443540 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#817760}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63fa6951fb7e..985f6835c900 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC pkasting@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099650,chromium:1117577,chromium:1137914 Tbr: pkasting@google.com Change-Id: Ic906b9076b8c85ff4c505662db9401ad1da0d405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477291Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#817759}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I9e52d0154dba2b3b1b5dbe532bb3daba4167a48c AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471880Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Weilun Shi authored
Support the simplest case of out-of-line patterned histograms migration in suffixes_to_variants script. The script should be able to migrate most of: 1. Histogram suffixes with a single affected histogram to an inline patterned histogram 2. Histogram suffixes with multiple affected histograms but these affected histogram are all present in a single file. Bug: 758782 Change-Id: Id1bf98d74b8e072bdd05f063cdf1884b73f1f86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473561 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#817757}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4244b5f6b438..fa9520e752b4 2020-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9b1cb285..070c3d67 (817475:817632) 2020-10-15 joedow@google.com Fixing the error logging in desktop_capture for Windows 2020-10-15 perkj@webrtc.org VideoStreamEncoder report VideoLayersAllocation for simulcast If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5850e822556a56a9206e3fd0fed5763beb1891ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477599Reviewed-by:
-
Ryan Heise authored
See bug for context. Bug: chromium:1139057 Change-Id: I634955a854d11c5dbe1970b23487b4f5c045a955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477237Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#817755}
-
Weilun Shi authored
Users should be able to extend the out-of-line variants by specifying some inline variants under the <token> node. Bug: 758782 Change-Id: I44a91a4b694dee148435f588552c6c91d89ecdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473442 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Yue Ru Sun authored
The macro UMA_HISTOGRAM_PERCENTAGE passes a bucket max value of 101 https://source.chromium.org/chromium/chromium/src/+/master:base/metrics/histogram_macros.h;l=130 https://source.chromium.org/chromium/chromium/src/+/master:base/metrics/histogram_macros_internal.h;l=146 However the supposedly equivalent function base::UmaHistogramPercentage passes a bucket max value of 100 here https://source.chromium.org/chromium/chromium/src/+/master:base/metrics/histogram_functions.cc;l=42 This patch fixes this discrepancy in the histogram function,and rename all existing usages of base::UmaHistogramPercentage to base::UmaHistogramPercentageObsoleteDoNotUse. TBR=mukai@chromium.org,dmazzoni@chromium.org,finnur@chromium.org,engedy@chromium.org,xiaohuic@chromium.org,sophiechang@chromium.org,bmcquade@chromium.org,amoylan@chromium.org,dschinazi@chromium.org Bug: 1121318 Change-Id: I30ddbfd35c6478cf2bf3313b5e6180f92e3bbaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468465Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#817753}
-
