- 04 May, 2018 33 commits
-
-
Eric Orth authored
Convert final usage to a ClearAllEntries() call since the final usage is building a duration to clear everything anyway. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id6a4c1fc0000fb0d0aacb37a39e6998842c01f0d Reviewed-on: https://chromium-review.googlesource.com/1035942 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555946}
-
Ben Pastene authored
This "cros_vm_launcher" target generates a script at build time (located at $out_dir/bin/launch_cros_vm) that you prepend to any other command and it will ensure a cros VM is running for the duration of the command. Also add it as a dependency to telemetry unittests. Invoking it in a bot's tests will come in a later CL. Bug: 828607, 832374 Change-Id: I56ee169c81127bf8cac1114b719f1cdeeb2c3d31 Reviewed-on: https://chromium-review.googlesource.com/1040117Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#555945}
-
dpapad authored
Previous code was working around crbug.com/689158 and crbug.com/768555. New code still works around them, but without requiring JS logic to do so, achieved by wrapping the cr-toggle contents with a <button>. Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I435f6a44979a934b8548b13bdbd947d324eab5c5 Reviewed-on: https://chromium-review.googlesource.com/1040683Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555944}
-
danakj authored
Replaces the WebBlendMode enum with a BlendMode enum in graphics_types.h under platform/graphics/ which is used throughout blink. This type is kept because the bindings generator requires an enum with matching names as the CSS property names (namely kNormal instead of kSrcOver). Then we convert from BlendMode to SkBlendMode in GraphicsLayer in order to pass it to the WebLayer. TBR=fserb Bug: 838693 Change-Id: If306343f4cd51911b46d6e1ca96529789477d29d Reviewed-on: https://chromium-review.googlesource.com/1038403 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#555943}
-
Majid Valipour authored
We use the latter on everything else in cc/animation and better to be consistent. This change should have no functionality change. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I87b37c9ab02166b628420cad95b7ea6a74d57caa Reviewed-on: https://chromium-review.googlesource.com/1042847Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#555942}
-
https://pdfium.googlesource.com/pdfium.git/+log/525147a1f6d6..ad178855775d $ git log 525147a1f..ad1788557 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 rharrison Invalidate GIF input buffer when moving file cursor backwards 2018-05-03 tsepez Prove that the memory was good at FPDFBitmap_CreateEx() create time. 2018-05-03 hnakashima Use pointers instead of refs in CXFA_TextLayout params. 2018-05-03 dsinclair [xfa] Verify we can get a font manager before setting up XFA 2018-05-03 dsinclair [xfa] Verify field count before accessing Created with: roll-dep src/third_party/pdfium BUG=chromium:839348,chromium:839361,chromium:838886,chromium:835693,chromium:837585 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I06ec60f0a34b13f864be053ffe512402c4c8ad7a Reviewed-on: https://chromium-review.googlesource.com/1043278Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555941}
-
Hiroshige Hayashizaki authored
As the current minifier doesn't support module scripts (e.g. import statements) and [1] is going to add module scripts that contain imports to a grit archive, this CL adds a |skip_minify| option to skip minifier for individual files as a workaround. |skip_minify| will be used in [1]. [1] https://chromium-review.googlesource.com/1031749 Bug: 829084, 839512 Change-Id: Ie4c3ad21cd2ef8cfb715d0eb57e7045f754acc1a Reviewed-on: https://chromium-review.googlesource.com/1031108 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555940}
-
Jun Choi authored
Currently FidoDiscovery::Start() is called in the constructor of FidoRequestHandlerBase class. This potentially leads to crash in authenticator_impl_unittest.cc when FakeU2fDevice is used. When FakeU2fDevice is used, the device is added in a synchronous manner as soon as discovery starts. This leads to invocation of FidoRequestHandlerBase::DeviceAdded() which then calls CreateTaskForNewDevice() which is a pure abstract function. This has been a non-issue until now as may unit tests does not actually call AuthenticatorImpl::{MakeCredential, GetAssertion}() and because AuthenticatorImpl constructor we used in unit tests has empty |protocols_| field. This should be changed as we add more end to end tests in future. Thus this CL moves invocation of FidoDiscovery::Start() from base class constructor to constructor of implementing class and add hid transport to AuthenticatorImpl::protocols_ in constructor. Bug: 798573 Change-Id: Iaca4978dd06233f670b44b52a30ec192b5f2cb51 Reviewed-on: https://chromium-review.googlesource.com/1032258 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555939}
-
Gabriel Charette authored
Cleanup while working towards crbug.com/839525 R=fdoray@chromium.org Bug: 839525 Change-Id: I5616ebb2f2037fb8d7d1f1259c3cb57e958d02d4 Reviewed-on: https://chromium-review.googlesource.com/1042881Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555938}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c692edf010c..8f20428bf4dc $ git log 6c692edf0..8f20428bf --date=short --no-merges --format='%ad %ae %s' 2018-04-25 ehmaldonado Reland "bot_update: Patch on gclient by default." Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1aeb8f42c55a23a9fc1f92555fe37b794373fa4 Reviewed-on: https://chromium-review.googlesource.com/1043154Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555937}
-
Lukasz Anforowicz authored
Bug: 838623 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6afbc0a870a7818ebec64da5d81875dd72173586 Tbr: olivierrobin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1036527 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555936}
-
Stefan Zager authored
This includes two chromium-specific commits to support CPU profiling on Android with simpleperf. R=agrieve@chromium.org Change-Id: Ibce20aae72d5c01af055f3125cdbd848fe6c427d Reviewed-on: https://chromium-review.googlesource.com/1043069Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#555935}
-
Kenneth Russell authored
The chromium/src CL needs to land before the tools/build CL does, or the builder will break completely. Bug: 838970 Change-Id: I3d788eac5564ad90bdd67f6e387a309b8718185b Tbr: zmo@chromium.org Tbr: cwallez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1043489Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/19282cf9d32d..153134ef26c3 $ git log 19282cf9d..153134ef2 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 dtu [pinpoint] Increase task queue rate. 2018-05-03 szager Add support for profiling on Android using simpleperf 2018-05-02 ssid Fix symbolization of heap profiles when so is mapped from apk 2018-05-03 nednguyen Fix cache_temperature_unittes to use working pages from test archives Created with: roll-dep src/third_party/catapult BUG=chromium:734705,chromium:839127 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I97dd890c7eda177ae8b603b830e60bfbb215da98 Reviewed-on: https://chromium-review.googlesource.com/1043079 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555933}
-
Noel Gordon authored
Bug: 833834 Change-Id: Iea9d32052c6ffbe17bf2cdd5075cbf5e9a203e0a Reviewed-on: https://chromium-review.googlesource.com/1042428Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555932}
-
Peter Collingbourne authored
This is useful for files that are only read by the linker, such as orderfiles. We were normally getting this right in the case where the target contained at least one source file, as the output file would transitively depend on the inputs via the source files, but if the target only contained dependencies on other targets, the inputs wouldn't be depended on at all. Bug: 835622 Change-Id: Ic7fb39caeacd4698b7ec6cfb0cb583a429a117dd Reviewed-on: https://chromium-review.googlesource.com/1041274Reviewed-by:
-
Dongseong Hwang authored
In the case, the fullscreen strategy is used for scanning out fullscreen scaled buffers (i.e. fullscreen youtube), instead of single on top strategy. It makes the case not submit the unnecessary primary plane to display engine. TEST=Youtube https://youtu.be/w8RN8T13rjE on soraka BUG=683347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8c82c7dd6182c34c0420ff4819ba37d5881039f0 Reviewed-on: https://chromium-review.googlesource.com/656222 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#555930}
-
Maks Orlovich authored
Bug: 832908 Change-Id: Ibf6b40fc043dfded18d500d71fa5f5316d1a31af Reviewed-on: https://chromium-review.googlesource.com/1042219Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#555929}
-
Fernando Serboncini authored
So calling it should be a noop, not an error. Change-Id: Id92d427c1e5e9f5795881de30f322a4556f6ade1 Reviewed-on: https://chromium-review.googlesource.com/1042958Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#555928}
-
Kenneth Russell authored
This reverts commit 66531351. Reason for revert: broke webgl_conformance_gl_passthrough_tests on all Linux bots; see https://bugs.chromium.org/p/chromium/issues/detail?id=776877#c31 . Original change's description: > Turn on presentation feedback for Linux > > Bug: 776877 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9d9590a5174db94392a447ab280e9218b37c2958 > Reviewed-on: https://chromium-review.googlesource.com/1040725 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555782} TBR=penghuang@chromium.org,piman@chromium.org Change-Id: Ib7da20d9bfb7729a6afadf075c7b99a58131014a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1043227Reviewed-by:
-
John Rummell authored
MP4 'cbcs' boxes specify an encryption scheme when used with encrypted media. Although the current CDMs don't support this scheme, it will in the future so enable desktop builds to parse these headers and pass it to the CDM. BUG=658026 TEST=existing 'cbcs' browser_tests still pass Change-Id: I6dc6c1596cf6bd1ecd776877fe45b5908fea4dce Reviewed-on: https://chromium-review.googlesource.com/1041266 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#555926}
-
Istiaque Ahmed authored
Bug: None Test: No visible change expected. Change-Id: I40f440cc25f8ab447a7a5c3cef84d76805d64537 Reviewed-on: https://chromium-review.googlesource.com/1040879Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555925}
-
Andrey Kosyakov authored
Bug: 721408 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifd9be7ae953b43bdeca09ec7f2c8dfa51dcbe7d1 Reviewed-on: https://chromium-review.googlesource.com/1042857 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555924}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=warx@google.com Change-Id: Ic1beb219a4494c552daa3835dc43a228be4a6e06 Reviewed-on: https://chromium-review.googlesource.com/1043028 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555923}
-
Noel Gordon authored
Add a AddEntriesMessage helper to convert the JSON dictionary value of the addEntries command to an AddEntriesMessage |message|. In the addEntries command, use that converter to extract the |message| and also FAIL if the message.volume is an invalid volume type. Covered by existing FileManager browser tests. Bug: 833834 Change-Id: Ib7ec56fee7c5b4857ccdfb0155a414430db73e97 Reviewed-on: https://chromium-review.googlesource.com/1042125Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
-
Muyuan Li authored
Test: browser_tests --gtest_filter=ArcVoiceInteractionArcHomeServiceTest.* Change-Id: I25e45f2663767d5d7ef20bd8bb5637b077c6eb44 Reviewed-on: https://chromium-review.googlesource.com/1014464 Commit-Queue: Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#555921}
-
Avi Drissman authored
BUG=838398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I0cf62fc688cdcd8b05320f1eb96543c50a8fca51 Reviewed-on: https://chromium-review.googlesource.com/1036249 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#555920}
-
Scott Chen authored
Bug: 836391, 832184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1ae3418e5b153a89b6d6bd5169365cc50bab7a15 Reviewed-on: https://chromium-review.googlesource.com/1040273Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555919}
-
Michael Thiessen authored
In some cases the Metadata for a RWHVA is set before VR code calls SetIsInVr on the RWHVA, so we miss the initial top controls update. (The only reason we care about VR-ness when updating the frame metadata is that sending the initial top controls update breaks interstitials) Bug: 837807 Change-Id: Ic108fa324725e7c126c9f721c27e4c5f99521af6 Reviewed-on: https://chromium-review.googlesource.com/1042500Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#555918}
-
Xiaocheng Hu authored
This is a reland of 85d8d125 Original change's description: > Stop using RenderedPosition in VisibleUnitsLine > > VisibleUnitsLine uses RenderedPosition instances without using > the bidi-related functionalities. > > Since RenderedPosition is a wrapper of InlineBoxPosition with bidi > utility functions added, this patch changes VisibleUnitsLine to > use InlineBoxPosition directly for simplicity. > > Bug: 822575 > Change-Id: I158ddfb3dec1ead3f8b66e1255f3465f3f0353a2 > Reviewed-on: https://chromium-review.googlesource.com/1024645 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553008} Tbr: yosin@chromium.org, yoichio@chromium.org Bug: 822575 Change-Id: I1fd854234f2c9265a758578023e07e220e63b86a Reviewed-on: https://chromium-review.googlesource.com/1042615Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#555917}
-
Scott Violet authored
This way it can be responsible for various interfaces that need to be registered. This also makes it easier to use in consuming code. I deleted from the README with the expectation that I'll update it later on once things are further along. BUG=837689 TEST=none Change-Id: I07f8f2902d02a6f2a8183bf141855494661a33d3 Reviewed-on: https://chromium-review.googlesource.com/1042879 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#555916}
-
Vlad Tsyrklevich authored
BUG=838858 Change-Id: Ibbdf3500626a11b7c73c179f582aaee3f452498f Reviewed-on: https://chromium-review.googlesource.com/1043259Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#555915}
-
Johannes Henkel authored
This was suggested by dcheng in https://chromium-review.googlesource.com/c/chromium/src/+/1038808. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4e9de0aaf4d126de446b9134c7d1e6062d397385 Reviewed-on: https://chromium-review.googlesource.com/1041189Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
- 03 May, 2018 7 commits
-
-
Vlad Tsyrklevich authored
BUG=839362,838785 Change-Id: I09528458d875c93e7c821c7789fc013f3f836b0a Reviewed-on: https://chromium-review.googlesource.com/1043283Reviewed-by:
-
Christian Fremerey authored
The API of video_capture.mojom.DeviceFactory allows clients to register virtual video capture devices which use shared memory buffers for transporting frames from producer to consumers. This CL expands the API with a second type of virtual video capture device, which is fed with textures (via MailboxHolder), which are subsequently passed down all the way to the consumers. This allows for displaying frames fed into such devices without the frame data having to be moved/copied out of the GPU memory/context. Design Doc: https://docs.google.com/document/d/1Vt8ME9foAR7vs9azwTP0mAQYUxAEbA1SOQ7hzrcXxP8/edit?usp=sharing virtual devices. An integration test has already been written and will be put up for review in the next CL of the series. Bug: 834478 Test: Note, that this cannot be tested manually, since there is no UI for adding Change-Id: I3a031fe849aa3eb69ce0a429b2ea803ae1855a2b Reviewed-on: https://chromium-review.googlesource.com/1028582 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555912}
-
DongJun Kim authored
This patch is for refactoring aria-haspopup following latest spec. Changed the value type of aria-haspopup from boolean to token in ARIA 1.1 [1]. Also, the implicit value for role combobox was changed from true to listbox. Supported values are : - true - false (default) - menu - listbox - tree - grid - dialog We expose both of "HASPOPUP" state and "haspopup:" values for backwards compatibility. [1] https://www.w3.org/WAI/ARIA/wiki/ARIA_1.1_Changes Bug: 740137 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib4988026c8728f64dfe4b30e842ef68620f093a5 Reviewed-on: https://chromium-review.googlesource.com/896672 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#555911}
-
David Black authored
This wires up text query functionality. Note that the bubble this view is housed in is InActive when shown and DialogPlate does not yet request focus on its textfield. So the user must activate the widget and focus the textfield manually. See bug for demo. Bug: b:79108829 Change-Id: I55a48076208b967031f48d6693bea2e8125c3641 Reviewed-on: https://chromium-review.googlesource.com/1040532 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555910}
-
Tom Anderson authored
This CL adds a warn-before-quitting flag. When enabled, pressing Ctrl+Shift+Q will show a bubble asking to continue holding the shortcut to quit. Pressing the shortcut a second time while the bubble is showing will also confirm the quit. R=sky BUG=243164 Change-Id: I97c4dc37cb5107fde975a4162f349e1ea5337b5d Reviewed-on: https://chromium-review.googlesource.com/1031097Reviewed-by:
-
Evan Stade authored
This is a first step towards moving BrowserFrameHeaderAsh into //ash/public and making it useable both in Ash (for Mash) and Chrome (for classic). Bug: 836992 Change-Id: I76109ef3949f803e87c153008c0bf462e8228492 Reviewed-on: https://chromium-review.googlesource.com/1042786 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#555908}
-
Noel Gordon authored
FileManagerBrowserTest is a parametric test: none of the other browser tests are (Gallery, VideoPlayer, AudioPlayer). Having the Param postfix in the getter names is a leftover from a time when there was only FileManagerBrowserTest. Remove the Param postfix. Bonus points: the implementation details of the test extension browser tests is no longer exposed. FileManageBrowserTestBase does not need to know, nor does it care. Bug: 833834 Change-Id: I3919b3751122afdccd1f6f0689107ab91440c427 Reviewed-on: https://chromium-review.googlesource.com/1042426Reviewed-by:
-
