- 27 Aug, 2020 40 commits
-
-
James Cook authored
CrOSComponentManager::Unload() calls into code in MetadataTable that assumes that system salt is available. This isn't always true when chrome restarts to apply non-owner flags. Unfortunately the MetadataTable API is synchronous and non-trivial to convert to async. Work around the crash by ensuring system salt is available before attempting to unload the lacros component. Filed crbug.com/1122753 to track refactoring MetadataTable so it doesn't depend on data that isn't guaranteed to be available. in about:flags, restart and let Lacros download/install. Then explicitly set flag to "Disabled" and sign out (not restart). Sign in again. No crash. Test: With non-owner account (secondary user), enable LacrosSupport Bug: 1122674 Change-Id: Idf25ef8955315e92c6f823a0da8f8b65fd0a40c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380320Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#802427}
-
Jinsuk Kim authored
This CL adds new histogram EphemeralTab.CtrPeek that indicates that user interacted with the peeked preview tab to open it beyone peeking state, in contrast to EphemeralTab.Ctr that indicates the preview tab got fully opened. Bug: 1025081 Change-Id: I7555ed9b21cc33d7348b4fd60052b49111fbc596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377029Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#802426}
-
Yuly Novikov authored
Flaky on D3D11 Intel WebGL2. TBR=bsheedy Bug: 1122744 Change-Id: Idb03c637582150acc120e2f13818a0914bb58a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380495Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#802425}
-
Weiliang Chen authored
In viz, the display compositor owns the context provider, and as the display compositor is getting destroyed, the context provider should be destroyed at the same time. Objects created by the GLRendererCopier has been the only ones keeping the context provider alive longer than the display compositor. This change will fail copy requests when the display compositor is getting destroyed. Bug: 1096487 Change-Id: I3cedd70dff42ed7ef9f946ec4b34017d3560df7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253159 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802424}
-
Dan Sanders authored
Change-Id: I922b80ac8b9b67b0500c69ba764d6e4ef4ae266d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380149 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#802423}
-
Robbie McElrath authored
crrev.com/c/2252560 separated 'All sites' and 'Storage' settings categories into their own Fragment, which broke them in WebLayer. This CL adds support for the new AllSiteSettings Fragment. Note that the new Intent being created in this CL does get passed to the client in order for it to start the new Activity, but its contents are transparent to the client so this is backwards compatible with older client versions. I'll add tests for every settings page in a followup that should catch issues like this in the future. Bug: 1122705 Change-Id: I94f69d1cebfbd19add42e936afccc0a5f2512aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380575Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#802422}
-
Daniel Classon authored
Adds deep links to the Apps Page and the Android Apps subpage. Bug: 1084154 Change-Id: I613b8ca1fc3074927efdff7820871f4dae3fa6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378875Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#802421}
-
David Bertoni authored
ExecuteScriptApiTest.ExecuteScriptPermissions was disabled for flakiness on Windows. Recent changes made to clean this test up have de-flaked it. It passed 3000 iterations on the bots without any flakes. Bug: 174715 Change-Id: I54e231b6dce37edd5cc0cea3df6e021e554cf10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375012Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#802420}
-
Chloe Pelling authored
Change-Id: I34548f56ef60ca5ef1fa3cba934ea86f3797677e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376941Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Chloe Pelling <cpelling@google.com> Cr-Commit-Position: refs/heads/master@{#802419}
-
rbpotter authored
Run most of the PDFExtensionJSTests with the PDFViewerUpdate flag enabled and disabled. Exceptions: - Run toolbar_manager_test only with the flag disabled. The tests in this file test toolbar hiding/showing behavior that is not relevant with the new UI. - Return early from one annotations_feature_enabled test and one basic_plugin test with the flag enabled, as there are some issues (noted with TODOs) that need to be fixed with these tests. Started from pieces of https://chromium-review.googlesource.com/c/chromium/src/+/2368821/7 by dpapad@ Bug: 1120279 Change-Id: Idb3445068dd7902e2934a8c8fd4e60b21b431ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376871 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#802418}
-
Wez authored
Bug: 865172 Change-Id: I687021367afc08315226049d18302b70856aa595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366743 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802417}
-
Scott Violet authored
and OnNavigationCompleted. Content does not allow WebContents to be deleted from WebContentsObserver::DidFinishNavigation(). Unfortunately we keep seeing crashes because of this restriction, so I'm inclined to provide some mitigation. This patch takes the approach of detecting this scenario and delaying deletion of the WebContents. All the surrounding WebLayer classes are deleted/destroyed and ownership of the WebContents is passed to the Profile and deleted from a post-task. Doing this may introduce it's own set of problems. For example, if a callback/notification is still in flight from content that gets processed before the deletion, and the code assumes there is a Tab associated with the WebContents, then there will be problems. My preference is still to fix this in content, but in the mean time this should work. BUG=1111127 TEST=covered by test Change-Id: I9dbd9f90b88cbdbdfbab9aab81840b986fcdc410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377552 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#802416}
-
Jon Mann authored
Previously during logout, when the notification came in to SyncedNetworkMetricsLogger that the tether network status changed to disconnected, the pref service was already destroyed. When the metrics logger attempted to check the network's metadata to see if it was eligible for logging, it caused a crash. This fix prevents querying the metadata store for non-wifi or tether networks in the first place, it also performs a null check on the metadata store before querying for information about eligible networks in case something changes with the timing of teardown during logout. Fixed: 1122678 Change-Id: I8d273b4f7c0d1d0ee5f58fcbc6b946743d28456a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380083 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#802415}
-
Piotr Bialecki authored
I2P: https://groups.google.com/a/chromium.org/d/msg/blink-dev/U5Iy4LrcwoI/dIlbC2OhAwAJ Explainer: https://github.com/bialpio/webxr-depth-api/blob/master/explainer.md Bug: 1119487 Change-Id: I81dcb8eb2b2fe3f599fcfb5d9b8fc4afe70d7fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367739Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#802414}
-
Emily Stark authored
In the simplified domains hide-on-interaction field trial, we elide the URL to the simplified domain (the most security-critical information) when the user focuses a text form field, which can be a moment where the user is making a security decision. However, this can lead to a weird experience when webpages autofocus input fields without user interaction. Therefore, this CL only elides the URL when the user specifically clicks a form field to focus it. (Focusing by keypress will already cause the URL to elide all keypresses trigger elision via DidGetUserInteraction()). Bug: 1104280 Change-Id: I016aa5df5ce34bf71ccec86401f9ed192f6d9ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377322 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#802413}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/282596778418..1e068e1dbb62 2020-08-27 jonahr@google.com Suppress functional_shaders_indexing_tmp_array_*_const_* on Metal 2020-08-27 tobine@google.com Vulkan:Use roundUpPow2 where possible 2020-08-27 amy.liu@arm.com Disable forceOldRewriteStructSamplers on Mali. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: dEQP-GLES31.functional.uniform_location.nested_array.*sampler2D_* Change-Id: I9d871ebf80dcf1db925cee244d438755fff5b55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#802412}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/532a264c141d..ee58da9d6f49 2020-08-27 johnstiles@google.com Remove unused `count_returns` method. 2020-08-27 johnstiles@google.com Prefer unique_ptr<> and make_xxxx over raw pointers and new. 2020-08-27 egdaniel@google.com Add GrInternalSurfaceFlag for vulkan input attachment. 2020-08-27 johnstiles@google.com Replace complex `count_returns` method with a ProgramVisitor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I8179c2ce3eeebd14cddde42c3071eabd37ad20e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380206Reviewed-by:
-
Scott Little authored
The test http/tests/devtools/sources/debugger/source-frame-inline-breakpoint-decorations.js has been flaking on the WebKit Linux MSAN builder for a while now, so this CL marks it as flaky. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7280 TBR=szuend@chromium.org Bug: 1122742 Change-Id: Ifcb0ba10cbb792b04be4c922866a4f02dc54eb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380436Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#802410}
-
Prashant Nevase authored
Replace blink::FloatPoint3D by SkV3 and blink::TransformationMatrix by SkM44. Bug: 1091095 Change-Id: I4d5c386757365cd2e7dee8d5dcd5cb27c4576131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212226Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#802409}
-
Jonah Ryan-Davis authored
SwANGLE needs to be told when to lock/unlock the IOSurfaces that are being rendered to. This is accomplished via wrapping shared GL image Begin/EndAccess in calls to Bind/ReleaseTexImage. Bug: swiftshader:154 Change-Id: I9994dd6a2f01682b212175c353c0cb89c5b51d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378539Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#802408}
-
Xing Liu authored
This reverts commit 44e43142. Reason for revert: Lots of builders are failing in gclient runhook. https://ci.chromium.org/p/chrome/builders/ci/test-wifi-tablet/19099? Original change's description: > Reland "Temporary add verify_file_exists to check files downloaded." > > This reverts commit 2b17e053. > > Reason for revert: Reland initial cl after fix the typo > > Original change's description: > > Revert "Temporary add verify_file_exists to check files downloaded." > > > > This reverts commit e69f63a3. > > > > Reason for revert: Causing infra failures on chrome/ci/android-internal-chromium-tot, see crbug.com/1122206. > > > > Original change's description: > > > Temporary add verify_file_exists to check files downloaded. > > > > > > R=bsheedy@chromium.org > > > > > > Context: to make sure those wprarchive files are downloaded properly. > > > Bug: 1096656 > > > Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386 > > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > > Commit-Queue: Arthur Wang <wuwang@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#801957} > > > > TBR=dpranke@google.com,bsheedy@chromium.org,wuwang@chromium.org > > > > Change-Id: I4d7f023d4e4d8f441d2cbdc33788e17f859377ab > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1096656 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378541 > > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#801977} > > R=bsheedy@chromium.org > TBR=dpranke@google.com, wuwang@chromium.org, wylieb@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1096656 > Change-Id: If288ccd984009baacb9dda60f14aa548ec94a272 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378892 > Commit-Queue: Arthur Wang <wuwang@chromium.org> > Reviewed-by: Arthur Wang <wuwang@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#802390} TBR=dpranke@google.com,bsheedy@chromium.org,wylieb@chromium.org,wuwang@chromium.org Change-Id: Ia62b89df8121aa6cbf6726a81f8f64a400a49d33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1096656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380742Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#802407}
-
kdillon authored
A previous CL changed two spots that call UpdatePolicy() to instead directly change the compositor policy since a full policy update was not needed. This CL further modifies that change by moving the compositor priority out of the policy so that it can be changed without altering the policy outside of a call to UpdatePolicy(). Change-Id: Ibf2ad8da64ea34f0c0aa776b1be8dc79a3bbfe2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357092 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#802406}
-
Maksim Sisov authored
This is a reland of f1d35ca2 Original change's description: > linux sysroot: fix libwayland-client-symbols file. > > I initially generated it by myself and made a huge mistake by > setting base version to a single version. However, some symbols > only appeared after certain version. Thus, fix that problem by > copying and using the symbols file from wayland packages > in https://git.launchpad.net/ubuntu/+source/wayland. > > Bug: 1116384 > Change-Id: Idc3b4f1a6c1f810243a4090d9008f9ad83482dfe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379674 > Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#802226} Bug: 1116384 Change-Id: I0bbdcc98f0c88d414edef74db8b38e30249cbc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380318Reviewed-by:
-
Jian Li authored
When the top toolbar in new tab page layout view is out of screen, we need to notify SnapScrollHelper in FeedSurfaceMediator.ContentChanged to bring back the toolbar. This is done by hooking up the stream content change listener between FeedStream and FeedSurfaceMediator. Bug: 1120298 Change-Id: Ib763185f33c78308372914f87b45989e55827fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377608 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#802404}
-
Jazz Xu authored
Bug: 1035213 Change-Id: I3da4241c0e97ab3b546ee3cf8b4dc885cc93359d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369573 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#802403}
-
David Bienvenu authored
This moves the clearing of the gesture state to before the ole32 drag drop. Otherwise, the ole32 drag drop nested event loop can trigger two kGestureScrollBegin events in a row, causing a DCHECK. Long term, per mustaq@, when the drag-drop controller takes over control from the gesture recognizer at gesture-long-press, the GR should be ignoring the "current gesture stream" (from the very first finger going down until the very last finger leaving the screen). Bug: 1120809 Change-Id: I792471a2212647282b84d7745c5e7f861b15a28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378851 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#802402}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/d8fb72d5ad9c..e447bc609047 $ git log d8fb72d5a..e447bc609 --date=short --no-merges --format='%ad %ae %s' 2020-08-27 fayang Neuter initial packet in the coalescer when discarding initial keys. 2020-08-27 fayang Deprecate gfe2_reloadable_flag_quic_update_packet_size. 2020-08-27 bnc Refactor GOAWAY-related accessors. 2020-08-26 dschinazi Add memory safety guard for QuicFrame 2020-08-26 dschinazi Add some QUIC DCHECKs Created with: roll-dep src/net/third_party/quiche/src R=dschinazi@chromium.org Change-Id: I66ddfd794c1ff4620603d9a954375686c0fae256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380214 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#802401}
-
Dirk Pranke authored
The 'generated_script' type in MB configs allows the user to specify an alternative to "bin/run_$target" as the script to use. However, in order to make things consistent, we really don't want to support that. This CL is a first pass at cleanup by removing every case where script was set to match "bin/run_$target", and then adjusting the logic in mb.py to supply that. It also removes a bunch of unnecessary `args` settings where the setting just matched the default ([]), and updates the doc comments in gn_isolate_map.pyl. Bug: 816629 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: Iedd072c4fc2b53605c0f225152bcc7ee6b80ec5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380420Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#802400}
-
Emily Stark authored
This CL plumbs the blink::mojom::FocusType of a focus event into WebContentsObserver via FocusedNodeDetails. This allows observers to differentiate focuses that occurred from mouse clicks vs keypresses etc. Bug: 1104280 Change-Id: I01494e89034e7172dfa808965280013987ac1c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378392 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#802399}
-
Jérôme Lebel authored
kSigninShouldPromptForSigninAgain should be reset before any EG tests, like other preferences. Fixed: 1122648 Change-Id: I4cb998134b2c4e4b0f8819ebc87fab03a53911de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380272 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#802398}
-
Kirill Ovchinnikov authored
This CL returns back MemoryPressureMonitor for Linux that was temporarily removed during memory subsystem changes. Based on the previous implementation with some refactoring. Bug: 463606 Change-Id: I5e6fbf46c913a86c152faea7964288249cc04247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1386856 Auto-Submit: Kirill Ovchinnikov <kirill.ovchinn@gmail.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#802397}
-
Rune Lillesveen authored
Spec: https://drafts.csswg.org/css-content/#quotes Intent-to-ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/iqihcxi-CzY/m/U_0GkEoqCAAJ Bug: 990557 Change-Id: I82ab72f05468b846bf10c6b37b74eaa3e35c457c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366720Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#802396}
-
Prakhar authored
As per suggestion at https://docs.google.com/document/d/1Q9oYW2w0-QTR6R8uI6yjriFu75e6_K50qcHyj3lda6c/edit?disco=AAAAKHpexIU It will be renabled with a separate pool, but currently disabling it to free up the resources Bug: 1024915 Change-Id: I83f411ccfc3aa7db690fb175810f5287153ff96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379399 Auto-Submit: Prakhar Asthana <pasthana@google.com> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#802395}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8e6246dafe61..cc61e5a98324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9cde8726e2fd67c65015929c2ac31a1e6f2a9609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380570Reviewed-by:
-
Yann Dago authored
Bug: 1102927 Change-Id: Iee104ca7c5c75ecaa964e8d121c331cfbb8b5abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289384 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#802393}
-
Chong Gu authored
Allow git to ignore build/fuchsia/internal directory. Make DeviceTarget generic class for non-emulator targets that don't need provisioning. Replace original DeviceTarget with GenericX64Target, for provisioning devices with generic x64 build. Bug: 1080854 Change-Id: I2e70a85689ce9527b86bcb5eeb24895119454da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343228 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
-
Dan Sanders authored
Renames EncodedVideoConfig -> VideoDecoderConfig. Adds coded, crop, and display sizes, removes aspect ratio. Bug: 1122126 Change-Id: If80fef74d64f35a83e531bc7789d3559ec510a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377899Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#802391}
-
Arthur Wang authored
This reverts commit 2b17e053. Reason for revert: Reland initial cl after fix the typo Original change's description: > Revert "Temporary add verify_file_exists to check files downloaded." > > This reverts commit e69f63a3. > > Reason for revert: Causing infra failures on chrome/ci/android-internal-chromium-tot, see crbug.com/1122206. > > Original change's description: > > Temporary add verify_file_exists to check files downloaded. > > > > R=bsheedy@chromium.org > > > > Context: to make sure those wprarchive files are downloaded properly. > > Bug: 1096656 > > Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > Commit-Queue: Arthur Wang <wuwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801957} > > TBR=dpranke@google.com,bsheedy@chromium.org,wuwang@chromium.org > > Change-Id: I4d7f023d4e4d8f441d2cbdc33788e17f859377ab > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1096656 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378541 > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#801977} R=bsheedy@chromium.org TBR=dpranke@google.com, wuwang@chromium.org, wylieb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1096656 Change-Id: If288ccd984009baacb9dda60f14aa548ec94a272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378892 Commit-Queue: Arthur Wang <wuwang@chromium.org> Reviewed-by:
Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#802390}
-
Thomas Lukaszewicz authored
CandidateWindowView inherits from BubbleDialogDelegateView which creates a NonClientFrameView with a non-zero default corner radius. It then replaces the border with its own BubbleBorder subclass with a corner radius of 0. This was causing issues where a clipping mask would initially be applied due to non-zero border radius but never updated once the 0 radius border was set (masks aren't applied to views that are identified as not needing one). This CL fixes the issue by disabling the use of rounded corners on the CandidateWindowView, bringing the class' behavior inline with the code author's intentions. Bug: 1122476 Change-Id: I8c727e1c04ceab6e650924159dab2ef47c3b5eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380211Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#802389}
-
Xianzhu Wang authored
Combine OverflowClipBehavior enums for platform overlay scrollbars and CSS overlay scrollbars because they don't have any difference about layout and clipping behavior. We clip for overflow:overlay (CSS overlay) scrollbars because we didn't properly handle z-order of these scrollbars, and they might be covered by stacked children. Now use the same z-ordering algorithm for both overflow:overlay scrollbars and platform overlay scrollbars. This CL fixes issues of overflow:overlay scrollbars, and also makes it easier to remove it in the future because this CL reduces the difference of overflow:overlay scrollbars from platform overlay scrollbars. Bug: 984167 Change-Id: Id239734ec773d826291ec357fa1036f6b4b95038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370564 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
