GitLab

A URLRequest can signal the end of a stream by calling OnReadCompleted()
with a byte count of zero. No further reads should be issued after this.
However, ResourceLoader could issue a second Read() if the
ResourceHandler::OnReadCompleted() handler sets defer to true. I.e.

When a read completes:
  URLRequest calls
    -> ResourceLoader::OnReadCompleted(request, 0)
    -> ResourceHandler::OnReadCompleted(id, 0, &defer)
       (ResourceHandler sets defer to true)

Prior to this CL, the behavior on resumption was:

  ResourceHandler calls
    -> ResourceLoader::Resume()
    -> ResourceLoader::ResumeReading()
    -> ResourceLoader::StartReading()
    -> ResourceLoader::ReadMore()
    -> URLRequest::Read()

The new behavior is:

  ResourceHandler calls
    -> ResourceLoader::Resume()
    -> ResourceLoader::ResponseCompleted()

The new behavior is parallel to what happens if the ResourceHandler
didn't defer.

BUG=320394

Review URL: https://codereview.chromium.org/267563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269518 0039d316-1c4b-4281-b951-d872f2087c98

This is required for some internal update generation.

R=grt@chromium.org

Review URL: https://codereview.chromium.org/271823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269517 0039d316-1c4b-4281-b951-d872f2087c98

This backs out r296483, r269492, r269501, and r269511. The iOS bots hated it.
They don't like mach_vm_* and must use vm_* instead, and they can't #include
<mach/mach_vm.h> at all. The above patches dealt with that, but then when it
turned out that the iOS bots also weren't even building ScopedMachVM or
MACH_LOG at all, I decided to call it quits.

http://build.chromium.org/p/chromium.mac/builders/iOS%20Device%20%28ninja%29/builds/919/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.mac/builders/iOS%20Device%20%28ninja%29/builds/921/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16185/steps/compile/logs/stdio

TBR=rsesek

Review URL: https://codereview.chromium.org/274193007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269516 0039d316-1c4b-4281-b951-d872f2087c98

This CL prevents the dragging of app list folders to the Windows taskbar
by disabling synchronous drags for folders.

BUG=371665

Review URL: https://codereview.chromium.org/279673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/270803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269514 0039d316-1c4b-4281-b951-d872f2087c98

Previously we set the packet size in BasePacketEvent proto during
construction and never overwrite it. The problem is that the proto is
most often created as a result of seeing a receiver packet event first,
which does not contain packet size information and thus the size field
is set to 0. We'd need to overwrite the size field when we see a sender
packet event, which contains packet size information.

Most of the time we see receiver event first because they often arrive
sooner (via RTCP packets) than sender events (via IPC every second).

Review URL: https://codereview.chromium.org/272873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269513 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Linux Asan is failing with this patch: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2483/steps/unit_tests/logs/stdio

Original issue's description:
> Resubmit: Add real file for AdNetworks DB
> 
> This is a resubmit of https://codereview.chromium.org/268063004/.
> 
> The previous version was reverted because it caused a memory leak. This was a
> problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
> has been fixed.
> 
> Details:
> Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
> (which according to the class comment, "the ref counting does not matter" [1]),
> the ref-counting _does_ matter. The fix for this went in as part of a refactor
> in https://codereview.chromium.org/263953003/.
> 
> [1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44
> 
> BUG=357204
> 
> TBR=jhawkins@chromium.org (previously approved)
> TBR=felt@chromium.org (very minor changes)
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269494

TBR=jhawkins@chromium.org,felt@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357204

Review URL: https://codereview.chromium.org/277133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269512 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/273183003/


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363840

Review URL: https://codereview.chromium.org/267573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269510 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the writeCharacteristicValue function of the
bluetoothLowEnergy API.

BUG=265663
TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.*

Review URL: https://codereview.chromium.org/263333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269509 0039d316-1c4b-4281-b951-d872f2087c98

Tapping the back button, cancel button, or outside the dialog should not set the value.
DatePickerDialog has a bug since JellyBean where the onDateSet callback is called every time the dialog is dismissed.

BUG=325841

Review URL: https://codereview.chromium.org/260903006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269507 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366947

Review URL: https://codereview.chromium.org/269813012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269506 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269503 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rsesek

Review URL: https://codereview.chromium.org/273183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269501 0039d316-1c4b-4281-b951-d872f2087c98

    
Add AUD, SEI and reserved NALU types to the set of NALUs that
trigger the end of current frame, i.e. NALUs that indicate
that we have already got all the slices belonging to the
current frame.

BUG=370758
TEST=vdatest, stream with AUDs

Review URL: https://codereview.chromium.org/268363018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269500 0039d316-1c4b-4281-b951-d872f2087c98

On mac/linux the debug stub port is allocated chrome side and provided to
Native Client. On Windows (where socket handles cannot be passed between
processes), the debug port must be allocated by the nacl process (which can
only happen when the outer sandbox is disable).

Propagate the debug port selected by the nacl side to the task manager to make
it available to the user and debugging extensions.

Depends on this nacl side change:
https://codereview.chromium.org/206493005

BUG=328714
TEST=None
R=mseaborn@chromium.org,jschuh@chromium.org

Review URL: https://codereview.chromium.org/198083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269499 0039d316-1c4b-4281-b951-d872f2087c98

BUG=b/12492817

Add the internal Aw API to enable/disable DRP.

NOTRY=true

notry due to irrelevant failures in windows rel tests.

Review URL: https://codereview.chromium.org/271523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269498 0039d316-1c4b-4281-b951-d872f2087c98

Refactor clients using equivalent non-deprecated methods.

R=reed@google.com,enne@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/271653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269497 0039d316-1c4b-4281-b951-d872f2087c98

Aura's current slop region is boundary exclusive, whereas Android's is boundary
inclusive.  With the unified GR, both platforms will use a boundary inclusive
slop region, but until such time the TouchEventQueue should support either
model.  Allow this distinction via a configurable TouchEventQueue::Config
parameter.

BUG=354763

Review URL: https://codereview.chromium.org/273933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269496 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245025

Review URL: https://codereview.chromium.org/274943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269495 0039d316-1c4b-4281-b951-d872f2087c98

This is a resubmit of https://codereview.chromium.org/268063004/.

The previous version was reverted because it caused a memory leak. This was a
problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
has been fixed.

Details:
Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
(which according to the class comment, "the ref counting does not matter" [1]),
the ref-counting _does_ matter. The fix for this went in as part of a refactor
in https://codereview.chromium.org/263953003/.

[1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44

BUG=357204

TBR=jhawkins@chromium.org (previously approved)
TBR=felt@chromium.org (very minor changes)

Review URL: https://codereview.chromium.org/274563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269494 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerConnection is deriving from a non exported interface IViewManager.

Attempt 2 at fixing this. The previous approach of using NON_EXPORTED_BASE does not work in
the template base derivation used in this class.

Proposed fix is to explicitly disable this warning for Windows.

BUG=none
R=cpu@chromium.org, cpu
TBR=darin

Review URL: https://codereview.chromium.org/271363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269493 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rsesek

Review URL: https://codereview.chromium.org/271353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269492 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/270833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269488 0039d316-1c4b-4281-b951-d872f2087c98

 * Added ToValue() method on BeginFrameArgs.
 * Added a ToTrace method inside cc/traced_value.h for easy conversion, just do a ToTrace(XXX) of anything which has a ToValue() method.
 * Rename Scheduler::StateAsValue to AsValue so it works with above.

BUG=371223

Review URL: https://codereview.chromium.org/270703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269487 0039d316-1c4b-4281-b951-d872f2087c98

Answers in Suggest requires a version number on all suggest queries.
Add a gs_rn=42 attribute to requests if Answers is enabled.

BUG=370192

Review URL: https://codereview.chromium.org/269293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269486 0039d316-1c4b-4281-b951-d872f2087c98

The update script should build `ant package` and copy the entire
out/package directory.

This moves the path to domdistiller.js to .../package/js so update
that reference.

The old (non-proto) API is still supported, so this keeps using that.

Picked up changes:
fdb023d Fix Proto module's path
44e9366 This adds two simple protoc plugins.

NOTRY=true

Review URL: https://codereview.chromium.org/277563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269485 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to add these targets when I added the build file for GN and
they will be needed to fully build ui/base target and friends.

This patch ports only webui_resources to GN build for now, since making
resources a group target does not work yet.

BUG=367592
TEST=None
R=brettw@chromium.org
TBR=ben
NOTRY=true

Review URL: https://codereview.chromium.org/265953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269484 0039d316-1c4b-4281-b951-d872f2087c98

where it makes sense to do so in existing code.

This migration shook out a couple of bugs in mach_logging.h carried over
from mac_logging.h (fixed there too).

R=rsesek@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/278923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269483 0039d316-1c4b-4281-b951-d872f2087c98

The goal is to reorganize the sync attachment code so that in the future
attachment code can include stuff it needs (like src/net/) without
loosening the DEPS rules for the rest of sync.

Replace internal_api's coarse grained dep on net/ with finer grained
deps.

sync/api/attachments - Home to attachment code that's needed by both
sync itself and users of sync.

sync/internal_api/public/attachments - Home to attachment headers needed
by sync/api/attachments.

sync/internal_api/attachments - Home to attachment code that's private
to sync.

TBR=mef,erikwright,phajdan.jr

BUG=

Review URL: https://codereview.chromium.org/270633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269481 0039d316-1c4b-4281-b951-d872f2087c98

This is the first effort at moving some of the ReverseService logic out of the
trusted plugin. I'd like to move these over soon since the tangled callback is
pretty nasty, and hidehiko@ has run into the ugliness while adding features for
Bare Metal Mode.

This one is pretty easy since it's stateless.

BUG=239656

Review URL: https://codereview.chromium.org/268793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/278553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269479 0039d316-1c4b-4281-b951-d872f2087c98

crypto.subtle.wrapKey() orders the key to be wrapped before the wrapping key. Use the same convention throughout webcrypto code to avoid confusion.

BUG=245025

Review URL: https://codereview.chromium.org/272033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269478 0039d316-1c4b-4281-b951-d872f2087c98

These are bitmaps to use in dark colored frames, for
https://codereview.chromium.org/274013002. This change also moves
the buttons currently in use from win/ to common/ as they are also used
on Linux.

BUG=339558
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/270873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269477 0039d316-1c4b-4281-b951-d872f2087c98

In order of precedence, set size according to:
* Command line parameters if present
* Environment variable if present
* 1600x1200,3840x1600 if RANDR is present, otherwise just 1600x1200.

R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/278753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269476 0039d316-1c4b-4281-b951-d872f2087c98

Without this CL, I observed that the sender sometimes gets stuck trying to catch up.
I could provoke this by using the "bad" netork profile in the udp_proxy in combination
with the "Extreme" (4Mbit/s) sender profile. I could provoke the behaviour by killing
the proxy for a few seconds, and then observe that the mirrored video would remain
slow and jerky for a very long time. (Perhaps forever)  With this patch, the video
catches up again after a few seconds.

Review URL: https://codereview.chromium.org/276783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269475 0039d316-1c4b-4281-b951-d872f2087c98

Adding an output_test_common.xx file which will also gain more testing features
for BeginFrameArgs soon.

BUG=371223

Review URL: https://codereview.chromium.org/275543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269474 0039d316-1c4b-4281-b951-d872f2087c98

- Remove k{Audio,Video}XXX event types and add in kXXX event types to
be shared between audio and video.
- Changed RTCP event mapping to accept both k{A,V}XXX and kXXX event
type encodings from the receiver. Old encodings get mapped to the
unified types on sender side.
- Changed reciever reference implementation to always send new unified
event types.
- Changed LoggingImpl::Insert{Frame,Packet}Event calls to take
additional EventMediaType argument.
- Added a param in RTCP to indicate whether receiver events
from incoming ssrc are audio or video events.
- Remove generic event types.
- Remove other unused events
-- kVideoFrameSentToEncoder
-- k{AV}PacketSentToPacer
-- kDuplicate{AV}PacketReceived


BUG=365829

Review URL: https://codereview.chromium.org/270493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269473 0039d316-1c4b-4281-b951-d872f2087c98

animation_update_pending_ is never reset to false, so this almost never does anything, and shouldn't matter with threaded compositor.

BUG=362164

Review URL: https://codereview.chromium.org/271803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269472 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerConnection is deriving from a non exported interface IViewManager

BUG=none
R=cpu@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/271353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269471 0039d316-1c4b-4281-b951-d872f2087c98