- 13 Jan, 2021 40 commits
-
-
Haiyang Pan authored
Introduced packager_vars.star so that properties will be the shared between CI and matching try builders. Also reorg the following builder to use a similar starlark structure: * android-androidx-packager * android-avd-packager * android-sdk-packager Bug: 1132368 Change-Id: I8001cfa818c2e647cc513e46a2f166fbe1e253df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625271 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#843125}
-
Liquan (Max) Gu authored
Motivation: Currently, we allow all mime-types except for pdf as Payment Handler pages. This exposes payment handlers to the vulnerabilities of certain less-maintained mime-types. Since "text/*", "image/*", "video/*", javascript, xml, json could satisfy a majority of use cases, this CL allowlist the supported mime-types for payment handlers. Before, we disallowed the "application/pdf" mime-type for payment-handler pages. After, we allowlist the following mime-types for payment handler pages: * text/* * image/* * video/* * application/javascript * application/xml * application/json Before, we applied the throttle to mainframes. After, we apply the throttle to all frames. Bug: 1165367, 1165392 Change-Id: Ie69e296dc2c287c38a10ed08c1c40527f941ee47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622871 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843124}
-
Richard Knoll authored
Adds additional timing metrics for the mute notifications feature: - How much time passes before the user takes an action on the notification - How long a screen capture session lasts - How much time passes from start of a session until the user reveals notification content again Bug: 1131375 Change-Id: I70e99cfe5f5726c4372930df84b3a90c37970629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617942Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#843123}
-
Ben Joyce authored
Bug: None Change-Id: I39c221fd574b9d19fe0d9cbabf81769644823e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627142Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#843122}
-
Mitsuru Oshima authored
Bug: 1155308 Change-Id: I6dc2ef187ccd5ab06b6b9b27b9d6ee2880ca8489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617203Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#843121}
-
Benoit Lize authored
Switch to PartitionAlloc for malloc() on Android. According to dev experiments, this is either neutral or a win for memory, performance and stability, with the exception of median GPU process footprint, which regresses by a small amount, but is being addressed. Note to sheriffs: If something breaks in this range on Android, this CL is a likely culprit. Note to perf sheriffs: This is expected to move a lot of performance metrics, in both directions. For details, see linked bugs, and for performance data from experiments, https://docs.google.com/document/d/1asZy8Dy0m97AECTTU2jTbgwc-mwI9BLOMVYKKiQAp04/edit (Google internal). Bug: 1121427, 998048 Change-Id: Ice8d5c65e814a3086d121f8e8641f874d6b9e68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625869 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#843120}
-
Josh Nohle authored
We make a few simple changes to help diagnose the crash occurring in https://crbug.com/1162157: 1) Reset the URL loader and stream parser before invoking the callback to ensure we stop streaming before any callback side effects occur. 2) Add a CHECK to OnDataReceived() to ensure the stream parser is not null. Will change to DCHECK when the crash is resolved. 3) In the stream parser, use the native StringPiece methods to get the underlying data and string length. 4) Add additional VERBOSE logging to ReceiveMessageExpress. I'm skeptical that these changes will fix the crash, but they will help eliminate some possibilities. Bug: 1162157 Change-Id: Ic1eef5c4bf0d047c66420aad29cbd3d93992ba05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627564 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#843119}
-
Oleg Davydov authored
Back in https://crrev.com/c/2485936 a new flag in ExtensionSettings policy was added. Since name of the flag was changed during the discussions, unfortunately, in parsing code and in policy scheme it landed with different names (override_update_url vs update_url_enforced). This CL fixes this. Bug: b:177419604 BYPASS_POLICY_COMPATIBILITY_CHECK=update_url_enforced is the wrong name for the flag and wasn't used anywhere Change-Id: I3df2247f0a75d8737425dba1d4ceb88763326693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627319 Auto-Submit: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#843118}
-
Caroline Rising authored
This metrics is being adding to show trends in user behavior when accessing the reading list. We want to find out whether the user is on the NTP (where the bookmarks bar is always visible) and the status of the bookmarks bar pref (shown/hidden) when a user accesses the reading list. Bug: 1163938 Change-Id: Ie846717e1dca5b217f234d35ef74213623ccf665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622990 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843117}
-
Andreas Haas authored
A new tracing category was introduced in https://crrev.com/c/2595436. Bug: chromium:1084929 Change-Id: I9327c3375dfd65727f6d5a81bf1efcf51eda90cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627398Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#843116}
-
Dominique Fauteux-Chapleau authored
A small change in ConnectorsService is required to make this test config work. When checking analysis/reporting settings, 2 things are required to obtain settings: a policy set to a valid value and a DM token (from the browser or the profile). The previous implementation checked the DM token first, meaning the blocking BrowserDMTokenStorage::RetrieveDMToken call would trigger on multiple tests and crash them (see patchset 1 failures for examples of this). The solution is to simply switch the order of checks and read the policy first. This is also a valid optimization of Connectors logic, as reading prefs is faster than potentially reading the DM token from local storage. Change-Id: Ie1026b57cf7a4fd66663530ec2a77a72f21d6d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623812 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Marc-André Decoste <mad@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#843115}
-
Nicolas Ouellet-Payeur authored
Previously, when DestroyProfileOnBrowserClose was enabled, the last-used profile could get deleted. This would leave Chrome in a state where no profiles were loaded at all, but the Chrome process is still alive. Some codepaths assume that GetLastUsedProfile() returns a loaded Profile. This patch makes AppController hold a ScopedProfileKeepAlive when there's only 1 Profile loaded. This prevents that Profile's deletion, so GetLastUsedProfile() works as expected. Bug: 88586 Change-Id: I128933003cd708500457ddf8d55b8dfecbcab29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593749 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#843114}
-
Jamie Madill authored
Was missed on a prior expectations update. Bug: angleproject:5499 Change-Id: I7dbfc0061daf03ca149345f00b620a35095c9d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625992 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843113}
-
Mila Green authored
Bug: 1144151 Change-Id: Ie836759be36fc86e9a3b15b2ee2b6c086bc2f890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625227Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843112}
-
yiyix authored
We are still getting useful data from these. Pushing the deadline of Canvas.TextMetrics.SetFont and OffscreenCanvas.TextMetrics.SetFont by another year. Bug: 1165020, 1160818 Change-Id: Ifa9124c3ceb383d5b15064c2eb8cb42443982339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622098Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#843111}
-
Robbie Gibson authored
There are actually two issues fixed by this CL. The first is the tab strip reappearing after backgrounding/switching dark mode. This happens because the BVC currently just sets the hidden status when revealing the thumb strip and when the trait collection changes, so unhiding on trait collection change overrides the hiding from revealing the thumb strip. This is fixed by tracking these two separately in the tab strip controller and using both to determine the overall hidden state. Second is the thumb strip breaking on backgrounding. This happens because I slightly misunderstood the UIGestureRecognizerDelegate. -gestureRecognizerShouldBegin: doesn't necessarily mean WILL begin, so the |currentRecognizer| should only be set once the pan gesture actually begins. Fixed: 1166020, 1165984 Change-Id: I177231f8be13fbc372358b2648a5a0d0a15d7f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626390Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#843110}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41a30fd36cbe..d8d98e1b9627 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mpearson@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1165897 Tbr: mpearson@google.com,fdoray@google.com Change-Id: Ia76c499bd1f4c780cf7d723045defe0f86dcdb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627621Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843109}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..59abfbcd2b03 2021-01-13 lalitm@google.com Merge "tp: don't propogate constraints on tables with left/outer span join" 2021-01-13 hjd@google.com Merge "ui: Limit bug filing links to 8kb" 2021-01-13 fmayer@google.com Merge "Dynamically decrease sampling rate when buffer fills." 2021-01-13 treehugger-gerrit@google.com Merge "tp: strip on all Android targets" 2021-01-13 treehugger-gerrit@google.com Merge "tp: remove unnecessary stripping script" 2021-01-13 treehugger-gerrit@google.com Merge "traced: add statsd instrumentation" 2021-01-13 fmayer@google.com Merge "Make names of malloc hooks / preload more descriptive." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie746ac95cc14ba1c1123fac03a40a59dfec3bf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627617Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843108}
-
Leo Lai authored
This would help developers understand how costly the TPM ownership process is in real life. For the corresponding ChromeOS change, see CL:2619438. BUG=b:176463814 TEST=build ok. Change-Id: I1bde763f3d776c16abc86ab4ddb4d340f37c3159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619359Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#843107}
-
Andrey Kosyakov authored
Bug: 1154370 Change-Id: Idba34c7fdf87f561747fc9ca7d37656aaffe2886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626125 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#843106}
-
Marc Treib authored
Credit cards can now be saved to the account for all signed-in users (no Sync required), so promoing Sync after a credit card save doesn't make sense anymore. This CL deletes the code for that promo. Bug: 1139330 Change-Id: Ie2512fd8239a9ee05682c29a4ddaba1717220061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618338 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#843105}
-
Eric Lawrence authored
https://crrev.com/573558 accidentally reversed the polarity of a test such that loading of an XML document by the XSLT processor would stop if a chunk parsed successfully instead of stopping if the chunk failed to parse. This CL corrects the break condition. Bug: 1165774 Change-Id: Ic37c7f9939e1357bf816810f23169603c43cdd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625089 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#843104}
-
Andrew Xu authored
In this CL, when the mouse click on the main button or the delete button is canceled, the menu selection is refreshed by: (1) Select the menu item hovered by mouse if any; otherwise, (2) Select the root menu item to cancel the selection on a child item. Bug: 1165999 Change-Id: I86bebc2b1dc08665a98da366a6a6bdb9fab532d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625798Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843103}
-
Henrique Ferreiro authored
Bug: 1101837 Change-Id: I21f981c1b5c154ca68d3e310653a9485d7e903ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617847 Commit-Queue: James Cook <jamescook@chromium.org> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#843102}
-
Nico Weber authored
With use_thin_lto, needs_stack_alignment is false, so `defines` wasn't, uh, defined when adding PREFIX to it. Bug: none Change-Id: I08ddd80386fce17bfd5b135b6a075d7f3bd0cf12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626774 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#843101}
-
Shimi Zhang authored
The previous fix http://crrev/c/2562059 isn't very correct: 1) It introduced menu flickering because the icons could be set after the menu is already showing. 2) Even after a pre-warming, the second #loadDrawableAsync() call could still be slow, so the icons doesn't show sometimes. 3) An internal Android framework change made the situation worse that sometimes the menu item won't send the intent. Because the menu item can change its icon from null to an actual drawable, but the framework code made the assumption that the menu item won't change. This fix moves the icon loading work to the same background task for the smart text classification task, after we get the classification result. In this way we could have a deterministic icon loading result while not violating the strict mode rule. Fixed: 1129211 Change-Id: I7c35d8221bf57bd8ed68295f797d5bd6871dbae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626461Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#843100}
-
Joe Mason authored
This will call WebMeasureMemory randomly after a page load, and discard the results, to check for crashes. It is controlled by an experiment feature ("StressTestWebMeasureMemory") that will only be enabled for some Canary users. Also removes some unused headers from performance_manager_lifetime.cc. Bug: 1085129 Change-Id: I32f24d4bf35032dea26b672a4fa899c5bf182cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627360Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#843099}
-
Yann Dago authored
Bug: 1081222 Change-Id: Ifc710417bd6a26b72de1168f06820fab1df7d127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612951 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843098}
-
Bret Sepulveda authored
RequestType is a new enum in the permissions package that is not burdened by UMA backwards-compatibility like PermissionRequestType is. PermissionRequestType is renamed to RequestTypeForUma and is now only used inside permission_uma_util.h/cc (and related tests). RequestType also replaces most usages of ContentSettingsType within the permission package. Prompt icons are now fetched statically via the RequestType. RequestType will eventually also represent combined requests (for example, camera and microphone together) but this will be done in a future patch. Bug: 1110905 Change-Id: I8a1141488a5b500e796d8baa1fde02a93b8b4169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569656 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843097}
-
Seokho Song authored
When the children appended, the height of <select> popup must be changed. Therefore, Add a condition for calling the function. Bug: 753001 Change-Id: If20fae2d1d578839ef3b6d6405c8400198968464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603763Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Seokho Song <0xdevssh@gmail.com> Cr-Commit-Position: refs/heads/master@{#843096}
-
Dominique Fauteux-Chapleau authored
This CL adds code to read the DM token from ConnectorsService instead of policy::GetDMToken so that the correct token (profile vs browser) can be obtained depending on the value of the scope pref. Bug: 1163992 Change-Id: I772199d08bb5e5a99c582453106fe2ec0365f1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615779Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843095}
-
Nicolás Peña Moreno authored
Change-Id: Ia362147eee429f4000db067914e755dadc6b014a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627687Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#843094}
-
Ben Pastene authored
All of chrome's mb_configs should have been swapped over to using 'builder_groups'. V8's and WebRTC's copies of mb.py still have references to 'masters': https://chromium.googlesource.com/v8/v8/+/master/tools/mb/mb.py https://webrtc.googlesource.com/src/+/master/tools_webrtc/mb/mb.py So updating those are left as a follow-up for the relevant project owners. Bug: 1117773 Change-Id: Ic58469c050cac77d834c63f4a2b6478c377d9411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622751Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#843093}
-
Regan Hsu authored
Prior to this CL, a scan for instant tethering networks is performed every time the PHoneHub UI bubble opens. Now, a scan for tether networks only occurs the first time the user opens PhoneHub when its enabled during their session. Fixed: 1164517 Bug: 1106937 Change-Id: I281fb88bafdc375391e0596052b327657ee71c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621982 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#843092}
-
Gauthier Ambard authored
This CL change the behaviour when editing a the omnibox to not stop the load of the page when typing in the omnibox. Bug: 818649, 1159147 Change-Id: If4e71aee5a8ad5367122058630a54039399d7040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627490 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#843091}
-
Peng Huang authored
We would like to only include ANGLE library in Android canary build. Archive this by use use_static_angle when chrome version is 90. I will land it on the 89 branch date. Bug: 1161513 Change-Id: I445a2b5a38cbfc585f277ac538031d8c0c2fa611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613150 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843090}
-
Andrey Kosyakov authored
This reverts commit 13fc65a6. Reason for revert: broke build (https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/105660) due to a mid-air collision with https://chromium-review.googlesource.com/c/chromium/src/+/2589206 Original change's description: > Origin-keyed agent clusters: rename in Blink and plumbing > > 942aca88 performed the minimal updates > to the implementation to shift from "origin isolation" to "origin-keyed > agent clusters" for the web-observable API surface. This followup also > renames much of our internal implementation references to the concept. > > Specifically, it takes care of all the Blink-side infrastructure > supporting the window.originAgentCluster getter, as well as > document.domain restrictions. This includes all the navigation-params > plumbing to get the value from the browser process into the renderer > process. > > This does not yet tackle any renaming for code that is entirely within > the browser process. > > The only observable effect of this is changing the console warning > message for document.domain to mention "origin-keyed" instead of > "origin-isolated". > > Bug: 1158853 > Change-Id: I8feb507eee17db53e58b70e4ee5820c555ba962f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617583 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843082} TBR=creis@chromium.org,kinuko@chromium.org,domenic@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ic0bc0bbcf6ba4b8f3c920a34356e3cb8cfca823e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625916Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#843089}
-
Wenyu Fu authored
This reverts commit 55f04b52. Reason for revert:
🤠 Seems this CL is causing compiling error here, looking to revert. Details: https://ci.chromium.org/ui/p/chromium/builders/ci/Cast%20Audio%20Linux/95820/overview Original change's description: > Copy attributes of old DocumentLoader on javascript: URL & XSLT commits > > When javascript: URL evaluates into a string, or XSLT document change > happens, we will commit a new document but won't notify the browser of > the change of documents, as no URL/origin change happens, essentially > treating it as just a content update within the previously committed > document. > > However, we actually create a new DocumentLoader and Document for the > commit, and not all attributes of the old document are actually carried > over to the new document. This CL copies most attributes from the > previous document through DocumentLoader::CreateParamsToClone(), to > ensure future navigations within the new document won't result in > confusion in the browser. Some examples of things that are now copied to > the new document: HistoryItem, http_method, http_status_code, > devtools_navigation_token (so XSLT document transformations show up > on devtools), etc. > > Bug: 1151954, 1048106 > Change-Id: Iefd620c7c3896f2f1ae2fdcc60404361363124eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589206 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843047} TBR=dcheng@chromium.org,creis@chromium.org,japhet@chromium.org,rakina@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Id3ca501b35c039300d8b3155fd09709a26dc425b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1151954 Bug: 1048106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626099Reviewed-by:Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843088}
-
Rushan Suleymanov authored
The interested data type list will be sent on each change. Before this CL, if sending of interested data types was just enabled, then the new field containing the list wouldn't have been sent to the server after the next browser startup. Bug: 1155030 Change-Id: I50ffb01b8592432128f3929abd554d874023d47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598908 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843087}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6cbcce5b..5f223d7f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6c2ca51b7361135ba190163d6db4c73e1aa2c42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627139Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843086}
-