GitLab

Many *-dbg packages are being replaced with *-dbgsym ones.  This CL begins using
those packages when they are available, instead of just skipping the package.

BUG=785818
R=dpranke@chromium.org

Change-Id: If2d3ea398353628caec77b202a1526451d628931
Reviewed-on: https://chromium-review.googlesource.com/792608Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519560}

 - Show the IPH bubble for at least 10 seconds or until the bottom sheet
   is opened or tab switcher is entered
 - Record more IPH events for sheet opened from swipe, sheet opened from
   button, and pull-to-refresh
 - Add a new IPH feature that uses pull-to-refresh as a trigger

BUG=787030

Change-Id: I864029dc5b8d737f26d088613a515e88d78a320d
Reviewed-on: https://chromium-review.googlesource.com/779944
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519559}

TBR=amineer@chromium.org

Change-Id: I59232b67fab1ac0ef1cd3a2851df5dfd093b37d7
Reviewed-on: https://chromium-review.googlesource.com/792277Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519558}

Add a new metric for recording whether or not the detachable
base is connected on boot:

  Platform.DetachableBase.AttachedOnBoot

(Metric implemented in CL:725102.)

BUG=b:64195183
TEST=./validate_format.py && ./pretty_print.py

Change-Id: I2ead8f3d1e0e3c0d92a50247655baba7a8383177
Reviewed-on: https://chromium-review.googlesource.com/780640
Commit-Queue: Joel Kitching <kitching@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519557}

files out of chrome namespace.

From discussion on chromium-dev, it was decided to remove 'chrome'
namespace.

TBR=tbansal@chromium.org,asvitkine@chromium.org,mmenke@chromium.org

Bug: 289619
Change-Id: I6f2bc674a8bd42c15910e1c5d025eb9559835d4f
Reviewed-on: https://chromium-review.googlesource.com/787492Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#519556}

SetParent was called by mistake for popups. That only makes
sense for top level shell surfaces. This removes the incorrect
SetParent call so that SetContainer works as expected and
switches the container type to 'menu'. Menu container behavior
matches the expected XDG client behavior much better.

The result of this change is that popups are no longer placed
below the shelf.

Bug: 788782
Test: weston-terminal
Change-Id: If2b1fc54f23ffc517c767d9f52511d20a34d6b19
Reviewed-on: https://chromium-review.googlesource.com/792274
Commit-Queue: David Reveman <reveman@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519555}

For each XxxInstance interfaces that have Init(),
- Deprecate current Init() by renaming it to InitDeprecate(), and
- Introduce a new Init(), which has callback.

Unfortunately, whether the method has callback or not is
not versioned in Mojo. So, instead, deprecates old ones,
and adds new ones.

BUG=750563
TEST=Ran bots.

Change-Id: I48ea0a3b900ee998e01f3ea07e420cad610d07c8
Reviewed-on: https://chromium-review.googlesource.com/785434
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519554}

Bug: 782848
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I49f3bf6cf68a9d6d5771d5715d65c742bdbb03a3
Reviewed-on: https://chromium-review.googlesource.com/784235Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519553}

This patch moves the function to SelectionAdjuster.
The file local class ShadowBoundaryAdjuster is introduced to encapsul
helper functions.

Bug: 787295
Change-Id: Ic1b1be49b9aa6b4a29ff829b321cb6f1d4b270fd
Reviewed-on: https://chromium-review.googlesource.com/784757Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519552}

Rename to SetShouldInvalidateIfNeeded() using more
popular term "IfNeeded" than "IfNeeds":
https://cs.chromium.org/search/?q=ifneeded+file:%5Esrc/third_party/WebKit/+package:%5Echromium$&type=cs

Bug: 739062
Change-Id: I124a13d27659ff29a5e3c75c45348f64f8815063
Reviewed-on: https://chromium-review.googlesource.com/784744Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519551}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: I782d000d8a330fef0bef697d24611303dc63d059
Reviewed-on: https://chromium-review.googlesource.com/789717
Commit-Queue: Chris Watkins <watk@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519550}

I renamed the test directory to clarify the focus of these tests.

Bug: 667560
Change-Id: I62f9823820d2e058a76fff3a10547259dc1a7684
Reviewed-on: https://chromium-review.googlesource.com/792344Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519549}

Add TestBrowserDialog tests for PageInfoBubbleView to show all permissions
either allowed or blocked, regardless of their factory default setting. In
future, these tests can be used in automatic screenshot taking to track UI
changes, but currently it can be run with
--gtest_filter=BrowserDialogTest.Invoke --interactive
--dialog=PageInfoBubbleViewBrowserTest.InvokeDialog_AllowAllPermissions (or
BlockAllPermissions).

Bug: 654151
Change-Id: I06aaf4f39f0d660acbd1024198692b35cacef8cb
Reviewed-on: https://chromium-review.googlesource.com/788638
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519548}

The number of callers is not many. Let's pass task runners explicitly
for code health.

This CL is a preparation to replace base::ThreadTaskRunnerHandle::Get
with more appropriate task runners.

Bug: 780785
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I998fb338228069f6c164b13144319c0810b1de2c
Reviewed-on: https://chromium-review.googlesource.com/784910Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519547}

Link was outdated since documentation got polished
in kernel's review https://goo.gl/2eWpB2 .

Bug: 
Change-Id: I329ff0984bcd707c76daea6bffb209a49896d76c
Reviewed-on: https://chromium-review.googlesource.com/791453
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519546}

R=calamity@chromium.org
Bug:

Change-Id: I3bf272b61ce8661d6f0af58a57908569e37e0a53
Reviewed-on: https://chromium-review.googlesource.com/789075
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519545}

This reverts commit 63b59877.

Reason for revert: Mistakenly thought that cursor provider would be updated if necessary in https://cs.chromium.org/chromium/src/services/ui/ws/event_dispatcher.cc?type=cs&l=754 when called from WindowNoLongerValidTarget. But we only update mouse_cursor_source_window and not cursor provider because it was not the capture_window.

Original change's description:
> Don't call to update native cursor from WS when removing a window.
> 
> When we remove a window, e.g. opening the network settings page, which
> is going to remove the status tray bubble window, we changes the
> window hierarchy and updates cursor provider for the old parent [1],
> which finds the target based on the last mouse location. Viz hasn't been
> notified of this change yet and the status tray bubble window is still
> in the window mappings in mus-ws (until destroyed), so we still finds
> this status tray bubble window as target with --use-viz-hit-test. Then
> when we adjust this target for modal window, we fail to find its root
> window [2].
> 
> [1] https://cs.chromium.org/chromium/src/services/ui/ws/window_server.cc?gsn=GetRootForDrawn&l=920
> [2] https://cs.chromium.org/chromium/src/services/ui/ws/event_dispatcher.cc?type=cs&l=362
> 
> This CL checks if we are actually removing a window before we call to
> update native cursor in WS; the logic for moving a window from one
> display to another remains unchanged. When we remove a window,
> EventDispatcher::WindowNoLongerValidTarget is going update cursor if
> necessary, so there's no need to call to update cursor in
> WindowServer::OnWindowHierarchyChanged and do the work twice.
> 
> Bug: 788185
> Change-Id: I48a7bfa4e981ae1b768768b0f011e53d6b968451
> Reviewed-on: https://chromium-review.googlesource.com/788230
> Commit-Queue: Ria Jiang <riajiang@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519162}

TBR=sadrul@chromium.org,riajiang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 788185
Change-Id: Ib1c2b4366eda94ccbf8f4d0ff22cf9012a27803b
Reviewed-on: https://chromium-review.googlesource.com/792150Reviewed-by: Ria Jiang <riajiang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519544}

See the bugs and cxx post for justification and details:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8

This change was done using clang-tidy as described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

In some cases the the tool leaves behind a string of commas where it
replaced a member initializer list
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957

Change-Id: I3805211c70d2c2340afa4d6d956339d1b25751fc
Reviewed-on: https://chromium-review.googlesource.com/789728Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519543}

Ozone/X11 does not support use cases that rely on aura's
ET_MOUSE_EXITED event. This is because X's LeaveNotify events
are being translated to ET_MOUSE_MOVED, instead.

This differs, for instance, from stock chrome/x11, where the
translation happens in ui::EventTypeFromXEvent
(ui/events/x/events_x_utils.cc).

CL aligns both chrome/x11 and ozone/x11 behaviors, by changing
::TranslateXEventToEvent to call ::EventTypeFromXEvent.
As a result EnterNotify keeps being translated to ET_MOUSE_MOVED
(no change here and it matches chrome/x11), but LeaveNotify starts
to get translated to ET_MOUSE_EXITED.

This allows ozone/x11 chrome (external window mode) to hide tooltips
whenever cursor leaves a chrome window bound
(see TooltipController::OnMouseEvent).

BUG=666958

Change-Id: I8e134450d6014a8c8032c738f22ebf3d81d5e98f
Reviewed-on: https://chromium-review.googlesource.com/790611
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519542}

When using distributed cross compilation build tools, clang plugin
compiled for Linux can get a file to check which was preprocessed on
Windows. This file can contain backslashes as file path separators.
This results in the chromium-style checks failing on code that has been
explicitly banned from style checks.

Change-Id: Iae042ab7ae79098096c7383b91418367b256301e
Reviewed-on: https://chromium-review.googlesource.com/787090Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Kalugin Alexander <akalugin@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#519541}

BUG=787223
R=dpranke@chromium.org
TBR=jam@chromium.org

Change-Id: I53e3069033a0ff41525ca80fa60504b3fc3c3c14
Reviewed-on: https://chromium-review.googlesource.com/784351
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519540}

This CL is a minor change to the margins for the extension icon in the
details view.

Bug: 787225
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4bb41c4d3ea9a72314e16ad35e9576ad3a57d47c
Reviewed-on: https://chromium-review.googlesource.com/792331Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519539}

This is a reland of 935a591a.

Original change's description:

>Remove WTFLogAlways in blink

>As a step not to use utilities in Assertions.h, this CL removes both WTFLogAlways() and its all
>of uses in the blink. Additionally vprintf_stderr_with_trailing_newline() is also removed because
>it has been only using by WTFLogAlways().

Bug: 638849
Change-Id: I7120ca5b70a115bb1c45db57f077254eef57b140
Reviewed-on: https://chromium-review.googlesource.com/792550
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519538}

This logic was only used for testing purposes before we had
a proper XDG shell implementation. wl_shell_surface is still
supported and used by simple test clients. However, this
transient logic is not well tested and preferably removed.

Bug: None
Test: wayland_client_perftests
Change-Id: Iee6db6d4458339ea827ccf0eb933ccad4a34a7e0
Reviewed-on: https://chromium-review.googlesource.com/792432Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519537}

These binaries allow us to run QEMU on ARM; the current deployment
in the Fuchsia SDK folder is x86-64 only.

The "qemu" folder can safely be removed from the Fuchsia SDK
once this CL lands and the trybots are confirmed to still be in
working order.

Also modify the runner script to use arch-specific QEMU binaries.


Bug: 786193
Change-Id: I1515bdf330f496ff47f88ba3b131629d4e24fea3
Reviewed-on: https://chromium-review.googlesource.com/783699
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519536}

As per UI review request, adjust the style of history ClearBrowsingBar:
1. Horizontal margin: 16pt
2. Vertical margin: 8pt
3. Spacing between button: 8pt
4. Font size: (same as bookmark cell)
5. Font color
6. Shadow opacity and radius
7. Button text wraps across multi-lines when needed (and bar height will
   grow when text wrapped.)

Screenshot:
https://drive.google.com/file/d/1rRj-1fKsjRk8n0rG6C-XB2mXoyPooMC6

Bug: 788601
Change-Id: I9a0fbe68122e01301665a48ed77086be96d7de65
Reviewed-on: https://chromium-review.googlesource.com/790013
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519535}

https://skia.googlesource.com/skia.git/+log/dfaa057c1518..c9c97b7fd5f9

$ git log dfaa057c1..c9c97b7fd --date=short --no-merges --format='%ad %ae %s'
2017-11-27 csmartdalton CCPR: Transform path points before parsing
2017-11-27 mtklein remove SkDebugCanvas clip query overrides
2017-11-27 csmartdalton Cleanup yes/no enums in Ganesh
2017-11-27 mtklein update SkJumper docs to Clang 5
2017-11-27 bsalomon Batch ops together in SkAtasTextTarget
2017-11-27 mtklein clean up SkDeferredCanvas
2017-11-27 csmartdalton Include opList ids in GrOnFlushCallbackObject::postFlush
2017-11-27 egdaniel Fix caps for advanced blend extension with regards to layout qualifiers
2017-11-27 robertphillips Revert "Make sure to visit clips and dst proxies during gather"
2017-11-27 mtklein roll GN
2017-11-21 csmartdalton Make sure to visit clips and dst proxies during gather
2017-11-27 ethannicholas added SkSL support for all blend mode layouts
2017-11-27 angle-deps-roller Roll skia/third_party/externals/angle2/ 994ee3f23..ebee5b3b7 (2 commits)
2017-11-27 mtklein Handle null colorspace in SkToSRGBColorFilter.
2017-11-27 liyuqian Add forceDAA parameter to AntiFillPath
2017-11-17 robertphillips Add Fiddle DrawOptions for the backend objects
2017-11-20 csmartdalton Delete an opList's clips when it survives a flush
2017-11-27 bsalomon Make EGL test context access GL via GrGLInterface
2017-11-27 caryclark bookmaker refresh
2017-11-27 reed saturate when converting float to fixed

Created with:
  roll-dep src/third_party/skia
BUG=787718


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: Ibfc18a318dfc01efeb3baefcd41127fc139fbbe6
Reviewed-on: https://chromium-review.googlesource.com/791996Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519534}

There are many places where WTF_MAKE_NONCOPYABLE is transitively defined. This
CL starts replacing these uses with DISALLOW_COPY_AND_ASSIGN and includes
base/macros.h as required.

Where required the declaration of DISALLOW_COPY_AND_ASSIGN is moved to
the end of the class definition.

Also, take the opportunity to use "= default" rather than {} for
ctors and dtors, in line with recent discussions on chromium-cxx@.

There are no logic changes in this CL.

Bug: 565932
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idc53c473b134277cc2a079704648f99b3f9d47f1
Reviewed-on: https://chromium-review.googlesource.com/791870Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519533}

 Test: manually click (with ChromeVox using Search+Space) ARC++ notification; verify app opens.
Bug: 786981

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6809ff0371e5315e0fe6aaf01e9c567215c77fc4
Reviewed-on: https://chromium-review.googlesource.com/783669
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519532}

base::debug::Alias can only reliably trick the compiler into retaining
the values of local variables, not class member variables. Therefore it
is important to copy class member variables to locals before aliasing
them.

Bug: 756589
Change-Id: I5c67f386c2a6ad192af74fd9aefbc9103b355774
Reviewed-on: https://chromium-review.googlesource.com/792297Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519531}

This requires exposing a previously-local-to-the-file function as protected, but
this seems like an OK tradeoff.

In the process, also rejiggered a few things (e.g. eliminated a file-scope using
directive).

BUG=none
TEST=none

Change-Id: I5fafda5ce264370cbe6d67e39f24c58fef7543ee
Reviewed-on: https://chromium-review.googlesource.com/792123
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519530}

Add a method to ContentBrowserClient. Note this controls gpu process
"launch" for in-process GPU as well. The method still allows using an
existing GPU process, so in-process case should be minimally impacted so
probably not worth carving out special conditions for it.

For now, only call this new API from BrowserGpuChannelHostFactory, which
controls GPU clients in the browser process. Clients in child process is
more risky, so holding going to do that part in a follow up CL instead.

ChromeContentBrowserClient on android implements the API by checking if
there are running or paused activities. Paused activity may still be
visible, so allow it to launch GPU in that case.

Bug: 779211
Change-Id: Ic48acc9f9ab6134371d7f193d9031e912a05d947
Reviewed-on: https://chromium-review.googlesource.com/783495Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519529}

https://chromium.googlesource.com/catapult.git/+log/a1422259024f..884db2336247

$ git log a14222590..884db2336 --date=short --no-merges --format='%ad %ae %s'
2017-11-27 bokan Re-reland "Test that gestures scroll the correct distance"

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I9092c03768e4ec5b95f2d236e387052a2eca066d
Reviewed-on: https://chromium-review.googlesource.com/792008
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519528}

This makes sure nine-patch is updated when rounded corner radius
has changed and not only when elevation has changed.

WMTestSuite has also been updated to allow tests that call into
skia and use discardable memory (needed for corner radius test).

Bug: 788461
Tbr: sadrul@chromium.org
Test: wm_unittests --gtest_fiter=ShadowTest.AdjustRoundedCornerRadius
Change-Id: I4489fbf11416559a3da8ac3b194f96c59ed5801c
Reviewed-on: https://chromium-review.googlesource.com/789730
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519527}

This CL adds a new ChromeBroadcastObserver method for the toolbar
height.  It also creates FullscreenUIState, an object that holds the
broadcast properties for toolbar UI.

Bug: 785625
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibebff64db6c33ec5e7e0ca6eb24a96973a533b36
Reviewed-on: https://chromium-review.googlesource.com/773443
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519526}

this is in preparation for the libwebp-0.6.1 update; include paths were
changed from '../...' to 'src/...'.

BUG=788275
NOPRESUBMIT=true (due to presubmit confusion about local DEPS)

Change-Id: I608f0271d9132aae9f9681d9514dd61c951ee044
Reviewed-on: https://chromium-review.googlesource.com/792251Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#519525}

Previously this was an enum declared in the TabStripModelObserver class. This
was incorrect layering since it was used by calls into the TabStripModel, which
shouldn't depend on that class' own observer definition.

With the experimental tab strip, the need for this enum to be at a more
fundamental layer becomes more obvious. This change adds the change type to the
experimental tab strip observer and uses it.

Bug: 778461
Change-Id: I12921deea21e264d7f7b883fd2c4c1557022eb61
Reviewed-on: https://chromium-review.googlesource.com/791990
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519524}

Fix ExoParts destruction order to ensure that WMHelper instance
is valid when exo::Display is destroyed.

Bug: 788731
Test: Running Chrome with DCHECKs no longer fails at shutdown.
Change-Id: I9bddecd863d92b600378488e04612cff87cef1ae
Reviewed-on: https://chromium-review.googlesource.com/792214
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519523}

In the few use cases that were using WebNonCopyable I followed the Google
C++ style guide, which explicitly states that to remove copy
operations "explicitly disable them using = delete in the public: section".
https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types

Most places were just including the header file without actually using
the type.

This CL contains no logic changes.

Bug: 788846
Change-Id: I991e4b9b548f67a41d79882723525a97f3625432
Reviewed-on: https://chromium-review.googlesource.com/792190Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519522}

Response's MIME type can change during the download and DownloadTask
should support the change. This will allow to report
DOWNLOAD_PASS_KIT_WRONG_MIME_TYPE_FAILURE metric for PassKit downloads.

Bug: 787943
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I137f9aa4ff966c140a9a6cb5b03dc026062bc0b7
Reviewed-on: https://chromium-review.googlesource.com/786265Reviewed-by: Gregory Chatzinoff <gchatz@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519521}