- 21 Jun, 2019 40 commits
-
-
Henry Jian authored
Previously, we have ShortcutSource.WEBAPK_SHARE_TARGET to show chrome is launched as a result of user sharing text. As we introduce the ability for WebAPK to receive file sharing, we add ShortcutSource.WEBAPK_SHARE_TARGET_FILE to show that chrome is launched as a result of binary file sharing. Change-Id: Id21d055baad3e5ff1ddb55309d1e6b278f144117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668089 Commit-Queue: Henry Jian <hzjian@google.com> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#671346}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/569931dc3a36..6dc0eea4cbfd git log 569931dc3a36..6dc0eea4cbfd --date=short --no-merges --format='%ad %ae %s' 2019-06-21 perezju@chromium.org Revert "[Telemetry] Make benchmark metadata in CreateResults optional" 2019-06-21 perezju@chromium.org [Telemetry] Make benchmark metadata in CreateResults optional Created with: gclient setdep -r src/third_party/catapult@6dc0eea4cbfd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973837,chromium:973837 TBR=sadrul@google.com Change-Id: I9ee4078388f40a3032c9e4957f4142b8226fc925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671345}
-
Mihai Sardarescu authored
Bug 976143 shows a case when the token database could not be opened. My suspicion is that another process had a handle on this file and that forbids Chrome for using it. However debugging it was fairly complex. This CL separates this state to make debugging easier. Bug: 976143 Change-Id: I2106201c3ae17299a3ce3d2e4675bb90bab1f062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670223Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#671344}
-
Mohammad Refaat authored
viewForPrinting provide the wk weview directly. Instead use the built in UIView print methods to provide a printformatter that only print the webview inside the contained view. and given that we can use WebState->GetView() to print directly (as it returns a container view). Bug: 977393, 960950 Change-Id: I1257d7ccbcd8dcd7cd07590bcd59dc36c154d555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670066 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#671343}
-
Joshua Bell authored
A fast-path for Array to sequence<> conversion assumed that the length would remain constant. This failed some WPTs that mutate the array during conversion itself (via toString() overrides. Modify the fast-path to observe length changes, and add tests. Bug: 977305 Change-Id: I1206c9475813868f5e26c690ea3a1d210bbeb7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670055Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#671342}
-
Sophie Chang authored
Change-Id: Ie365d148c8a872464f833826b601c2faa294c7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670049Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671341}
-
Xiyuan Xia authored
- Make ash::TabletMode a concrete class that holds a bool of whether tablet mode is enabled and notifies observers when its changed; - Make ash::TabletModeController an ash::TabletMode::Delegate to provide real state and test support; - Move tablet mode observing part from TabletModeClient into ash::TabletMode. This leaves TabletModeClient only to track and enable mobile behavior for tabs. Bug: 974238 Change-Id: Ifda13f72a5016d62439bf96087a5fae3be9df50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665553 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#671340}
-
Sergio Villar Senin authored
IdlenessDetector was not using the mock clock coming from TestMockTimeTaskRunner in some tests. That can be really problematic sometimes (like when the monotonic clock has a really high value as a result of not rebooting a machine for quite a while for example), as it might consistently schedule timers forever, making calls like TestMockTimeTaskRunner::FastForwardUntilNoTasksRemain() to go on indefinitely. Instead of fixing the specific tests that were failing we're modifying DummyPageHolder so it creates the IdlenessDetector with the passed in clock. IdlenessDetector does no longer need a statically set clock. All the failing test cases were either creating the DummyPageHolder directly or indirectly as descendents of PageTestBase. In the particular case of PageTestBase tests, they will automatically get the mock clock set whenever EnablePlatform() is called. The API contract of EnablePlatform() had to be slightly changed and from now on it must be always be called before SetUp(). For those tests not wanting to use the TestingPlatformSupportWithMockScheduler provided by PageTestBase a new virtual method GetTickClock() was added so they can still hook up and provide their own mock clock. Bug: 976539 Change-Id: Id0af3424a60787a642023963de8698314e87bad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667311Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#671339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/82774f8bad1c..c7a773b6fa9a git log 82774f8bad1c..c7a773b6fa9a --date=short --no-merges --format='%ad %ae %s' 2019-06-21 fmalita@chromium.org Add SkShaderMaskFilter.h to public header list 2019-06-21 brianosman@google.com ByteCode: Better signature for innerRun, avoid memory stomping 2019-06-21 herb@google.com Simplify intercepts 2019-06-21 fmalita@chromium.org [skottie] Radial swipe effect 2019-06-21 brianosman@google.com ByteCode: Support out params in local function calls Created with: gclient setdep -r src/third_party/skia@c7a773b6fa9a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I55915bc33a119d3dccab4db3fcbc9db9a3a6cb0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670686Reviewed-by:
-
Robert Ogden authored
Bug: 971918 Change-Id: Ibee761de7be924f01024a5e155ef539d62041ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667742 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#671337}
-
Alex Ilin authored
CHROME_ID_CONSISTENCY_STATE cookie is going to be affected by the planned "Remove third party cookies" privacy feature. Setting SameSite=LAX for CHROME_ID_CONSISTENCY_STATE cookie will allow to avoid the removal of this cookie. Bug: 965509 Change-Id: Iff641cd37b7f2ca6ebe08caa3b8ec679fec20881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665932Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#671336}
-
Xiaocheng Hu authored
CSSCalcExpressionNodeParser's member functions use boolean return type to indicate whether parsing is successful, together with a output parameter as the parsed result. This is unnecessary as the result is always null when parsing fails and vice versa. So this patch simplifies the return type to a raw pointer to directly indicate whether parsing is successful or not. Change-Id: Iee69dc98c761d007407e9a229ea22c4c6f933a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669953Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#671335}
-
Nicholas Hollingum authored
It is possible to force a UAF in the remote shell by pinning the surface and then deleting it (without unpinning). Eventually ash will try to keep the window on top which involves using the deleted surface. This cl fixes that by unpinning the surface on deletion. Bug: b:135707944 Change-Id: I4cac53620384958dcee1f36366a500357d97c380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670172 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#671334}
-
Umesh Patil authored
Bug: b/135708243 Change-Id: Ib2052ffb994d39b86b7197592f7bd3b9fc78cd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670351Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Umesh Patil <upatil@google.com> Cr-Commit-Position: refs/heads/master@{#671333}
-
Eugene But authored
DownloadManagerCoordinator owns UnopenedDownloadsTracker, which in its turn observes DownloadTask objects. UnopenedDownloadsTracker used to remove the observer only inside OnDownloadDestroyed callback. After one of BVCs refactorings Chrome changed the order of destruction, so now model gets destructed after UI (Coordinator gets destructed after DownloadTask). This introduced a crash because OnDownloadDestroyed was called on destructed UnopenedDownloadsTracker object. This CL extends UnopenedDownloadsTracker to track observed DownloadTask objects and remove observer in ~UnopenedDownloadsTracker. Bug: 940382 Change-Id: I18e991bda960bb748c0222fd4f84ce126a712d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668207 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#671332}
-
Natalie Chouinard authored
Migrate the Data Reduction preferences ("Lite mode") from the deprecated framework preferences to the support library. Bug: 968592 Change-Id: Ia5abf0115953ea7cbbb4cfcd32d5ade35594931c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669240Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
-
Julian Kung authored
Fixed a bug that occurred when the parent element of a content editable element returned null. R=johnchen@chromium.org Bug: chromedriver:2960 Change-Id: Ia4d3b144cfa4e41c7f34e3bd5b0267cb6e96eb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669793Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Julian Kung <juliankung@google.com> Cr-Commit-Position: refs/heads/master@{#671330}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I293ffc004cf68a1c7e431ae7d1411c19c42c6b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670661Reviewed-by:
-
Sergio Villar Senin authored
This is a reland of f40c21d5 TBR=dcheng@chromium.org,haraken@chromium.org,jbroman@chromium.org Original change's description: > Remove WTF wrappers of base::{Time|TimeDelta|TimeTicks} classes > > As part of the wtf/time.h removal effort, we're removing the WTF wrappers of > base::Time classes, i.e., WTF::Time, WTF::TimeDelta and WTF::TimeTicks. Most of > the replacements happened before, we're just removing the low hanging fruit and > the wrappers themselves. > > TBR=dcheng@chromium.org > > Bug: 919383 > Change-Id: I7e97aa452ad315ec2c4cd2cc8b26e56db6db05b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669362 > Commit-Queue: Sergio Villar <svillar@igalia.com> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671220} Bug: 919383 Change-Id: I49bbca9e30a766c278a632d331c943fe0fcf7731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670887Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#671328}
-
Harsh Patel authored
R.java source files and module root R.java files both contain all resource types in base. This allows for org.chromium.chrome.{feature} imports to access all base module resource types. Add new resource types to resource_utils.py ALL_RESOURCE_TYPES. Bug: 977311 Change-Id: I9bea15e4b8c9850a22a74f69fcb6596cf0c43c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670851 Commit-Queue: Harsh Patel <harshpa@google.com> Reviewed-by:Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#671327}
-
David Maunder authored
This is for consistency with how the data was previously recorded (root -> child chain). Currentlly we are recording Parent, Root. Storing Root then Parent will achieve consistency. Bug: 977437 Change-Id: Iead6f72c16d5cef031ffd875e089b180fd802be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670390Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#671326}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/53c4495a3366..9d275db4331a git log 53c4495a3366..9d275db4331a --date=short --no-merges --format='%ad %ae %s' 2019-06-21 syoussefi@chromium.org Vulkan: Add vkCmdFillBuffer support Created with: gclient setdep -r src/third_party/angle@9d275db4331a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: If4f9a0d1b6804270af604b8de8e3d9faf3516080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669075Reviewed-by:
-
Morten Stenshorne authored
SweepLegacyDescendants() finds every layout object not in placed_objects, and gets them laid out, assuming that they are inside legacy objects, since they were not in the list. However, for block fragmentation, an out-of-flow positioned object will only be a descendant candidate in the fragmentainer it occurs. So checking with LayoutBlock::PositionedObjects() for every fragmentainer won't be right. We'd end up with a replica fragment for one and the same out-of-flow positioned box in every fragmentainer (the new unit test would fail like that). Just skip SweepLegacyDescendants() if we're in a block fragmentation context. If we're in a block fragmentation context, we already know that there can't be any legacy objects, due to CL:1667344. The web test that starts to pass isn't very interesting, since it also contains spanners, which we haven't implemented yet. Bug: 829028 Change-Id: I3ec80ae50395ec31de4df7c99c881c5220ffd7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669933Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#671324}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a7edc1cd1d8f..c8f25d90ac2b git log a7edc1cd1d8f..c8f25d90ac2b --date=short --no-merges --format='%ad %ae %s' 2019-06-21 srisser@google.com Don't try to render out-of-bounds viewports Created with: gclient setdep -r src/third_party/swiftshader@c8f25d90ac2b The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I3931aebc0e2a737763c426d87e442550f43461eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670927Reviewed-by:
-
Xiyuan Xia authored
Bug: 977569 Change-Id: Ia72a35f48d3da8cb7d00898717877cb5de66ca49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669076 Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#671322}
-
Dave Tapuska authored
Rewrite some of the layout tests that require a data: URI (which is an opaque origin) to be accessed from a file URI inside the test framework. This was partially done in https://chromium-review.googlesource.com/c/chromium/src/+/1454163 where it removed the setting after it was re-initialized. The problem is that if the web preferences were never reinitialized (which is most of layout tests it would have this value enabled) There is no need for this security mechanism bypass for layout tests because the tests can either be implemented by loading another file URI, moving them into the http tests, or by postMessage from a data URI to the parent. The AllowUniversalAccessFromFileURLs was exposed in Android WebView API so it is likely impossible to remove it entirely but this decreases its usage. Change-Id: Ica229f7959d051ca068c14481cf6dad4efe2ac73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665197 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#671321}
-
Mohammad Refaat authored
This was added way-back in cl: https://chromereviews.googleplex.com/71817013/ The purpose of it was to stop all requests before deleting the request context. This is no longer needed. Bug: 977208, 960950 Change-Id: I66a128b05be990d7bb5b4a2c171121a25bd287cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669752Reviewed-by:
-
Andrew Grieve authored
This reverts commit a5749b7e. Reason for revert: Breaks "gn gen" for release Original change's description: > Android: Move add_unwind_tables_in_apk logic into chrome_public_apk_tmpl.gni > > Noticed the upstream and downstream logic had diverged. This should > allow deleting the downstream logic (since it's the same). > > This was also causing the binary size trybot to include assets/unwind_cfi in > size reports, which it shouldn't do. > > Bug: 977574 > Change-Id: I24ac52bf806455866081c1bf7bf0d6643ecda12b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670025 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671295} TBR=agrieve@chromium.org,tiborg@chromium.org Change-Id: I8a7e49cddc188a282ee5bcd7095eff6d0d13c192 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977574, 977584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669978Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#671319}
-
rnasri authored
The visual viewport size is needed when implementing some metrics, so add a trace event to record it. Bug: 972097 Change-Id: I3367bebcab39771859b067c7f7fe92e485b94b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649147Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Rasha Nasri <rnasri@google.com> Cr-Commit-Position: refs/heads/master@{#671318}
-
Sergey Ulanov authored
This change includes the following fixes in IPC code that works with Zircon handles: - Removed one of the two constructors in HandleAttachmentFuchsia. Unlike the other constructor it was not taking ownership of the and so it was error-prone. - There is only one case when VMO handles need to be duplicated in the IPC layer. Now that case is handled directly in ParamTraits<base::SharedMemoryHandle>::Write() instead of the removed HandleAttachementFuchsia constructor. - ParamTraits<base::SharedMemoryHandle>::Write() now correctly handles OwnershipPassesToIPC(). Previously those handles were leaked. - Fixed ParamTraits<zx::vmo>::Write() not to leak handles. - Removed ipc::HandleFuchsia class. It's no longer useful. Bug: 977435 Change-Id: Ibaa2df136a3753217cbb609fbcb1c76af55ce792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670568 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#671317}
-
Huanzhong Huang authored
Disabling the test due to flakiness. TBR=pkasting@chromium.org Bug: 977510 Change-Id: Ie4ba85b7f4e608c766f7e4c6307250630bbfc68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670869Reviewed-by:
Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#671316}
-
Vadym Doroshenko authored
Bug: 949519 Change-Id: Ibc23dca6f0b50f46a50601fa59a4779b71d72e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661674 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#671315}
-
Allen Robinson authored
Bug: 934451,970240 Change-Id: I170beb2d6e88d73548e32bd479b2f3b5d09d9d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669184 Auto-Submit: Allen Robinson <arobins@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#671314}
-
Marijn Kruisselbrink authored
This reverts commit 914838ac. Reason for revert: Seems to be causing null pointer dereferences Bug: 977525, 977528, 977579 Original change's description: > AppCache: Clean up and document AppCacheUpdateJob general flow. > > Change-Id: Ie6e8161b4b45472c728c63034dfadad086285414 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669638 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Auto-Submit: Victor Costan <pwnall@chromium.org> > Reviewed-by: Staphany Park <staphany@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671166} TBR=pwnall@chromium.org,staphany@chromium.org Change-Id: If095d10f7139e577792f480aaf9a8960f1b48818 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669083Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#671313}
-
Caitlin Fischer authored
Before: The availability of suggestions was not announced by ChromeVox when using the Tab key to navigate to a form field, e.g. first name. ChromeVox read "Name Edit text Form", and no suggestions were shown. After: ChromeVox now says "Name Edit text Form Press up or down arrow for auto completions". Upon pressing the up or down arrow keys, ChromeVox announces that the Autofill menu was opened. Bug:865101 Change-Id: I1c4f9f1b8bc28a747435e0e1e3d4d9c11c1b9905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666476 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#671312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8ec6e758bb3..3c7a4c0959ca Created with: gclient setdep -r src-internal@3c7a4c0959ca The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Iee1b17fb745c0a2bb276961371de47a8beed49f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670684Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671311}
-
Eric Robinson authored
This CL adds the subframe_origin member to NetworkIsolationKey, as well as adding a flag to enable it. When enabled, it is used by the NetworkIsolationKey, when disabled, it is unused and the field is always empty. Change-Id: I97a65eefaaa50c7e5931589db5e38cb2161104aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644895 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#671310}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/52056cb4..0ff9f9ea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6310e62929900946e3341f2f171aa8ba06fbbeba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670850Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671309}
-
danakj authored
The BrowserMainLoop::PreMainMessageLoopRun() method will call base::DisallowUnresponsiveTasks(), preventing 3 classes of tasks from being performed: - long cpu work - blocking - base sync primitives Previously we avoided this in browser tests by running the |ui_task| before DisallowUnresponsiveTasks(), which allowed the test to run without them being disallowed. However, on Android startup is asyncronous and we end up running the |ui_task| later, instead of inside the BrowserMainParts. I'd like to work to make all platforms work similarly as well. Since on Android we run the |ui_task| later, after Java has a chance to fully initialize, we must allow the test to perform these unresponsive tasks explicitly by using a newly introduced ScopedAllowUnresponsiveTasksForTesting. This provides that mechanism. R=gab@chromium.org Bug: 961849 Change-Id: I2fb5202f16a896f3e1a9d360a522e7fa5c9d304c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669732 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#671308}
-
Ian Clelland authored
Bug: 977323 Change-Id: Iece34f86ec9263234fa3b264d0082e626fcedaaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669883Reviewed-by:
-
