- 21 Aug, 2018 40 commits
-
-
jonross authored
Similar to https://chromium-review.googlesource.com/c/chromium/src/+/1173437 this patch updates autoscroll-iframe-no-scrolling.html to have timeout pass as expectations. TBR=hayato@chromium.org Bug: 873829 Change-Id: Ib534bc8d45b487888c6f75033241786aba768878 Reviewed-on: https://chromium-review.googlesource.com/1183461Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#584760}
-
Khushal authored
Don't queue a cleanup task if one is already pending. This avoid queueing multiple redundant tasks for the case where images are being purged mid-draw due to exceeding budget constraints. R=fserb@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I17ba7c59ee6031bf2c18f81e3691685a78634f3c Bug: 876001, 872117 Reviewed-on: https://chromium-review.googlesource.com/1182601Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#584759}
-
Jeroen de Borst authored
Bug: 875213 Change-Id: Ida2e195ae818724a72012fb2f0907ef09adbde10 Reviewed-on: https://chromium-review.googlesource.com/1180366Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Hoi Pipeloi <jeroendb@chromium.org> Cr-Commit-Position: refs/heads/master@{#584758}
-
Christian Biesinger authored
When we are a legacy node and computing our min/max content, we need to check if we are an orthogonal writing mode before just returning legacy min/max, so that we return the right dimension (matching container_writing_mode). Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9663bf8a384fe3bfddd457371d6ecf879fcbf03b Reviewed-on: https://chromium-review.googlesource.com/1182142Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#584757}
-
Javier Ernesto Flores Robles authored
Add strings used in Manual Fallback and in the new Autofill input accessory bar design. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1d4c6c89ee74853d76b0890c19226a1ce9000d59 Reviewed-on: https://chromium-review.googlesource.com/1179826Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#584756}
-
Xiyuan Xia authored
Bug: 866942 Change-Id: I98736af3ee98fde639b0aac6cd6ffb052802f22e Reviewed-on: https://chromium-review.googlesource.com/1180414Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584755}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b2b00c31f48c..a16d9c72d60f git log b2b00c31f48c..a16d9c72d60f --date=short --no-merges --format='%ad %ae %s' 2018-08-21 delphick@chromium.org Fix usage of deprecated V8 Value::*Value methods Created with: gclient setdep -r src/third_party/pdfium@a16d9c72d60f The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic8d598c5317831c2b239c202e69dfb5dcfd5e08c Reviewed-on: https://chromium-review.googlesource.com/1183404Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584754}
-
Henrik Grunell authored
Bug: 807547 Change-Id: Ie8374888ddfa5e81f4920dbbf9fe6bb35d7fadc4 Reviewed-on: https://chromium-review.googlesource.com/1181266 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584753}
-
Parastoo Geranmayeh authored
Reads the profiles fields validity map from the profile validation pipeline on the server side via ChromeSync PriorityPreferences. Returns the fields validity map of a profile by its GUID. Change-Id: I85ffad3495463bf38c452ced99858d1240cd6b89 Reviewed-on: https://chromium-review.googlesource.com/1178933Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#584752}
-
Christopher Grant authored
This change adds the plumbing necessary to create a UI using a future native feature module library. The code is currently behind a define, which will become a feature flag. Bug= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8f71a78f980bda790517d0bd7c41ed091ce66c52 Reviewed-on: https://chromium-review.googlesource.com/1181924Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#584751}
-
Christopher Grant authored
Desktop is moving to the refresh icons, so VR ought to move in lockstep. BUG=874671 Change-Id: I729cc8e9ff7494301464b179b9ddeb0c513475e7 Reviewed-on: https://chromium-review.googlesource.com/1182014Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#584750}
-
Tommy Martino authored
This CL: * Adds a boolean parameter to AutofillDropdownAdapter to allow us to programmatically choose between two visual styles (the existing UI, and the WIP visual refresh). * Removes dividers drawn between items in the refresh case. * Wires up the existing feature and flag which will control which style is used. Change-Id: Ia7cbb79b31e8ad9d086ef1a9a69cb6090b58d533 Bug: 874077 Reviewed-on: https://chromium-review.googlesource.com/1171558Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#584749}
-
Joe Downing authored
This CL was reverted due to Win7 failures (missing function on DXGI.dll), apparently remoting_unittests are not run on Win7 as part of the standard set of CQ trybots which is why this wasn't seen earlier. The fix is to do a LoadLibrary/GetProcAddress dance to remove the DXGI dependency. I was able to reproduce this failure on a test Win7 machine and by using the win_chromium_dbg_ng try-bot. I then verified the tests were passing using those two methods and verified the original fix is still valid on my Win10 machine. BUG=875619 Change-Id: Ie56bb9463117b2785c3340ccf4e4785e2e65235d Reviewed-on: https://chromium-review.googlesource.com/1181528Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#584748}
-
Joe Downing authored
I've found two more binaries which require Mojo init so I've updated them. I decided not to update every binary as we can easily add the init call later if we find something else which needs it. Change-Id: I7eec1ef23842d8247975edb2f0d9fccc67cdab33 Reviewed-on: https://chromium-review.googlesource.com/1182011Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#584747}
-
Ben Wagner authored
Skia is planning on making SkTCopyOnFirstWrite private to Skia. The use of SkTCopyOnFirstWrite is replaced with base::Optional. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I70d9b8537f7f2a27214f304c48111f679576c536 Reviewed-on: https://chromium-review.googlesource.com/1182363Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584746}
-
Thomas Tangl authored
The sync-paused suppress reason should only be recorded when the consent bump needs to be shown. Bug: 876235 Change-Id: I65667f941bc7e15a49681e0b61d08ab070fc71da Reviewed-on: https://chromium-review.googlesource.com/1183237Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#584745}
-
John Delaney authored
Now that per-resource updates are sent to page load metrics, we no longer need to send totals from the renderer process. Remove all piping/callbacks and convert existing consumers to OnResourceDataUseObserved. Per-resource updates: https://chromium-review.googlesource.com/c/chromium/src/+/1164222 Change-Id: I1cb03df5e6579fc0ff767900336308a6bbad244a Reviewed-on: https://chromium-review.googlesource.com/1178324Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584744}
-
Florian Uunk authored
Fixing a bug where the wallet data bridge was reading address metadata. Change-Id: I1a8dc41a59b4bb8f5855eb7c5f0fa81a3611a419 Bug: 876300 Reviewed-on: https://chromium-review.googlesource.com/1183437 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#584743}
-
Egor Pasko authored
I found that cooling down between runs helps a lot with the noise. Applying the usual threshold of 35Celsius, identical to the one used by story_runner. My testing methodology is simple: connect a N5X and run this with bash: COMMON_LOG="logs/noise" for ((i=0;i<10;i++)); do OUTPUT="$COMMON_LOG/old$i" mkdir -p "$OUTPUT" CHROMIUM_OUTPUT_DIR=gn_android/ReleaseOfficial \ tools/perf/run_benchmark -v \ experimental.startup.android.coldish \ --browser=android-chrome --output-dir="$OUTPUT" 2>&1 \ | tee "$OUTPUT/run.log" OUTPUT="$COMMON_LOG/new$i" mkdir -p "$OUTPUT" CHROMIUM_OUTPUT_DIR=gn_android/ReleaseOfficial \ tools/perf/run_benchmark -v \ experimental.startup.mobile \ --browser=android-chrome --output-dir="$OUTPUT" 2>&1 \ | tee "$OUTPUT/run.log" done On my N5X we appear to have to wait ~2 times per 10 Chrome starts to cool down the device, which is a lot of waiting. My desk is not the coldest across offices though, close to 25C right now. Noise is still an issue for 2-3 last measurements out of every batch of 10. These last runs are typically 200-300ms slower than the first 5+ runs (for messageloop start). I suspect there are still effects of overheating. The battery cutoff at 35C is probably not providing sufficient time to cool the CPU down in the new benchmark. But why is it 'good enough' for the old benchmark? I think the old way performs more dummy intermediate steps (reinitializing commandline/trace file, restarting forwarder/WPR, etc.) to allow the device to cool down. Frankly, upwards trend is present on the old benchmark as well, but more around +50ms over 10 runs. While it is not too bad at the current stage, it may become unpleasant at bisect with more iterations, or in a room that is slightly hotter. So I'll probably take a look at limiting the clock frequency for big cores, like we do for N5. Bug: 760498 Change-Id: Id050cf54c6ea21c51acdfbb1c06f20023d909454 Reviewed-on: https://chromium-review.googlesource.com/1180202Reviewed-by:Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584742}
-
Peter K. Lee authored
This gives the image button a pressed state provided by the system. Bug: 848879 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8912e4cf438a57f27bf432ccb0b1bec10146672c Reviewed-on: https://chromium-review.googlesource.com/1182669Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#584741}
-
Eugene But authored
This boolean will be true for loadHTMLString: navigations. -[CRWWebController setDocumentURL:] will have a DCHECK when new document URL does not match last committed URL in WKBasedNavigationManager. This DCHECK will help to diagnose possible URL spoofing bugs in Slim Navigation feature. For loadHTMLString: the URLs will not match, which is not a problem because loadHTMLString: are only used in tests and error pages. Bug: 876077 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iae163faf7f5cf90d5bb0e48a191786be2e1d8ee6 Reviewed-on: https://chromium-review.googlesource.com/1182313Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#584740}
-
Tommy Martino authored
Currently in the Autofill dropdown, spacers which are subject to flex sizing can end up smaller than the desired minimum size, which means the primary and secondary text run together. This CL adds a small class for the spacers which enforces a minimum size, and tells the layout manager to respect the minimum size. Screenshots (Googlers only): https://docs.google.com/presentation/d/1IeyKg22nSbt8aDkvCGrHx1SBg7UBQIqymWDj2sLJ9JQ/edit?usp=sharing Change-Id: I3b62af0f8355edf2353485986c7e529f8a0a8017 Bug: 875014 Reviewed-on: https://chromium-review.googlesource.com/1179981 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Daniel Erat authored
Add README.md files in //ash/dbus and //chrome/browser/chromeos/dbus. Bug: 843392 Change-Id: I31181b72aabf60f7c09feda7e8081078215ad472 Reviewed-on: https://chromium-review.googlesource.com/1182951 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584738}
-
Helen Li authored
This is to help with investigating cookies bugs. This is based on rdsmith@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/925181 Bug: 801910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia0fbfca17a8a8ad76cbcc4e1ae46330b3f706ea0 Reviewed-on: https://chromium-review.googlesource.com/1175921 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#584737}
-
Vadym Doroshenko authored
As part of implementation of the saving in new parsing we need to make the similar operations with NewPasswordFormManager as with PasswordFormManager in PasswordManager. In order to avoid copying the code, this CL introduces PasswordFormManagerForInterface for handling both classes though it. Details of implementation of saving in PasswordManager with NewPasswordManagePasswordManager in CL https://chromium-review.googlesource.com/c/chromium/src/+/1180220 Bug: 831123 Change-Id: I509be6c9b1f295e7e6d2bd482fbf2dc8177d7ac9 Reviewed-on: https://chromium-review.googlesource.com/1181025 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584736}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ca77050d3e65..1a8cd3c7348f git log ca77050d3e65..1a8cd3c7348f --date=short --no-merges --format='%ad %ae %s' 2018-08-21 primiano@google.com Merge "Bump NDK to 17b." Created with: gclient setdep -r src/third_party/perfetto@1a8cd3c7348f The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I93a83407503bef723f2cfd64c808aad55051a550 Reviewed-on: https://chromium-review.googlesource.com/1183401Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584735}
-
Tibor Goldschwendt authored
If we enter VR without a Daydream headset paired the assets component won't be registered. This is intended. However, we will always trigger an on-demand update no matter if the component is registered or not. Thus, remove DCHECK for testing whether component is registered when on-demand updating the component. The component updater will just return if we try to on-demand update an unregistered component. Change-Id: If512f9c8aa7170e34864c40333ba6a727da01a58 Reviewed-on: https://chromium-review.googlesource.com/1182362Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#584734}
-
Max Moroz authored
TBR=inferno@chromium.org,liaoyuke@chromium.org Bug: 817798 Change-Id: Id38a434ce51619e66962a789eb6d4c808a11bda0 Reviewed-on: https://chromium-review.googlesource.com/1183524 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#584733}
-
Vasilii Sukhanov authored
Bug: 875237 Change-Id: Id3ea73365dd50c9bc4d2d13659d37b03bc26c180 Reviewed-on: https://chromium-review.googlesource.com/1183430 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#584732}
-
Guido Urdaneta authored
The test has flaked on Windows, Linux and Mac. Bug: 875908 TBR: lazyboy@chromium.org Change-Id: I214ecaea3d96bd5d2e892556b0f92d7bb4f652d6 Reviewed-on: https://chromium-review.googlesource.com/1183433Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#584731}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f13375c925bf..4d727c560b58 git log f13375c925bf..4d727c560b58 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 scroggo@google.com Add dummy SkEncodedInfo.cpp Created with: gclient setdep -r src/third_party/skia@4d727c560b58 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: Ib5caa7b1d100cce66a2b3bf25bff1b0ff98faa63 Reviewed-on: https://chromium-review.googlesource.com/1183402Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584730}
-
Kevin Bailey authored
Most of the time, we only use the most important arguments when constructing a SuggestResult, those passed to the Result sub-constructor. This change adds a constructor for this most often used case, and also adds methods for setting the answer-related fields separately. Change-Id: I2ed077b93b142f90fa16d53d146e6081174f7907 Reviewed-on: https://chromium-review.googlesource.com/1178102Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
What was happening? When the keyboard was hidden, te form suggestion controller was being reset. At the same time, the form observer had triggered a suggestions look up, causing call to an unexistent block. Bug: 875177 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie42fc8588fd368a24779134ad9370114995fefaf Reviewed-on: https://chromium-review.googlesource.com/1183181Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#584728}
-
DongJun Kim authored
autofill : Use ContainsValue() instead of std::find() in components/autofill This simplifies many conditions around the code. Bug: 561800 Change-Id: I36579da9e0e62fbf834a39419c9bc253546fec24 Reviewed-on: https://chromium-review.googlesource.com/1183268 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584727}
-
Max Moroz authored
- Move all report post processing logic to a separate coverage_utils file. - Add switch for disabling component view. - Fix shared libraries regexp to match versioned libraries. - Move HTML post processing methods into a class (to reduce passing a bunch of parameters back and forth). - Add _Main() to coverage_utils.py that can be used outside of Chromium. For example, to use that script on OSS-Fuzz we would need to do the following: 1) git clone https://chromium.googlesource.com/chromium/src/tools/code_coverage somewhere 2) echo -en '#!/bin/bash\npython3 somewhere/coverage_utils.py $@\n' \ > /usr/local/bin/coverage_helper Bug: 817798 Change-Id: I8de8cec2d118f022eb43634dd85b96e4126f5e63 Reviewed-on: https://chromium-review.googlesource.com/1180364 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#584726}
-
Ramin Halavati authored
DOM distiller preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: Icb08ad733b48a193c3ec52087d92decde6563191 Reviewed-on: https://chromium-review.googlesource.com/1179144Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#584725}
-
Francois Doray authored
ScopedAllowBlockingForTesting should be used instead. This should be a no-op change. TBR=gab@chromium.org Bug: 766678 Change-Id: I02f4af90c410efa3dccce193d134ec46555e7ef1 Reviewed-on: https://chromium-review.googlesource.com/1171559 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#584724}
-
Amirhossein Simjour authored
VrTabHelper is not Android specific anymore, so I remove the ifdef condition and DCHECK. Moreover, I added a new UiSuppressedElement that covers the suppression of permission bubble without confusion with suppression of the PermissionRequest. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7300ee5cab28d1ce5b95bf6a60e9a67b9aef94a9 Reviewed-on: https://chromium-review.googlesource.com/1175036 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#584723}
-
Justin Cohen authored
Xcode 10 obscures compile failures when build output includes relative paths, and our xctest-build-sources fail to compile. Disable build system for now. Bug: 852522 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ice0e5c7e6734270f804ae0f8a21cf5621ff13f58 Reviewed-on: https://chromium-review.googlesource.com/1182143Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL updates the OpenInNewTab animation. Bug: 865863 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1138a23bb96c9b81e50f247b5bf2b293df001e60 Reviewed-on: https://chromium-review.googlesource.com/1181128Reviewed-by:
-
