- 12 Oct, 2018 40 commits
-
-
Aga Wronska authored
Logging demo setup steps will help to determine at what point problems occured for example in case of infinite loading. Change-Id: I04725e4c9d0de12553f6f14fb3d8ee7d106e9699 Reviewed-on: https://chromium-review.googlesource.com/c/1277957Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#599088}
-
Ian Clelland authored
This queues a report through the Reporting API whenever the Generic Sensor API is used in a frame in which the specific sensor is not allowed according to feature policy. Bug: 867471 Change-Id: I9c50f4a331b2b2230890ee0c357047704af8425a Reviewed-on: https://chromium-review.googlesource.com/c/1263041Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#599087}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d23bbdb87b57..9a72c51a329f git log d23bbdb87b57..9a72c51a329f --date=short --no-merges --format='%ad %ae %s' 2018-10-12 vapier@chromium.org paygen: download_cache_unittest: convert to lib.gs & delete gslib.Cat 2018-10-12 vapier@chromium.org paygen: gslib: drop unused Stat Created with: gclient setdep -r src/third_party/chromite@9a72c51a329f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5c3d6623dd88c54fd144213025257ecc157d0565 Reviewed-on: https://chromium-review.googlesource.com/c/1278489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599086}
-
Roger Tawa authored
Bug: 893874 Change-Id: Id07fb2e9d67403cb77d571df41b4b2aef11bb46d Reviewed-on: https://chromium-review.googlesource.com/c/1278475 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599085}
-
Ryan Hansberry authored
Links can't be opened like they usually would be in OOBE, because there's no browser to open them in. This CL creates a webview modal which is displayed when the user clicks on one of the two "Learn More" links in the MultiDevice OOBE screen, and loads it with the appropriate URL. Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png Bug: 893349 Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127 Reviewed-on: https://chromium-review.googlesource.com/c/1275296 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599084}
-
Dominick Ng authored
This will allow WebAPKs to be bounced to the desktop browser on Chrome OS devices. BUG=893927 Change-Id: Ic70b58d2ab2b23960cc894dd3420174b523908e6 Reviewed-on: https://chromium-review.googlesource.com/c/1272756Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#599083}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f2ed299569c0..c4533eae082f git log f2ed299569c0..c4533eae082f --date=short --no-merges --format='%ad %ae %s' 2018-10-12 yizhou.jiang@intel.com Enable ANGLE_texture_multisample in glsl in es 3.0 Created with: gclient setdep -r src/third_party/angle@c4533eae082f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ie5a6b652c2c723a90215ae863749da0c24965d4d Reviewed-on: https://chromium-review.googlesource.com/c/1278528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599082}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I81c44eb87bd68655b6cbc34a68cde6f851a839f0 Reviewed-on: https://chromium-review.googlesource.com/c/1278328Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599081}
-
Kyle Horimoto authored
This ensures that connections to our Mojo services are disconnected, which will result in the Shutdown() code added in this CL will run: https://chromium-review.googlesource.com/c/chromium/src/+/1274886 Bug: 884066 Change-Id: Ifb4fad53fc9d1a693ae83099dc43ee9908303ea7 TBR: jhawkins@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1277588 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#599080}
-
Sadrul Habib Chowdhury authored
It looks like on android, presentation timestamps can sometimes be very large. DumpWithoutCrashing() in such cases to collect some data to understand why/when/where this is happening. BUG=894440 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I22817f68014c3f57f7180accc593506eee86f291 Reviewed-on: https://chromium-review.googlesource.com/c/1276549 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599079}
-
Azeem Arshad authored
This CL adds a special note under messages for android entry in notification permissions to indicate usage in ChromeOS multidevice features. This note will be displayed whenever the messages sync feature is enabled. Please refer screenshot: https://screenshot.googleplex.com/VnGZ1qApzHk.png Bug: 845706 Change-Id: Ibcbe706cf9c579d980e4440825b8bc70b64466df Reviewed-on: https://chromium-review.googlesource.com/c/1260503 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#599078}
-
Albert J. Wong authored
Bug: 419087 Change-Id: Ic870c7059fef752560d0299064a0cef4a1733f3a Reviewed-on: https://chromium-review.googlesource.com/c/1277594 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599077}
-
Becky Zhou authored
Bug: 894660 Change-Id: Ib8b7d6484bd050daf4d295c1c9367bd132cb9e80 Reviewed-on: https://chromium-review.googlesource.com/c/1278269Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599076}
-
wutao authored
This cl checks the |allowed_status| before starting assistant service. Bug: b/117371953 Test: manual. Change-Id: I0b638db9d92abd5f54c5f7f41d5f66c25a719f77 Reviewed-on: https://chromium-review.googlesource.com/c/1278345 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#599075}
-
David Black authored
Per request from UI/UX folks, enlarging DialogPlate icons sizes to 24dip and adjusting left inset for voice input modality layout container. Note that the vector icon files themselves were also updated per request in the bug to ensure consistency of internal padding. Also per request, the greeting label is shifted up by 4dip. See bug for discussion/screenshots. Bug: b:112313532 Change-Id: I5b72c6867452470abbc8bd562c83ba37492279ea Reviewed-on: https://chromium-review.googlesource.com/c/1276947 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599074}
-
David Black authored
This CL moves processing logic out of UiElementContainerView and into AssistantResponseProcessor which is owned by AssistantInteractionController. The controller will now initiate processing of the Assistant response before it is finalized. This cleans up the view logic considerably as well as provides better synchronization of animations since processing will have already occurred prior to the stage initiating a change. Bug: b:117344968, b:116751668 Change-Id: I3ac1300978a3448fd7e244b6a7312ec9bf3c39bd Reviewed-on: https://chromium-review.googlesource.com/c/1265820 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#599073}
-
Pavel Feldman authored
Bug: 893705 Change-Id: I6df37f886de9c080fa20c972df7457b0a726ce3e Reviewed-on: https://chromium-review.googlesource.com/c/1278206Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599072}
-
Zhizhou Yang authored
This patch will remove a linker flag for ThinLTO. The flag was first introduced to work around a nacl crash bug. After the compiler upgrade, there is no need to keep this work around. I tested the nacl_helper code size changes on several different boards: on samus: 30MB -> 11MB on elm: 19MB -> 7MB on veyton-minnie: 19MB -> 7MB Tested correctness by trying to reproduce https://crbug.com/799642 and no error shows up. BUG=chromium:799642 TEST=USE="afdo_use" emerge-samus chromeos-chrome Change-Id: I6fff65700e6d5a5d0e02ad810def5317ea912263 Reviewed-on: https://chromium-review.googlesource.com/c/1277596Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Zhizhou Yang <zhizhouy@google.com> Cr-Commit-Position: refs/heads/master@{#599071}
-
Scott Chen authored
The original CL 1252906 was reverted due to breaking unit tests for branded window builds. This CL fixes that by removing obsolete unit tests. It was testing the mechanism that conditionally directs users to the chrome://welcome/email and chrome://welcome/apps experiment URLs, which will no longer be used. Bug: 874153 Change-Id: I3b92b53e191606a6f5889cf17b15a570ce566994 Reviewed-on: https://chromium-review.googlesource.com/c/1275294Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599070}
-
Patti authored
This reverts commit c3acb7ba. Reason for revert: This change may be causing ash_unittests to fail on multiple builders - see crbug.com/894683 Original change's description: > splitscreen: Adjust bubble dialog bounds if splitscreen is active. > > When a dialog is added to a window that's currently showig in > splitscreen, we should adjust the dialog bounds to show the dialog > aligned within its own side of the split, rather than across the divider > bar. > > Note the divider is still placed on top of the snapped windows and its > transient children if they are placed in default container. > > Bug: 878268 > Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880 > Reviewed-on: https://chromium-review.googlesource.com/c/1274197 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598827} TBR=xiyuan@chromium.org,xdai@chromium.org Change-Id: I74d78ce0184d2028811872ac633da33ede16f296 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878268, 894683 Reviewed-on: https://chromium-review.googlesource.com/c/1277907Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599069}
-
Kent Tamura authored
This CL makes LayoutTests/PRESUBMIT.py and some tests in LayoutTests/ workable in blink/web_tests/ too. Moving LayoutTests directory gets easier by this CL. * PRESUBMIT.py - Use PresubmitLocalPath() instead of 'LayoutTests' - Remove unnecessary check for existence of 'LayoutTests' in AffectedFiles(), which returns files under the PRESUBMIT directory. _FindNewViolationsOfRule() also handles only files under the PRESUBMIT directory. * Tests - Update code searching for 'LayoutTests' so that it searches for 'web_tests' too. - Drop 'LayoutTests' from test expectations if we can - Introduce relativeTestPath() Change-Id: I741ab3cb29d8e6c2a35e3b7669f92744f76c2839 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1276047Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#599068}
-
Henrique Nakashima authored
Previously, after HandleMessage matched the message type, if the argument types were wrong it would keep trying to match with the other message types. Change-Id: Ia270ddc0ac4614b3ef998bcd30d3686f987dd809 Reviewed-on: https://chromium-review.googlesource.com/c/1277445Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#599067}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 08d41ac5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25970 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ic18cb6ace02a8e07c8b1c4fcca71bd9ce8704ebd Reviewed-on: https://chromium-review.googlesource.com/c/1278142 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599066}
-
John Rummell authored
BUG=894422 TEST=test passes on Windows Change-Id: I3907fecda3642f542db153e68ce12cb33c074402 Reviewed-on: https://chromium-review.googlesource.com/c/1278467 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599065}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55ac0aa2f68f..616feb1a7c2c Created with: gclient setdep -r src-internal@616feb1a7c2c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia68c999e8e301f47fc1e0dadeb8cd369a1377495 Reviewed-on: https://chromium-review.googlesource.com/c/1277840Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599064}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c7f66edd2244..94f3ca931552 git log c7f66edd2244..94f3ca931552 --date=short --no-merges --format='%ad %ae %s' 2018-10-11 thestig@chromium.org Fix some nits in CJS_Document helpers. 2018-10-11 thestig@chromium.org Use pdfium::Vector2D in CCodec_FaxEncoder ctor. Created with: gclient setdep -r src/third_party/pdfium@94f3ca931552 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I062fef526b85eec3b0d299893951ad74a10d4b2c Reviewed-on: https://chromium-review.googlesource.com/c/1278485Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599063}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7078e2599b7b..d23bbdb87b57 git log 7078e2599b7b..d23bbdb87b57 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 gmx@chromium.org kip: enable new tcmalloc Created with: gclient setdep -r src/third_party/chromite@d23bbdb87b57 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7c19b61739142e56b9c1053adbbf8b5884e2738c Reviewed-on: https://chromium-review.googlesource.com/c/1277836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599062}
-
Edward Lemur authored
Bug: 881860 Change-Id: I32d8c17e2501010a24b9550c433407dfd55a3807 Reviewed-on: https://chromium-review.googlesource.com/c/1278525Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#599061}
-
Eric Roman authored
Bug: 891526 Change-Id: I3ecda33cc7c1dbc2df96a613c5723a77ead9806c Reviewed-on: https://chromium-review.googlesource.com/c/1258505Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599060}
-
Jeremy Klein authored
Adding a temporary exception for one link-in-text-block error. This error comes from the fact that we (intentionally) removed the underline from the learn more links in our settings. I've filed crbug.com/894602 to work with UX on a new strategy and remove this exception. Bug: 894602 Change-Id: I0da37adfee02699415a011939dbfc6d4e1d93f34 Reviewed-on: https://chromium-review.googlesource.com/c/1278131 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599059}
-
Jeremy Klein authored
The phone side flags and enrollment will be slower than the ChromeOS rollout. In order to avoid breaking Instant Tethering in the meantime, look for cases where: 1) There are no host devices reporting BETTER_TOGETHER_HOST support. 2) There is at least one host device reporting INSTANT_TETHER_HOST support. In this scenario, the only possiblity is that this host device has not reenrolled yet after receiving the new flags. Bug: 893769 Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d Reviewed-on: https://chromium-review.googlesource.com/c/1277272 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599058}
-
Lei Zhang authored
Also remove some unused/redundant headers, and remove a check that will always evaluate to true. Change-Id: I816ab3154c50b1f0f1f8c4fc738760b97e607d7e Reviewed-on: https://chromium-review.googlesource.com/c/1277677Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#599057}
-
Nico Weber authored
This reverts commit 4e9c4b37. Reason for revert: This might no longer be needed; revert to check. (I thought the bot built in two different build dirs, and for that to work we need to land https://chromium-review.googlesource.com/c/chromium/src/+/1273479 first, but it builds in one dir, moves that elsewhere, and builds in that dir again. We should probably make it build in two different dirs once that other CL is in, to make sure that that keeps working.) Original change's description: > Set symbol_level=0 on Windows Deterministic. > > If /debug is passed to lld, the pdb aging in PDB70DebugInfo currently > means that repeat builds get different PDB70DebugInfo headers, so for now > don't pass /debug to the linker. > > Bug: 330260 > Change-Id: I86e6b470ad95f3f6556c8f8f69d6d394a32661ff > Reviewed-on: https://chromium-review.googlesource.com/1162948 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580765} TBR=thakis@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 330260 Change-Id: I8637e6c089464eddc7d9cfc35f6fa28b0cd54987 Reviewed-on: https://chromium-review.googlesource.com/c/1277486Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599056}
-
khmel@chromium.org authored
TEST=Manually BUG=b:117366533 Change-Id: I1038cbd9adf7e92df1953a428cd9b1a9bceb9b45 Reviewed-on: https://chromium-review.googlesource.com/c/1278291 Commit-Queue: Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#599055}
-
HyeockJinKim authored
Remove sub-namespace and rename symbols to start with WebSpeechSynthesisConstants. Bug: 889726 Change-Id: I48be833ca3b71f6a482f23d168a2aeaf212323f4 Reviewed-on: https://chromium-review.googlesource.com/c/1257722Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#599054}
-
rbpotter authored
Fixing CrSettingsPeoplePageSetupPinDialogTest.All with 2 changes: (1) Reading updated pin dialog from the pin-change event, rather than from |pinKeyboardValue_|. In Polymer 2, this value is not updated at the time the pin-change event arrives. (1) In the test for the backspace button, set the value in cr-input instead of on the pinKeyboard directly, so that |selectionStart_|, used to determine if the backspace key should be enabled, will be > 0. Bug: 875454 Change-Id: Iec83f3a85a4d04fe710cb6b5e23b99d59be54f49 Reviewed-on: https://chromium-review.googlesource.com/c/1274462 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#599053}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: accessibility/ animations/ battery-status/ bindings/ clipboard/ compositing/ crypto/ Most of this patch is mechanical rebaseline, except: - Some LayoutNG-specific baselines become redundant and are removed - One test is turned into failure with LayoutNG flag due to LayoutNG innerText bug with ellipsis (crbug.com/873957). Bug: 887148 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Idf28a2696b4824f3fd845c7392b588544e8de1d3 Reviewed-on: https://chromium-review.googlesource.com/c/1239165Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599052}
-
Kunihiko Sakamoto authored
This removes internal testing API that overrides SignedExchange signature verification time, which is no longer needed since --ignore-certificate-errors-spki-list now ignores signature timestamp errors. This is mostly a revert of https://crrev.com/c/991833. Bug: 803774 Change-Id: I5b2f77062d897f6c025566ea98fe740735ae8172 Reviewed-on: https://chromium-review.googlesource.com/c/1270457Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599051}
-
Thomas Anderson authored
This reverts commit 6d83f4b9. Reason for revert: Suspected cause of browser_test failures on "Mac10.13 Tests (dbg)": https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/5697 Original change's description: > macOS V2 Sandbox: Report correct sandbox profile for nacl-loader. > > The nacl loader process, used only on macOS, currently tries to load an > invalid profile type under the V2 sandbox. This loads the correct type. > > Bug: 892554 > Change-Id: I7b2733db426e3c91181b1f375d791d2918ac6763 > Reviewed-on: https://chromium-review.googlesource.com/c/1268671 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Derek Schuff <dschuff@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598380} TBR=dschuff@chromium.org,tsepez@chromium.org,kerrnel@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892554 Change-Id: Ib5a7767695fce263830cf9329da0cda99aaab9b7 Reviewed-on: https://chromium-review.googlesource.com/c/1278162Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599050}
-
Sunny Sachanandani authored
EGL_ANGLE_flexible_surface_compatibility allows contexts to be able to bind to surfaces with different formats e.g. with or without alpha. With DirectComposition, we have a real surface inside a Begin/EndDraw pair, and use a default 1x1 pbuffer surface outside of that. That surface must be created with flexible surface compatibility so that we can MakeCurrent outside of Begin/EndDraw. Noticed this while working on a related change. There were some crashes in MakeCurrent in SetSwapInterval which was fixed in a different way by removing SetSwapInterval, but it's possible the root cause was this. Bug: 800950 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I05aa1a61bfa0d1445778bbd9599d3f630dddbe8c Reviewed-on: https://chromium-review.googlesource.com/c/1237535Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#599049}
-