GitLab

The 'http_lib' target was erroneously configured as a component rather
than a source set, which broke the component build.

Bug: 874155
Change-Id: I968b2418891d5a702f408791cd88b3077090f47d
Reviewed-on: https://chromium-review.googlesource.com/c/1290512
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601033}

Previously, page visits were recorded in RecordTopHostMetrics() for
several transition types that were filtered out when retrieving
TopHosts, such as reloads. This has been changed so that the same
filters are used for both, which should make the UMA histogram more
accurate.

HistoryServiceTests have been updated to test the top hosts histogram
and an additional test has been added to verify that the page
transitions recorded as visits by RecordTopHostMetrics() and those
retrieved from the db when TopHosts() is called remain in sync.

Additionally, PAGE_TRANSITION_KEYWORD_GENERATED is no longer culled
from those incrementing the visit count.

Lastly, histograms.xml has been updated to reflect the current state
of History.TopHostVisitsByRank. This histogram hasn't been in active
use since September of 2017, although it'll soon become active again.

Bug: 846459
Change-Id: I3fb153fab5c4e8db06a980d60ba869a2b25af903
Reviewed-on: https://chromium-review.googlesource.com/c/1270183Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jered Gray <jegray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601032}

When llvm-nm finds no symbols in an object file (.o file or embedded in
in .a file) it prints 'no symbols' to stderr. This produces a lot of
noise when running 'supersize archive' from command line.

This CL makes SuperSize capture stderr for calls to llvm-nm (and nm,
although it seems to be more quiet). The number of stderr lines (all
'no symbols' as far as we see), if non-0, is returned by
nm.RunNmOnIntermediates(), and printed by obj_analyzer._RunNm() as a
warning.

Change-Id: I2090f8762614d5fc3102f0ec94ef7e83fc305bfd
Reviewed-on: https://chromium-review.googlesource.com/c/1289989Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601031}

testVariationArgs and testTelemetryUsesChromeClockDomain should be
handled by https://chromium-review.googlesource.com/c/1284756

Bug: 895977
Test: chromeos-amd64-generic-rel
Change-Id: I2627df526bfa56d5ae6e32d4954cb08c8f8c8378
Reviewed-on: https://chromium-review.googlesource.com/c/1289949Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601030}

Bug: 879306
Change-Id: I7f425130467b120cfc8822c7ec6e77126a1c018c
Reviewed-on: https://chromium-review.googlesource.com/c/1289703
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601029}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5a432f7b9d71..299607e8f0fa

$ git log 5a432f7b9..299607e8f --date=short --no-merges --format='%ad %ae %s'
2018-10-16 niwa Pass arc_file_picker feature flag to ARC container as an Android property
2018-10-16 isandrk cryptohome: Remove deprecated TpmGetVersion call
2018-10-10 matthewmwang shill: Add HTTPS URL to system_api and percolate it down to ConnectivityTrial

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 117814025
Test: Built succeeded
Change-Id: Icf6ae5aec850283404f97f61fa3a582b52f384b9
Reviewed-on: https://chromium-review.googlesource.com/c/1288516Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601028}

Screenshot: https://imgur.com/a/YlClsZ0

Bug: none
Change-Id: Ic6732ba029cb0c03a166db77b32daf31f3b79cfa
Reviewed-on: https://chromium-review.googlesource.com/c/1290199Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601027}

TextPrompts have contenteditable="plaintext-only", which keep their
text selection after losing focus. This CL hides their text select
highlight when not focused.

Also, live expressions no longer keep their highlight when
losing focus.

Bug: 820007
Change-Id: I19f1e498c3e3c03ad38f022e3c2e9ebbf0f96d94
Reviewed-on: https://chromium-review.googlesource.com/c/1069334Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601026}

This CL removes MarkAllPopupsAsShown from MessagePopupCollection.
MarkAllPopupsAsShown was the root cause of multiple heap-use-after-free
e.g. https://crbug.com/869716 and https://crbug.com/869593 .

The method marks active popups as shown and closes them, but ideally
it's better to do that in MesageCenterImpl (model) rather than in
MessagePopupCollection (view).

TEST=MessagePopupCollectionTest
BUG=none

Change-Id: Iec1dac95ab68ca0a29b3b70d7284392bc826904e
Reviewed-on: https://chromium-review.googlesource.com/c/1280562Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601025}

BUG=896519

Change-Id: Ic6572e30daf960501f14ecac4a932f1091be5957
Reviewed-on: https://chromium-review.googlesource.com/c/1290132
Commit-Queue: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601024}

VPN feature pod button didn't update when VPN connection state changed
during UnifiedSystemTray is open. It was because it didn't observe the
network state change.

TEST=manual
BUG=896411

Change-Id: I1b9333b277dbcfc86265837b74a5864279b4b3ca
Reviewed-on: https://chromium-review.googlesource.com/c/1288333
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601023}

Previously, RemoteFrame navigations did not perform any renderer-side
checks and relied solely on the browser-side logic to block disallowed
navigations via mechanisms like FilterURL.  This means that blocked
remote frame navigations were silently navigated to about:blank
without any console error message.

This CL adds a CanDisplay check to the remote navigation path to match
an equivalent check done for local frame navigations.  This way, the
renderer can consistently block disallowed navigations in both cases
and output an error message.

Bug: 894399
Change-Id: I172f68f77c1676f6ca0172d2a6c78f7edc0e3b7a
Reviewed-on: https://chromium-review.googlesource.com/c/1282390Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601022}

https://pdfium.googlesource.com/pdfium.git/+log/1ee77bd42da6..1f120c74ea2e


git log 1ee77bd42da6..1f120c74ea2e --date=short --no-merges --format='%ad %ae %s'
2018-10-18 tsepez@chromium.org Fully populate JS platform callbacks in pdfium_test
2018-10-18 thestig@chromium.org One more round of IWYU in fxjs/.
2018-10-18 tsepez@chromium.org Try assigning more kinds of values to doc props


Created with:
  gclient setdep -r src/third_party/pdfium@1f120c74ea2e

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I93634c658f5a2697ffd0a495575e3ce948c65cff
Reviewed-on: https://chromium-review.googlesource.com/c/1290390Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601021}

This patch renames |ContainsOnlyLatin1()| to |ContainsOnlyLatin1OrEmpty()| as
consistency with the patch[1] for improving readability.

Note: All renaming is done by global replace tool.

This patch similar to the patch[2] which renames |ContainsOnlyASCII()|.

[1] http://crrev.com/c/1288157 Rename ContainsOnlyWhitespace() to
ContainsOnlyWhitespaceOrEmpty()
[2] http://crrev.com/c/1288502 Rename ContainsOnlyASCII() to
ContainsOnlyASCIIOrEmpty()

Change-Id: I6dbe6230ebf859b366c978c89973c508a6c0c090
Reviewed-on: https://chromium-review.googlesource.com/c/1288501Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601020}

Bug: 896884
Change-Id: I8071de9ccebf71bcb112990d2e35ca55eb4d7df6
Reviewed-on: https://chromium-review.googlesource.com/c/1289708
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601019}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c1e6594df580..93277a7fc8ef


git log c1e6594df580..93277a7fc8ef --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ehmaldonado@chromium.org git-cl: Don't report metrics for not-known repos.


Created with:
  gclient setdep -r src/third_party/depot_tools@93277a7fc8ef

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:896868
TBR=agable@chromium.org

Change-Id: I6fc12fb825faf3aaac42ce49bca253c0b07cd855
Reviewed-on: https://chromium-review.googlesource.com/c/1289656Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601018}

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Idf883678744f87a7d431154608242d0ed0ec7e91
Reviewed-on: https://chromium-review.googlesource.com/c/1288309Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601017}

Initial implementation of an AHardwareBuffer backed sharableImage and
corresponding unittests.

Bug: 891060
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I785a8666c210a21463514b79f8cc253c6b9544d3
Reviewed-on: https://chromium-review.googlesource.com/c/1282442
Commit-Queue: vikas soni <vikassoni@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601016}

This change also splits the reporting of offline page counts between
prefetched and non-prefetched.

Bug: 896095, 894643
Change-Id: Ic3bfc53ecd2558df1b349af66bbe7d3f88bd6531
Reviewed-on: https://chromium-review.googlesource.com/c/1285750Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601015}

This CL makes following improvements:
* Now first time Shift-Tab will focus on "Clear All" button.
* Now "Change" button for lock screen notification is included in
  focus cycle.

TEST=manual
BUG=880041

Change-Id: I3185936e505755a9d0de19c4425c285b3337e9ad
Reviewed-on: https://chromium-review.googlesource.com/c/1288110Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601014}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3102c9b3cef9..bf9c8d4c233a


Created with:
  gclient setdep -r src-internal@bf9c8d4c233a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:856278
TBR=mmoss@chromium.org

Change-Id: I7b602eecd1c474f742827645b5911e2ebf6f51e8
Reviewed-on: https://chromium-review.googlesource.com/c/1290389Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601013}

Not all invalidations for Drive come with a version, so check
is_unknown_version().

Bug: 870004
Change-Id: I4640f65883fc858fe98404dd9c6c74d3313ac03e
Reviewed-on: https://chromium-review.googlesource.com/c/1290449Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601012}

I'm introducing a binary type to the devtools protocol;
autofill assistant uses a forked version of our client code generator
against the .pdl files and third_party/inspector_protocol/pdl.py.

So here, I'd like to map binary to string, to avoid having to
backport the protocol::Binary support for the autofill assistant.
This means that just like now, this code will have to base64decode
the strings manually to get the payload.

My overall WIP change is in here, and happy to explain more:
https://chromium-review.googlesource.com/c/chromium/src/+/1244719

I'm adding a TODO to this script to later follow up with
protocol::Binary support. See http://crbug.com/896940.

Bug: chromium:891377
Change-Id: I29613a787c037fada0845372a84f3d283906f153
Reviewed-on: https://chromium-review.googlesource.com/c/1285751
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601011}

https://skia.googlesource.com/skia.git/+log/798a713685a9..60ad17593c93


git log 798a713685a9..60ad17593c93 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@60ad17593c93

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: Iba4f7af0171d307e86bcf5e7ad427392a74e7879
Reviewed-on: https://chromium-review.googlesource.com/c/1289660Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601010}

Bug:896541

Change-Id: Ic1055a756eea05d5399d93e805ca9389b89805cc
Reviewed-on: https://chromium-review.googlesource.com/c/1287952
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601009}

https://chromium.googlesource.com/angle/angle.git/+log/2b73d6251f92..e4c64c3dc862


git log 2b73d6251f92..e4c64c3dc862 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ianelliott@google.com Implement new API/interface for the ANGLE feature-support utility.


Created with:
  gclient setdep -r src/third_party/angle@e4c64c3dc862

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Icffbd40fca27ff8a695cfb5302bcb57ceb214314
Reviewed-on: https://chromium-review.googlesource.com/c/1289659Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601008}

Changes:
1. Duration from 600ms to 350ms.
2. Tween type from linear to fast_out_slow_in

Bug: 884386
Change-Id: Id095124d2259ca211df004d6365b96aabfa57601
Reviewed-on: https://chromium-review.googlesource.com/c/1290143Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601007}

Bug: 893218
Change-Id: I95f07482e66f0e30d77c2ebda94f6a47f2eb86e7
Reviewed-on: https://chromium-review.googlesource.com/c/1290000
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601006}

Bug: 893761
Change-Id: Ia90c742402dca369847c22aa91c037c45fb92edd
Reviewed-on: https://chromium-review.googlesource.com/c/1288500Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601005}

Bug: b:69899077
Change-Id: I84c1083869ce6fc7f4579ae22271ea2a344e459c
Reviewed-on: https://chromium-review.googlesource.com/c/1283478
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601004}

The enum GL_QUERY_RESULT_AVAILABLE_NO_FLUSH_CHROMIUM_EXT was not being
handled, and as a result we were doing a check before the result was
available and causing a flush.

R=piman@chromium.org

Bug: 896830,894200
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ic4dc1ec22b2768d7d47ee63c61cc410554be563e
Reviewed-on: https://chromium-review.googlesource.com/c/1289958Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601003}

When scanning the stack we're really just checking if any element in
the vector is true. We can replace this O(n) check with O(1) if we
keep track of the number of true elements in the vector.

Bug: 894505
Change-Id: I378cffe80212277a7fa8ad414e15a5cf3c9824c8
Reviewed-on: https://chromium-review.googlesource.com/c/1289329
Commit-Queue: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601002}

https://chromium.googlesource.com/catapult.git/+log/7c50ac5ddf5b..cedb2de8832d


git log 7c50ac5ddf5b..cedb2de8832d --date=short --no-merges --format='%ad %ae %s'
2018-10-18 bpastene@chromium.org devil: When fetching HealthyDevices, retry a configurable amount of times.


Created with:
  gclient setdep -r src/third_party/catapult@cedb2de8832d

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:892670
TBR=sullivan@chromium.org

Change-Id: I742f07e46dc22cb354eeda835ca13341cdc912ac
Reviewed-on: https://chromium-review.googlesource.com/c/1289891Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601001}

In the combined CronetChromeWebView framework, Cronet may be started
first, resulting in ignored command line flags set in
web_view_global_state_util.mm.

Change-Id: I1b65558d9042d726f634a87ac5ea1e1bd8df0a9c
Reviewed-on: https://chromium-review.googlesource.com/c/1290193Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601000}

InProgressCache is no longer being used as we are switching to in-progress db.
Remove the class and its usage

BUG=894978

Change-Id: I1309de54c265e60f6e707765f67b7a1666b0e9f9
Reviewed-on: https://chromium-review.googlesource.com/c/1289167
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600999}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=scottmg@chromium.org

Bug: 681136
Change-Id: I64f5b45d9f9d378578c3d0f2d80deb675fe3aa6a
Reviewed-on: https://chromium-review.googlesource.com/c/1288341Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600998}

When a sync user confirms to sign out after trying to turn
off the signin-allowed toggle, the toggle is now turned off.

Additional change:
 - The code related to the sign-out dialog in settings is
 extracted into its own element and refactored.

Bug: 892745
Change-Id: I9d638d8c77b1f4318fc592cc88f4be95e5eab7c8
Reviewed-on: https://chromium-review.googlesource.com/c/1280542Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600997}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=battre@chromium.org

Bug: 681136
Change-Id: Ie31e3afbb761c43dded20d7b15da8354e167014a
Reviewed-on: https://chromium-review.googlesource.com/c/1288490Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600996}

DownloadItem should know whether it is created from history.
No need to keep DownloadHistory::WasRestoredFromHistory.

BUG=895597

Change-Id: If8aa8c5e07a5d4d4e35edff9e37b98adefe77df7
Reviewed-on: https://chromium-review.googlesource.com/c/1289084Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600995}

BUG=896814

Change-Id: I07d4e0895862874347422661d7a3963e25216440
Reviewed-on: https://chromium-review.googlesource.com/c/1289514Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600994}