GitLab

R=mark
BUG=15904
TEST=no more weird errors when generating bindings


Review URL: http://codereview.chromium.org/155089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19952 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/13924
TEST=none

Review URL: http://codereview.chromium.org/155011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19950 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/149203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19949 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15818
TEST=Valgrind-Mac green
Review URL: http://codereview.chromium.org/149201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19947 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19946 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/155012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19945 0039d316-1c4b-4281-b951-d872f2087c98

Add remaining functionality for popup blocker: popup menu to unblock individual popups and whitelist sites. Also fixes intermittant leak on valgrind bots from poorly constructed unit test.
BUG=13160, 15818
TEST=unblocking popups, whitelisting sites, and unwhitelisting them. Green valgrind bot.
Review URL: http://codereview.chromium.org/149145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19944 0039d316-1c4b-4281-b951-d872f2087c98

Move Emf class to the printing library.  Also creates a platform agnostic NativeMetafile definition to ease platform porting.

BUG=none
TEST=none (No functional change)

Review URL: http://codereview.chromium.org/149181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15818
TEST=None
TBR=pinkerton

Review URL: http://codereview.chromium.org/149196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19942 0039d316-1c4b-4281-b951-d872f2087c98

These are the same tests that were rebaselined on Windows, with additional
tests that have form control buttons, since we draw those with a Skia gradient.

BUG=15918

Review URL: http://codereview.chromium.org/155084


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19941 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15918

Review URL: http://codereview.chromium.org/155054


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19940 0039d316-1c4b-4281-b951-d872f2087c98

adds stack trace colletion for Errors, and avoids execution stack recursion 
when parsing regular expressions.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/155082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19939 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15912

Review URL: http://codereview.chromium.org/155068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19938 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/155074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19937 0039d316-1c4b-4281-b951-d872f2087c98

Redraw the location bar on reload. This change is Mac port of http://codereview.chromium.org/100198.

BUG=none
TEST=open http://dev.chromium.org/, double click the location bar, press delete (delete URL string), press reload button, verify the URL is redrawn.

Review URL: http://codereview.chromium.org/155070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19936 0039d316-1c4b-4281-b951-d872f2087c98

Right after Destroy() is called, render_widget_host_ is deleted.  So
clear render_widget_host_ and guard calls to render_widget_host_.

http://crbug.com/14613
http://crbug.com/13514
http://crbug.com/12725

Review URL: http://codereview.chromium.org/155021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19933 0039d316-1c4b-4281-b951-d872f2087c98

TEST=15977
BUG=none

Review URL: http://codereview.chromium.org/149190

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19932 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that VisitedLink listener Add event only fires when new fingerprint is added, and not during resizing/rebuilding or deleting fingerprints.

R=brettw
TEST=VisitedLinkTest.Listener
BUG=15926

Review URL: http://codereview.chromium.org/149185

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19931 0039d316-1c4b-4281-b951-d872f2087c98

Add an ExtensionBrowserTest base class that allows in-process browser tests of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled.

Review URL: http://codereview.chromium.org/150213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98

This is still the foundation, has no implementation, just plain old html and its structure.

BUG=173, 947
TEST=none

Review URL: http://codereview.chromium.org/155051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19918 0039d316-1c4b-4281-b951-d872f2087c98

This should not affect other targets.

BUG=None
TEST=None
TBR=sgk

Review URL: http://codereview.chromium.org/149152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19916 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=slows down the try server


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19913 0039d316-1c4b-4281-b951-d872f2087c98

This will close issues 10346 and 14679

TEST=lots
BUG=10314,10343,10469,10479,11322,11613,11795,12053, 15132,15217,15270,15733,15873,10346,14679
Review URL: http://codereview.chromium.org/155058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19912 0039d316-1c4b-4281-b951-d872f2087c98

correctly.  Currently, we leak all allocated RGBColor values because
we are messing up the refcounting.

This is part one of three of fixing http://crbug.com/9514.  Part two
is landing the corresponding codegenerator change upstream.  Part
three is making the RGBColor constructor private.

TEST=LayoutTests/transitions/shorthand-border-transitions.html
BUG=9514
Review URL: http://codereview.chromium.org/155049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19911 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw
BUG=http://crbug.com/231
BUG=http://crubg.com/5160
TEST=ExpireHistoryTest.ArchiveSomeOldHistory
TEST=ExpireHistoryTest.ExpiringVisitsReader
TEST=VisitedLinkTest.Listener
TEST=VisitedLinkTest.Resizing
TEST=VisitedLinkRelayTest.*
TEST=VisitedLinkEventsTest.*


Review URL: http://codereview.chromium.org/113591

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19910 0039d316-1c4b-4281-b951-d872f2087c98

was a bad idea because of its significant dependencies on NavigationController
and NavigationEntry. I'm trying to make renderer_host not depend on tab_contents
at all.

Remove the dependency on TabContents pointers for notifications from the
ResourceDispatcherHost. Instead of having the broadcast code in the
ResourceDispatcherHost, I made it call a RenderViewHostDelegate callback. Then
TabContents implements the notification, so that it's really from the
TabContents.
Review URL: http://codereview.chromium.org/150069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=15921
TEST=none

Review URL: http://codereview.chromium.org/155056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19908 0039d316-1c4b-4281-b951-d872f2087c98

Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument.
Also made the --debug-print startup parameter only active in non-official builds.

BUG=none
TEST=Should have no functional affect.

Review URL: http://codereview.chromium.org/149148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19907 0039d316-1c4b-4281-b951-d872f2087c98

Create the foundations of implementing a tab for printing should be in the form of:
print:http://www.google.com
I have followed similar approach as what has been done with view-source: and chrome-extension:

BUG=173, 947
TEST=none

Review URL: http://codereview.chromium.org/150207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/149178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19904 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: do console evaluations in the global context of the inspected window. That context is exposed as contentWindow global variable to inject.js by ResetUtilityContext method.
Review URL: http://codereview.chromium.org/149174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19903 0039d316-1c4b-4281-b951-d872f2087c98

send() can send parts of the buffer fed in. We should send parts of the buffer until the entire buffer has been transferred.
Review URL: http://codereview.chromium.org/150229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19902 0039d316-1c4b-4281-b951-d872f2087c98

Some layout tests failed in a recent merge due to a FocusController change. They now pass (and a new test fails).

BUG=http://crbug.com/15780
TEST=Run the layout tests.
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/155044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19901 0039d316-1c4b-4281-b951-d872f2087c98

one in which isNull() returns true.

This assertion was being tripped as a result of some
recent changes I made to expose a CGImageRef as the basis
or a WebKit::WebImage.  I think it makes sense to put
this null check in CGImageToSkBitmap instead of at each
callsite.

TEST=covered by mac ui tests
BUG=none
TBR=mark

Review URL: http://codereview.chromium.org/149173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19900 0039d316-1c4b-4281-b951-d872f2087c98

We used to store/restore the frame and node that were focused last when a age would lose/gain focus. 
This patches lets WebKit takes care of it by using the new FocusController::setFocused method.

BUG=http://crbug.com/15777
TEST=Open www.google.com, the focus should be on the text-field (focus ring + blinking caret). Activate another window. The page should not show the text-field with the focus. Switch tabs, make sure the focus is remembered correctly. Do the same tests in a page with frames. Run the layout tests.


Review URL: http://codereview.chromium.org/151195

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19899 0039d316-1c4b-4281-b951-d872f2087c98

SkBitmap member (avoiding a level of indirection).

This CL makes it so that Mac Chrome will now write bitmap data to the clipboard
when requested by WebKit.  I also simplified the ImageDecoder class that lives
in glue.

BUG=15648
TEST=none
R=dglazkov

Review URL: http://codereview.chromium.org/155010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19898 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19892 0039d316-1c4b-4281-b951-d872f2087c98