GitLab

This delegates timeout logic to the step command.

BUG=
R=bulach@chromium.org, craigdh@chromium.org

Review URL: https://codereview.chromium.org/23784006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221721 0039d316-1c4b-4281-b951-d872f2087c98

BUG=103846

Review URL: https://chromiumcodereview.appspot.com/23587012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221720 0039d316-1c4b-4281-b951-d872f2087c98

> rAc: Wallet: UMA for wallet response codes.
> 
> BUG=261814
> 
> Review URL: https://chromiumcodereview.appspot.com/23461033

TBR=ramankk@chromium.org

Review URL: https://codereview.chromium.org/23604043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221718 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23979003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221716 0039d316-1c4b-4281-b951-d872f2087c98

This function copied an empty GUID leading to Shill not matching the right networks.
This change prevents copying an empty GUID and also checks that all other (required) identifying properties are non-empty.

BUG=280146

Review URL: https://chromiumcodereview.appspot.com/23819024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261814

Review URL: https://chromiumcodereview.appspot.com/23461033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221713 0039d316-1c4b-4281-b951-d872f2087c98

- LoadDirectoryIfNeeded calls GetResourceEntryByPath for directory metadata.
- GetResourceEntryByPath calls LoadDirectoryIfNeeded for its parent if needed.

The cycle enables to fetch deep entries at any time without waiting for
the full feed nor user to dig down the hierarchy from the root.

Along the way, I removed the handling of  ReadDirectoryByPath("drive/other")
that waited the full feed to arrive. By removing it, all FileSystem
operations are now clearly ensured not blocked by full feed fetching.
Listing up "drive/other" is meaningless; Files.app never does that.

BUG=285614

Review URL: https://chromiumcodereview.appspot.com/23441049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221712 0039d316-1c4b-4281-b951-d872f2087c98

It's multi-sided patch, so again it has ugly ifdefs.

Corresponding blink patch:
https://codereview.chromium.org/23704004/

BUG=257349
TEST=try, both with and without Blink patch

Review URL: https://chromiumcodereview.appspot.com/23762002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221710 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221709 0039d316-1c4b-4281-b951-d872f2087c98

The style guide says that the _test suffix should be used for tests, and the
_unittest suffix is deprecated. Rename all the src/net/websockets test files to
match.

BUG=280943
TEST=net_unittests --gtest_filter="WebSocket*"

Review URL: https://chromiumcodereview.appspot.com/23614009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221708 0039d316-1c4b-4281-b951-d872f2087c98

R=reed@google.com

Review URL: https://codereview.chromium.org/24021004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221707 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221706 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157337:157356&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/24029002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221705 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vrk@chromium.org
BUG=276894

Review URL: https://chromiumcodereview.appspot.com/23480030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221704 0039d316-1c4b-4281-b951-d872f2087c98

> Simple refactoring - remove outdated page index 
> 
> BUG=282464
> TBR=ygorshenin@chromium.org 
> NOTRY=true 
> 
> Review URL: https://chromiumcodereview.appspot.com/23571009 

Most likely caused this: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/17876/steps/browser_tests/logs/stdio 

TBR=antrim@chromium.org


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221703 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r221413.

Original CL: https://src.chromium.org/viewvc/chrome?revision=221413&view=revision

BUG=286266
NOTRY=true
TBR=dgrogan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23538008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140717
R=toyoshim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23522021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221701 0039d316-1c4b-4281-b951-d872f2087c98

Implement Device Orientation data fetcher for the Windows 7 or greater platform. The fetcher uses 3D inclinometer windows sensor to update the orientation information in the shared memory buffer.

BUG=261165

Review URL: https://chromiumcodereview.appspot.com/22926032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221700 0039d316-1c4b-4281-b951-d872f2087c98

Drive API v2 can copy a file not only into root directory but also other
directory directly, and it should more efficient and simpler.
This CL uses it to upload JSON GDoc file.

BUG=277353
TEST=Ran unit_tests and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23344004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221697 0039d316-1c4b-4281-b951-d872f2087c98

Implement ToValue() for SystemMetrics, SystemMemoryInfoKB, DiskInfo, and SwapInfo. These are used to serialize the data inside these structs.

BUG=236763

Review URL: https://chromiumcodereview.appspot.com/23155002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221696 0039d316-1c4b-4281-b951-d872f2087c98

> Save password functionality added to the save password bubble behind flag. The buttons now let the user save and blacklist passwords.
> 
> BUG=261628
> 
> Review URL: https://chromiumcodereview.appspot.com/22975006

This caused a regression in the media permission UI.  See bug for details.
BUG=286294
TBR=npentrel@chromium.org

Review URL: https://codereview.chromium.org/24024006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221695 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/24035002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221693 0039d316-1c4b-4281-b951-d872f2087c98

Extension pointer can be null in the if clause, so we should rely on extension_id instead of extension->id().

BUG=None
CID=109059
TBR=yoz

Review URL: https://chromiumcodereview.appspot.com/23496030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221692 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282464
TBR=ygorshenin@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23571009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221691 0039d316-1c4b-4281-b951-d872f2087c98

As we switched FastFetch back to GData WAPI, but fetching next page on r221196
mistakenly keep using Drive API v2's one. This CL fixes it.

BUG=283622
TEST=Ran unit_tests and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23647010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221690 0039d316-1c4b-4281-b951-d872f2087c98

It's replaced by a version which takes an isolate. The default ctor will be
removed soon.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/23679004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221689 0039d316-1c4b-4281-b951-d872f2087c98

All interactive views implement GetAccessibleState
to provide accessibility information about the current
state of the view. This struct now includes a callback
that can be used to change the string value, since
automation software wants to fill in text fields,
and this interface is implemented for Textfield
and LocationBarView, and hooked up to put_accValue.

BUG=260266

Review URL: https://chromiumcodereview.appspot.com/23441024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221688 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/23694017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=204944
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23462008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221686 0039d316-1c4b-4281-b951-d872f2087c98

The fixture of ID is needed not only for WAPI -> DriveAPI
but also for WAPI -> FakeDriveService.

BUG=285614

Review URL: https://chromiumcodereview.appspot.com/23670006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221685 0039d316-1c4b-4281-b951-d872f2087c98

This adds the output device id to places where we already have an input device id.
On windows we now support a non-default device id in the WASAPI implementation.

BUG=276894
R=henrika@chromium.org

Review URL: https://codereview.chromium.org/23466008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221684 0039d316-1c4b-4281-b951-d872f2087c98

These were removed from skia and aren't used here in Chromium, so lets remove
them now.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/23548012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221681 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284998
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23462023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221679 0039d316-1c4b-4281-b951-d872f2087c98

Following long discussion at https://chromiumcodereview.appspot.com/23129027/
it's better to keep infrastructure team dealing with all reviews in here.

BUG=None
TEST=None
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/23814005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221677 0039d316-1c4b-4281-b951-d872f2087c98

This adds "Hide <app>" to the app menu that is shown when an app window
has focus. This also enables the Cmd+H shortcut. 

This also adds an IPC message to instruct the shim to hide.

This also adds a command ID for Hide and a corresponding tag to
MainMenu.xib.

BUG=168080, 276052
TEST=Start an app.
Press Cmd+H or select Hide from the main menu. The app should hide.
Clicking the app's dock icon, or Cmd+Tab to the app should show it again.

Review URL: https://chromiumcodereview.appspot.com/23514021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221676 0039d316-1c4b-4281-b951-d872f2087c98

Suppression the problems on the build bots: There were two reasons why that CL broke the build tree. One is the size bloating, which was solved by https://codereview.chromium.org/23460018. The other is compiling error on ARM, and this was also solved by updating CLD2 (https://chromiumcodereview.appspot.com/23606017/). 

--

Use Finch to compare the performances of CLD1 and CLD2

Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used.

By this CL, each platform will have the below status:

Linux:    Use both CLD1 and CLD2 (and use Finch).
Mac OS X: Use both CLD1 and CLD2 (and use Finch).
Windows:  Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap.
iOS:      Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.)
Android:  Still use only CLD1. (The same reason as iOS)

So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.)

BUG=240647

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221380

Review URL: https://chromiumcodereview.appspot.com/22867032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221675 0039d316-1c4b-4281-b951-d872f2087c98

> Switch to doing user-resizing via system for panels on Mac
> 
> We used to track and handle user-resizing by ourselves. This brings up a few problems and makes the user-resizing hard to use on Mac. For example, the user-resizing could not be triggered outside or on the edge. Switching to doing it via system solve all these problems.
> 
> Also removed EnableResizeByMouse which is not really used in our code.
> 
> BUG=282652,282657
> TEST=manual test by user-resizing panels
> 
> Review URL: https://chromiumcodereview.appspot.com/23918002

TBR=jianli@chromium.org

Review URL: https://codereview.chromium.org/23922003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284400

Review URL: https://chromiumcodereview.appspot.com/23935004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221673 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes an 'autocomplete-suggest' element which wasn't fixed in the previous patch(r220270) and adds some comment.

BUG=280928
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23465011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221672 0039d316-1c4b-4281-b951-d872f2087c98