GitLab

/analyze pointed out that the bit testing in gles2_cmd_decoder.cc was
always returning true due to the wrong operator being used.

Warnings were:

src\gpu\command_buffer\service\gles2_cmd_decoder.cc
(3128) : warning C6316: Incorrect operator:  tested expression is constant and non-zero.  Use bitwise-and to determine whether bits are set.
(5103) : warning C6316: Incorrect operator:  tested expression is constant and non-zero.  Use bitwise-and to determine whether bits are set.

BUG=427616

Review URL: https://codereview.chromium.org/690943004

Cr-Commit-Position: refs/heads/master@{#302343}

Previously it didn't, and perhaps there was no need for
it to, but it seems like NaCl has a need. Specifically,
NaCl has two targets A and B with both run fine on their
own, but A can delete the output of B, and so needs to run
before B.

R=brettw@chromium.org
BUG=428576

Review URL: https://codereview.chromium.org/693443002

Cr-Commit-Position: refs/heads/master@{#302342}

BUG=428816
NOTRY=true

Review URL: https://codereview.chromium.org/696843002

Cr-Commit-Position: refs/heads/master@{#302341}

The incorrectly placed parentheses means that failure of the first
function didn't stop the others from executing, and overall failure was
evaluated incorrectly -- always succeeding I think.

Warnings were:

d:\src\chromium2\src\media\audio\win\core_audio_util_win.cc(361) :
C6215: Cast between semantically different integer types: Boolean type to HRESULT.
C6230: Implicit cast between semantically different integer types:  using HRESULT in a Boolean context.

BUG=427616

Review URL: https://codereview.chromium.org/688663004

Cr-Commit-Position: refs/heads/master@{#302340}

Otherwise it will leave dangling pointers in the SurfaceManager. Also add a DestroyAll method to allow owners to ensure every surface in the factory is destroyed.

BUG=428127

Review URL: https://codereview.chromium.org/693623004

Cr-Commit-Position: refs/heads/master@{#302339}

BUG=424650

Review URL: https://codereview.chromium.org/686983002

Cr-Commit-Position: refs/heads/master@{#302338}

BUG=

Review URL: https://codereview.chromium.org/669783003

Cr-Commit-Position: refs/heads/master@{#302337}

With this CL, the ServiceWorkerCacheListener holds a reference to the
caches that it calls async functions on to ensure that the callbacks
are called.

Note: Keeping the cache alive longer does not alter cache deletion
behavior as cache deletion destroys the cache's backend but not the
ServiceWorkerCache object itself.

BUG=429161

Review URL: https://codereview.chromium.org/682383005

Cr-Commit-Position: refs/heads/master@{#302336}

BUG=none
TEST=none
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/689143002

Cr-Commit-Position: refs/heads/master@{#302335}

CL https://codereview.chromium.org/633373010 added some output files
but did not update the expected output files in the corresponding GN
files.

BUG=429299
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/694853003

Cr-Commit-Position: refs/heads/master@{#302334}

Also includes changes from https://codereview.chromium.org/695953002/ to
update html_viewer for API changes.

Review URL: https://codereview.chromium.org/694923002

Cr-Commit-Position: refs/heads/master@{#302333}

Revert of WebView Guest should use ZOOM_MODE_ISOLATED. (patchset #2 id:100001 of https://codereview.chromium.org/645153002/)

Reason for revert:
This CL seems to be at the root of several other issues, including https://code.google.com/p/chromium/issues/detail?id=429004.

In particular, it seems to be allowing re-entrancy into ZoomController that was unexpected due to the timing with which OnGuestReady() is called.

Original issue's description:
> WebView Guest should use ZOOM_MODE_ISOLATED.
>
> In order that changes to zoom levels in a WebView Guest don't affect
> the embedder, set the WebView Guest's WebContents to use
> ZOOM_MODE_ISOLATED.
>
> BUG=418605
>
> Committed: https://crrev.com/f71a5dc79473cc74990d1e288c66ac282c2926a1
> Cr-Commit-Position: refs/heads/master@{#299493}

TBR=fsamuel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=418605

Review URL: https://codereview.chromium.org/690373002

Cr-Commit-Position: refs/heads/master@{#302332}

BUG=428055

Review URL: https://codereview.chromium.org/688973004

Cr-Commit-Position: refs/heads/master@{#302331}

Revert of Roll src/third_party/skia d8aa7b7:3bdd7dc (patchset #1 id:1 of https://codereview.chromium.org/683733007/)

Reason for revert:
XP tests are crashing again. See https://code.google.com/p/chromium/issues/detail?id=429207

Original issue's description:
> Roll src/third_party/skia d8aa7b7:3bdd7dc
>
> Summary of changes available at:
> https://chromium.googlesource.com/skia/+log/d8aa7b7..3bdd7dc
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
> TBR=hcm@google.com
>
> Committed: https://crrev.com/a0a1b16124cb5c4340cf56e6df92fef846fb0337
> Cr-Commit-Position: refs/heads/master@{#302311}

TBR=hcm@google.com,skia-deps-roller@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/696833002

Cr-Commit-Position: refs/heads/master@{#302330}

## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:445: ERROR - Property wifiCredentialsSynced never defined on args
##         $('wifi-credentials-checkbox').checked = args.wifiCredentialsSynced;
##                                                  ^
##
## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:447: ERROR - Property wifiCredentialsSynced never defined on args
##             args.wifiCredentialsSynced;
##             ^
##
## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/chrome/browser/resources/sync_setup_overlay.js:449: ERROR - Property wifiCredentialsEnforced never defined on args
##             args.wifiCredentialsEnforced;
##             ^

BUG=none
TEST=green closure bot
TBR=quiche@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/696013002

Cr-Commit-Position: refs/heads/master@{#302329}

Now that prefixed EME code can add event handlers before calling
generateRequest(), the flakiness problems with these tests is
fixed.

BUG=402766
TEST=re-enabled tests pass

Review URL: https://codereview.chromium.org/689153003

Cr-Commit-Position: refs/heads/master@{#302328}

BUG=429205

Review URL: https://codereview.chromium.org/695753003

Cr-Commit-Position: refs/heads/master@{#302327}

BUG=408772

Review URL: https://codereview.chromium.org/530593002

Cr-Commit-Position: refs/heads/master@{#302326}

The NSS dependency should be guarded by a use_openssl check. BoringSSL and NSS
cannot be linked together as they define some of the same symbols. Update BUILD.gn
analogously by depending on //crypto:platform.

Also condition nss in build/all.gyp on use_openssl in preparation for
https://codereview.chromium.org/694643002/ which will disable the nss and nspr
targets altogether.

BUG=429021

Review URL: https://codereview.chromium.org/686693004

Cr-Commit-Position: refs/heads/master@{#302325}

This is useful for instrumentations required for jankiness investigations. See the .h file comment for details.

In fact, one of my investigations is blocked on this feature.

BUG=401560

Review URL: https://codereview.chromium.org/683283004

Cr-Commit-Position: refs/heads/master@{#302324}

Removes some dependencies from codegen.cc as it now only deals with
emitting programs, not with disassembling them too.

BUG=414363

Review URL: https://codereview.chromium.org/694013002

Cr-Commit-Position: refs/heads/master@{#302323}

TBR=vsevik@chromium.org
BUG=

Review URL: https://codereview.chromium.org/689173002

Cr-Commit-Position: refs/heads/master@{#302322}

The C++ code was added in r185124, but without the histograms.xml entry,
we cannot view the histogram.

Review URL: https://codereview.chromium.org/693063002

Cr-Commit-Position: refs/heads/master@{#302321}

BUG=429131
TEST=none

Review URL: https://codereview.chromium.org/684983004

Cr-Commit-Position: refs/heads/master@{#302320}

BUG=429131
R=dalecurtis@google.com

Review URL: https://codereview.chromium.org/684763005

Cr-Commit-Position: refs/heads/master@{#302319}

Fix lint errors along the way.

Review URL: https://codereview.chromium.org/635573005

Cr-Commit-Position: refs/heads/master@{#302318}

BUG=427605

Review URL: https://codereview.chromium.org/696583004

Cr-Commit-Position: refs/heads/master@{#302317}

FieldTrialTest.DisableProbability was using Time::NowFromSystemTime - 1 year to generate a date before the build time. Instead use GetBuildTime - 1 year.

TransportSecurityState::IsBuildTimely is using GetBuildTime to determine if the build is older than 10 weeks. Disable this and return a default value if DONT_EMBED_BUILD_METADATA is defined (i.e. The build time is invalid) and we're not doing an official build.

CL based on https://codereview.chromium.org/685123005/ with some additional fixes for the unittests.

BUG=314403

Review URL: https://codereview.chromium.org/695523002

Cr-Commit-Position: refs/heads/master@{#302316}

BUG=419870,427671
R=davidben@chromium.org, felt@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/649413004

Cr-Commit-Position: refs/heads/master@{#302315}

This ensures that key handling works while in a frame.

R=arv@chromium.org
BUG=424135

Review URL: https://codereview.chromium.org/682393002

Cr-Commit-Position: refs/heads/master@{#302314}

BUG=428204

Review URL: https://codereview.chromium.org/691253003

Cr-Commit-Position: refs/heads/master@{#302313}

Many requests that would eventually be timeout errors instead show up
as ERR_ABORTED, so make requests ending in ERR_ABORTED visible to
Domain Reliability collectors.

BUG=

Review URL: https://codereview.chromium.org/690083002

Cr-Commit-Position: refs/heads/master@{#302312}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d8aa7b7..3bdd7dc

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/683733007

Cr-Commit-Position: refs/heads/master@{#302311}

Linux and Android need some more work before this can
happen there. No intended behavior change.

BUG=427584

Review URL: https://codereview.chromium.org/679143004

Cr-Commit-Position: refs/heads/master@{#302310}

Devtools is not ready to get callbacks if accept returns connections
synchronously.

BUG=428389

Review URL: https://codereview.chromium.org/683733006

Cr-Commit-Position: refs/heads/master@{#302309}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=400876

Review URL: https://codereview.chromium.org/694853002

Cr-Commit-Position: refs/heads/master@{#302308}

BUG=418975
R=bnc@chromium.org

Review URL: https://codereview.chromium.org/687263002

Cr-Commit-Position: refs/heads/master@{#302307}

We need a full IDR frame (not just I slices) when requesting keyframe because
we need all the reference buffers to be reset.

BUG=424443
TEST=verify with video_encode_accelerator_unittest and H264 test app on squawks and daisy

Review URL: https://codereview.chromium.org/686283002

Cr-Commit-Position: refs/heads/master@{#302306}

These strings form a message box which is shown when drag-n-dropping an
extension onto chrome://extensions. This message is the same as the one
shown when loading an extension through "Load unpacked extension..."
button but it is not localized.

R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/684153002

Cr-Commit-Position: refs/heads/master@{#302305}

When a browser window is instructed to open a URL, if the only existing tab is
the NTP, the NTP should be replaced with a tab with the given URL.

This was partially fixed by https://codereview.chromium.org/240273002, but that
only tackled the case where Chrome was launched as a result of an open URL
Apple Event. This CL replicates the behavior for Chrome receiving a URL from
Handoff, and for Chrome receiving an open URL Apple Event while Chrome is
already running.

BUG=428081, 43520

Review URL: https://codereview.chromium.org/678423003

Cr-Commit-Position: refs/heads/master@{#302304}