- 16 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e4e0146560d..0449293b6768 2020-07-16 taylori@google.com perfetto-ui: Show import errors as icon If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:161404000 Tbr: perfetto-bugs@google.com Change-Id: I5ae0f74b5af9e1fb69f8c494753dcaaf9ba01eb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789043}
-
Mohamed Amir Yosef authored
Screenshots: Example 1: https://screenshot.googleplex.com/yWX9dnL5eEK.png Example 2: https://screenshot.googleplex.com/76D3hhLNgOH.png Bug: 1100814 Change-Id: Iaa9bb2f2bbf8af375fa9f18833f9f9113822a795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300385 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789042}
-
Etienne Pierre-doray authored
Not used in active investigations and expiring soon. Bug: 1105064, 1105067 Change-Id: I587e2df361526494c0564ab18470d4d3e131e92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300264Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#789041}
-
Chris Sharp authored
It incorrectly referenced impact inputs, but it only impacts outputs. Change-Id: Ie5e655f1075f75ce12a462df306c1d3a651ef1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298259Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789040}
-
Dylan Cutler authored
This will automatically add instrumentation to this field using web IDL bindings code that will be used to determine whether this API leaks info about users' cross-origin identity. You can see a similar CL which annotates other fields of the navigator interface here: https://chromium-review.googlesource.com/c/chromium/src/+/2290052 Bug: 973801 Change-Id: I6215424b9fd517b97a8d226e966e7d771f30a629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295686 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789039}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I50880834ccdb413ed9a42ebd356c1b725dc77712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301875Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789038}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=morlovich@chromium.org Change-Id: I6dc40eacd222ec9d022ee13caf8715c92f619f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298841 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#789037}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib0d94a7f3515c86ef8e49933509d65cbe4c0044d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789036}
-
Sergey Ulanov authored
Previously decoded image cache size was set to 128MB on all devices that have less than 4GB of memory. It's too high for some devices. Reduce it to 32MB in low-end device mode. This is intended for Fuchsia devices that run in low-end mode. This change doesn't affect Android. Also updated non-Android version of the code to use SysInfo::IsLowEndDevice() instead of checking the flag directly. This change has no affect on systems with more than 512MB of memory, so it shouldn't affect supported desktop systems. Bug: 1106046 Change-Id: I2029d7383fc036a5627370a37b3d66ef1752b481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300329Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789035}
-
Olivier Robin authored
When transitioning to active state, call activity handling with active = NO so URL is stored in startupParameters and is handled later in the function. Bug: 1104042 Change-Id: I8ad6ab404db118b03d62b7f5e3f633ba694c3f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299349Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789034}
-
Andrey Zaytsev authored
RequestGenerator::getNumSignedIn() made an incorrect assumption that it was running on the UI thread. Fixed it to match RequestGenerator::getNumGoogleAccountsOnDevice(), which posts the necessary code to the UI thread. Tested manually by having OmahaBase::getRequestGenerator() return a custom version of MockRequestGenerator and checking "adb logcat". Bug: 1070620 Change-Id: Ib04e34ea0b2d7ca2fc64a209731013e6d43fd09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300384 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#789033}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1b9b53a39576..e28cc55cac22 2020-07-16 tommek@google.com Implementing Queue::WriteTexture in Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7e5866e64de1b54bf235dfd4f6202e26b997246c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789032}
-
Chris Sharp authored
Bug: 1018157, 1006822 Change-Id: I1b8d72c079f8cf8be1e4defd543f84738531a244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295714 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789031}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: I5b53efc7ebd6b9d870c83c883f59279596a0583c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295836Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#789030}
-
Adlai Holler authored
This is part of a larger effort to force users to provide the direct context for image manipulations that need it instead of blindly talking to the context that created the image. See bug for details. Bug: skia:104662 Change-Id: I95709c65abeafcb8b1b126b3af3bb787ae970a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299194 Commit-Queue: Adlai Holler <adlai@google.com> Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#789029}
-
Eric Leese authored
Bug: 1094436 Change-Id: If17169c8c629c7ad7f87ba86e1d09f6435cf249b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289788 Commit-Queue: Eric Leese <leese@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#789028}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594878809-35ea1154d4590798f7d37522056e8d492cada716.profdata to chrome-mac-master-1594899981-52deb7a5a818691ecf42e5c040aa970329d9defe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I5112b4cff06769ef34e9b55fa022a544db2d35fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789027}
-
Oleh Lamzin authored
Move message_pipe.js to component, so it can be reusable for Media App and Telemetry Extension. Bug: b:159927590 Change-Id: I9ea31e3b8c43ae80e7adeef5958c4ac6411fa376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244251 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#789026}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6d8669ad9a0..187489319e76 2020-07-16 jacktfranklin@chromium.org Reland "Ship new ElementsBreadcrumbs to production" 2020-07-16 kprokopenko@google.com [issues] Update protocol by adding source location to CSP issue details. 2020-07-16 tvanderlippe@chromium.org Move copy_inspector_images to Images/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9f89a6e6ce57ea07a1331b283f9fa34985628e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301991Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789025}
-
Ramin Halavati authored
Since we are not planning to resurruct incognito CCTs anymore, a TODO for using app's name as OTR profile id is removed. Bug: 1023759 Change-Id: I519414964146c608fc2cbc16d7fa2265acd93eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302190Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#789024}
-
Zhongyi Shi authored
Bug: 1103915 Change-Id: Iefbcfefce800d32f2848bf96b7087af87ab99503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301203 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789023}
-
Aaron Leventhal authored
Accessibility is in a good position to review our changes to these files, which will help increase our velocity. NOTRY=true Bug: None Change-Id: I4d86e3f86637c8c912323af71597efe40db06ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298041Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789022}
-
ckitagawa authored
These tests are blocking a Skia update without a good reason. For now they will be disabled. Swapping out the SkPicture directly is non-trivial due to how we used googlestorage and need to update the stored copy when the test isn't live to avoid issues with bots having out of sync data compared to the test. For now I'm just going to disable all the affected tests. Bug: 1106035 Change-Id: I3db25f37c311e951500ce60abe5d61e0fe0b5ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300277Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#789021}
-
Mikel Astiz authored
No behavioral differences: a new struct (SyncErrorInfo) is introduced to centralize attributes that can be inferred from sync_ui_util::AvatarSyncErrorType and that are relevant when displaying the sync info container. Change-Id: I2318613b265135c57c936575216fcecf8bf8a344 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302030Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#789020}
-
Che-Yu Wu authored
policy, and reporting on non-Chrome OS devices. The existing fields in the requests duplicated by the fields in browser_device_identifier will be deprecated and removed in the future. Due to some sync issues, the proto changes were submitted in crosreview.com/2294659, this CL add comments to explain our plan. Bug: 1104858 Change-Id: I65cedb89bd74b77df5f097c8f6867433b52f734a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240354 Commit-Queue: Che-yu Wu <cheyuw@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789019}
-
Vasiliy Telezhnikov authored
This CL fixes two problems with external stencil: * When we draw FBO at clip_rect.origin we essentially apply translate to existing transform. To compensate this we apply reverse translate to transform (in RecalculateClipAndTransform) before setting it to SurfaceQuad. Before this change Translate() was used, which is essentially PreTranslate instead of PostTranslate, which is not correct. * This CL also adds VAO state reset if it's supported. While this code doesn't use or care about VAO, it potentially could change state of last binded VAO after rendering. Bug: 1106007 Change-Id: I983b07886d5061dbb4407a498c50f6c1858093e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300345Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789018}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8d8e2e15743a..7e4e0146560d 2020-07-16 lalitm@google.com Merge "ci: update docker files to allow building" 2020-07-16 lalitm@google.com Merge "tp: move thread state implementation to trace processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I412bc97614101d32d749a8f3197b4bddb56dae78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301989Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789017}
-
Sreeja Kamishetty authored
Remove BackForwardCache::EvictIfCached which is being used to check if the RenderFrameHost is in cache or not and evict it accordingly. For this, we already have IsInactiveAndDisallowReactivation, which would be a more correct fit as we also check for other RenderFrameHostImpl::lifecycle_state() for inactivity. In this CL, we replace the usages in Autofill, PasswordManager with IsCurrent() and in PermissionContextBase with IsInactiveAndDisallowReactivation() which should only allow showing UI when the frame is active. BUG=1041021 Change-Id: I170fd671fb0c9c9c9979bbc2e78b0d8a9f18afa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295819 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789016}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id028788d685e5e3c4f0031b866b6226776eaee56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299476Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789015}
-
Matt Jones authored
This patch changes TabsTest to call show/hide for the tab switcher directly on the layout manager without animation rather than finding and clicking the button. The testNewTabButton test has also been updated to avoid using TouchCommon. Bug: 799728 Change-Id: I2fb2483a6855535d541e6eaa569b6b5d45da70ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300504 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#789014}
-
Andrey Zaytsev authored
* 1 second delay is a UI guidance * Removed dividers between the Safety check elements * Disabled the Safety check elements in the "Running" state * Updated the strings to match the latest UI mocks Bug: 1070620 Change-Id: Ib15a4f9dc38fa4155b9eb9daaf7f64d17bf857ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297384Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#789013}
-
Andrei-Laurențiu Olteanu authored
Change serial type from uint32 to string, to ensure a more stable API in case product serial number is larger than uint8. Bug: b:160628527 Change-Id: Ia6f97977abffb4569c0c4d7af141ad0d8cdf756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294805Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#789012}
-
Mohamed Amir Yosef authored
This CL brings the move banner one step closer to the mocks. Follow up CLs will polish it more. Screenshots: Example 1:https://screenshot.googleplex.com/HJEjgB1jNSt.png Example 2:https://screenshot.googleplex.com/zR8GEYpfCvX.png Bug: 1100814 Change-Id: I17d7234c3da059508ff40d02abe33d83036026af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301772Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#789011}
-
Ehimare Okoyomon authored
Temporary fix for the mappings of Preferences to ContentSettingsType in android settings. Fix the order and add a correctness test. Bug: 1103597 Change-Id: Ic33748e8f04a0b491252d5aae8d83ceedfe7275c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294804Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#789010}
-
Alex Chau authored
- Start using Core in NerabyConnections to get the stack compiuled - Add back bloom_filter to BUILD.gn Bug: 1037793 Change-Id: Ic3a8b564761ea62720a08a43e888ac034dec9a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299749 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#789009}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8794ac6b442e..f6d8669ad9a0 2020-07-16 changhaohan@chromium.org Abstract out functions that do not access instance variables If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096230,chromium:1106251 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7dd92d7c1dfbad0ebb6033142d869b8e68cde330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789008}
-
Mugdha Lakhani authored
Add tests for omnibox popup for NoStatePrefetch. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I7fa291408f9a3a5d2cb6e606ff21b1cc339ff754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299750 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789007}
-
Fredrik Söderqvist authored
Replace Contains()+insert()+at() with single insert(). Change-Id: If64f6d6e9822b682ea886eedce4c0a4731e422ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289787Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#789006}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0ea0cd51026f..cdb0ce794bb7 2020-07-16 fancl@chromium.org auto-triage: Update issue summary when new alerts are added If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1103384 Tbr: oysteine@google.com Change-Id: I40589250018d74f0dcea12c2fa398ce9fec05540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789005}
-
Vasilii Sukhanov authored
We use it for our dashboard. Fixed: 1105026,1105071,1105072,1105073 Change-Id: I66e47054d610615669648b666f01f3ec630561c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299228Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789004}
-