- 14 Nov, 2019 10 commits
-
-
Azeem Arshad authored
This CL adds aria labels for host and port input fields in manual proxy configuration section in network details page. Also adds labels for proxy exception input field. Bug: 1024355 Change-Id: I0fe751e248b9f51916d83bb5ca7ae92ee14ac3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913097Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715121}
-
Anand K. Mistry authored
Also convert usages of Bind -> Bind{Once,Repeating}. Bug: 1007814 Change-Id: Ib242b593fe7b0870bf5953fa5e614aa092aa6a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913233Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#715120}
-
Steve Becker authored
Updates FileSystemDirectoryHandle.getSystemDirectory() and chooseFileSystemEntries() to reject with a SecurityError when called by a sandboxed window. This change also adds a WPT test that accesses the NativeFileSystem from opaque origins. The test includes a data URI iframe, sandboxed iframe and a sandboxed opened window. Unlike sandboxed iframes, for data URI iframes, the NativeFileSystem API is undefined because data URI iframes do not provide a secure context. This change gives the NativeFileSystem the same behavior as other web platform storage with write operations. LocalStorage, indexedDB, and cacheStorage all fail with SecurityErrors when accessed from a sandbox. However, sandboxes can read files using <input type=file> and drag&drop. In the future, if a read-only sandbox scenario emerges, we can consider loosening this policy for the NativeFileSystem. Bug: 1014248 Change-Id: Ibeafcdbf102275f2cd45f3cd7dbd8ed592c850c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907278Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Steve Becker <stevebe@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715119}
-
Anand K. Mistry authored
Bug: 1007814 Change-Id: I6f3bfac9b4a0d68a53339aef8471fae379c924c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913234Reviewed-by:
-
Ahmed Mehfooz authored
The order of the stacked notifications icons can be broken if a notification is added / removed from the middle of the stacked notifications. This fix prevents it by removing a notification's icon through id lookup when a notification is removed and resetting the notification_icons_container_ if a new notification is added while the tray is open. Change-Id: I108c983dcb1b42be67354598064e5e1daa299697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913877 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715117}
-
Xianzhu Wang authored
We create multiple FragmentData objects for all fragmented layout objects, not just self-painting layers. Change-Id: Ib95bda3415b3bd7570f74f26746adcea8c35eafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913096Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715116}
-
arthursonzogni authored
about:srcdoc document is always loaded inside an iframe and is same-SiteInstance with its parent. This is checked in CommitNavigation. As a precautionary measure, this initially landed as a DumpWithoutCrashing() to avoid hurting canary/dev/beta users if those check were violated. It was planned to remove the DumpWithoutCrashing for M79 if there was no reported DumpWithoutCrashing. There are none of them: https://crash.corp.google.com/browse?q=product_name%3D%22Chrome%22+AND+STRPOS%28expanded_custom_data.ChromeCrashProto.magic_signature_1.name%2C+%27CommitNavigation%27%29+%3E+0+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3ARenderFrameHostImpl%3A%3ACommitNavigation%27+AND+product.Version%3E%3D%2778.0.3904.63%27&stbtiq=&reportid=70db5bbe497238ba&index=9#4 Bug: None Change-Id: Iee51ddcb31fd3a7b1b7155c02f726e24c160f31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913401 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#715115}
-
Brandon Wylie authored
Bug: 1022504 Change-Id: Ia1d34e69ed8d90fd17bb74207f38d48770d2e0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904765 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#715114}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9e7107eb96af..321c12255e73 git log 9e7107eb96af..321c12255e73 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 cwallez@chromium.org Remove the "Base" from pure-frontend dawn_native types Created with: gclient setdep -r src/third_party/dawn@321c12255e73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I5ca499d938b09fe467df5e10e8af7d142f11fa00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914615Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715113}
-
Josh Karlin authored
Reverted in https://chromium-review.googlesource.com/c/chromium/src/+/1906860 What changed: I missed a test that needed to be updated. TBR=csharrison@chromium.org Change-Id: I2621da585a94b31a11730bd7f64492a525ab648e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914972 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715112}
-
- 13 Nov, 2019 30 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f32a29a69b4..6006105f67c3 git log 4f32a29a69b4..6006105f67c3 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 csmartdalton@google.com Implement mixed samples support in vulkan 2019-11-13 csmartdalton@google.com Enforce extra constraints for mixed samples at GrCaps level 2019-11-13 emircan@google.com Disable VkProtectedContext_DDLMakeRenderTargetTest Created with: gclient setdep -r src/third_party/skia@6006105f67c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I29f4ac39facf9a2e7010b265e4f43275867383d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914614Reviewed-by:
-
Karan Bhatia authored
This helps debugging in tests when some rules fail to index correctly. BUG=696822 Change-Id: I38be0f707e7de7b5a4be49aacb037b7d9bd42fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911279 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715110}
-
Ana Salazar authored
Measures Presentation Time and Max Latency on Clamshell and Tablet Mode. On Tablet Mode we also measure in-app and not in-app shelf. Bug: 1020386 Change-Id: I03bfe4fb1422195326fe3ce46280b7cb45a45846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910878 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#715109}
-
Ovidio Henriquez authored
This change converts all of the uses of base::Bind and base::Callback in device/bluetooth/device.{cc,h} to use the Once version. This is part of the Chrome Code Health rotation. Bug: 1007780 Change-Id: Ie1a19a4447c777ab7ecd067da695bda0a2566a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900665Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#715108}
-
Rob Schonberger authored
This is the actual parameters of the model that is checked in, rather than the current 1/1. I.e. there's a bug in submitted code that shows when executing. Apologies. Bug: 1009290 Change-Id: I3bcbe8eed8a81cb6979029f5f52f350b50c2e765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913683 Auto-Submit: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#715107}
-
Dan Beam authored
Partially borrowed from https://crrev.com/c/1836021 by Archana Simha <archanasihma@chromium.org> Bug: 1020025 Change-Id: I7de22a41d872ec624f25d1633782d27448988c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893824 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#715106}
-
Sammie Quon authored
Gave the parent a rect that has x-bounds, but still using the parent's parent width, resulting in a overflow. Test: manual Bug: 1020539 Change-Id: I983cf0813c6b99a74960761c8c8fd241b2995e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914942Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715105}
-
Alice Boxhall authored
Bug: 1015529 Change-Id: I59c9991f3fd50582553883d4d27668960b4a6481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911064Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715104}
-
John Williams authored
Bug: 972751 Change-Id: I37adf77ed0c9de8f73d2467f2d57f7db0ba9df10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770433 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715103}
-
rbpotter authored
Autogenerate a JS module version of FindShortcutBehavior, its dependencies (KeyboardShortcutList), and its browser test. This is a prerequisite for migrating pages that depend on this behavior to Polymer 3 (e.g. bookmarks). Bug: 1022213 Change-Id: Ifbf2680c5f044474de68b11da9a434c96a13381e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913510 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715102}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9dab499b2b5b..fa6d4dc30478 git log 9dab499b2b5b..fa6d4dc30478 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 alexclarke@chromium.org Add android-weblayer as a target browser Created with: gclient setdep -r src/third_party/catapult@fa6d4dc30478 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1022812 Change-Id: Ie7fa454800e8f1010a2b99ef1cfcee6da4976c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914612Reviewed-by:
-
Peter Kasting authored
This makes it clearer (everywhere) that the animation is simply animating the alpha value of a single alert color. Bug: none Change-Id: Iad30d326dd3af811cc0e065d10ef637d32e5a94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914963 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715100}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c062acf6a20a..d85c18b05dcf git log c062acf6a20a..d85c18b05dcf --date=short --no-merges --format='%ad %ae %s' 2019-11-13 dburger@chromium.org Stop scheduling master-paladin. Created with: gclient setdep -r src/third_party/chromite@d85c18b05dcf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I85d42e47f6e7b2788c6d63c40b54fb3bf291cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914611Reviewed-by:
-
Dominic Mazzoni authored
TalkBack doesn't yet consume these yet, but this matches the same way native Android TextViews expose misspelled words, whether from typing, or from dictation with multiple suggestions. Bug: 524654 Change-Id: I3a78b78f12a5a9c67b15718422d7c3c6cc524376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881695 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#715098}
-
Tommy Steimel authored
This reverts commit fdf71331. Reason for revert: compile failure:https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf/129178 Original change's description: > Move DownloadManagerBridge to chrome/browser/download > > Part of the modulization effort. > > Bug: 1013759 > Change-Id: I3a250fb293925ebe3c98fc068003b32568112ff9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902072 > Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715066} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org Change-Id: I8751d6528d8b800a409657b3fdbd9a8c7897e0ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1013759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915219Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715097}
-
Sasha McIntosh authored
When working with YUV images, uses the stride of the plane when creating pixmaps for each plane. Bug: 919627 Bug: 1023090 Change-Id: I1bf1dd5f0ac96a2eac5a8f4bb2f73453042fe7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906954 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715096}
-
Yulun Wu authored
Bug: 1024509 Change-Id: Ic34e1871aa9b828926f22b847e9001f2c5a2aa8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914971Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715095}
-
Reilly Grant authored
This collects effectively the same data but uses the more modern infrastructure. Bug: 1017844 Change-Id: Ibafe3991d5129faf0481bef7acb8e7cd157cae12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895946 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715094}
-
wutao authored
When AssistantCardElementView is focused, the true focused item is a node in the contained web contents. We override ScrollRectToVisible() to defer the scroll to FocusedNodeChanged() called by the contents. In addition, when View::HandleAccessibleAction(ax::mojom::Action::kScrollToMakeVisible) is called on AssistantCardElementView, it will scroll to currently focused node. Bug: b/143370952 Test: manual Change-Id: I315db0131e5517bf98d3e76f41203d00555237b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902709 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715093}
-
Eric Roman authored
Bug: 1021236 Change-Id: Id7dccac2d79abd3f03806679edb08dd8c1de4a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904764 Auto-Submit: Eric Roman <eroman@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Chris Mumford authored
Also switched leveldb_chrome::Globals::memory_pressure_listener_ from std::scoped_ptr to inline member to reduce heap fragmentation. Bug: 1007837 Change-Id: I680b34ec71a3876c0137c957a1aec91a83632396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909295Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715091}
-
Jason Chase authored
This was using the JSONReader::ReadDeprecated(), so replaced that with Read(). Also replaced usage of deprecated base::DictionaryValue and associated methods. Change-Id: I097f6117b1e267ab939ee8c58ca16d9103d76975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914029Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#715090}
-
Mitsuru Oshima authored
Bug: 843354, b/141898654 Test: covered by unittest Change-Id: Ib92013f3e0721c054c94981d93a8b2167076fa8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911100Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#715089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ba6deba4dfb..f901c4c03461 Created with: gclient setdep -r src-internal@f901c4c03461 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I482ade155e317a5c0e4555a4a1445d77d52913d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914609Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715088}
-
Toby Huang authored
Add a TODO comment to fix the logic in ExtensionSyncService::HasPendingReenable() in the future. This is a follow-up CL to address the remaining issues in the prematurely committed crrev.com/c/1861280. Bug: 1019813 Change-Id: I00a57eaa4f04d64a34902240ce0e31fe8cbeddeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890726Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715087}
-
Scott Violet authored
This is called when a tab opened by way of window.open() is asked to close (window.close()). BUG=none TEST=covered by test Change-Id: I0d97069faed7a77edfef2e2932328e271d5d6db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913601 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#715086}
-
Gang Wu authored
Change-Id: Ia9bcb02d21d1b44605857cad4d74f0ded44e2d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914962Reviewed-by:
-
Yue Li authored
Bug: b/144074713 Test: Manual Test Change-Id: I0ab1cf17c45ee0e3a468c5cd2a5fe6524b813728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913700Reviewed-by:
-
Joshua Pawlicki authored
Bug: 1007393 Change-Id: I49a1269a45ccbe3f5da67db2ec8adfc03ddd1d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893496Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#715083}
-
John Lee authored
https://imgur.com/a/O5kt6EL Bug: 1023492 Change-Id: I9a84da205c979c4631fccee4a9c3dd8d249bce25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912883Reviewed-by:
-
