- 30 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/24bd418544c6..7030291356e4 2020-10-30 dproy@chromium.org Add a way to skip tests 2020-10-30 robdclark@chromium.org Add msm gpu trace support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111537 Tbr: nuskos@google.com Change-Id: I44e9523ff00eb9f4611df3be33e2777f36ce5ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822567}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604015897-cbf2d5639eb5b5579fe2658cc59cbce3c1075df1.profdata to chrome-linux-master-1604037316-5cbbc085308516b08a183c882c2ebb61cfb969d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If7d5490ecb7a4188522dfed14256f1b79c43ca03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509038Reviewed-by:
-
Mikel Astiz authored
The predicate that determines whether sync allows uploading demographics metrics now adopts GetUploadToGoogleState(), which is the standard way to implement this kind of logic. Note that the patch can have behavioral differences because it's more strict. These changes are expected to be very small and even desirable, for example: 1. If user manually disabled sync-ing of preferences, then the new predicate will return false. 2. If there is permanent auth error (other than user signout, which was already handled before), the new predicate will return false. Change-Id: I05f1c93ba6028cc4c91b790fd142b494d499d837 Bug: 1137346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467519Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#822565}
-
Xiaodan Zhu authored
This CL implements an alert bubble to prevent fake login. When a device returns from sleep or low brightness and the active window is fullscreen. Others can utilize the fullscreen window to imitate the lock/login screen to steal user's password. To prevent this, we generate an alert bubble to remind the user to exit fullscreen before entering the password. The users can also use the button in the bubble to exit fullscreen. Bug: 1107185 Change-Id: I181f1173777ada1ec45fe7148e7dc889668d6753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505335 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822564}
-
Omar Morsi authored
This is a reland of CL:2435386. It was reverted in CL:2507465 because it broke linux-chromeos-rel (see https://crbug.com/1143713). The main reason was real work being done in a DCHECK in key_permissions_manager_browsertest.cc Original CL description: > This CL introduces KeyPermissionsManager (KPM). KPMs are responsible for > managing platform keys permissions by reading and writing permissions > into chaps keys' attributes. > > Bug: 1113115, 1127284, 1082459 > Change-Id: I5d242604fe784566d086d2012313f77ca0fdbc44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435386 > Commit-Queue: Omar Morsi <omorsi@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Edman Anjos <edman@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822131} TBR=asvitkine@chromium.org,edman@chromium.org Bug: 1113115, 1127284, 1082459, 1143713 Change-Id: I6f482bd06cf4801299ea28210fcb1498f38f57fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507712 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#822563}
-
Antonio Sartori authored
The PolicyContainer is a property of the RenderFrameHostImpl that stores several security policies. This CL mirrors the PolicyContainer in Blink in the LocalFrame on creation. There are several paths for frame creation (some are started by Blink, some by the Browser), and this change covers all of them. Additionally, the LocalFrame's PolicyContainer is wired via a mojo remote to the RenderFrameHost counterpart. Change-Id: Ia058d4dde077b9cb9dd51f891155ef1849d60afa Bug: 1130587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428242Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#822562}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3c2eb0f04c8..0eec65e17008 2020-10-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0290c2bcaef4bf2427e35bf6b324ee95d36f556b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509034Reviewed-by:
-
Asami Doi authored
This CL removes RunOrPostTaskOnThread from ServiceWorkerContainerHost because a service worker runs on the UI thread now. Bug: 1138155 Change-Id: I4b9d7631011f0fb9f7a294c4af68ba16a0fb9eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507301 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#822560}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb00c0bc74ca..7ce259ef71f7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: Icefe7de68e69678167a4e4f45f2f9c1a69abc183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508658Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822559}
-
Tal Pressman authored
Wrap the message in a unique_ptr to make sure it isn't leaked, if some branch doesn't pass it on to another sender or delete it. Also change a conditional NOTREACHED to a DCHECK following the style guide[1]. [1] chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#check_dcheck_and-notreached Change-Id: I149d2b28d462be32b7170c0b8973fe74ad74ed6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507277Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#822558}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e8dff372902f..75ae62960411 2020-10-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ie4b1f841baf972df38c8487a2fa6667ce0d81844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508564Reviewed-by:
-
Kent Tamura authored
https://drafts.csswg.org/css-pseudo-4/#placeholder-pseudo > All properties that apply to the ::first-line pseudo-element also > apply to the ::placeholder pseudo-element. https://drafts.csswg.org/css-pseudo-4/#first-line-styling > User agents may apply other properties as well except for the > following excluded properties: > * writing-mode > * direction > * text-orientation Bug: 1144040 Change-Id: Ia8c74ec80a7d94dc11053e4d95e3facae148f094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509073Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#822556}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2be25f08deaf..e6c9497255c6 2020-10-29 capn@google.com Fix LLVM pointer element type 2020-10-29 capn@google.com Avoid false-positive MSan error for thread_local 2020-10-29 capn@google.com Update Marl to 3285a2dfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I453d1bf73dbf6fbb5af2b844e181e4cd82aedb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508710Reviewed-by:
-
sandromaggi authored
So far we could not determine whether or not we *expected* the field to be empty: `!match_success && not_empty` is ambiguous. It may mean that the field had a value we didn't expect ("Default" instead of "Changed") - or - it may mean the field had a value and we didn't expect that ("Default" instead of ""). This CL adds explicit |expected_empty| reporting to check if a field could successfully be cleared. This CL also changes the reporting of |match_success| to only be added if we had an expectation (otherwise the success is pointless). Bug: b/169924567 Bug: b/171860312 Change-Id: Ifd01b445529ac1720b8bf74c48c94c83789ada3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506180 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#822554}
-
Stephan Hartmann authored
Building with use_x11=true and use_ozone=false fails, because it includes unneeded //ui/ozone dependency. Change-Id: Ia35af9adec1d530bd77db251435f6e0a0261d333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506446Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+2) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#822553}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/. Bug: 1143194 Change-Id: I1cb4fec2479d845c9f288cf03215e36cdd029949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508131Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#822552}
-
Ian Kilpatrick authored
This change simplifies how we determine the position of children within a -webkit-box. -webkit-box is special as any overflow always "hangs" to the line-right. This patch adds any negative available-space instead of performing a more complicated "flipped-offset" calculation. There should be no behaviour change. Change-Id: Ic204e2e2167b88a7fd1ab02c2ec5cff4d0355ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508029 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822551}
-
Ian Kilpatrick authored
In preparation for: https://chromium-review.googlesource.com/c/chromium/src/+/2490323 There should be no behaviour change - just moving things around to reduce deltas of subsequent behaviour changing patches. Change-Id: Iac5714cb492cfaf7b2dc5117cb39d4f1b7b9b452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507336 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
chrome://inspectFrançois Beaufort authored
This CL makes sure local presentation pages (1UA cast and wired display fullscreen tabs) are visible in chrome://inspect. It also now uses one single prefix for the OTR profile for both types of local presentation pages. Change-Id: I65603c8258104d8c3219b1ba611780a82aa844cc Bug: 840029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498588Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#822549}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/646cf5b2dabd..39b777c6f00f 2020-10-30 jmadill@chromium.org Capture/Replay: Two cleanups. 2020-10-30 ynovikov@chromium.org Skip InstancingTest.NonIndexed* with non-zero Offset on Mac Mini 8.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I929558de220d3c0319fada6e6bcac6f693805753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508979Reviewed-by:
-
Takuto Ikuta authored
Bug: 1142713 Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#822547}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4691b0f82bd0..8a6bdf14d215 2020-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from a584311a6a73 to 25eb373eede4 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I0d277684b1cf7bfb579c770b4b98d9dc7c0d6eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508980Reviewed-by:
-
Jan Wilken Dörrie authored
This change adds a base::sorted_unique tag to the constructors of base::flat_tee, allowing callers to skip the sort and unique step if this is not necessary. Bug: 682254 Change-Id: I7b0c210e8bca56fcbba5840e0aaf214c185b60bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494941Reviewed-by:
-
Noel Gordon authored
Add a files app SWA integration test: test that files app SWA loads in the files app browser test harness. Remember the SWA web_contents so we can shut it down at the end of the test. Supports only one running files app SWA instance for now. Test: browser_tests --gtest_filter="*launchFilesAppSwa*" Bug: 1113981 Change-Id: I78b4fafab57622fecc134b009858554bdcb05126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507316 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#822544}
-
Wei Lee authored
Since we use web assembly when doing MP4 encoding, it should be extracted to untrusted context. Bug: 980846 Test: Record video works on both version of CCA (Platform app/SWA) Change-Id: I8267e32be560b571c74751ebff04eba09057aeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352264 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#822543}
-
Yoshifumi Inoue authored
This patch changes |ShapeResult::CopyRangeInternal()| to copy |is_applied_spacing_| flag to source to copied |ShapeResult| to prevent reusing them. Background: In |NGInlineNode::ShapeText()|, we shape text as much as possible, eg. using same font like "abc <u>def</u>", then split |ShapeResult| for each DOM node, e.g. "abc " and "<u>def</u>" by using |ShapeResult:: CopyRange()|, uses |CopyRangeInternal()|. Before this patch, each copied |ShapeResult::is_applied_spacing_| is false because we forgot to mark it. Bug: 1124446 Change-Id: Ibc0601f214a166c6cfd0a713d79ffa60fafb66ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507244 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#822542}
-
Christopher Cameron authored
The ScopedAccessPermission argument to OnIncomingCapturedExternalBuffer is no longer used, now that GpuMemoryBufferTrackerMac keeps the buffer from being reused via its gfx::ScopedInUseIOSurface. Remove the argument and its many entrails. Bug: 1125879 Change-Id: I58c7a74621f09a0bbb4524f55ee2a740179e14de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505457Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#822541}
-
Kuo Jen Wei authored
Add |subSettingOpener_| field for remembering the element opening sub setting, and focus back to sub setting opener when go back from sub setting. Bug: 1010852 Test: Manually Change-Id: Idce60f8051abf6f5c8fdd6c68b58462a5afcb655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505363 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822540}
-
Greg Thompson authored
r798844 introduced the idea of reporting a 32-bit metric via ExtraCode1 on success. This CL generalizes the strategy gently so that it's easier to use for future changes. It also removes a duplicate definition of the PathString type. BUG=none Change-Id: I4a4b87a8bd91a0d9083f47b6786598c290122033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508591 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#822539}
-
Greg Thompson authored
r798844 introduced a metric to report whether or not the work directory was created in CWD or %TMP%. Sadly, the metric unconditionally reported that the fallback was never used. BUG=516207,1100280 R=wfh@chromium.org Change-Id: I64140cac44dde7baf029e03c31e460a91fa177b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508611 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
Alexander Dunaev authored
The Linux implementation of //ui/base/idle was X11-only and was not aware of Ozone. This CL fixes that by moving the necessary pieces from //ui/base/idle to //ui/base/x and extending the Screen and PlatformScreen interfaces with two methods: IsScreenSaverActive() and CalculateIdleTime(). Bug: 1098201, 1098202 Change-Id: I5ab4dcde323562000b3b3870a778ba3515a774d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504234 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#822537}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 561e62bd. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ie0c173685c0c28693cd5a5c10b378b8bf10665f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507388Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822536}
-
Nico Weber authored
Over time a bunch of suites got added to chromium_linux_gtests but not to similar lists that run on memory bots. Fix this. This adds this list of tests: - openscreen_unittests (*) - weblayer_browsertests - weblayer_unittests - x11_unittests - xr_browser_tests to the following bots: On chromium.memory: - Linux ASan LSan Tests (1) - Linux CFI - Linux MSan Tests - Linux TSan Tests On chromium.clang: - CFI Linux ToT *: openscreen_unittests currently fails on msan and cfi, so it doesn't add them to the msan and cfi bots, see crbug.com/1143946 and crbug.com/1143983 FYI: jophba for openscreen_unittests, https://chromium-review.googlesource.com/c/chromium/src/+/2432762 msisov for x1_unittests, https://chromium-review.googlesource.com/c/chromium/src/+/2228652 bsheedy for xr_browser_tests, https://chromium-review.googlesource.com/c/chromium/src/+/1478403 jam for weblayer_*tests, https://chromium-review.googlesource.com/c/chromium/src/+/1865684 Bug: 843511,1025244,990756,933606,1143946,1143983 Cq-Include-Trybots: luci.chromium.try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: I64048744649d74e0ab6790f732e06bbcdd42f5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507489 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#822535}
-
Trent Apted authored
Use chrome::GetChannel() and feed in a default value for the "flagsMenu" feature via loadTimeData. Fixed: b/170423915 Change-Id: I90294f80a6bb8f650c78f2f77061b3717e734e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507417 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#822534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85b44b21edd6..eb00c0bc74ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC johannkoenig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: johannkoenig@google.com Change-Id: Ie4cc5068eebcb6ea6f14a8793eaa0e798b438e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508514Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I9fdbd36658baa76aa8b19b422060da5fd91a50f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508560Reviewed-by:
-
Kent Tamura authored
A textfield INPUT element has one or two block children; - Optional ::placeholder - TextControlInnerEditorElement or ::-webkit-textfield-decoration-container We need to lay out the latter first because the former's baseline should be aligned to the baseline of the latter, and the former should be painted earlier than the latter. This CL is a preparation to implement it. * NGContainerFragmentBuilder::AddChildInternal() inserts the fragment for ::placeholder before another child. * NGBlockLayoutAlgorithm::Layout() lays ::placeholder out after other children. This CL has no behavior changes. Bug: 1040826 Change-Id: Ib8768194c2a7e86cb162cb4470eac9881a22d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503379 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#822531}
-
Joe Mason authored
Moves base classes and helper functions for V8DetailedMemory testing from v8_detailed_memory_unittest.cc to v8_memory_test_helpers.h. Use the shared helpers to move the WebMeasureMemory test to web_memory_aggregator_unittest.cc. R=chrisha Bug: 1085129 Change-Id: If01be575a07280ab610a641fc183ab96c64dea69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503308 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#822530}
-
Lu Huang authored
These changes enable the 'url_handlers' member in the web app manifest to be parsed. This is the first of a number of CLs that will allow progressive web apps to be launched to handle or "capture" https URL activations. Please refer to the crbug for links to the design doc and overview "uber-CL". design doc: https://docs.google.com/document/d/19dGklalQTRtRrG3PKrVbDRmYPLHGLnsGEwUaed7sAFQ/edit?usp=sharing design overview cl: https://chromium-review.googlesource.com/c/chromium/src/+/2393252 Chrome status: https://www.chromestatus.com/feature/5739732661174272 Bug: 1072058 Change-Id: Ic8251bf74e0a17cd147d4d46389e66f7576c1763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405696Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Commit-Queue: Lu Huang <luhua@microsoft.com> Cr-Commit-Position: refs/heads/master@{#822529}
-
Darren Shen authored
Right now, all the logic is in DecoderEngine, which is the primary engine used for the IME service launch. To avoid breaking this important launch with WIP code, move the WIP system PK code out into a separate engine that is only used when the system PK flag is enabled. Bug: b/161490915 Change-Id: I2b2352c88d3276e7d79f17cc4b8afbe14328453a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498021Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#822528}
-
