- 15 Apr, 2020 40 commits
-
-
Lei Zhang authored
In order to do so, add a new AddResourcePathsBulk() variant that takes a span of GritResourceMap entries. Change-Id: Ie3907bf811b654904ad9c650c53b30db7d9fdff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150072Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#759393}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 01d5f76e. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." c21ee9b0 "[css-masking] Migrate clip-path-descendant-text-mutated.html to WPT" 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 231c063a "[css-grid] Migrate whitespace-in-grid-item.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: If6bc9723c4cd2507d97ae4a3792e66dacdd64bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150675Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759392}
-
Matt Menke authored
In particular, make GetNormalizedHeader() and RemoveHeader() and take StringPieces. Both are already calling StringPiece-friendly methods internally, so this should reduce copies slightly. Also make a number of methods take a "base::StringPiece" instead of a "const base::StringPiece&". Bug: 1068194 Change-Id: I7a27d505a8f5c20ddb5c1313b9de4f2cb1069dec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149690 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759391}
-
dpapad authored
These files are purposefully not compressed, since unpack_pack.py does not support decompressing files. This is part of a series of CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I2467173ec95bd5086fbbde262dc5206d9112b032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149638Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#759390}
-
Elly Fong-Jones authored
The Views subclass is now the only subclass of the original base class, so fold the base class into the Views implementation. This reveals a few unused methods on the delegate interface itself and some other simplifications that will come in a followup CL. Bug: 1070331 Change-Id: I223f32b784c85c406b1dd82116bf19cf5360ee86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148020 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759389}
-
Devlin Cronin authored
ExtensionInstalledBubbleView tests didn't pass with the ExtensionsMenu enabled. Fix them (by waiting for the bubble to show - it doens't happen immediately because the extension slides out of the menu), and parameterize them so they run automatically on both the old and new UI. Bug: 943702 Change-Id: I1ed98e80b7ce8c312c82e2d01cc2ba05bcee5f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150058Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759388}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that repeat(auto-fill, ) syntax works as expected inside grid layout. Bug: 1063749 Change-Id: If837131b95e0583a965ae1468f6072537b589ad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147402Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#759387}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1a9c8db7e7c..fc5e10322119 git log e1a9c8db7e7c..fc5e10322119 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 agrieve@chromium.org Fix "git freeze" failing on broken symlinks Created with: gclient setdep -r src/third_party/depot_tools@fc5e10322119 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071066 Tbr: agable@chromium.org Change-Id: Idd255d88f409419be113f17df3a4832ecfb1952f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759386}
-
David Van Cleve authored
This CL adds a new switch, --additional-trust-token-key-commitments, and updates TrustTokenKeyCommitments to read its default commitments from the switch's value (via the key commitment parser). This is useful for automated testing; it's also useful for playing around manually with Trust Tokens functionality in environments without access to the component updater, or against Trust Tokens issuers whose keys aren't being shipped through the updater. R=csharrison Bug: 1068651 Change-Id: If6483d4210856d91665784e730a4af31ee3558af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144412Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759385}
-
Sebastien Lalancette authored
- Created helper file with function to create the UIImage. - Added unit tests to validate the generated image. - Added the generated QR code image to the QRGeneratorViewController. - Added portrait/landscape constraints. Bug: 1064990 Change-Id: I79038e3119be5ea9be1f1af5143dc3d1f4c8821a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136042 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759384}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ff1d841f6cc..0f1f87d7bd4b git log 9ff1d841f6cc..0f1f87d7bd4b --date=short --first-parent --format='%ad %ae %s' 2020-04-15 reed@google.com transition matrix44 to opt-in only 2020-04-15 mtklein@google.com report all test errors in fm 2020-04-15 herb@google.com Schedule using tree order traversal the DAG. Created with: gclient setdep -r src/third_party/skia@0f1f87d7bd4b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: If377335460731b234bef1b0a6f1056c127c92f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151068Reviewed-by:
-
David Bertoni authored
The LaunchWebAuthFlowFunctionTest.InteractiveSecondNavigationSuccess test was disabled in 2014 when it was only flaky on MacOS. The flake seems suspicious and was never investigated. I will monitor this test to make sure it's OK on MacOS and disable it only on that platform if necessary. Bug: 377624 Change-Id: I925aaa4a04d01b1a4ce30160feeb17ee1aa83bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149912 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#759382}
-
Sean Harrison authored
update the banner images on the security, cookies, and permissions settings subpages Bug: 1032584 Change-Id: Ibb0c6d7f7b8eb1a31487746baf6f774ff6c2e3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150427Reviewed-by:
-
Neha Gupta authored
This CL adds ability to tab across links and highlights (along with already supported widgets) behind a newly added feature flag kTabAcrossPDFAnnotations. This is done by calling the newly added PDFium API FPDFAnnot_SetFocusableSubtypes(). A unit test has also been added to validate the added support. Here is the related CL: https://pdfium-review.googlesource.com/c/pdfium/+/60011/ Bug: 994500 Change-Id: I00312c00f3e6373949a4723cc65778fdb32ab963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783695Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Neha Gupta <negupta@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759380}
-
Eugene But authored
-[AppState applicationWillTerminate:applicationNavigation:] crashes on dereferencing null or invalid pointer returned from ios::GetChromeBrowserProvider(). GetChromeBrowserProvider returns pointer to an object created in application:didFinishLaunchingWithOptions:, so there are 2 possible explanations for this crash: 1. application:didFinishLaunchingWithOptions: was not called 2. there is a memory corruption (which is inlikely given the high volume of crashes with this particular stack) This CL should workaround the problem if root case is #1 and logs histogram to understand how often GetChromeBrowserProvider() can return null. Bug: 983504 Change-Id: Idfd5b22d0319cba5e1a38f78020d6fca1e01529c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145968 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:Brian White <bcwhite@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759379}
-
Kai Ninomiya authored
Change-Id: Ic7e2fa7612652cbb86b2be07ce10d9bea3ce194d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151330 Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759378}
-
bttk authored
RecordHistogram can now be used without native. Bug: 1069507 Change-Id: If4a6dd84b510f021f6e690df7e6e8d112e031caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148042Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#759377}
-
Siyu An authored
Add an experiment flag and change the navigation logic for upstream bubble and card migration bubble. New sets of metrics will be added in the following CL. Bug: 1070799 Change-Id: I7c81b1b568ea10c179c402aeb9be9a3002496370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149696 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759376}
-
Kurt Horimoto authored
TabHelperDelegateInstaller is a utility class template that sets up delegates for tab helpers for all the WebStates in a Browser. Now that OverlayPresenter can be used to implement tab-specific UI functionality, tab helpers can show UI without delegating this functionality to coordinators. This coupled with the increasing usage of BrowserAgents in preparation for multi-window support means that more tab helpers will be using Browser-scoped C++ delegates implemented in BrowserAgents. Bug: none Change-Id: Ieed54409bcfb228685baa417ad4fdc7d3e3f45b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Taylor Bergquist authored
Revert "Tab strip ideal bounds are calculated from the available width instead of the current width." This reverts commit d091784a. Reason for revert: caused crash regression https://bugs.chromium.org/p/chromium/issues/detail?id=1070980#c1 Original change's description: > Tab strip ideal bounds are calculated from the available width instead of the current width. > > This obviates the need for the work described in > go/chrome-nonpredictive-tabstrip-animations. > > One known issue: with stacked tabs enabled, resize a window to trigger > a transition into the stacked layout. The tabs will animate into the > new layout, and while this is taking place, they will ignore any > further changes to the tabstrip's bounds. > > Further work: Continue removing now-dead code from the new animation > system. > > Bug: 958173 > Change-Id: I977b3836ad87647fa17e431a1215ebd1ce81727c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055544 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759054} TBR=sky@chromium.org,pbos@chromium.org,tbergquist@chromium.org,connily@chromium.org Change-Id: I4b995aeb6515aa675442e4cf69a4a4d0be48e840 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151425Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#759374}
-
Antonio Gomes authored
BUG=767015, 1063749 R=svillar@igalia.com Change-Id: I727fd772a631c03e038da4687881d3f9ec707ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144250 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Aaron Leventhal authored
It's a performance bottleneck. It was originally added here: https://codereview.chromium.org/1195353002 - but the test added then still passes without this code. I tried reverting some other recent patches but I can't pinpoint what made it start working. We re-landed this a year ago and it caused crashes on the index.html page for the built-in PDF viewer extension, specifically on Mac. We should try relanding and determine the actual cause of that crash if it occurs again, since we know what page causes it. Bug: 489590, 579199, 916936 Change-Id: Ic142d7ac2711698513069bdda5376920a8e00bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148035Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#759372}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2a94f532d738c88f24b6dc7fa4fa2f8d990a421e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150400Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#759371}
-
Harald Alvestrand authored
This simplifies the class hierarchy; the class is no longer used outside of modules/peerconnection. Bug: chromium:787254 Change-Id: Iff526b1ef1d6d324c67b72ff3e1420ccd1f0ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144025Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#759370}
-
Bryan Clark authored
We don't have support for alsa on borg, so this is needed to prevent an endless stream of alsa related errors. Bug: b/151360165 Change-Id: I765b98d637ed1741c16069024160c5748ec6cde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150032 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Bryan Clark <bryanclark@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#759369}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97d22cb8bd41..9f64a3e1686e git log 97d22cb8bd41..9f64a3e1686e --date=short --first-parent --format='%ad %ae %s' 2020-04-15 tross@microsoft.com Fix check-type-closure for serverless Java installs 2020-04-15 livvielin@chromium.org [DevTools] Improve Security Panel color contrast Created with: gclient setdep -r src/third_party/devtools-frontend/src@9f64a3e1686e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1062409 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0514e23457023b32157f7c7b4d2c7106d68dc9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151065Reviewed-by:
-
Kurt Horimoto authored
This CL refactors the browser container to use a mediator and consumer. The BrowserContainerMediator observes presentation of HTTP authentication dialogs. If one is presented from a different host than the rendered page in the content area, a blocking view is inserted behind the HTTP auth overlay to block out the page. In order to support this change, a URL is added to the OverlayRequest config so that it can be compared with the last committed URL of the Browser's active WebState. Bug: 1063690 Change-Id: I21c7abe83818180762e3a2dda6f764ea635ee42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136232 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Ben Joyce authored
This CL needs to land first: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2886688 Bug: 1070424 Change-Id: Idf685c8a428e90520c752f734c8d63172098b9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150767Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#759366}
-
Jesse Schettler authored
This reverts commit f64a6c0a. Reason for revert: Logging no longer needed. Original change's description: > arc: Add logging to investigate ARC print failures > > Print preview occasionally fails in the arc.Print tast test. Add logging > to investigate these failures. > > Bug: b:152251595 > Change-Id: I5b8b18213ec8c7fc2a56646c65dfe5262b86f677 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144456 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758262} TBR=thestig@chromium.org,jschettler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:152251595 Change-Id: Iaaa10289a1ba47b7415b1fa820702d9791ad19ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150817Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#759365}
-
Sigurdur Asgeirsson authored
Bug: 1068233 Change-Id: Iac17d0b65f6b9c996b5b4e35b97c5bb5d79a211b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150063Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759364}
-
Becca Hughes authored
Add a histogram to store the safe search result. BUG=1024362 Change-Id: Ie6b7cf349f502f85b1ba39103092a56879671643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137584 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#759363}
-
Rune Lillesveen authored
When color-scheme affects other CSS properties, invalidation diffing those properties are sufficient. However, some parts of UA rendered UI elements are painted based on colors not defined in CSS. Invalidate paint when the used color-scheme value changes so that such elements are properly repainted on color-scheme changes. Bug: 929098 Change-Id: Icedafd9fa1d787b4db64e6d698ecfcdc144a4ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150905Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#759362}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b26c7ec23a..6732305714ca Created with: gclient setdep -r src-internal@6732305714ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1005895,chromium:1019685,chromium:2877672 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: Iceaad3d6b2f4b417544ee4cb2841d91f1163cfd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149942Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759361}
-
Clark DuVall authored
This splits chrome-specific logic into ChromeContentSettingsAgentDelegate, and moves common logic into //components/content_settings. This will allow sharing the content settings agent with WebLayer. The unit test for WhitelistedSchemes was moved into the browser tests, which means we no longer need a static version of IsWhitelistedForContentSettings() just for testing. Bug: 1065537 Change-Id: I99d401542497e3c180e7ff5024adcb3691d84e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142636 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759360}
-
Jeffrey Cohen authored
Bug: 1036023 Change-Id: I4bb00ab9185e03b08ec1204f82049270f86eb214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148242Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759359}
-
Alexander Cooper authored
Describes the source of the two static_initializers so that anyone who adds a new one can more easily diagnose which is theirs. This is especially useful when the new static initializer may come from a lib or other such code being linked in that the developer may not be familiar with. Change-Id: Ibaecb74f66f87d83bc5140ba7ed281399e56e95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150057 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#759358}
-
Sinan Sahin authored
After switching themes (dark/light), the ConnectivityDetector instance would not be destroyed since it's added as an observer to the NetworkChangeNotifier singleton. This was keeping a lot of objects around and causing invalid status indicator instances to access a null activity reference through a lambda created in TabbedRootUiCoordinator. This CL adds a #destroy method to ConnectivityDetector and a call to it from OfflineIndicatorControllerV2#destroy(). Bug: 1070386 Change-Id: Iee7a9cb913fa8aa62960f602e6f45242e0cc60e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150026Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
-
David Tseng authored
This change fixes a case where Googletts, running in split mode, would not have both extensions kept alive. In particular, when running in the login session, Googletts would be loaded into both the off the record and non-otr profiles. The otr profile gets all tts extension api calls, but the extension system calls OnExtensionLoaded with the non-otr BrowserContext. Fix this by explicitly looking for an associated otr profile and modifying the keep alive count for Googletts there accordingly. Test: manually test on: - login session - guest session - normal session R=dmazzoni@chromium.org - flip on ChromeVox; wait for > 20 seconds. Trigger speech. Verify that speech comes immediately (aka tts kept alive) - flip off ChromeVox; wait > 20 seconds. Verify that flipping back on ChromeVox incurs a delay in speech response. Also, inspecting Chrome, verify tts is actually not loaded. Do: Change-Id: I93bc68d058017e3722c486dbb1848fac94ddca3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147014Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/60af4efbe0e2..9ac89e3e1842 git log 60af4efbe0e2..9ac89e3e1842 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 skyostil@google.com TrackEvent: Detect incorrect use of dynamic event names Created with: gclient setdep -r src/third_party/perfetto@9ac89e3e1842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148779455 Tbr: perfetto-bugs@google.com Change-Id: I8f059848d3e0688017ca0cf629d25c5f83d15900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149944Reviewed-by:
-
Mark Schillaci authored
This CL relands AccessibilityEvent throttling on Android. Original CL: http://crrev.com/c/2067443 Revert: http://crrev.com/c/2132927 This change was reverted to prevent regression before M83 was cut, but with this CL it will be relanded along with the improvements added here. This CL improves the throttling logic by separating it from the WebContentsAccessibilityImpl into it's own class, which we have called AccessibilityEventDispatcher. Whenever the WCAI wishes to send an event, it sends it to the dispatcher. The dispatcher can then act as a pass-through, throttle the event, discard the event, etc. as determined by preset rules that are opaque to the WebContentsAccessibilityImpl. This will make unit testing easier and allows us to make wholesale changes to our throttling without affecting implementations. This CL also adds an improvement by taking into account the |virtualViewId| of whatever node is trying to send an event. Until now we have relied solely on the eventType and ensured that no two events of the same type are sent in quick succession (if the eventType is one we are throttling). This creates an issue where two separate nodes with different |virtualViewId|'s can each request an event of some type to be sent, but only one will get through. We fix this problem by making our throttling check not just the eventType but also |virtualViewId|. This requires some sort of 2D structure, or a key of Pair or some wrapper object that will hold the two ints (|virtualViewId| and eventType). Here we use a long in place of a Pair, by bitshifting |virtualViewId| left 32 bits and doing a bitwise OR with eventType. This gives us a 64bit long that is essentially two int's concatenated in memory, which will be a unique id for a |virtualViewId|-eventType pairing. This CL also adds an improvement by allowing us to specify a delay time on a per eventType basis. Before this change we had a simple Set that contains a list of eventTypes to delay. We have now made this a map from eventType to delay time in ms, so that we can potentially delay different events by different amounts. Change-Id: I7431253a715cc712a81b1f6ac2b39d19e91daa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139905Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
