- 09 Oct, 2020 40 commits
-
-
Maggie Cai authored
This CL updates browser test to test for all desktop platforms, user can use intent picker to launch PWA. BUG=939205, 990256 Change-Id: Ibba41fc6c2fd22da42f57e56a73869b36d7e9754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440081 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815482}
-
Kent Tamura authored
ValueWithHardLineBreaks() assumes InnerEditor elements don't contain <br>s other than the last child. DCHECK()s check the assumption, and don't need to emit LFs for non-last <br>s. This CL should not change any behavior. Change-Id: Ifed37f35e01fb34c95c31d966066c25a86cdce81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462742 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815481}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a9b91b5..5cbb8488 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ica0ee82346ca94450c1d0393566d3c4a8accf516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462823Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815480}
-
Yoichi Osato authored
This CL introduces mojo_base.mojom.BigBuffer instead of array<uint> so that fetch can send big ArrayBuffer. Bug: 919361 Change-Id: I45c3c560ca787858453c677cc0c7fbc8c1983063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415810Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#815479}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f811799235c1..cd8eb564689a 2020-10-08 geofflang@google.com GL: Work around Mac glBindBufferRange issue. 2020-10-08 timvp@google.com Target the "absl" component for component builds. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1134776 Tbr: timvp@google.com Change-Id: I1b6379572fc53f8f90960ca6b9b424f7adc9f024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815478}
-
Koji Ishii authored
In LayoutNG, when `box-decoration-break: clone` is set, |NGInlineBoxState| clones the inline box fragments for every line, but it had no effects in line breaking and measuring. This patch implements the logic in |NGLineBreaker| so that the property is taken account for line breaking, line width (and therefore `text-align`), min-max sizing, etc. |NGInlineNode::ComputeMinMaxSizes| started to hit DCHECK with the |NGLineBreaker| change, because it computes `max-content` from `min-content`. When this property clones box decorations to every line, the logic does not work. This patch disables the fast codepath, instead run a separate layout path when this property is effective. This fixed an old crbug.com/612641. This property is used ~0.7%. The regression crbug.com/1006599 got 10 stars. Bug: 1006599, 612641 Change-Id: I6425fb5e7f8dc951d882eb90d1c081abd127468e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454349Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#815477}
-
Glen Robertson authored
Change-Id: I147b5bc188428802a6be8ed82347633ae57a8dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462882 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#815476}
-
Hidehiko Abe authored
It turned out current physical key tracking does not work if IME is enabled. It is not only for ARC, but also Lacros (as we start using IME soon), and crostini in the future when IME is fully enabled. Currently, we have workaround for ARC, so Lacros follows the approach for short term. We need a long term fix in the future, though. if there is no composing text. Bug: 1133651 Test: Typed cursor key on Lacros window. It works as expected Change-Id: Ib709ea852ddbec75d4790cf3aabdf353cade089d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452273 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:Jun Mukai <mukai@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#815475}
-
Karandeep Bhatia authored
Remove the IsolatedWorldCSP blink runtime feature and have the isolated world CSP always enforced. The current behavior when the IsolatedWorldCSP feature is disabled, is to just bypass the main world CSP for clients which set the isolated world CSP. For the most part, there shouldn't be any behavior change. Currently there are 3 blink clients which set an isolated world CSP: - Mv2 extensions specify an empty CSP, so there shouldn't be any behavior change for them. The empty CSP should behave the same as the main world CSP being bypassed. - The translate component does set a non-empty CSP. To preserve the same behavior we change it's CSP to an empty one. - Mv3 extensions specify a non-empty CSP and this CSP will now be enforced in isolated worlds, which is what we want. BUG=896041 Change-Id: I9c5bf6cff5dda6f5ee9090a873c9fcbc42eab317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439540 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#815474}
-
Chan Li authored
This reverts commit 6bcf1a99. Reason for revert: experiment not ready Original change's description: > Re-enable `chromium.resultdb.result_sink` experiment on chromium fyi builders at 30% > > Bug: 1108016 > Change-Id: I90beaf78f9f4b8508f6229b17b07a44943f442d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462049 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Chan Li <chanli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815450} TBR=chanli@chromium.org,tikuta@chromium.org Change-Id: I5efd5125c5391970ea34316cc27a000570e7b9df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462052Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815473}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I69ddb1e4466164740d3f8649f52f8bc56282839d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461692Reviewed-by:
-
Ken Rockot authored
This CL introduces generated mojom.m.js modules for mojom JS bindings, allowing most JS bindings consumers to import bindings with the convenience and efficiency afforded by JS modules. These modules can be used as-is by Component Extensions, Web Platform Tests, and Blink Web Tests. A follow-up change will introduce a slight variation on these modules to support consumption by WebUI pages. Bug: 1004256 Change-Id: Ic2b4a6bcadf68023d2078bf065befafce3ccb19b Tbr: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451589 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#815471}
-
Josh Simmons authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/5df72efed1de..fe6fea125882 $ git log 5df72efed..fe6fea125 --date=short --no-merges --format='%ad %ae %s' 2020-09-28 simmonsjosh seneschal: Add support for mounting smbfs paths into Crostini 2020-09-16 hollingum vm_tools: Make cicerone track VM type 2020-09-16 jiejiang remove copybara initialization artifacts 2020-09-16 jiejiang Copybara Service Migration Initialization. 2020-09-16 jiejiang patchpanel: Add NeighborStateChanged signal 2020-09-18 keiichiw vm_tools: concierge: Allow to specify kernel/rootfs paths for Termina 2020-09-17 ivadasz vm_tools: Add initrd field to the concierge protocol. 2020-09-18 allenwebb system_api: Refactor to support dev-rust/dbus-0.8* Created with: roll-dep src/third_party/cros_system_api Bug: 962924 Test: Manual - Build chrome Test: unit_tests --gtest_filter="*FileManagerPathUtilTest*" Change-Id: I5a0ecf24ae8e73f585ccd99c9311bff38f4cdb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462749 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815470}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/660580a68ad0..8bce4b0b83a5 2020-10-09 vidorteg@microsoft.com Enable ModuleUIStrings as a fallback in i18n If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6bd6ba7db296deef900b3131a5144eb0ee825c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461690Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602104345-4733e14208bb636a7ce6e80f22bf814b0d8103be.profdata to chrome-win64-master-1602179909-18dbc89acedf4f15864b841a6fe7487536bbc059.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7be127850ce3f5f00e6005d57b87bd53cc5d7c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462355Reviewed-by:
-
Alan Cutter authored
CL suppresses OS hooks to avoid flooding the system with shortcut icons. Additionally it adds back some checks that were removed by: https://chromium-review.googlesource.com/c/chromium/src/+/2459512 Bug: 1125269 Change-Id: I56ef61f38a538a64e34847783268b252d0455176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462754 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815467}
-
David Munro authored
Now that we round sizes to human-friendly numbers (e.g. nearest 0.1GiB), and we round down the top of the range of allowed sizes, it's possible to end up with a disk that's allocated a legal amount, but which is beyond the slider range. Now we ensure that we always include whatever size disk the user currently has in the range. Bug: chromium:1126705 Test: Run new unit test that hits this case. Change-Id: I7f8fb7bfe652b596da0763693699d74c6c61d39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459133 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#815466}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/02a7aa75bb24..7c2d888fdffc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If6af7f0cb9171702891cf8c4677759eeccad4aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461048Reviewed-by:
-
Antonio Gomes authored
aura::Window* properties in this file will be accessed by both Ash and Lacros code. For now, it moves ash::kIsShowingInOverviewKey to the newly added //chromeos//ui/base/window_properties.h|cc files. The property is used by //ash/public/cpp/caption_buttons/ code. Today, Lacros code will access the properties directly, but the idea is to avoid a generic window property API, and instead have specific methods to access the properties (backed by Mojo) - follow up. This implements section 0, on the design doc [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit BUG=1113900 R=jamescook@chromium.org Change-Id: I4c10ab79b766839551fbb2322cf38d6b1dbf2b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450666 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#815464}
-
wutao authored
When the secondary user logs in, the OnLockStateChanged() was returned due to the Ambient mode is not allowed, therefore the ambient UI is not closed. This patch moves the close ui logic before the ambient enabled check. Bug: 1136302 Test: Added new unittest Change-Id: I2d9c93087b8e8139936271db2a797f6322bb55ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462246Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#815463}
-
Hajime Hoshi authored
Bug: 1136690 Change-Id: Icefa36ff77c21cb49e3ff65120e9a91ad679dec0 Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462758Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815462}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I63c1953958510d34850c8369be168c7360ddef8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461800Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815461}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602179909-9d7f0b29438414a4f2265cc4ee2a14492d697def.profdata to chrome-linux-master-1602201537-8720b3c79a1854f8e56100a84c355502c0dbbf4a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7654b6af8076400cec97d018f5bb14790a44765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462766Reviewed-by:
-
Roberto Moura authored
Resetting the grid view controller's |reorderingLayout| to a GridReorderingLayout (instead of a TabSwitcherReorderingLayout, which subclasses TabSwitcherLayout instead of a GridLayout) fixed the issue. Bug: 1135507 Change-Id: I35f9faa1bdb5962709bef528f9ec849fb499895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454709 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#815459}
-
Tomasz Wiszkowski authored
This change: - Wires up all event signals for the MostVisitedTiles. - Adds the Integration tests for the MostVisitedTiles. - Adds CONTENT_DESCRIPTION TileView property. - Drops the proxy class 'AutocompleteCoordinatorTestUtils' consolidating the Omnibox Test support code within OmniboxTestUtils. - Explicitly calls some of the Test-specific methods so these are not accidentally used outside of test environment. MV Tiles still require the Unit-Testing part which will be introduced with the next related patchset. Skip-Translation-Screenshots-Check: True Change-Id: I600cae57f6242b6374d8f9d6e68a1179194ffeaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446771 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#815458}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/30378382aa3e..2ae1dd93d853 2020-10-09 jvanverth@google.com Revert "Add sk_Caps.builtinDeterminantSupport and use it in cross()." 2020-10-09 brianosman@google.com Remove custom iterators from SkSL::Program 2020-10-08 jvanverth@google.com Revert "Rename GrStencilAttachment class to generic GrAttachment" 2020-10-08 johnstiles@google.com Add sk_Caps.builtinDeterminantSupport and use it in cross(). 2020-10-08 michaelludwig@google.com Add SkImageFilters::Shader in place of Paint factory If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ida4527b1fd606d491992707392c1750286a7e183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461687Reviewed-by:
-
Michael Checo authored
This is a reland of 4f4586fd Issue: FocusRowBehavior was not initializing properly which caused "keydown" events to target the Polymer element itself, most likely through event retargeting (http://shortn/_Nfy2DTMeen). Fix: After populating nearby printers, wait for the next render of the nearby printers page to ensure the FocusRowBehavior setup is completed. With this change, the element with the "focus-row-control" attribute now consistently becomes the focused element when navigating through the printer entries. Original change's description: > Printer settings: Make saved/nearby printers use FocusRowBehavior > > Description: > This change allows users to tab to the first printer in the saved > and nearby printer lists and use the arrow keys to navigate the > remaining printers. Users can also use the arrow keys to navigate > through a printer entry's associated buttons/icons. Lastly, the > printer entry row will be highlighted (blue background) if it is > being focused. > > Screenshots: > - http://shortn/_Fqf1Nn9qjF nearby printers > - http://shortn/_BSspETkjzV saved printers > > Bug: 987422 > Test: gtest_filter=OSSettingsCupsPrinterLandingPageV3Test.All > Change-Id: I68fc5fc3ff2ceec88ce81f95da5b451a6ad3beb1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399601 > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Commit-Queue: Michael Checo <michaelcheco@google.com> > Cr-Commit-Position: refs/heads/master@{#809354} Bug: 987422 Change-Id: I0982fe466e2c16d2b5b4a0f364808e223a668793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432306 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#815456}
-
Josh Nohle authored
This reverts commit cd0974ca. Reason for revert: Causes a crash (crbug/1136605). We will assign crbug/1136605 to melzhang@ to implement this change safely. Original change's description: > fix an instance of bugprone-unused-return-value > > This new clang-tidy check fires when the result of a function like > `unique_ptr.release()` is unused. Sometimes this is intentional, other > times, it's not (e.g., the dev intended to `.reset()`). > > Bug: 1134714 > Change-Id: Ia6a272a8b45bfc3eace44d94f244cbfcedede608 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457649 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: George Burgess <gbiv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815188} TBR=gbiv@chromium.org,dominickn@chromium.org Change-Id: I34a595e9773b1c9d28ce0fe713ca093625a5e2c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462629Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#815455}
-
Daniel Ng authored
We expect this test to call Cancel(), I've added the expectation. Tests: Run browsertests for Borealis Change-Id: Ic05b94cb73d3a859d55f90c6a47720bc12569c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454573Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#815454}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/628c64d7a14c..7c2d888fdffc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I558791cc032687fdec220c20bb3e0ce216d840d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462571Reviewed-by:
-
Adam Whiteside authored
Currently audio output streams inside MixerInputConnection have a fixed maximum buffer size of 8192 frames. This means that the overall delay changes depending on sample rate (with lower sample rates accumulating substantial delay, 512ms at 16000Hz). The current 8192 frame buffer is equivalent to 170ms of audio at 48000Hz, which is unnecessarily high. Set non-communications streams to 70ms and communications streams to 50ms. confirmed both with logging and listening test that the latency is substantially reduced. Bug: internal 168254375 Test: On device. Ran sample app at both 48000 and 16000 sample rates and Change-Id: I109df7dd10e3067f9cb4f9117c31e96cbdef581b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461218 Commit-Queue: Adam Whiteside <awhiteside@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#815452}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6740cd70. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I56d238e667cf29b7602413e1ab91dc8c1534e699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461637Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815451}
-
Chan Li authored
Bug: 1108016 Change-Id: I90beaf78f9f4b8508f6229b17b07a44943f442d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462049Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#815450}
-
James Cook authored
We've settled on "Lacros" instead of "LaCrOS". Bug: none Change-Id: Ie70ad8e81c1340466ad40f130495177aa0db9b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462297 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#815449}
-
Jimmy Gong authored
- Responsible for sending requests for displaying the notification access setup UI to the user's phone. Bug: 1106937 Test: chromeos_components_unittests Change-Id: If00b19664b4dd6240558e48b4bf5bb45c98e2723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453511 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815448}
-
Darwin Huang authored
Refactoring change only. No functional change. Change-Id: If333b87c14cf8c9e06cd3bae544c5e71ce998678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458825 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815447}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602179909-33e9e654a138340f2ff74cc84be2567f323eeba5.profdata to chrome-mac-master-1602201537-11aed398f2fb6b4c095a189eb8886f38c679c48f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I404f00803d14f78b77bd85afaec9e1ba3bedb46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461688Reviewed-by:
-
Clark DuVall authored
Review from Patchset 1 to get the right diffs on the changes in ChromeBackupAgentImpl. Bug: 1126301 Change-Id: I441e3dc4cf098212d6170db7f3913ef2edbc2066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461221Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815445}
-
Jing Wang authored
In some edge cases, these function may return nullptr which will crash chrome. TEST=passed unit tests and browser tests BUG=1121330 Change-Id: I4863ac4a43b5dcdae684f948abbf40d627c4ab9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462745Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815444}
-
Tarun Bansal authored
Bug: 1130607 Change-Id: If75e1cd436fc5383f5c786e95a6525f35606f627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462625 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#815443}
-
