- 21 Oct, 2019 40 commits
-
-
Mario Sanchez Prada authored
Convert the remaining bits in both the browser and renderer processes for the media::mojom::VideoDecoder, media::mojom::VideoDecoderClient and media::mojom::VideoFrameHandleReleaser to the new mojo types. Bug: 955171, 978694 Change-Id: Idbf067fa0d374ec8c52abd22774e9e2a29c4ed99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865214Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#707749}
-
Raphael Kubo da Costa authored
We were previously only checking if a WakeLockSentinel had any registered event listeners to decide whether it should be kept alive in HasPendingActivity(). This is not enough, as if the sentinel has been released, either by release() being called or because the WakeLock class ended up calling WakeLockManager::ClearWakeLocks(), it should also be eligible for garbage collection even if it still has one or more event listeners (as they will never be called again anyway). Bug: 1015788 Change-Id: I2fa328915e4e1d39344ef3ed5e56c985ef7ad451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868875 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#707748}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c9fa747..8bbd6af6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I892afe9f3275e003792e4a6e4c5bccb894c2981e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871172Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707747}
-
Jan Scheffler authored
This is a reland of 12915a69 Original change's description: > [devtools] Add Url and Path Column to Network Log > > This patch adds url and path as available columns to > the network log view and allows the name to be removed > because it is not needed if the user decides to show > the path or the whole url. > > Bug: chromium:993366 > Change-Id: Ib4600d1631bd436cb3c8b8e79b3709dddc38b166 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809161 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jan Scheffler <janscheffler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698891} Bug: chromium:993366 Change-Id: I0061afbb7bdbc03cf3a7bd567530d21b66fa6d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823859Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#707746}
-
Guido Urdaneta authored
Fix type and replace "audio stack" with "audio subsystem". Bug: 1009332 Change-Id: I6b4b80eca15c7e0ae2dc74c03f039a429e857d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869652 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#707745}
-
Hiroki Sato authored
When android clickable nodes are nested, currently only the outer nodes are clickable. In this case, even if there are multiple clickable inner nodes, only the outer node was clickable. This CL changes to set clickable property only when the node that is clickable in Android and there is no clickable descendant node of it. menu is accessible from ChromeVox.) Bug: b:141969848 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manually (open PlayStore and confirm that search box and hamburger Change-Id: I6f62658f8d620d650678162d3547d86af66efa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849548 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#707744}
-
Javier Ernesto Flores Robles authored
The disabled test was checking a workaround for when the keyboard had a cycle of hide/show notifications without actually hiding itself. On iOS 13 this is fixed. Mark deprecated API as deprecated. Reenable test on iOS < 13. Bug: 1015550 Change-Id: I22931b1df71638bbebb4b11c1a1017317b446c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807325 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#707743}
-
Fergal Daly authored
Without this, isolate.py fails. python tools/swarming_client/isolate.py check -i out/Android-arm-dbg/android_browsertests.isolate -s out/Android-arm-dbg/android_browsertests.isolated Failed to find an input file: Input directory /usr/local/google/home/fergal/chromium/src/components/test/data/payments must have a trailing slash -> returned 1 Change-Id: I624016f2711038ad0f7920cac645e1b2c3d0f045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871159Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#707742}
-
Peter Kasting authored
Bug: 82078 Change-Id: I6c2e5ed7712540ac43f5b8db55e9a258c31778b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870601 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#707741}
-
Yuki Shiino authored
Supports UnlikelyExitNode (will be used frequently) and LikelyExitNode (will be used rarely). SymbolScopeNode now inserts SymbolDefinitionNodes much smarter than before. Bug: 839389 Change-Id: I4d0b708c39ea97ae1c500b69cf0d16158f748659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868578Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#707740}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4c80c322597..c70966b3505e git log f4c80c322597..c70966b3505e --date=short --no-merges --format='%ad %ae %s' 2019-10-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6dee176c8d7d..4a80ba25e67b (13 commits) Created with: gclient setdep -r src/third_party/skia@c70966b3505e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:None Change-Id: I83adf702dd44d988f2f75b26f206d680c86984db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871333Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707739}
-
Takashi Toyoshima authored
Because of performance implication, we decided to require 'extraHeaders' option to intercept CORS preflights. Bug: 1002884 Change-Id: I00678e265a0488d18bd44451e5b2b1c6c71ad31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847607 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#707738}
-
Henrik Boström authored
This unblocks https://webrtc-review.googlesource.com/c/src/+/155621 from landing and rolling into chromium. TBR=asapersson@chromium.org, hta@chromium.org NOTRY=True Bug: webrtc:7065 Change-Id: I59f9779c265bd3e1c6f24ae3a377a0d18cf95fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871430Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#707737}
-
Francois Beaufort authored
This CL renames NFCReader to NDEFReader, NFCWriter to NDEFWriter, NFCReadingEvent to NDEFReadingEvent, NFCScanOptions to NDEFScanOptions, NFCPushOptions to NDEFPushOptions, and NFCError to NDEFError as suggested in Web NFC spec at https://github.com/w3c/web-nfc/pull/392 Bug: 520391 Change-Id: Ifc7d26d68b76bbf771a83cba94fc275819c28cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869227Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#707736}
-
Alexey Baskakov authored
We don't know the app_id of an install URL ahead of time. Sync-initiated installs should fail if expected client tag (global app id) doesn't match a publisher's app_id. This functionality will be used in dependent CL: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 Bug: 860583 Change-Id: I74588fdc3e675553a30eaf85f647a22ab786137a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866124 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#707735}
-
sandromaggi authored
* terms requires review * thirdparty privacy notice Previously these texts were set from Android resource strings that had a parameter for the domain. To avoid discrepancies in displaying said domain, we aim to set it from the backend instead of evaluating and formatting it on the frontend. Add UI tests for texts newly being set by model changes (i.e. from the backend). Bug: b/142621971 Change-Id: Iffa48f200eeaa26c0c4b47ade4f2ea0dc330da19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862685 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#707734}
-
Yang Guo authored
Bug: 1011259 Change-Id: If6a80fa169c5286ed536688ab39f67c37a27faad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855938Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707733}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/acf922ce48cf..77780358011f git log acf922ce48cf..77780358011f --date=short --no-merges --format='%ad %ae %s' 2019-10-21 ukai@google.com put goma client in depot_tools Created with: gclient setdep -r src/third_party/depot_tools@77780358011f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:b/77663154 Change-Id: Ie57db75c380dde755fe425afc8eb77afd56bab31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871194Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/554a876f7e75..f4c80c322597 git log 554a876f7e75..f4c80c322597 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@f4c80c322597 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: If6b3efcc1138f55b4dfa518b303029acba8ec01d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871193Reviewed-by:
-
Yang Guo authored
This adds external devtools frontend as DEPS, but does not start using it except for scripts and documentation. Build and tests are not affected. Bug: 1011259 Change-Id: I3b6173582bf88974784f6d758ad91b6f740b1b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855740 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707730}
-
Peter Kasting authored
Bug: 82078 Change-Id: I27457fb30c8f78060cdcc2bfdae18fd5d78c3920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870048 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#707729}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b32cc651..8c9fa747 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iccadf2d2d5536635abd93109483e1caec79f595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871170Reviewed-by:
-
Keith Lee authored
Change-Id: I47ddf6f917faff92a1b639c1f09cab3191d79f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833028Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Auto-Submit: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#707727}
-
Matt Giuca authored
- Add mgiuca as owner for these histograms. - Remove logging of Manifest.IsEmpty (it is not useful). - Fixed enum names and histogram description: s/unique/opaque origin. Bug: 1006971 Change-Id: I649a752df64e460701c3989ee5f606057932d54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826066 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#707726}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ff3029411808..6efb3466e0f2 git log ff3029411808..6efb3466e0f2 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 zhuohao@chromium.org kukui: add factory builder Created with: gclient setdep -r src/third_party/chromite@6efb3466e0f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id8d8d9c21afd1862312c4624fae180d8055b5911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871192Reviewed-by:
-
Marina Sakai authored
IntersectionObserver and MutationObserver are no more private properties and do not use the functions generated by the macro V8_PRIVATE_PROPERTY_GETTER_NAME. However, they are registered as private properties in the macro V8_PRIVATE_PROPERTY_FOR_EACH. This CL cleans up the macro V8_PRIVATE_PROPERTY_FOR_EACH by deleting the registerations. Bug: 715418 Change-Id: Id3c4b553446a942c96a6c5fedf4678518e0facf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868752Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Marina Sakai authored
The new API in V8PrivateProperty to get Symbol was created in CL1810511. The new API needs a key for uniquely identifying v8::Private as an argument and we need to use the same key for each CachedAttribute in AttributeGetter and AttributeSetter. There are two types of CachedAttribute. One has a setter and the other has no setter. Since a CachedAttribute that has no setter only needs to define the key in the getter function, this CL divided the location of the key definition depending on whether or not CachedAttribute has a setter. Bug: 715418 Change-Id: I7d994d4f804e22c5221463067a6957052808d4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855151 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fc7fb089205..f206982b4654 Created with: gclient setdep -r src-internal@f206982b4654 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ieec418116a8b91816112e5e169ee3fb3c93a337d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871189Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707722}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d26e865f413b..554a876f7e75 git log d26e865f413b..554a876f7e75 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a68a80a4dbf9..26c6c4a5eb83 (1 commits) Created with: gclient setdep -r src/third_party/skia@554a876f7e75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:None Change-Id: I5ff1f1ba2a17d6c50cfb06f71b5514415afed6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871191Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id864186eb8596af7c6c0125b530e097e77140da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870574Reviewed-by:
-
Xianzhu Wang authored
If the background is on LayoutView and all backgrounds are painted on the main graphics layer, we don't need main thread scrolling. Bug: 521555, 1015833 Change-Id: Icbf179658b48ccca30d0e652537c7c05bc8d5668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869381Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#707719}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68591effc086..4a80ba25e67b git log 68591effc086..4a80ba25e67b --date=short --no-merges --format='%ad %ae %s' 2019-10-21 timvp@google.com Vulkan: Ignore VK_INCOMPLETE from vkGetPipelineCacheData Created with: gclient setdep -r src/third_party/angle@4a80ba25e67b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: None Change-Id: I8421e0b64c70a880e354a2e1c4dd4281aa1fe772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870688Reviewed-by:
-
Kent Tamura authored
test_runner::TestRunner::WorkQueue::ProcessWork() can run after the main WebView destruction, and we have to clear main_view_ when the WebView is destructed. The code assumed TestInterfaces::WindowClosed() cleared main_view_ if the closing WebView is the main WebView. However, |proxy->webview()| is already null here because WebView is destructed before calling WindowClosed(). This CL adds SetMainView(nullptr) to ~WebViewTestProxy(). It is called if the global delegate is same as the delegate owned by the WebViewTestProxy. This condition is equivalent to 'this WebViewTestProxy is the owner of the main WebView.' Bug: 1010581 Change-Id: I868ce9223d253dbf02620fdebff8ada4a51c60d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865734Reviewed-by:
-
Hsin-Yu Chao authored
We want to track the selected codec of all bluetooth HFP connections. Ideally we want the codec negotiation result to be mSBC, of value 2, which is by far the best quality codec. But there are cases it falls back to CVSD, of value 1. We want to track this value in order to know how frequent the failure happens. Patch in CRAS that send this value to UMA CL:1864253 Bug: 971568 Change-Id: Idf53fead80c7e4e055b85c00dd23cb322b1f9282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865049 Commit-Queue: Hsinyu Chao <hychao@chromium.org> Auto-Submit: Hsinyu Chao <hychao@chromium.org> Reviewed-by:
-
Chih-Yu Huang authored
In CL:1824303, we changed the flow of using V4L2 output buffers. At that CL, we forgot to enqueue V4L2 output buffers after we copy the content to bitstream buffers and free them. This CL fixes this issue by calling Enqueue() after that. BUG=chromium:1015257 TEST=tast run $(DUT) video.EncodeAccelPerfH264360PI420 on elm Change-Id: Iaa80779982c0c234ed9100095c9bb4b5b954288a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871150Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#707715}
-
Jason Lin authored
The visual design follows this spec [1]. [1]: https://bugs.chromium.org/p/chromium/issues/attachment?aid=352503&signed_aid=cMK94eiGY6JTFz05FJtiKw==&inline=1 Bug: 929571 Test: browser_tests --gtest_filter='CrostiniInstallerBrowserTest.*'; Manual testing Change-Id: I756872f7fb232b89ba9f85b49ecc1c907e4e1fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833194 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#707714}
-
Kenichi Ishibashi authored
The previous CL (crrev.com/c/1851624) seemed to make some tests flaky. I'm not sure the exact reason. This CL attempts to fix flakiness by not using default parameters. Bug: N/A Change-Id: Ia6fae23881704e4eb41e33ebe3e22e89872d7f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866093 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#707713}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If4b8f6d456c9f3a19292d104cc31665e7d88e6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869827Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707712}
-
Yoshifumi Inoue authored
This patch makes |NGCaretPosition| to utilize |NGInlineCursor| as part of migration to |NGFragmentItem|. Note: To reduce size of patch, following patches will utilize |NGInlineCursor| into caret rect, visible line etc. to replace |NGPaintFragment| usage to |NGInlineCursor|. Change-Id: I0d543204c0acba7b1ac215afed43b34295276d49 Bug: 982194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866101 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707711}
-
Peter Kasting authored
Bug: 82078 Change-Id: I69c553e9746328e41880f8f51b5ec990303819a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866262 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#707710}
-
