GitLab

Clang won't let you form a pointer to member without an explicit
'&ClassName::' before the method name.  In fact, neither will MSVC
unless you explicitly disable the error, which the ATL does.  This has
been documented on MSDN since VS 2005:
http://msdn.microsoft.com/en-us/library/ms174271.aspx

Clang doesn't implement this extension, so just fix the code.

R=wez@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/410853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285118 0039d316-1c4b-4281-b951-d872f2087c98

This class is doing more than just an observer.
Add a default implmentation of OperationDelegate::OnFileChangedByOperation() to remove DummyOperationObserver in sync_client_unittest.cc

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/408143014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285117 0039d316-1c4b-4281-b951-d872f2087c98

Once Embed() is called on a node the connection that created the node
can no longer see any of the children. If the node had existing
children they are removed.

BUG=396804
TEST=covered by test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/415793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285116 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372212

Review URL: https://codereview.chromium.org/411763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285115 0039d316-1c4b-4281-b951-d872f2087c98

This patch is the second part of ensuring that recycle tree does not
contain any unshared tiles.

This is done by removing recycle tree tilings when active tree removes
those tilings.

This includes a check in RemoveTilings for NULL tilings. When the first
pending tree activates, it swaps with active tree's NULL tilings, which
become the recycle tilings. When removing tilings, we have to ensure
that tilings is not NULL before accessing its members.

BUG=393802
R=danakj, enne

Review URL: https://codereview.chromium.org/399233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327719
TEST=None
TBR=fukino

Review URL: https://codereview.chromium.org/413943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396730

Review URL: https://codereview.chromium.org/414803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285112 0039d316-1c4b-4281-b951-d872f2087c98

The pakge should be specified by the code in Android, not here.

BUG=396680

Review URL: https://codereview.chromium.org/415703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285111 0039d316-1c4b-4281-b951-d872f2087c98

Provide a reference implementation of the MotionEvent interface, usable by mock
implementations and platform-specific implementations.

BUG=394562

Review URL: https://codereview.chromium.org/407313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285110 0039d316-1c4b-4281-b951-d872f2087c98

These changes provide support for observers for DistilledPagePrefs
to listen to changes in DistilledPagePrefs.

BUG=383630

Review URL: https://codereview.chromium.org/403323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285109 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118639

Review URL: https://codereview.chromium.org/373523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285108 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds:

- third_party/closure_compiler/

  - compiler/ (latest version of closure compiler)
    - COPYING (copying instructions)
    - compiler.jar (closure compiler as a .jar)
    - README.md (how to use compiler)

  - runner/ (needed to run the compiler in IDE mode)
    - build_runner_jar.py (builds runner.jar)
    - runner.jar (a .jar to execute to compile)
    - src/org/chromium/closure/compiler/Runner.java (a compiler runner)

  - LICENSE (closure compiler's license)
  - OWNERS (reviewers)
  - README.chromium (description of new directory's contents)
  - checker.py (class for checking .js files with settings for chrome code)
  - compile_modules.py (parses modules with sources/dependencies/externs)

BUG=78368
R=arv@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/369643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285107 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Fails on multiple android bots. For example:

http://build.chromium.org/p/chromium.perf/builders/Android%20Nexus4%20Perf/builds/1134/steps/memory.mobile_memory/logs/stdio

Original issue's description:
> Re-enable mobile memory tests.
> 
> BUG=370977
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284854

TBR=starodub@google.com
NOTREECHECKS=true
NOTRY=true
BUG=370977

Review URL: https://codereview.chromium.org/413093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/drmemory/issues/detail?id=1052
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/415913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285104 0039d316-1c4b-4281-b951-d872f2087c98

GetCompatibleCommand checks chromium revision to set appropriate browser type.
While processing 3rd party repositories by bisect, it was trying to compare dependency module
revision instead of chromium revision.

BUG=388411
NOTRY=true

Review URL: https://codereview.chromium.org/414893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285103 0039d316-1c4b-4281-b951-d872f2087c98

Moves the remaining invalidations code from
sync/internal_api/public/base/ to components/invalidation/.

TBR=atwilson
BUG=259559

Review URL: https://codereview.chromium.org/400073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285102 0039d316-1c4b-4281-b951-d872f2087c98

If the context change is of type REFRESH_NEEDED, we post a notification
to refresh the type. This is a temporary workaround until the
GenericChangeProcessor can properly tell the SyncManager that a refresh
is needed.

BUG=396298

Review URL: https://codereview.chromium.org/411463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396752
R=kalman@chromium.org
TBR=ben@chromium.org, dbeam@chromium.org

Review URL: https://codereview.chromium.org/413913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285100 0039d316-1c4b-4281-b951-d872f2087c98

The gadget.Gadget class implements the basic USB control requests
required by all devices. It handles common operations like changing
the configuration and interface alternatives and fetching descriptors.
The device interfaces with a "chip" which is the USB peripheral
controller that connects the emulated device to a USB host.

BUG=396682
R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org

Review URL: https://codereview.chromium.org/407353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267773

Review URL: https://codereview.chromium.org/404993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285097 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=brettw@chromium.org, nyquist@chromium.org, phajdan.jr@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/408063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285096 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393686

Review URL: https://codereview.chromium.org/412643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285095 0039d316-1c4b-4281-b951-d872f2087c98

This CL whitelists two more apps that have been approved for use in
public sessions.

The CL also includes whitespace fixes enforced by git cl format.

BUG=396710
TEST=None

Review URL: https://codereview.chromium.org/405353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285094 0039d316-1c4b-4281-b951-d872f2087c98

This enables running libaddressinput unit tests on DrMemory bots, which
work from the directory above src/.

TBR=estade@chromium.org
BUG=395169,396203

Review URL: https://codereview.chromium.org/401883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285093 0039d316-1c4b-4281-b951-d872f2087c98

Changes to the locale made via the settings screen persist outside the
current session and affect e.g. the login screen. Public session users
should not be permitted to make such changes.

BUG=214904
TEST=Manual - public session cannot, regular user can change locale

Review URL: https://codereview.chromium.org/412583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285091 0039d316-1c4b-4281-b951-d872f2087c98

R=tbreisacher@chromium.org
TBR=kevers@chromium.org
BUG=393873
TEST=no red bots

Review URL: https://codereview.chromium.org/406143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285088 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87200
R=stgao@chromium.org
TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/417863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285087 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369886
TBR=rkc@chromium.org

Review URL: https://codereview.chromium.org/413083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285081 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces EventType and EventFlags enum types
which mirror ui::EventType and ui::EventFlags. With these,
simple mouse/touch based Mojo apps no longer have to depend
on the ui module.

Note that this doesn't introduce any keycodes. It will need
some non-trivial work which deserves its own CL.

BUG=330467
R=beng@chromium.org, darin@chromium.org, viettrungluu@chromium.org
TEST=none

Review URL: https://codereview.chromium.org/413633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285080 0039d316-1c4b-4281-b951-d872f2087c98

* Also open the extension "uninstall URL" only when uninstall is user initiated.

BUG=84556

Review URL: https://codereview.chromium.org/406063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285079 0039d316-1c4b-4281-b951-d872f2087c98

Previous patch failed because of GC issue (GC for the first test
only happens after the second test started, and it turns out
that we rely on __del__ in that test -- not good!). This is fixed in:

https://codereview.chromium.org/409113006/

BUG=392901

Review URL: https://codereview.chromium.org/408913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285078 0039d316-1c4b-4281-b951-d872f2087c98

The descriptor module defines a generic infrastructure for declaring USB
descriptor formats. Features such as fixed and computed descriptor
fields are intended to make it as easy as possible to construct a
well-formed descriptor.

BUG=396682
R=rockot@chromium.org,rpaquay@chromium.org

Review URL: https://codereview.chromium.org/409883008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285076 0039d316-1c4b-4281-b951-d872f2087c98

This change adds a toggle to turn webspeech off when tab goes background.
And further request to turn media capture devices on will be denied.
So Both WebRTC and webSpeech won't be able to initiate new requests when tab is in background.

BUG=396054
R=dalecurtis@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/415433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285072 0039d316-1c4b-4281-b951-d872f2087c98

The DeviceLocalAccountTest.Extensions* assumed that extensions get copied
to an account's cache after successful installation. In reality,
extensions are downloaded to the cache at first and then removed again if
installation fails. The removal happens asynchronously on a background
thread. This led to a race where tests would try to verify that an
extension does not exist in a cache without waiting for the removal
process to finish first.

This CL switches the tests from verifying that an extension has been
removed from disk to checking whether the cache entry has been removed,
which happens synchronously on the UI thread.

BUG=393208
TEST=DeviceLocalAccountTest.Extensions*

Review URL: https://codereview.chromium.org/389313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285070 0039d316-1c4b-4281-b951-d872f2087c98

Extensions unit tests originally ran as part of Chrome's unit_tests suite.
We have introduced a extensions_unittests target which is now running on
trybots, CQ and main waterfall. It started with duplicates of tests in
chrome_tests_unit.gypi (so we wouldn't lose coverage).

Now that extensions_unittests is running everywhere we can remove the
duplicate test entries.

BUG=348066
TEST=unit_tests extensions_unittests

Review URL: https://codereview.chromium.org/417603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285069 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/412433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285068 0039d316-1c4b-4281-b951-d872f2087c98

Rename gpu_unittest_utils test_utils for project consistency.

Add angle unit tests.

Update comments in GPU GYP file referencing GN targets.

Review URL: https://codereview.chromium.org/409423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/417503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285066 0039d316-1c4b-4281-b951-d872f2087c98

chrome.logPrivate.dumpLogs(function(fileEntry) {...});
  
- dumps all system logs as |fileEntry| (a .tgz file)


chrome.logPrivate.startEventRecorder(type, function(){});
chrome.logPrivate.stopEventRecorder(type, function(){});

- start/stop additional log collection for dumps generated with chrome.logPrivate.dumpLogs(). 

TEST=LogPrivateApiTest.*
BUG=385289

Review URL: https://codereview.chromium.org/329853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396752
R=estade@chromium.org

Review URL: https://codereview.chromium.org/414753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285064 0039d316-1c4b-4281-b951-d872f2087c98