- 11 Jan, 2021 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53f842487859..7e543a256b4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harrisonsean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harrisonsean@google.com Change-Id: Ice64dc5ab4775adf58b4d648ec1b46d7917d936e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620481Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841998}
-
Rohit Agarwal authored
ToolbarDataProviderTest is a batch tests which keeps the ChromeTabbedActivity alive in between the tests. These tests also included CCT tests which launched CustomTabActivity on top of the existing ChromeTabbedActivity. In test environment, launching multiple Activities often results in Android killing the background process and all the Activities encapsulating it. This CL, therefore decouples the CCT tests from ToolbarDataProviderTest and move it to CustomTabActivityIncognitoTest. Bug: 1154445 Change-Id: If7a69773fb441d17439401fe2881a11d7a1c5eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621058Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841997}
-
Anton Bikineev authored
Bug: 11297512 Change-Id: If7e4e3dc494c36649fcc538bc858ffd7638f626b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565686 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841996}
-
Luciano Pacheco authored
Add JS module for //ui/file_manager/file_manager/foreground/js/ui/table: - table.js - table_column.js - table_column_model.js - table_header.js - table_list.js - table_splitter.js NOTE: TableColumn.width property changed to be inline instead of Object.defineProperty() because the old cr.defineProperty() allowed to overwrite only the getter however using Object.defineProperty() doesn't allow it. Bug: 1133186,1134497 Change-Id: I0e3aea36240674ef055ebb75865f7d229bd3da84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619104 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841995}
-
Wei Lee authored
This reverts commit 94464131. Reason for revert: b/176770937 Original change's description: > [CCA] Only use CameraDialog for intents under clamshell mode > > For tablet mode, we should better use the regular way to launch CCA, > which means opening CCA in a Browser, rather than using CameraDialog so > that the size of the CCA can be fullscreen as well. > > Bug: b/175322338, b/175326967, b/174891007 > Test: tast run [DUT] camera.CCAUIIntent* > Change-Id: I39cecffb36e4d104253d74ffd9e44c6740a648b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596282 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838170} TBR=sky@chromium.org,shik@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/175322338 Bug: b/175326967 Bug: b/174891007 Change-Id: If6ffd5e3903b7e10174e05651ada687292289db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620823Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841994}
-
Fredrik Söderqvist authored
Bug: 1162628 Change-Id: I5fae5bd6c0b6d9cfb80f2b65778dfaa6f13291bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620562 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#841993}
-
Maya Lekova authored
This CL updates the expiry date and owners list of V8.TurboFanOptimizeNonConcurrentTotalTime to match the rest of the V8.TurboFan* group. Bug: chromium:1149511 Change-Id: I8ade45123a24a7afac7b90982b0635eea1f61418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606359Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#841992}
-
Frédéric Wang authored
In [1] a test was added to to verify trustworthiness of custom schemes. However, the ones using IsOriginPotentiallyTrustworthy fails because non-opaque origin must be a "standard scheme" i.e. follow [2]. This CL adjusts the tests to actually use a "standard scheme", which is closer the intent to test chrome-extension URLs. It also removes corresponding test from SecurityOriginTest, as it does work well with url utils [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2593629 [2] https://tools.ietf.org/html/rfc3986#section-3 [3] crbug.com/1163060 Bug: 1153336, 1163060 Change-Id: I3e7f1d91558a97b1722a742d89c514b984b56ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595424Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#841991}
-
Aya Elgendy authored
Fix a typo in the pin dialog error message which read "1 attempts left" instead of "1 attempt left" when the user has attempted incorrect pins and there's only 1 attempt remaining. This CL is the second attempt to solve the issue after being reverted in commit 7672be058caa26d14678f8b0d4a06de56c155309 due to an issue in the error message format of the SAML login. The first attempt only handled the normal login while this one handles both the SAML login and the normal login. Bug: 1060695 Change-Id: Ieac135c90ef6e20cf53bd26d2ab87cf0147c21a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599814 Commit-Queue: Aya Nader Elgendy <ayag@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841990}
-
Kim-Anh Tran authored
V8 change will remove sending along data urls with Runtime.CallFrame, Runtime.ExceptionDetails, and Console.ConsoleMessage. Bug: chromium:1132260 Change-Id: I2c0ca7deea0f6384ffcbeee62fb230aa9b61c4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621532 Auto-Submit: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c46f2cb69a6..4e3706155af8 2021-01-11 jacktfranklin@chromium.org Fix flakey data-grid-controller interaction tests on Mac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f9c448f4c789840f274da7807fac1d24348a4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620480Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841988}
-
Roman Aleksandrov authored
Bug: 1151292 Change-Id: I318dcff8ec10a721844856ff089e59ef68f8a09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601484Reviewed-by:
-
Michael Lippautz authored
Bug: 1056170 Change-Id: If0f380fccf14c13a212f3101ad311f22d85f38a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616231 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Removes the following retain cycle: self-> animator-> animations block -> self Bug: N/A Change-Id: I614f6d81f328eed8e0707f87fa2a9065d00089ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617863 Auto-Submit: Javier Flores <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#841985}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/35f78f4a4562..eddc7d0df5d 2021-01-11 primiano@google.com Merge "Minor changes to IPC layer in preparation for Win port." 2021-01-11 primiano@google.com Merge "Exclude platform_unittest.cc from chromium builds" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. Bug: b/174454879 Change-Id: I3742be0d1dcb50e4c76433cbfe3efdb60063f477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621057 Commit-Queue: Primiano Tucci <primiano@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#841984}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0b90eef09f60..ac05066a00a9 2021-01-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 28ecef43 to 29d2d6a2 (82 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I6ac969799e206c402a99874160f93d35cae736a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621044Reviewed-by:
-
Jeff Yoon authored
Coverage instrumentation adds symbols in a different order to what's expected. We don't need to check symbol order for coverage instrumentation, so we'll skip it for now. Bug: 1163903 Change-Id: I074365d0f8a85c513e0988e4452931903005cc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620000 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841982}
-
Benoit Lize authored
With PartitionAlloc-Everywhere, there are two partitions: one for malloc(), and one for posix_memalign() (and equivalent). mallinfo() reports data for both partitions together. However there is a suspicion that having two separate partitions may increase GPU process memory footprint. To break these down, separate the aligned partition data from the regular one. On Linux, this shows that browser and renderer processes don't have a lot of aligned memory, but the GPU process does. For instance, with a single CNN.com tab open, there is a ~50/50 split between the regular and aligned partitions, and the aligned partition uses a lot of address space as well, respectively 128MiB allocated, and 179MiB mapped. Note: this may change sizes for some malloc() metrics with detailed dumps. Bug: 998048 Change-Id: I29dd7a93515ef25736ea830ddf663e85b9e122a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617848 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#841981}
-
Alice Wang authored
This CL breaks the circular dependency chain between SigninUtils and SigninActivity by moving the method .launchActivityIfAllowed() from SigninUtils to SigninActivityLauncherImpl. Bug: 1163470 Change-Id: I99a98142d8a5b604b0ebf847449754f55952d03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612858 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841980}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3a0405597374..1670c5184b9e 2021-01-11 stha09@googlemail.com IWYU: add missing include for size_t If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I73e7b7be0bb5333d929abc689916c2832303c0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620466Reviewed-by:
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I8e50aadb524f698ea259995d6ff90a90918e7dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618678 Auto-Submit: Javier Flores <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f8b83eaf..cd58c190 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I969e583e6fd9d2afee4c49ac8f70563f216c9947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620887Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841977}
-
arthursonzogni authored
Apply CheckedObserverAdapter::IsMarkedForRemoval() advise: ``` If |weak_ptr_| was invalidated then this attempt to iterate over the pointer is a UAF. Tip: If it's unclear where the `delete` occurred, try adding CHECK(!IsInObserverList()) to the ~CheckedObserver() (destructor) override. However, note that this is not always a bug: a destroyed observer can exist in an ObserverList so long as nothing iterates over the ObserverList before the list itself is destroyed. ``` I have absolutely no clue what is causing bug 1153966. All the observation are wrapped inside base::Scoped{Observation, Observer}, so this shouldn't happen in theory. However there are proof it happens in practice: https://crash.corp.google.com/browse?q=ReportID%3D%27e5305cdcd95db0cb Bug:1153966 Change-Id: I067ccdd4d0b34737ba54b31a6fb5b6b1a9d2e0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615346 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841976}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610333688-2ac90a21c191bd1ea4698597daab8949225692c9.profdata to chrome-win32-master-1610338418-0a30eb701be1732e98bc8c78e37a5b6340c67f55.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2da0a88ba93da59bf56763f86941623b2b7ddbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621039Reviewed-by:
-
Wei Lee authored
After https://crrev.com/c/2602969, |OnDeviceClosed()| might be triggered from different threads. But in |OnDeviceClosed()|, it will access |camera_app_devices_| and might introduce race condition. Therefore, to fix it, we can post the task to make sure that |OnDeviceClosed()| will be called on the same thread. And since now we will not call |OnDeviceClosed()| directly and the mojo error handler of a receiver set might be triggered more than once, we should also handle it properly. Bug: b/177191321 Test: Consecutively passes CCAUISettings.swa for 20 times Change-Id: I93e546a98c410017f17071c97336bfe40dcc7b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619247 Commit-Queue: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#841974}
-
David Roger authored
This CL fixes a crash happening after creating a signed in profile when the policy is set. This CL also adds browser tests checking that the signin profile is appropriately marked and unmarked ephemeral, and correctly destroyed at startup if required. Fixed: 1164314 Change-Id: I078fbc127d42267261b305149aff10e71ac53b59 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617926 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841973}
-
Alice Wang authored
This CL removes the redundant callback argument used in ForcedSigninProcessor. Bug: 1045525 Change-Id: I980e972cca487eed4f0669ffa44d9b44da33ef6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620259Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 29d2d6a2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I0c802a57f9296950b98fe752c9df4a06368ac8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619683Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841971}
-
dpapad authored
Bug: 1028829 Change-Id: Ib72761c7cafa6ec574fafebaf39d4c38e23a31c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616970 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841970}
-
Alice Wang authored
This CL moves the method logSigninStartAccessPoint to SigninMetricsUtils to group the metrics logging methods in one place. Bug: 1163476 Change-Id: Ib06a01d2a72bcd4c27ef4e66f77aa96300638261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611733Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841969}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f6c68d018a06..97eede48be1e 2021-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from f936dc21 to 9da1d76d (569 revisions) 2021-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 51603c63d1cb to 0b90eef09f60 (1 revision) 2021-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 00fcab636a05 to 3a0405597374 (4 revisions) 2021-01-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 937395c1ed5d to 348ba200aa29 (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I1c5b49e3858c830436e1f9f2cd12407c614d2d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621042Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610333688-1f5858297e8ef0a67e2af96364fce2691e142dbc.profdata to chrome-win64-master-1610338418-1bf01a8f47d2b9b410b39a25bf178b364099d014.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7a9fef036ed79a387a85fd92a95ea88febb96397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621037Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bca58b67b633..53f842487859 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC harrisonsean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: harrisonsean@google.com Change-Id: I70150f5728e12ed42cbc68c5d370dd1e1e2f3fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621040Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - dialog_types.js - directory_tree_naming_controller.js - mock_navigation_list_model.js in //ui/file_manager/file_manager/foreground/js/ui/: - directory_tree.js - directory_tree_unittest.m.js Add "jscomp_off=duplicate" to the closure flags for unit tests. This flag is present in the `default_closure_args` used for non unit tests, and is required here for the proper compilation of //ui/webui/resources/js/cr/ui/tree.m.js. Without this flag, closure complains about rowElementDepthStyleHandler being redefined after defining a getter and a setter for it. Rename TreeItem in directory_tree.js to FilesTreeItem, to have the necessary distinction between this class and the `TreeItem` defined within the cr.ui namespace. Bug: 1133186, 1134497 Change-Id: I6b5b5a64a20b9e70e2498ea9a8af33e048ae4efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616648 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#841965}
-
Aya ElAttar authored
- Change the clipboard bubble colors if the dark mode is enabled. Bug: 1150740 Change-Id: I128ccc9b0a4b746c8972e253f685ee4bd59ea85f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601363Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#841964}
-
Wojciech Dzierżanowski authored
With the aspect ratio maintained on all the platforms at the native widget level PictureInPictureWindowControllerBrowserTest.SurfaceIdChangeDoesNotMoveWindow was not realistic. It called SetBounds() on the window directly the way it never happens in real life due to the aspect ratio constraints. The video aspect ratio was 1.5 in this case, but the first SetBounds() call forced it to 1.0. Moving the test to OverlayWindowViewsTest makes it simpler and more stable without losing important coverage. Note that we don't need an actual video playing in the PiP window to verify the behavior we're interested in here. Bug: 1146047 Change-Id: If5ba686350d5823501b9ae05e486f8076771b3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611261Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#841963}
-
Francois Beaufort authored
Updates runtime_enabled_features.json5 to mark the Web NFC API stable on Android. Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/aoj06_plqPc Bug: 520391 Change-Id: Ieaf7bef30c7eb3fa26e60f75c1bcd76d805c379d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584803Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53c34d99574c..9c46f2cb69a6 2021-01-11 szuend@chromium.org Skip flaky DataGridController interaction tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1164826 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I10d53efa806d11cd05c7f978be053a1482cc93e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621041Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/952be209246a..8cf47fb7ac36 2021-01-11 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-11T04:01:55). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b78deccc718f36112c94a2cef4bf786e1f04053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620517Reviewed-by:
-
Simon Zünd authored
As part of the "First Party Sets" privacy effort, cookies get a new boolean attribute 'SameParty'. The attribute works similarly as 'SameSite' and allows cookies to be sent in same-party, cross-site contexts. This CL adds the attribute to the DevTools protocol, so it can be shown in the various Cookie tables in the DevTools frontend. R=caseq@chromium.org Bug: chromium:1161427 Change-Id: Ica094fcc3acc38e8fb36cada40c198c41ca82262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598846Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#841959}
-
