- 15 Nov, 2019 40 commits
-
-
Wez authored
DiscardableSharedMemory::Purge() attempts to proactively de-commit pages once the instance is unused, to free it quickly even if the peer is slow to unmap it. However, the DiscardableSharedMemoryManager (typically in the browser) maps instances but then closes their handles - Purge() must therefore be implemented without reference to the handle. Bug: 1023693 Change-Id: Ic645232c0b24d85acb64e915bbef05804b25b001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912698 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#715865}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cc221e838b01..83ca1b9af5cc git log cc221e838b01..83ca1b9af5cc --date=short --no-merges --format='%ad %ae %s' 2019-11-15 swiftshader.regress@gmail.com Regres: Update test lists @ cc221e83 Created with: gclient setdep -r src/third_party/swiftshader@83ca1b9af5cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I2a94b0426f5143ddbd052b3dec9cde9f7c564971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715864}
-
Matt Menke authored
It has been optional, but now that all the calls that need a meaningful NetworkIsolationKey argument have one, can make it mandatory and fill in the remaining callsites with an empty NIK. Bug: 997049 Change-Id: I9cc2809a0d67fe4298b122642bf1a502759f6871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913270Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#715863}
-
Maks Orlovich authored
Doing this in DoPartialHeadersReceived was OK for redirects, but caused trouble to things with bodies (e.g. 500) since the cache hit transaction ended up still marked as a writer, and so once the cache data was exhausted, TransitionToReadingState went to try to read from a non-existing network transaction. Instead, do this in DoSetupEntryForRead, to give it a chance to mark this as a reader. Bug: 1024918, 1015829 Change-Id: I8ddb736b2834b1e745228473402ad6584a5ffed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918315Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#715862}
-
Tommy Steimel authored
There are some media tests that occasionally flake on many different bots. They all have the same underlying issue that sometimes the first frame of the video hasn't painted yet when the screenshot is taken. Marking them as flaky for now until we can figure out a deterministic way to make them pass. Example failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48598 Bug: 1024976 Change-Id: I66e970c499f6719adcfd400966cf225aced68723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918321 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Auto-Submit: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#715861}
-
Alex Ilin authored
PlatformWrapperTest used the deprecated base::SharedMemory and base::SharedMemoryHandle classes. This CL converts the tests to use base::UnsafeSharedMemoryRegion class. Bug: 795291 Change-Id: Ia863616ba23e8ebe17a16fe994a9b6b3b2beafd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919150 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#715860}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b9e8ed45cb0..77c16a79405b Created with: gclient setdep -r src-internal@77c16a79405b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I2a3f3637569f5fea455fb7415374cdd4f6557c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919488Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715859}
-
Kamila authored
Bug: 986737 Change-Id: I6faa14dcf4dad51f008b61062325e4eb0b1ab28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917529Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715858}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/42251f9ad57e..ce2f6cfa67a4 git log 42251f9ad57e..ce2f6cfa67a4 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@ce2f6cfa67a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4f442dcd91a7be609cbded6c51a6be7855ba3794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919487Reviewed-by:
-
Henrique Nakashima authored
A new test verified all keys conform to "Chrome.[Feature].[Key]": ChromePreferenceKeysTest.testDeclaredConstantsConformToFormat() Grandfather in the constants currently used, since none of them conforms to the format. Bug: 1023839 Change-Id: I7175594d9027d0160d5f102175ee4df3ff27a61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912646 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#715856}
-
Wenjie Shi authored
This CL modifies the Sensors.Windows.WinRT.Activation.Result to log HRESULT_FROM_WIN32(ERROR_NOT_FOUND) when the sensor does not exist on this system. This brings the histogram on parity with the Win32 flavor. Bug: 958266 Change-Id: I6406c9ef3335d7d892ba8afaaa1b1848a6461ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919570Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wenjie Shi <wensh@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715855}
-
Alex Ilin authored
This CL removes all usages of base::SharedMemory and base::SharedMemoryHandle from media::UnalignedSharedMemory since there are no more callers of the constructor using these classes. UnalignedSharedMemory itself is deprecated and should be eventually removed as part of shared memory refactoring in future CLs. Bug: 795291 Change-Id: I808c9fff08923f3414643e6258667dba2365f621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917376 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#715854}
-
Jasper Chapman-Black authored
* In "method count" mode, sort by symbol count (descending) rather than size. * Tiebreak by name in method count mode and size view mode. Bug: 1001765 Change-Id: I849a61ce72c9b2bd5e2348cdfcb8d54d51d33f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919546 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715853}
-
Sasha McIntosh authored
Extends the decode-webp-images-to-yuv browser flag from M80 to M88. Bug: 966008 Change-Id: Ic27dcf609abe1af58d380417c248f90958297737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918944Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715852}
-
Michael Spang authored
Bug: 1021770 Change-Id: Ia7c8e3aff8aa84f05e105f161d56d7f9a0f7ef70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907775Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715851}
-
ckitagawa authored
Found while working on Cluster Telemetry, subframes will be saved to the wrong directory if capturing them is enabled. This CL fixes that behavior by making the root_dir part of the document data. Bug: 1025331 Change-Id: I39a82cca438da20368c6cb4692d628fb6aba2549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919545 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#715850}
-
John Budorick authored
Bug: 922145 Change-Id: I2f4259502b812e3bb4b411ca65318000bd3c7286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918310 Commit-Queue: Yun Liu <yliuyliu@google.com> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#715849}
-
Matt Jones authored
This patch makes the BottomSheet class protected. Accessors of the view have been restricted to test methods. Most of the initialization logic has been moved back into to BottomSheetController class with the exception of the creation of the view and snackbar manager. Bug: 986310, 1002277 Change-Id: I5e9cb255f89cd66add8fee93111cf09940be8452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910288 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Ken MacKay authored
When the mixer is in the same process, audio buffers are sent to the mixer service by just posting a reference. The mixer service holds the reference until the audio is written out; the audio buffer must not be overwritten until this occurs. Therefore, use an IOBufferPool to manage the buffer lifetime. Bug: internal b/143628666 Change-Id: I4bd247c806c0ec5d909ffa048dd0f8d30aeabed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917958Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#715847}
-
Tim Judkins authored
This changes the handling of the creation flag for withholding on install to always take preference for triggering withholding and changing the stored pref value. It also makes it so the pref value is always set to a default value on install / update, if a value had not been set previously. Bug: 984069 Change-Id: I0282ad3d159bffee0c26fecdcb47510ebfc92b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865773 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715846}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/86e9f140ce37..a6bbfb935a25 git log 86e9f140ce37..a6bbfb935a25 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 cduvall@chromium.org Fix getting pixel density on emulator Created with: gclient setdep -r src/third_party/catapult@a6bbfb935a25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: None Change-Id: I0ebfb8973b667c2d2eb7fe26e629c4cf1d2c2eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918402Reviewed-by:
-
Toni Barzic authored
* Updates the target drag distance at which the home screen stops scaling - instead of extending for a fixed point from the threshold at which transition is allowed, that target is set to the center of the screen * Significantly shortens the timeout to trigger transition * Allows transition if pointer is moving, provided that the velocity is below certain threshold (instead of requiring pointer to stay still) BUG=1005366, 1025283 Change-Id: Ic322932a3ae519a1989ef343f6f2e960dca29709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912993 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715844}
-
jameshollyer authored
The call to BluetoothTaskManagerWin::DiscoverDevices runs on a loop until either discovery stops or we find the device we are searching for. If discovery stops this function called BluetoothTaskManagerWin::OnStopDiscovery. However, we call BluetoothTaskManagerWin::OnStopDiscovery already when we stop. The second call causes a crash. This CL removes that call. Bug: 1022149 Change-Id: I74d977abdfd69cbde2e525a024b1f6016148ed7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915300Reviewed-by:
-
kylechar authored
Update code where NULL or 0 is assigned to a scoped_refptr to reset it. Just call reset() instead. If operator=(std::nullptr_t) is added these assignments become ambiguous. This CL was uploaded by git cl split. R=mattreynolds@chromium.org Bug: 1024981 Change-Id: I88fc42fe0c2b6e2925b9c5da0321438f51af2dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918201 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#715842}
-
Jasper Chapman-Black authored
Also adds diff_test.cc. Bug: 1011921 Change-Id: I3d678738719531d1c74e620f4fc3605cab08b325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918027 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#715841}
-
Andrew Grieve authored
use_uncompressed_dex: We already enabled uncompressed dex in chrome bundle via bundletool, but forgot to remove this GN arg and also forgot to enable in webview apk. This now enables uncompressed dex for trichrome library & trichrome webview. multidex_in_release: Was for an old experiment that is no longer relevant. Bug: 777858 Change-Id: I46adff481824c1975a7939fb6b2abbf357c4b5fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918142 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#715840}
-
Bailey Berro authored
Marks the "Set up" / "Verify" button as described-by the secondary text, which contains additional context about the button Bug: 1012565 Change-Id: I4c92615792e59177b33b3354557af14c5a3aa0f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917751 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#715839}
-
Samuel Huang authored
Previously resource_ids requires manual curation. These files contain an implicit "structure" that imposes grouping, dependency (avoids overlap), and parallel streams (allows overlap) of item lists. It turns out that the implicit structure of start IDs can be modeled as a Series-Parallel (SP) Graph. By introducing "META": {"join": #} fields to resource_ids, the graph structure can be made concrete. This CL adds a new GRIT tool that updates resource_ids file while preserving structure. The inputs are: * Existing start ID assignment, whose numerical sequence (along with newly added "join" meta data) stores the SP Graph. * GRD files linked to by resource_ids, which are parsed to find per-tag ID usages. * For GRD files that may be unavailable (e.g., generated ones, or src-internal ones), "META": {"size": {...}} fields is needed to specify bounds for per-tag ID usage. The main output is the resource_ids file with renumbered start IDs. Debug flags are available to access intermediate data. Chrome's main resource_ids file is updated to include the new "META" flags. However, as a precaution, the start IDs are not yet reassigned using the tool -- this will be done as a follow-up. Bug: 979886 Change-Id: If7c0a43f57a1d27950784da7eb8405a6a0567f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895736 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: -
Matt Wolenetz authored
The subtest, "Running: testStartFromPanel" is occasionally followed by unexpected text like: "error: Children are longer than parent at " ... See https://bugs.chromium.org/p/chromium/issues/detail?id=1025321#c1 for more details and links to example builder outputs. BUG=1025321 TBR=yangguo@chromium.org Change-Id: Idb75905f92265501792483e0aef10e976a83245f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919573Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715837}
-
Henrique Nakashima authored
Bug: 889467 Change-Id: Id76032003fef56b0bc9e18fc86fe55152d7a89fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904497Reviewed-by:
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/safe_browsing This CL was uploaded by git cl split. R=drubery@chromium.org Bug: 1018667 Change-Id: If7ddeb1e024b96a5d0e64e16c6306d15ab5ca3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917230 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#715835}
-
Kamila authored
These strings are added for an additional option in notifications, where the user can enable quiet notifications, or quiet notifications can be auto-activated by the browser after several denies. The strings are experimental, for two different UI flavours. Bug: 986737 Change-Id: Ib6c6c0752ecd91b3f8fa34605ec10b052e56c25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919208Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/adab0ef7..428e7aff Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I316538cf000bacb5634ab077d7eb90a21103a88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919599Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715833}
-
Lily Chen authored
This fixes the SameSite cookie behavior for the special chrome:// scheme which is used for UI. chrome:// should be treated as first-party when embedding a secure origin. This is done in several places by setting an |attach_same_site_cookies| flag to true when computing the SameSiteCookieContext to pass in the CookieOptions, if the special scheme is detected (which causes the context to be computed as same-site). For URLRequestHttpJob, we check for the special scheme via the CookieStore's CookieAccessDelegate, which checks the CookieManager's CookieSettings (which contains lists of special-case schemes). For RestrictedCookieManager, we check for the special scheme by directly querying the CookieManager's CookieSettings. For DevTools InterceptionJob, we check for the special scheme by calling a ContentBrowserClient method to identify the special schemes. Bug: 1007320 Change-Id: I7ce0f483bc7e2301f22cb13cef8666e399973979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904544Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#715832}
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/94591413f1fe..409b261f38af $ git log 94591413f..409b261f3 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 rch Add a new QUIC platform API QUIC_SLOW_TEST which will be used in chrome to disable tests which are too slow. 2019-11-15 wub gfe-relnote: (n/a) Change QUIC's AckedPacketVector and LostPacketVector from std::vector to QuicInlinedVector with a inline capacity of 2. Not protected. 2019-11-15 fayang Introduce HandshakeState enum to sent packet manager. Not used yet, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Add missing QUIC files to net/BUILD.gn Change-Id: If98c172bc524cac0e64c8445d54ed9041b3c29d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918285 Auto-Submit: Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#715831}
-
Renjie Tang authored
Change-Id: I0861e5a870f2e43f45d971b8c6b6530ac72db59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918836 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1018141 Change-Id: I3a6994275e215fbe0d6961aae974696840f77620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919341Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#715829}
-
Nektarios Paisios authored
Some attributes such as ID, class name, relative bounds and visibility are automatically added by ViewAccessibility. R=dmazzoni@chromium.org, sky@chromium.org Change-Id: Ic27ec3f3d30e57f4e6ecd6ba2bb264650b20c887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918682Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c795d9ef28b..deae1fce2cc5 git log 1c795d9ef28b..deae1fce2cc5 --date=short --no-merges --format='%ad %ae %s' 2019-11-15 lehoangq@gmail.com Enable Metal backend. 2019-11-15 timvp@google.com Update GLES31 Expectations Created with: gclient setdep -r src/third_party/angle@deae1fce2cc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: Ia1d131e44808dd0ed7920c763c338f185ac196f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919483Reviewed-by:
-
Toni Barzic authored
Makes home scale and fade in animation run in parallel with overview fadeout (instead of waiting for the overview animation to end). Change-Id: Ica9bd3cc98faf5dd2827fe6871a1f4b7b5d7c953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918664Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715826}
-
