- 21 Oct, 2020 40 commits
-
-
Luc authored
Bug: 1007635 Change-Id: I7e9a7bffda59cdda441018275a40cbb2144d146f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486962Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#819218}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603216608-9fdc3766d62145cb23e4981f379b4b4bd1eab8ae.profdata to chrome-linux-master-1603238376-41278602b445da41d1916a61de8117b0857ab174.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2fdd67e566be233b3c6c3eb2097f21330bb9cea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488155Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819217}
-
Sophie Chang authored
Also changes dougarnett to mcrouse/sophiechang where appropriate Bug: 1140005,1140000,1139999,1139998,1139997,1139996,1139995,1139994,1139993,1139992,1138428 Change-Id: Ie562d08a9038a7ff8fc4be093aa1f7771fa2cfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485757 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819216}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603216608-7529e831dfcfdc3eeb93d3e8d9f23aaded5766b2.profdata to chrome-mac-master-1603238376-a0754723f0cd6eaa7fc2494ab4a5f08c0cee1720.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8198fea6a11d4a25551739ccbaeb4495bc70323a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488150Reviewed-by:
-
Leo Zhang authored
ImeDecoder is used for loading decoder shared library and all required function pointers before sandbox is engaged. After sandboxing DecoderEngine will take advantage of these preloaded functions to decode inputs. TEST=local betty VM. BUG=b/161491092 Change-Id: I8ab77da32ad678a996f607be2b3840d7345be4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486825 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#819214}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a08f3d9f..d20e0a34 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I832901f133635060125f50b35abc3203a4c6400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489000Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819213}
-
Jinsuk Kim authored
ToolbarManager injects the necessary objects through ViewShifting- ActionBarDelegate to remove the dependendency on ChromeActivity in the class. Bug: 1127732 Change-Id: Ief8e4a5f12d2488389e02c4fbe5af0e353f3d8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430566Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819212}
-
Matt Mueller authored
Bug: b/143909628 Change-Id: I8942a9b3f68ad5266b7d10aa3146c9cf8778e76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488712Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#819211}
-
Nick Harper authored
https://boringssl.googlesource.com/boringssl/+log/3743aafdacff2f7b083615a043a37101f740fa53..a673d02458b1b7d897084266b93d5c610e36bd17 The following commits have update notes: cefbf9cea Const-correct X509_get0_extensions. Bug: none Change-Id: I256c6fcdd9217c1ca4be47409204d41413988b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461604 Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#819210}
-
Ian Wells authored
This reverts commit 8699ff59. Reason for revert: Caused crbug.com/1140401 and various other failures. Original change's description: > Enable JDK library desugaring by default > > Bug: 1056751 > Change-Id: Id517413e180ad7cc2f7688d47038587f2a3ecb5e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458853 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#817575} TBR=agrieve@chromium.org,iwells@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056751 Change-Id: I3da3c17f6b56f7233232f5ae9eee4af83158b525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487817Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#819209}
-
David Van Cleve authored
This change expands the definition of a Trust Tokens key commitment struct to accept a list of operating systems on which to redirect issuance operations (for the issuer hosting the key commitment) to the operating system, rather than sending these issuance requests directly via an HTTP request. It's the first step in implementing on-device ("platform-issued") trust token issuance support. Fixed: 1130249 Change-Id: I9eec53ecf2c3eb611e547b78ee60cbdc800e0c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432445Reviewed-by:Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819208}
-
David Schinazi authored
R=bnc@chromium.org Change-Id: Ib485c7c701ec9269829806be907a070b6829eb4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488754 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#819207}
-
Lachlan Ford authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2469836 Change-Id: I6f32193f583cf368d8de152d8577b6796f4a3387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488605 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#819206}
-
Haiyang Pan authored
When this property has the default value "no", AVDs with android-10 and later have issue with "back" and "home" buttons under graphical mode. These buttons will not work as they should when clicked. Setting the prop to "yes" will fix this issue. Bug: 922145 Change-Id: I67322347f323d9b31927589b00624a41f5acc356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486288 Commit-Queue: Haiyang Pan <hypan@google.com> Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819205}
-
Jinsuk Kim authored
With this CL, toolbar/ classes are free of dependencies on chrome/browser/ntp. A new interface NewTabPageDelegate plus its implementation in ToolbarManager replaces the references to NewTabPage. Dependencies on static URL util methods in NewTabPage, NativePageFactory were addressed by moving the methods to modularized targets - components/embedder_support/android:util_java and chrome/browser/ui/native_page, respectively. Bug: 1127732 Change-Id: I8619db6454b1aa274328a3a243b977cbd87aac02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467578 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Robert Ma authored
Calling killpg() on a process group whose leader is defunct causes a permission error on macOS, in which case we try to collect the defunct process. (On Linux, this would be a no-op. kill() a zombie process is always a no-op on both macOS and Linux.) Fixed: 1140363 Change-Id: I3253f315c40fecd3b9ebb4ebe4d0d18bcf0636d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488369 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#819203}
-
Bill Budge authored
- Adds a getter to go with the SetIsCrossOriginIsolated function. We need to be able to access this in content::RenderProcessImpl, in order to properly set V8 up. Bug: chromium:923807 Change-Id: I99337ea49537cd6f2b5ebb76f2ceddac38260dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488716Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#819202}
-
Koji Ishii authored
|ShapingLineBreaker::Hyphenate| should look for hyphenation points at the line edge or after, but it did not include the character at the line edge. This patch fixes this. This occurs often when `fit-content` inline size is used. Also changes the test to use Ahem because Win uses U+2010 HYPHEN instead of U+002D HYPHEN-MINUS, but other platforms use U+002D. Bug: 1140738 Change-Id: I5e1157de07b58edddb92c6c80ff8df460fc064b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485352Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819201}
-
Clark DuVall authored
All known issues have been fixed so enabling this in canary to see if there are any major problems. Bug: 1126301 Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819200}
-
Yi Zhang authored
//chrome/browser/devtools/ This CL is the 1st part of converting base::Bind to Once/Repeating in //chrome/browser/devtools/ Bug: 1007635 Change-Id: I8a58f155c3ae402f860492af77df21c133c5f453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486573Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#819199}
-
Thomas Lukaszewicz authored
This CL updates the read later bubble to use the WebBubbleDialogView. This change results in the bubble Widget being shown async. A follow up is required to ensure the Read Later button handles the async interaction correctly. Bug: 1099917 Change-Id: I61ca01d8774f8eacaaad360ab0e653f39c0d5cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462250 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819198}
-
David Bienvenu authored
Also some lint fixes, and c++ modernization; no functional changes. Bug: 1010217 AX-Relnotes: n/a. Change-Id: I3347ea195ecf3707727730e8f1ee9e9b0de2abff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476724 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819197}
-
Eliot Courtney authored
This also fixes a bug where sometimes fds are not received and lacros can't start. Bug: 1139796 Test: Can run lacros on chromeos via this script Change-Id: I33f5fae07b377fb7848dc444be7fcb4f8d4a3f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483749Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#819196}
-
Charles Zhao authored
Currently CreateBrowserWithTestWindowForParams takes a pointer as input, changes its value, and then use the value to CreateBrowser, and both the CreateBrowserWithTestWindowForParams and the caller do not need the pointer any more. It makes more sense to let CreateBrowserWithTestWindowForParams take a value as input. Bug: 1139754 Change-Id: I229a198e7f998cacd80ea8e092c94ad7a56d19d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484028Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819195}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ee18f390eead..85d9d5d4bbc6 2020-10-20 amaiorano@google.com Subzero: workaround bad codegen for Windows x86 at Om1 optimization level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iad880e3af0d472db8bccf29aa1c54deb77446f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487918Reviewed-by:
-
Rakesh Soma authored
if individual resolution url parsing fails. Bug: 1140575 Change-Id: Iebe612418486a2650632f0861c2622a426b65e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487825 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#819193}
-
Gavin Williams authored
Have ChromeVox refer to the right-arrow icons as "Subpage button" to clarify the button's action to the user. Bug: 1012105 Change-Id: Ia1159047aabf6e55bf2d5b989ab4ff40f919a684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481683Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#819192}
-
Dave Tapuska authored
I suspect something odd is going on with RenderDocument not marking the Frame as detached. Marking the frame as detached Closes the WebFrameWidgetBase via RenderWidget::CloseForFrame. Turn this into a strong assert (there already is a DCHECK in RenderWidget) that asserts the same thing. BUG=1139104 Change-Id: If164f299a2fa9964747556dee38216f7ff78a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487705 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#819191}
-
Yury Khmel authored
This enables ARC power control in Chrome with tracing support. Changing ARC power modes is available in developer mode only. DD: go/arc_power_control BUG=b:170982650 TEST=Locally Change-Id: I9be38e04417075578f4bd01c9952a68de4841653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481906 Commit-Queue: Yury Khmel <khmel@google.com> Auto-Submit: Yury Khmel <khmel@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819190}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/7156d3e3140b..4f79c8405028 2020-10-20 dsinclair@chromium.org [spirv-writer] Deduplicate sampler and comparision_sampler. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I0c34a524b9a2fc20525a051d174f3fa39ed47016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488587Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1227ffd79585..bd66f2d95186 2020-10-20 jalyn@microsoft.com Shortcut editor: Centralize button creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia17127f3ed024d31bb083977355506eb67783633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487919Reviewed-by:
-
Daniel Rubery authored
This feature collects certain features of the current navigation and includes it in CSD pings. But the data is not being used for training or protection, so remove it. Bug: 1138986 Change-Id: Id77a757569ee0bab40235ec2eb4145e75bb672c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487699 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819187}
-
Renjie Tang authored
Bug: b/171063562 Change-Id: Ib17016732a59cb434855af3098288ec4147fb939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488700 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Change-Id: I9e7db8e9775b9e6cd0813ffeaad68405bcc96607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487946Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819185}
-
Moe Ahmadi authored
"chrome-ntp" will be used for Google Suggest requests from non-searchbox (neither realbox nor omnibox) NTP surfaces including Repeatable Queries in the Most Visited tiles. Bug: 1110082 Change-Id: I64fd89fb1c624e1b7be77db04153cc255834a4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473443 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#819184}
-
Dave Tapuska authored
Since we no longer create a fullscreen widget we can remove its knowledge from WebContents and its delegate. BUG=1134674 Change-Id: Id12cf67c5ec76dcaddb564301bf032eac4b3370d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487148Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Yuki Shiino authored
In order to support IDL namespaces, refactors WrapperTypeInfo and related code. - WrapperTypeInfo::GetV8ClassTemplate replaces old DomTemplate member function. - WrapperTypeInfo::idl_definition_kind distinguishes IDL interface from IDL namespace. - Installer functions take v8::Template and v8::Object because an IDL namespace is not a JS function. - bindings::SetupIDLInterfaceTemplate in generated_code_helper.h replaces old V8DOMConfiguration::InitializeDOMInterfaceTemplate. (V8DOMConfiguration is no longer used in the code base.) Since we no longer use adapter functions for WTI::DomTemplate, the APK size will be reduced by 10 KB. Bug: 839389 Change-Id: I0adb59372adbfa6f4611009324b399c5249ba249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464515 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819182}
-
Nidhi Jaju authored
According to https://github.com/whatwg/streams/pull/1035, all methods and accessors are now enumerable, per Web IDL defaults, instead of non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can be removed from the Streams WebIDL files. This CL specifically removes them from writable streams. Bug: 1093862 Change-Id: I935a9f8726b3cb1dc4efb5b4d6db71384c8efe37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485664Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#819181}
-
Nidhi Jaju authored
According to https://github.com/whatwg/streams/pull/1035, all methods and accessors are now enumerable, per Web IDL defaults, instead of non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can be removed from the Streams WebIDL files. This CL specifically removes them from readable streams. Bug: 1093862 Change-Id: I2cab1814a7d34beeca16b15fd6c64339d296952f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485986Reviewed-by:
-
Kevin Marshall authored
Defines a Fuchsia package, "web_engine_with_webui", which is a variation on the WebEngine package with WebUI static resources included. Adds web_engine_with_webui to CIPD recipe. Modifies web_engine_shell to support running packages other than "web_engine", so that "web_engine_with_webui" can be used. Prepares GPU integration test runner to use "web_engine_with_webui" (pending integration with Catapult). "web_engine" will have its resources removed in a followup CL. Bug: 1092729 Change-Id: I321c95b8f41902180e9edbe5e7404438956e1e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424514 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819179}
-
