GitLab

TBR=vsevik
BUG=

Review URL: https://codereview.chromium.org/696553002

Cr-Commit-Position: refs/heads/master@{#302205}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9bde31e..d8aa7b7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/688953002

Cr-Commit-Position: refs/heads/master@{#302204}

This relands https://codereview.chromium.org/683583002/

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/695583002

Cr-Commit-Position: refs/heads/master@{#302203}

When no browsers are open and About Chrome, Preferences or
the Task Manager are selected from the menu, the guest profile is by
default used. If the guest profile preference is disabled, then first
show the user manager, then direct to the selected page.

This is somewhat of a follow up to: https://codereview.chromium.org/564453003

BUG=412862

Review URL: https://codereview.chromium.org/631163004

Cr-Commit-Position: refs/heads/master@{#302202}

This update includes the ones used in CL 576313002 (https://codereview.chromium.org/576313002/).

BUG=405690, 406200

Review URL: https://codereview.chromium.org/686223002

Cr-Commit-Position: refs/heads/master@{#302201}

Previously it was true to maintain consistency with the options_page key, but
this introduces more complexity than it avoids for extension developers.

BUG=414920
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/670623004

Cr-Commit-Position: refs/heads/master@{#302200}

This is a spinoff from: https://codereview.chromium.org/680193002/

BUG=NONE

Review URL: https://codereview.chromium.org/688343003

Cr-Commit-Position: refs/heads/master@{#302199}

This CL adds the following tests to app_shell_browsertests:
AppViewTest.TestAppViewGoodDataShouldSucceed
AppViewTest.TestAppViewRefusedDataShouldFail
AppViewTest.TestAppViewWithUndefinedDataShouldSucceed

BUG=352293

Review URL: https://codereview.chromium.org/643703007

Cr-Commit-Position: refs/heads/master@{#302198}

After landing of https://codereview.chromium.org/651593002,
the inheritance relationship between RendererAccessibility and
RendererAccessibiltiyComplete is not necessary anymore.
So we can make them one class.

BUG=417758

Review URL: https://codereview.chromium.org/688173002

Cr-Commit-Position: refs/heads/master@{#302197}

BUG=408328

Review URL: https://codereview.chromium.org/696453002

Cr-Commit-Position: refs/heads/master@{#302196}

BUG=428538

Review URL: https://codereview.chromium.org/690083005

Cr-Commit-Position: refs/heads/master@{#302195}

Since we deleted the gfx::screen each time we closed an app,
A query to the screen size during metrics gathering was causing
a check failure.

BUG=

Review URL: https://codereview.chromium.org/691023003

Cr-Commit-Position: refs/heads/master@{#302194}

This involves a couple of browser-side plumbing changes, as well as teaching RenderFrameProxy how to swap itself out in favor of a RenderFrameImpl.

BUG=422583

Review URL: https://codereview.chromium.org/600553003

Cr-Commit-Position: refs/heads/master@{#302193}

TBR=yurys
BUG=

Review URL: https://codereview.chromium.org/691903003

Cr-Commit-Position: refs/heads/master@{#302192}

BUG=428729

Review URL: https://codereview.chromium.org/690973002

Cr-Commit-Position: refs/heads/master@{#302191}

Many implementations of the NotificationDelegate include empty overrides
because of behavior they don't actually need to be informed of. Provide
empty default implementations so that they don't have to. (And remove the
associated TODO.)

BUG=428370

Review URL: https://codereview.chromium.org/684253002

Cr-Commit-Position: refs/heads/master@{#302190}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e228ba3..9bde31e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/688923002

Cr-Commit-Position: refs/heads/master@{#302189}

Review URL: https://codereview.chromium.org/691803004

Cr-Commit-Position: refs/heads/master@{#302188}

Revert "Revert of Reduce frequency of requesting bookmark clusters. (patchset #8 id:140001 of https://codereview.chromium.org/682933002/)"

This reverts commit 8077169f.

BUG=424254

Review URL: https://codereview.chromium.org/695493004

Cr-Commit-Position: refs/heads/master@{#302187}

The new flag carries the has_media status of a volume through from the DiskMountManager, so the information is available to chrome.fileManagerPrivate.onMountCompleted javascript listeners.

This is a re-land of issue 668013004, which fixes some initialization problems in VolumeInfo, which were causing flakey behaviour in tests.

BUG=420680

TEST=browser_tests: FileManagerPrivateApiTest.* FileManagerJsTest.*

Review URL: https://codereview.chromium.org/677413007

Cr-Commit-Position: refs/heads/master@{#302186}

BUG=314403

Review URL: https://codereview.chromium.org/691193002

Cr-Commit-Position: refs/heads/master@{#302185}

TBR=chrisha@chromium.org
BUG=

Review URL: https://codereview.chromium.org/680233004

Cr-Commit-Position: refs/heads/master@{#302184}

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3987
TEST=NaCl SDK example and run on NaCl Perf Bots

R=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/664543003

Cr-Commit-Position: refs/heads/master@{#302183}

BUG=133828

Review URL: https://codereview.chromium.org/642453003

Cr-Commit-Position: refs/heads/master@{#302182}

Using the Activity context ensures the content-targetted selection
handles use a theme consistent with the rest of Chrome's UI.

Review URL: https://codereview.chromium.org/696503002

Cr-Commit-Position: refs/heads/master@{#302181}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=harrym@chromium.org

Review URL: https://codereview.chromium.org/684643002

Cr-Commit-Position: refs/heads/master@{#302180}

Original was reverted due to a bad merge.

Rename BrowserActionView to ToolbarActionView
BrowserActionViews now represent significantly more than
just Browser Actions. Rename it to ToolbarActionView.

BUG=426448
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/653933003

Cr-Commit-Position: refs/heads/master@{#302179}

The change to accessibility_focus_ring_layer.cc prevents an endless loop if
the input ring is all the same point.

The change to accessibility_focus_ring_controller.cc addresses the underlying
cause - the timestamp we get from CompositorAnimationObserver::OnAnimationStep
is not guaranteed to be later than the most recent focus time (in practice,
it's up to 0.002 s earlier on an ARM Chromebook). A negative delta time
turned into NaN when we computed pow(fraction, 0.3) and that led to the
input ring being all zeros, triggering the issue above.

BUG=427649

Review URL: https://codereview.chromium.org/693623003

Cr-Commit-Position: refs/heads/master@{#302178}

We will revisit this at a later point in time. At the moment the decision is to have Win7 ASH mode as a
developer only option for debug builds of Chrome.

BUG=356475

Review URL: https://codereview.chromium.org/692863003

Cr-Commit-Position: refs/heads/master@{#302177}

Also removes the MixedScript_LoadAnyway_Bubble count (unowned, no longer in histograms.xml).

BUG=413057

Review URL: https://codereview.chromium.org/659573003

Cr-Commit-Position: refs/heads/master@{#302176}

DataReductionProxyStatisticsPrefs is instantiated on UI thread and then
its ownership is passed to IOThread. This causes weak_factory_ to be
invalidated on a different thread from the one it is created on. This
cl explicitly invalidates it on UI Thread.

BUG=428931

Review URL: https://codereview.chromium.org/669783004

Cr-Commit-Position: refs/heads/master@{#302175}

These tests do not need the full power of browser_tests and API tests
like these will eventually be moved out of app_shell_browsertests into a
new extensions_browsertests target that takes advantage of the lighter
app_shell framework.

BUG=

Review URL: https://codereview.chromium.org/695613002

Cr-Commit-Position: refs/heads/master@{#302174}

Missing enhanced bookmark owners coverage from https://codereview.chromium.org/682103003

NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/691853003

Cr-Commit-Position: refs/heads/master@{#302173}

BUG=

Review URL: https://codereview.chromium.org/687873003

Cr-Commit-Position: refs/heads/master@{#302172}

Add Spdy4Experiment group which can be kept at the same size as Spdy4Control,
while Spdy4Enabled can be arbitrary.  This allows enabling SPDY/4 on more than
50% while having a group the same size as Spdy4Control for convenient
comparison.

BUG=428690

Review URL: https://codereview.chromium.org/689923002

Cr-Commit-Position: refs/heads/master@{#302171}

CVC isn't recognized.

TBR=isherman@chromium.org
BUG=428926

Review URL: https://codereview.chromium.org/691073002

Cr-Commit-Position: refs/heads/master@{#302170}

I think this is a fix to this CL: https://codereview.chromium.org/656383002/
One of the internal bots has the following error:
  PullProfile at tools/telemetry/telemetry/core/platform/android_platform_backend.py:455
    self._ProfileDir(package), output_profile_path)
AttributeError: 'AndroidPlatformBackend' object has no attribute '_ProfileDir'
There does not seem to be a _ProfileDir, but there is a _GetProfileDir.

BUG=417542

Review URL: https://codereview.chromium.org/664583009

Cr-Commit-Position: refs/heads/master@{#302169}

The GetAnyChromePath and GetChromePathForInstallationLevel functions
previously returned the official Google Chrome executable path, even on
Chromium. Now on a Chromium build, they will return the installed path
to Chromium, if any.

BUG=428600

Review URL: https://codereview.chromium.org/686383002

Cr-Commit-Position: refs/heads/master@{#302168}

setsockopt() can now be called with these options:
  SO_RCVBUF
  SO_SNDBUF

BUG=none

Review URL: https://codereview.chromium.org/304373008

Cr-Commit-Position: refs/heads/master@{#302167}

Currently metadata record only contains size and it is not used anywhere.
In the future size will be used for storage management by datatypes.

Next step is to add crc to metadata record.

BUG=424304
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/690723004

Cr-Commit-Position: refs/heads/master@{#302166}