GitLab

This CL also have some renames and code changes related to state.

BUG=463671

Review URL: https://codereview.chromium.org/1026323002

Cr-Commit-Position: refs/heads/master@{#322079}

This will enable building the ANGLE perf tests on Windows perf bot
builders.

BUG=angleproject:744
BUG=468852
R=sievers@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1021763002

Cr-Commit-Position: refs/heads/master@{#322078}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6b6978f..3be346d

TBR=alph@chromium.org,jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/1024553011

Cr-Commit-Position: refs/heads/master@{#322077}

In order to avoid future regressions.

BUG=469235
TEST=interactive_ui_tests --gtest_filter=AcceleratorInteractiveUITest.*

Review URL: https://codereview.chromium.org/1026513005

Cr-Commit-Position: refs/heads/master@{#322076}

This logic was simplified and made more robust with
http://crrev.com/848003006, but there is still a report that this is still a
problem.

I am suspicious of the popover detection logic. The popover could belong
to any window, and could be in the middle of fading in or out. Change the
logic to a hopefully more robust on-demand detection using
[NSApplication targetForAction:@selector(performClose:].

BUG=47134

Review URL: https://codereview.chromium.org/1025793002

Cr-Commit-Position: refs/heads/master@{#322075}

1.6.0c provides the ability for clients to manually provide an app version when instantiating the analytics service.

BUG=469258

Review URL: https://codereview.chromium.org/1036443004

Cr-Commit-Position: refs/heads/master@{#322074}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/46bffd6..48dc6dc

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1011383008

Cr-Commit-Position: refs/heads/master@{#322073}

There are assumptions that the IPC message limit is 128MB
so ChannelMojo has to allow messages in upto the message size.
Such large messages happen when IDB reads/writes huge records.

BUG=464151
R=agl@chromium.org

Review URL: https://codereview.chromium.org/1029703002

Cr-Commit-Position: refs/heads/master@{#322072}

The answers in suggest doesn't put a space between, for example
+ the degrees Fahrenheit and the day of the week
+ the stock price and the stock delta (+/- value)

This CL puts a space between those values, which is more readable for the user.

BUG=

Review URL: https://codereview.chromium.org/1023993003

Cr-Commit-Position: refs/heads/master@{#322071}

Gate out ICU initialization for OS_NACL,
as it calls other code that is not built for nacl.
Undetected in gyp build since we always build the nacl irt as release
with gc-sections.

Stop building the ppb_var_deprecated_proxy as it's only used in the
trusted build for flash.
Undetected in gyp build since we always build the nacl irt as release
with gc-sections.

BUG=https://code.google.com/p/chromium/issues/detail?id=462791
TEST=trybots
R=dmichael@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/1034553002

Cr-Commit-Position: refs/heads/master@{#322070}

Design doc: https://docs.google.com/a/chromium.org/document/d/1PCQltNDdyZyuPHUdqYIjeObRrVOhf8WTr6BLfuTQ4ew/edit?pli=1#

BUG=468093
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1015623005

Cr-Commit-Position: refs/heads/master@{#322069}

The HTML encoding spec unified Big5 and Big5-HKSCS and we're not
distinguishing them any more.

The spec also has IBM866 that is not in the menu, yet.

BUG=None
TEST=manual:
1. load a page in ibm866 and check the encoding in More Tools|Encoding.
2. load pages labelled as in Big5 and Big5-HKSCS and check the encoding.
TEST=browser_tests --gtest_filter=*ncodin*
TEST=unit_tests --gtest_filter EncodingMenu*

Review URL: https://codereview.chromium.org/1024713002

Cr-Commit-Position: refs/heads/master@{#322068}

BUG=439651

Review URL: https://codereview.chromium.org/1031943002

Cr-Commit-Position: refs/heads/master@{#322067}

I extended the current CaptureAPIType exposure on chrome://media-internals page to work on ANDROID with the enum types defined below.

    enum CaptureApiType {
      API1,
      API2_LEGACY,
      API2_FULL,
      API2_LIMITED,
      TANGO,
      API_TYPE_UNKNOWN
    };

Enums are sourced from media/video/capture/video_capture_device.h file and auto-generated on the Android Java side by using java_cpp_enum scripts. They correspond to the same int values, and this is how it is communicated to cpp side on media/video/capture/android/video_capture_device_factory_android.cc.

                        +------------+
                        |VideoCapture|
                        +--+-------+-+
                           |       |
          +----------------+-+   +-+-----------------+
          |VideoCaptureCamera|   |VideoCaptureCamera2|
          +---+------------+-+   +-------------------+
              |            |
+-------------+-----+  ----+-------------+
|VideoCaptureAndroid|  |VideoCaptureTango|
+-------------------+  +-----------------+

On Java side, camera class structure is as above. CaptureApiType is defined by static getCaptureApiType() methods in each child.

Note that media/video/capture/android/imageformat_list.h is deleted as it is currently not used. Instead, enums defined on media/video/capture/android/video_capture_device_factory_android.h were autogenerated on Java side using java_cpp_enum scripts.

BUG=458743

TEST=Built with gyp and deployed:
- on Nexus 7, shows API2_LEGACY
- on Nexus 5, shows API2_LIMITED for front camera and API2_FULL for back camera
I added Android tests to MediaInternalsVideoCaptureDeviceTest.* and tested on Nexus 7.
Looked for the adding unittests on video_capture_device_unittest but ANDROID tests are currently disabled with a TODO specified[0]. I will investigate further, but let me know if you have suggestions.

[0] https://code.google.com/p/chromium/codesearch#chromium/src/media/video/capture/video_capture_device_unittest.cc&l=42

Review URL: https://codereview.chromium.org/1014943005

Cr-Commit-Position: refs/heads/master@{#322066}

BUG=465884

Review URL: https://codereview.chromium.org/1016113002

Cr-Commit-Position: refs/heads/master@{#322065}

This provides a list of new browser to run perf try jobs on tryserver.chromium.perf:
try-all: For tryjobs on all bisect bots (android, mac, win, winx64, linux).
trybot-all-android: tryjobs on all android bisect bots.
trybot-all-win: tryjobs on all windows bisect bots (win, win x64).
trybot-all-mac: tryjobs on all mac bisect bots.
trybot-all-linux: tryjobs on all linux bisect bots.

BUG=467124

Review URL: https://codereview.chromium.org/1020103006

Cr-Commit-Position: refs/heads/master@{#322064}

Revert of Decrease the lag when switching between different categories in the Cros wallpaper selector. (patchset #5 id:140001 of https://codereview.chromium.org/1028513003/)

Reason for revert:
I suspect this is causing failures in the cros_trunk official builder:
http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/31816

See https://code.google.com/p/chromium/issues/detail?id=470237

Original issue's description:
> Decrease the lag when switching between different categories in the Cros wallpaper selector.
>
> In the CL, we maintain a thumbnail list so that we don't need to fetch the thumbnail images from file system
> each time we switch between different categories. It might take some time at the first time, but will be
> instantly ready after that.
>
> And we also just preload grid items' thumbnail images in the current viewport, so that we don't experience noticeable
> lag when switching to a category at the first time.
>
> BUG=454932
> TEST=tested on devices (pixel & peppy)
>
> Committed: https://crrev.com/bb033ee318fc12de0b9e136c99acd25950b08e8f
> Cr-Commit-Position: refs/heads/master@{#322015}

TBR=bshe@chromium.org,xdai@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454932

Review URL: https://codereview.chromium.org/1030973002

Cr-Commit-Position: refs/heads/master@{#322063}

This makes the remaining NSS ports match the BoringSSL ports.

BUG=469387

Review URL: https://codereview.chromium.org/1020073005

Cr-Commit-Position: refs/heads/master@{#322062}

BUG=141198
Test=The change can be previewed at:
https://chrome-apps-doc.appspot.com/_patch/1013383004/apps/tags/webview#type-FullscreenPermissionRequest
(I'm getting internal server error atm though)

Review URL: https://codereview.chromium.org/1013383004

Cr-Commit-Position: refs/heads/master@{#322061}

BUG=462636
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/1028383003

Cr-Commit-Position: refs/heads/master@{#322060}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f5b17fb..46bffd6

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1033603005

Cr-Commit-Position: refs/heads/master@{#322059}

Latest version of PepperFlash now includes the correct x-ppapi-arch on x64, so commit 0bc0349c can be safely reverted.

BUG=458894

Review URL: https://codereview.chromium.org/1030803002

Cr-Commit-Position: refs/heads/master@{#322058}

In the case on the new avatar button, the UpdateAvatar...() methods just updates
the visibility of the button, not its contents, and the visibility doesn't depend
on the name.

I've also tried to name the methods a little more consistently. There's
a giant refactor that needs to be done to rename avatar_button to avatar_icon and
new_avatar_button to avatar_button, but this isn't that.

BUG=466692

Review URL: https://codereview.chromium.org/1004803002

Cr-Commit-Position: refs/heads/master@{#322057}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d0c7791..6b6978f

TBR=alph@chromium.org,jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/1033693004

Cr-Commit-Position: refs/heads/master@{#322056}

When we allow non-Service Workers to have access to the Cache Storage
API we will want to match other storage systems and use a database
identifier generated from a Blink SecurityOrigin object, rather than
just the origin URL, as the key for per-origin storage.

This change changes the computation of the directory name on disk (a
hash) from using the origin to a database identifier, in anticipation
of an identifier being passed in after some future CLs.

Existing data is preserved by preceding the uses of the directory name
(open, delete, or enumeration) with a directory rename from the
"legacy" name computed from the origin to the "new" name computed from
the directory identifier. The rename is done by posting a task to the
cache task runner just before the actual task. After a few releases we
remove the migration code.

R=michaeln,jkarlin
BUG=439389

Review URL: https://codereview.chromium.org/1020413002

Cr-Commit-Position: refs/heads/master@{#322055}

When Chrome's leveldb Env (ChromiumEnv) switched to using base::File for I/O, in
crrev.com/710373002, it also (unintentionally) switched some logged histogram
values from errno to base::File::Error. Prior to r305020 some values were logged
with errno values, others with PlatformFileError values, and still others with
Windows Error values (i.e. GetLastError()). The Windows values were introduced
in r245135 - also uintentionally. Teasing these apart is too difficult now so
switching to a new set of histograms reporting base::File::Error's.

BUG=431914

Review URL: https://codereview.chromium.org/862723002

Cr-Commit-Position: refs/heads/master@{#322054}

The test sometimes triggers a shutdown race condition that results in
a UAF in blink::FocusController::focusedOrMainFrame() in the renderer,
due to WebFrameWidgetImpl outliving Page.  Disabling the test until
this is fixed.

BUG=470055,468319

Review URL: https://codereview.chromium.org/1030883003

Cr-Commit-Position: refs/heads/master@{#322053}

Currently, when an activity is stopped, we explicitly hide the
foreground Tab. This is problematic, as current hiding semantics
might clear the visual front buffer before the window is hidden.
This in turn causes an unpleasant flickering during activity
transitions, e.g., when backgrounding Chrome or locking the screen.

Wire Activity onPause/onResume notifications to WindowAndroidObservers,
allowing the foreground tab to preserve its front buffer while hiding
its web content. If the tab is explicitly hidden, or the root window
is lost, the front buffer will be cleared as usual.

BUG=462752,434401

Review URL: https://codereview.chromium.org/1001573003

Cr-Commit-Position: refs/heads/master@{#322052}

Changed thread_checker usage on VideoCaptureImpl and VideoCaptureImplManager to make it more explicit that the calls are run on the IO thread.

BUG=463009
TEST=Succesfully ran VideoCaptureImplTest.* and VideoCaptureImplManagerTest.* in content_unittests.

Review URL: https://codereview.chromium.org/978993002

Cr-Commit-Position: refs/heads/master@{#322051}

In recent CLs that have turned on webview-based signin, the old chrome
signin url has been adopted by the new signin mechanism, but this has
resulted in the webview's embedder being placed in a separate storage
partition, which has broken both default page zoom behaviour.
It has also prevented the appearance of the signin
page's zoom level in the zoom exceptions list in
settings.

This CL restores previous behaviour, where the webview's embedder lives
in the default storage partition.

BUG=462559

Review URL: https://codereview.chromium.org/996743003

Cr-Commit-Position: refs/heads/master@{#322050}

The welcome page was removed in M40. Users who had the welcome page open
when upgrading from pre-M40 to post-M40 will see a "webpage not
available" error after the upgrade. This fixes that behavior by
replacing the welcome page with an NTP.

BUG=455427

Review URL: https://codereview.chromium.org/1036533002

Cr-Commit-Position: refs/heads/master@{#322049}

BUG=432280

Review URL: https://codereview.chromium.org/1027513005

Cr-Commit-Position: refs/heads/master@{#322048}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/230d131d..7c24c58d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1029923002

Cr-Commit-Position: refs/heads/master@{#322047}

This used to store the original size prior to calibration but that
changed in r304472 ("Keep track of window -> displays mapping"). It no
longer behaves as documented & isn't necessary, so remove it.

TEST=compile
BUG=none

Review URL: https://codereview.chromium.org/1035513002

Cr-Commit-Position: refs/heads/master@{#322046}

This CL updates the asset for the promo's image, and updates
the promo styles to conform with the new design spec.

See bug report for complete design spec and mocks.

BUG=441476

Review URL: https://codereview.chromium.org/982643002

Cr-Commit-Position: refs/heads/master@{#322045}

BUG=466215

Review URL: https://codereview.chromium.org/1026703004

Cr-Commit-Position: refs/heads/master@{#322044}

BUG=

Review URL: https://codereview.chromium.org/1022543002

Cr-Commit-Position: refs/heads/master@{#322043}

BUG=462445

Review URL: https://codereview.chromium.org/1025663002

Cr-Commit-Position: refs/heads/master@{#322042}

Followup to https://crrev.com/1018003002

BUG=463463

Review URL: https://codereview.chromium.org/1028603003

Cr-Commit-Position: refs/heads/master@{#322041}

    is embedded in WebUI.
This is no-op in CANARY or tott build.

BUG=469237
Test=launch chrome with --enable-inline-signin
Navigate a tab to sign in page: i.e. chrome://chrome-signin/
Right click on white background, you shouldn't see inpsect element.

Review URL: https://codereview.chromium.org/1024153002

Cr-Commit-Position: refs/heads/master@{#322040}