- 28 Oct, 2020 40 commits
-
-
Kent Tamura authored
This CL does not affect production. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Bug: 1040826 Change-Id: I2d72e0fccd34385846caa7cba8a5c4aee7fbbccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462900 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#821588}
-
Nancy Wang authored
When switch users, the 'FetchImage' function is called. However, if the icon image has been loaded, the 'ChromeAppIconLoader::FetchImage' function returns directly, and doesn't reset the icon for the delegate. This might cause the blank icon issue for some extensions, e.g. the Google Hangouts extension. This CL modifies the function 'ChromeAppIconLoader::FetchImage'. If the icon image has been loaded, call OnIconUpdated to set the icon for the delegate. BUG=1142226 Change-Id: I5d698844d72fbb71925d281cc11bc419e19f691e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494409Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821587}
-
Richard Chui authored
Drag affordances (drawn circles) are now hidden when the user clicks to start resizing on a corner or when they begin moving the selected capture region. Test: manual Change-Id: I20c701cc6deb894ff8803294ee28e783558fb163 Fixed: 1140787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500450Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Richard Chui <richui@chromium.org> Cr-Commit-Position: refs/heads/master@{#821586}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I3a8aeaa55b43e14bcc12619bce05470d5c3c208e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504651Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821585}
-
Darren Shen authored
This reverts commit 8f09dc30. Reason for revert: Seems to break https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/172912 Might need another file util include in: chrome/browser/ui/ash/holding_space/holding_space_client_impl_browsertest.cc Original change's description: > Reland "Remove SpawnedTestServer from BrowserTestBase." > > This reverts commit 1421dac0. > > Reason for revert: A fix has been landed in the internal repo. > > Original change's description: > > Revert "Remove SpawnedTestServer from BrowserTestBase." > > > > This reverts commit 89540fb3. > > > > Reason for revert: Causing all desktop builds to fail on perf waterfall (crbug.com/1142930) > > > > Original change's description: > > > Remove SpawnedTestServer from BrowserTestBase. > > > > > > The last browser tests using the built-in SpawnedTestServer have > > > finally been migrated the EmbeddedTestServer, so nothing is using it. > > > This also helps reduce visibility of the SpawnedTestServer, so makes > > > accidental use of it harder. > > > > > > This CL also fixes a bunch of IWYU issues that the removal unearthed. > > > > > > Bug: 492672 > > > Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401 > > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#821288} > > > > TBR=jam@chromium.org,mmenke@chromium.org > > > > Change-Id: Id5e778839d034d0d3c2e7e94241da5e370d1777d > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 492672, 1142930 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503315 > > Reviewed-by: John Chen <johnchen@chromium.org> > > Commit-Queue: John Chen <johnchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#821375} > > TBR=jam@chromium.org,mmenke@chromium.org,johnchen@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 492672 > Bug: 1142930 > Change-Id: I3b0e8ffccf7566c4a96c836d384520f2a08d5a28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503332 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821561} TBR=jam@chromium.org,mmenke@chromium.org,johnchen@chromium.org Change-Id: I9adaef72fce7fd6f4675dbf7dbcbdd4033a77ca7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 492672 Bug: 1142930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503991Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821584}
-
Hiroki Nakagawa authored
This CL moves the directory for IsolatedPrerender to chrome/browser/prefetch/prefetch_proxy/ based on the discussion on this design doc: https://docs.google.com/document/d/1e_8buEEhqgY72R2_kjGC3ChBRbA9lt5jEAZr8RLc-5Q/edit?usp=sharing This CL doesn't change file names, variable names, implementation comments, etc yet to minimize diffs. Subsequent CLs are going to address them. This CL also contains several changes other than mechanical renames: - Adds "COMPONENT: Internals>Preload>PrefetchProxy" to chrome/browser/prefetch/prefetch_proxy/OWNERS. - Updates annotations.xml using traffic_annotation_auditor tool. - Updates WATCHLISTS based on the new path. Change-Id: I20d33cffde8de7f4ecf8184bfe89c489f8682ede Bug: 1142211 TBR: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494246 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a7b2f5dd. With Chromium commits locally applied on WPT: 2b985496 "Add webgl2 tests for WebXR" e9e1f3fd "Use visual overflow rect for layout shift tracking" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I355e6ec474e40aa898dbc6e8b5522634b6f9397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504091Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821582}
-
Yue Li authored
Bug: b/171435744 Test: Manual Test Change-Id: Iad5b18d1fe2b536e90e6ed6d2edd45f706333b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503825 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821581}
-
David Bokan authored
This CL removes a special case for web test input routing where input is forced to the main thread. Input is now routed through the compositor input handler, as it would be in a normal browser. This now happens even when the compositor doesn't have its own thread. Input can still fallback to the main thread in cases where it needs to; however, this happens in the usual way it would: by first trying the compositor input handler and having it determine whether it can be handled, needs to be routed to the main thread, or should be dropped altogether. This change is a necessary prerequisite for scroll unification, since that'll remove all main-thread scroll handling code. Thus we need to stop unconditionally routing input there. Additionally, it also improves testing code coverage by making web tests work more like the real browser. Case-in-point, the number-wheel-event test here now reveals a real bug since the input now goes through the compositor and the compositor doesn't know about the spin control it drops the wheel events without forwarding them to the main thread. Force-routing input to the main thread covered this bug up. Bug: 915926 Change-Id: Ia26465e47ab50149e06131e99beed2db18856ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281179 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821580}
-
yjliu authored
When setting the |can_use_backdrop_filter_cached_result| flag, we do intersection check between the render surface's content rect and current accumulated damage. This damage should not include the damage on the same render surface. This bug was causing ChromeOS window cycling not using backdrop cache when there's no damage under the cycling container. Bug: 1141712 Change-Id: I4acb988d109beadf0507fddf98bdbbc881e6bef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498646Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821579}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603799921-5641a8e4cf3ceccb7c3fad2e0b8caf839faa62b9.profdata to chrome-mac-master-1603842982-f4d76b0dbc68c465997b53b2b1abd32fd48f8f3c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0f77f73439cd70f4ef89792429ad578d85718337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821578}
-
Shrek Shao authored
New UKM metrics Request doc: go/client-rendering-api-ukm-review A follow up of http://crrev.com/c/2473043 Adding UKM metrics collection for WebGPU canvas context and GPUDevice request Bug: 1135706 Change-Id: I0432ad82f5f5a99c85d966ca3b8ff58a5be3cecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501069Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#821577}
-
Austin Tankiang authored
A new onPinTransfersUpdated event is also added to FileManagerPrivate API, which will be fired by Chrome to notify the UI of pinning status. The new visual signal is hooked up to and updated by this event. Bug: 1137617 Change-Id: Icc5cb9f0b2851acc1d10839c9532d6d9a7e14fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474076Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#821576}
-
Scott Violet authored
Sorry for the huge patch. I'm hoping to merge to 87, which is why I haven't split this up. This patch consists of the following pieces: . Adds a feature (on by default) that enables this logic. . Adds a new ui::PageTransition type qualifier, FROM_API_2. . Modifies omnibox related code to not surface urls that have the qualifier if the feature is enabled. These visits won't be typed. . Modifies CCT to look for extra that will result in adding new qualifier. . If extra is present, the qualifier is persisted for any future navigations in the tab. . The qualifier is removed if 'open in browser' is issued. . Modifies android tab class to have ability to persist qualifier for future navigations. There's a design doc for this here: https://docs.google.com/document/d/1r8VfuUAjSGA_LsZplYu7ekkTyz7C16DRlWHeH34zEYQ Once enough data has been collected, large portions of this patch will be reverted (for example, FROM_API_2 and the WebContents parameter to OverrideNavigationParams will be removed). BUG=1141501 TEST=numerous in each area Change-Id: Ifcbc01bee632c0840671c24ec382d7c47ff5d84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483342Reviewed-by:Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821575}
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: Id0b3ad20b68682ba1abea184ebf2ba7e79ce8459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497904 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#821574}
-
Mitsuru Oshima authored
Bug: None Change-Id: I0aa45c8214cbd847aedbf2ffaeb24236d76b3cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493254Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#821573}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/06d17a5d6ff2..a1c7a0a66e54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com,szager@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1080853,chromium:1117663,chromium:1126258,chromium:1127088,chromium:1132894,chromium:1142874,chromium:1142921,chromium:1142927 Tbr: shend@google.com,szager@google.com Change-Id: Idd936560545a1831dd5b9b24a2f2e84addd60297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504499Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821572}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change completes a TODO for auto-sizing the grid container for the block direction. This is implemented by using the resolved row/column definitions to determine the total intrinsic grid block size. 'auto' inline sizes for the grid block will be addressed separately, as that will be calculated in ComputeMinMaxSizes and will require some refactoring to maintain const-ness. After this change, the grid-gutters (gap) WPT tests mostly pass. The only remaining failures have to do with % and calc sized gutters, which these changes will also be a prerequisite for. A number of other TestExpectations failures were able to be removed as well. Bug: 1045599 Change-Id: I6136c8daa6501facac67281ac5cb493bb07a34d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488665Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#821571}
-
Tom Anderson authored
R=sky BUG=1066670 Change-Id: I6adf7a46a90ca6dde87e270272b695d9793c4982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476600 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821570}
-
Fergal Daly authored
This makes it impossible to turn off replacing crashed frames. Delete ShouldCreateNewHostForCrashedFrame and simplify some code. To be submitted after going to 100% in finch. Bug: 1102233,936696 Change-Id: Ib7b779484ce5594ed5f2259c32c0da63b30127a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492480 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821569}
-
Hwanseung Lee authored
Use enum class instead of enum for FocusManager::Direction. enum class is more type safety. Bug: 940736 Change-Id: I2cce66fe638739b602637f756e6470d3a553e75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497733Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Allen Bauer authored
Bug: 938501, 1130078 Change-Id: Ic47c7c789d907e5cdec877c4771100b3bd094d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503822Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#821567}
-
Darren Shen authored
Korean used to be supported as a separate extension, where the IDs started with "hangul_". However, in [1], we added first-party support for Korean on Google branded builds, but the ID is "ko-t-i0-und". Currently "ko-t-i0-und" is recorded as T13N for metrics. Add an additional branch in the metrics code so that "ko-t-i0-und" is recorded as Korean too. [1] https://codereview.chromium.org/2898873002/diff/1/chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json Change-Id: If6c6c1af12d0ae7715a561fecbb803a7940575d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497630Reviewed-by:
David Vallet <dvallet@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#821566}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6b087819dd1e..47ee61679da0 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from bfd81096a5e6 to adb10d60de32 (1 revision) 2020-10-27 dneto@google.com Fix CMake build when building examples 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 70a3f152f2f0 to bfd81096a5e6 (2 revisions) 2020-10-27 kainino@chromium.org Allow unaligned source offset in writeTexture 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from fcbc6efa8fd3 to 70a3f152f2f0 (1 revision) 2020-10-27 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 57694c8dab3c to fcbc6efa8fd3 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I3ed0dccd15ec3afa56b5222925c00947aad39394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504771Reviewed-by:
-
Matt Mueller authored
Quic: add histogram for number of packets that failed decryption, only if a decryption key was present. Bug: b/170619368 Change-Id: Ifb9e2cde75e8e6ff79ed98372b26e35f2fd65a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503572 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821564}
-
Thomas Tellier authored
Bug: 1109266 Change-Id: Ia930e9aa352fe24eb5b10ecad2b47d4a7d2b21c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414394 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#821563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ia99a7f19f6407024f36b6085b9478060ca630bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504689Reviewed-by:
-
Matt Menke authored
This reverts commit 1421dac0. Reason for revert: A fix has been landed in the internal repo. Original change's description: > Revert "Remove SpawnedTestServer from BrowserTestBase." > > This reverts commit 89540fb3. > > Reason for revert: Causing all desktop builds to fail on perf waterfall (crbug.com/1142930) > > Original change's description: > > Remove SpawnedTestServer from BrowserTestBase. > > > > The last browser tests using the built-in SpawnedTestServer have > > finally been migrated the EmbeddedTestServer, so nothing is using it. > > This also helps reduce visibility of the SpawnedTestServer, so makes > > accidental use of it harder. > > > > This CL also fixes a bunch of IWYU issues that the removal unearthed. > > > > Bug: 492672 > > Change-Id: If2358789b250c62886c352c466cd2ad5c2d6a0d5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495401 > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#821288} > > TBR=jam@chromium.org,mmenke@chromium.org > > Change-Id: Id5e778839d034d0d3c2e7e94241da5e370d1777d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 492672, 1142930 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503315 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821375} TBR=jam@chromium.org,mmenke@chromium.org,johnchen@chromium.org # Not skipping CQ checks because this is a reland. Bug: 492672 Bug: 1142930 Change-Id: I3b0e8ffccf7566c4a96c836d384520f2a08d5a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503332Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#821561}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22ef2257c862..2acd43d7c9ba 2020-10-27 herb@google.com switch unique_ptr with deleter to GrMemoryPool 2020-10-27 tdenniston@google.com [svg] Implement gradientUnits="objectBoundingBox" 2020-10-27 adlai@google.com Add a bot to run with reduced ops task splitting 2020-10-27 jgaillard@google.com Use shared version of libcutils for host Android builds 2020-10-27 fmalita@chromium.org [skottie] Black & White effect 2020-10-27 johnstiles@google.com Revert "Update the SkSL pool interface to take an allocation size." 2020-10-27 herb@google.com replace GrOpMemoryPool with GrMemoryPool If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I6e5a18702f611c4d5d01f7ec757ae886f038f372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503336Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5d3967cb630c..daba50861af8 2020-10-27 landrey@webrtc.org Fix issues with setting error message to measurements and tokens If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128357 Tbr: zhanliang@google.com Change-Id: Iced5a60f310acb8c492b5cba0b6f6d2cfdaf1d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504691Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821559}
-
Matt Mueller authored
Stable rollout is starting in M87 now, update ending milestone to match. Change-Id: I6654f5ccc836430900a59ae4c58637175df1255e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499175Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821558}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ebb6a5523374..dfa44daef92d 2020-10-27 sokcevic@google.com Add git-migrate-default-branch 2020-10-27 brucedawson@chromium.org Print message when waiting for editor 2020-10-27 tandrii@google.com git-cache: pack refs to reduce # of files downloaded. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I29234dddee17f37edaac7f41912b6ecaa9c64921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504692Reviewed-by:
-
Lei Zhang authored
It is unused, and so are DeprecatedGetMockTickClock(), LegacyMockTickClock and LegacyMockClock. Fixed: 789079 Change-Id: Ic5c504a19dae5217c6e7971cecb3c3325d533c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496506 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#821556}
-
Dale Curtis authored
This changes our reporting to only log the last buffering state change and caps the mp3 stream parser errors at 5 (same as we use in FFmpegDemuxer). To enact this change it requires dropping const status on the MPEG stream parser which is fine. I took the time to move a bunch of unnecessary variables in the header to the .cc file. R=tmathmeyer Bug: 1141985 Test: Updated unittests. Change-Id: I2fd286f654bebb90ab9b0f60cb7d17fbc2c6e146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504008 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#821555}
-
Darren Shen authored
This reverts commit 5588dd6c. Reason for revert: Causing breakages in https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/18895 Original change's description: > Roll DevTools Frontend from ea2a4adced5c to 202a67eebb92 (11 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea2a4adced5c..202a67eebb92 > > 2020-10-27 brcui@microsoft.com Update Console Error/Warnings Counters CSS for consistency > 2020-10-27 pfaffe@chromium.org Implement support for recursive JS formatters > 2020-10-27 janscheffler@chromium.org [Puppeteer] Add unit test to make sure puppeteer runs in the browser > 2020-10-27 cpinnamaneni@microsoft.com Service worker button to show network panel in drawer. > 2020-10-27 w.hernandez.code@gmail.com Prevent “Emulated Devices” text from wrapping > 2020-10-27 changhaohan@chromium.org Move geometry-related utility functions to ui/Geometry > 2020-10-27 janscheffler@chromium.org [Puppeteer] Update puppeteer to v.5.4.0 > 2020-10-27 tvanderlippe@chromium.org Typecheck formatter/SourceFormatter.js with TypeScript > 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/ResourceSourceFrame.js with TypeScript > 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/BinaryResourceViewFactory.js with TypeScript > 2020-10-27 andoli@chromium.org [ts] Typecheck source_frame/ImageView.js with TypeScript > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1011811,chromium:1127915,chromium:1133060 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: I74359b54777be38acd0db3786e3af55fef836dd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503594 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#821543} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id83b0c90a4041186c94eb6216f55b0e460d0069d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011811 Bug: chromium:1127915 Bug: chromium:1133060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503530Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I6b71e4751b7127a7a8aa38cabd225f6ff4502a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504502Reviewed-by:
-
Minoru Chikamune authored
Context: Per-AgentSchedulingGroup task runners should be used where appropriate. What this CL does: Use per-AgentSchedulingGroup task runners for WebViewImpl's mojo interfaces instead of per-thread task runners. Bug: 1105403 Change-Id: I799dca8fc4425f7f8459c2964de838e292a76edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497785 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#821552}
-
David Dorwin authored
Bug: 1133984 Test: https://crrev.com/c/2503653 Change-Id: If73406bb71f3a0403a53891a260ff99a68e6c410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504052 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821551}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: Ia457b50bd07fe007158a7169c449b8be4cf3d92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492662Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821550}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I56893579f4ef6f99ee388dfd5a573e763d413505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504501Reviewed-by:
-
