- 17 Dec, 2020 3 commits
-
-
Shane Fitzpatrick authored
Fixed: 1157108 Change-Id: I25e82866706a81d579c338e15a1cdfd011e5d2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594092Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#837822}
-
Yi Gu authored
Bug: 1152282 Change-Id: Ib5c3905e9a06926701be42fcf7913392a380657f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592011Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837821}
-
Joon Ahn authored
http://screen/9h6LUEHGXebCfzv Bug: 1158473 Change-Id: I568e0e72e12636799491584ad7f65f84e0305df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593510Reviewed-by:
-
- 16 Dec, 2020 37 commits
-
-
Koji Ishii authored
Also removes some references still in the code. Calls to these references were already removed. The runtime flag for |NGFragmentItem| is still in the code. Removing it will be in following patches. Bug: 1154531 Change-Id: I98fa03d124d8f7684b3974eae2c6e6b82d38e25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589576 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837819}
-
Collin Baker authored
Previously, clients interested in seeing thumbnail updates had to derive from ThumbnailImage::Observer and register themselves with ThumbnailImage. Removing ThumbnailTabHelper and ThumbnailImage from the public API and instead exposing a global ThumbnailService is a design goal. ThumbnailImage::Observer makes this refactor difficult. This CL uses a callback-based subscriber model instead. base::Callbacks replace observer methods. Hints are supplied directly on the subscription object. The subscription models loosens the coupling between clients and ThumbnailImage. Clients subscribe by ThumbnailImage::Subscribe(). Subscription can later be pushed up easily to the ThumbnailService level by a method like ThumbnailService::Subscribe(content::WebContents*). Bug: 1090038 Change-Id: I020d848e00331d5f5bbb562f0c53aec5f8ccbc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593158Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#837818}
-
Jimmy Gong authored
If the user opts out of displaying phone notifications we should not attempt to process any incoming notifications. This change adds an additional check to ensure that notifications are allowed before processing any new incoming notifications. Fixed: 1158612 Test: chromeos_components_unittest Change-Id: Idfa464dd0dcc4e4ee225ebb4405a0da3c87d8f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594563 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
-
Alex Turner authored
Replaces use of RenderFrameHost pointers as keys with FrameTreeNode IDs in certain ContentSubresourceFilterThrottleManager maps. Those maps track frames by detecting cross-process navigations in ReadyToCommitNavigation. This migration removes the requirement for the special logic, improving readability and reducing the risk of missed edge cases. Bug: 1151500 Change-Id: I2ec236c58101fc956c2ff87538c77fd191fe3c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561207 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#837816}
-
Tanya Gupta authored
The bounds will be used to allow capturing while the user scrolls. Bug: 1153969 Change-Id: Ib29dfde98bedae3e26c55893fd7177f4166f4a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594180 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#837815}
-
Arthur Eubanks authored
The UBSan VPtr configuration fairly reliably repros the issue in https://crbug.com/1124983. However, this is (probably) the last issue blocking promoting the UBSan VPtr configuration from being promoted into the main waterfall, so disable the test under UBSan for now. Bug: 1124983, 1137496 Change-Id: Ie0c72c7e41c285f28787db05aefac3a99c73080f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589038 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837814}
-
Yuheng Huang authored
Bug: 1159462 Change-Id: I347539281db7a0fd16c0c5624e5744cba69f7bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596012Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837813}
-
Erik Chen authored
The ozone implementation of clipboard integration is async. The chrome cross-platform interface is synchronous. As a result, the ozone implementation runs a nested message loop. This in turns causes a variety of crashes turn to re-entrancy. See issue 1155662. The long-term solution is to make all chrome clipboard access asynchronous. This is tracked in issues 913422 and 443355. As a short term solution, this CL takes the only source of crashes (ChromePasswordManagerClient::OnPaste) and directs it to use a synchronous crosapi method rather than the ozone clipboard. This CL also creates the helper class crosapi::ScopedAllowSyncCall to allow crosapi OWNERs to audit access to synchronous crosapi calls, rather than mojo OWNERs. Change-Id: Ie419e5102bfe67daeafbef4218cfd3444c4fee88 Bug: 1155662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575879Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837812}
-
Matt Menke authored
In particular, enable partitioning Expect-CT state (which I forgot to do when I implemented it some time back), Domain Reliability, and NEL+Reporting. We are planning to enable these on pre-release channels in January. Bug: 1082280, 1138994, 993805, 969893 Change-Id: I27c973c410f484f2859eb7b63dd6adf67d610180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595610 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#837811}
-
dpapad authored
Bug: 1132403 Change-Id: I6e8ebf06f0d11d7525fee509c450001f51285b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594170 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
-
Side Yilmaz authored
This CL instroduce serialization mechanism for OTRProfileId and passes OTRProfileId from |DownloadUtils#showDownloadManager| function via reaching profile from WebContents. By this CL; - OTRProfileID class has serialization logic to be able to transfer via intent and pass to the components level. - OTRProfileIDTest class is created. Bug: 1099577, 1145502 Change-Id: I2e02b8881025cfb673f269f5de619f68ebfa0d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541683 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#837809}
-
Kenton Lam authored
Very basic skeleton of the interface with search box and list of emoji. Currently draws emoji into groups from the emoji_ordering.json file. There is also a row of icons (currently not rendering). Some changes to BUILD.gn have been made to build the components using Polymer. This allows us to write template in html and have them imported into the js component code (see `__html_template__` placeholders) Bug: 1152237 Change-Id: Ie7f803ba8c2f45d136e81ae2f6b0dd95d616fd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591988 Commit-Queue: Kenton Lam <kentonlam@google.com> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837808}
-
Meilin Wang authored
This CL adds two histograms: * Nearby.Connections.Bluetooth.Adapter.SetScanMode.Result, * Nearby.Connections.Bluetooth.Adapter.SetName.Result to record the result of a SetScan/SetName request. Bug: b/163064897 Test: unittested Change-Id: I6dc62b12f93143f21dacd69eaafe16a0b34fa6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586244 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#837807}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e7eec75ab9b..b3f5c337152a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com,smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1158590,chromium:1158819 Tbr: davidbienvenu@google.com,smcgruer@google.com Change-Id: I33c70d686fbb893b8edd5d6c98f7b713a7fca50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596051Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837806}
-
Steven Bennetts authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/71c09cd6053b..460536ec43e3 $ git log 71c09cd60..460536ec4 --date=short --no-merges --format='%ad %ae %s' 2020-12-10 matthewmwang shill: add RekeyInProgress WiFi device property 2020-12-09 matthewmwang shill: add WiFi.RoamState D-Bus property 2020-11-05 stevenjb shill: Device: Add Inhibit property for Cellular 2020-12-07 tomhughes Update for COIL Created with: roll-dep src/third_party/cros_system_api Bug: b:172077101 Change-Id: Icf51836069e08099b4a4f21fee4157e13585b505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596018 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837805}
-
Mohamed Amir Yosef authored
While this metric is seeing low values now, this is one of the essential health metrics for PwdMgr codebase that does help assess if there is a wide spread encryption issue. Fixed: 1153756 Change-Id: I260f8777250330cc550f40723e3511c0680462ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595107 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#837804}
-
Joel Riley authored
+ Fix for issue where paragraph navigation breaks if inlineTextBox nodes are invalidated (such as page resize) + Fix issue when navigating to offscreen nodes. Text was clipped to visible bounds, which caused issues for nodes scrolled just outside of view. + Allow Search key + single click if STS is currently active. + Fix for navigating from within a nested block. AX-Relnotes: N/A Bug: 1158240 Change-Id: I8869392c268e989c35c656029bf0f238d13ed93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587820 Commit-Queue: Joel Riley <joelriley@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837803}
-
Jason Lin authored
Note that `PluginVmShowCameraPermissions` and `PluginVmShowMicrophonePermissions` are still off by default. Bug: b/167491603 Change-Id: Ib8156f470423ee35b088e3b0e18b8b32281fdb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596396 Auto-Submit: Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#837802}
-
Tina Wang authored
This cl adds strings to the material toast. Mock: https://screenshot.googleplex.com/Awx9JmcTid6QE3n A material toast will be shown when Chrome opens in a non-user-expected mode if incognito mode is disabled/forced by the policy. Follow up cls are: - Modify the actions of app long-press menu items when incognito mode is managed. - Modify the browser mode when open Chrome from other app when the incognito mode is managed. Bug: 1159323 Change-Id: Ic3f17fd9e042e955538d3bc6b4e7f4f6e8a8dd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593939 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#837801}
-
Caroline Rising authored
Hide subheaders when there are no corresponding entries. Add helpful text when there are no unread or read entries. See screenshot of empty state in the bug. Bug: 1158847 Change-Id: I0c52e09e6277a785bed20b2994c6e6f8560518c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593476 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837800}
-
rajendrant authored
This CL records the login type detected tied to a page load. UKM review doc: https://docs.google.com/document/d/1MfiiDSGvHHn0Is7_6DByOTK1qTPNtHXuEJq1xveNgQo/ Bug: 1149853 Change-Id: Idd26b3ea8a6260aa15ba578715f92158c385b41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587802 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#837799}
-
Roman Arora authored
Tags the web contents created in the WebUIBubbleManager so that the specified label shows up in the task manager. Screenshot: https://drive.google.com/file/d/1cql788sSWWh2aRYrB05-IayXZUVGAzWP/view See 'Tool: Search Tabs' Bug: 1151373 Change-Id: Ibbef901623a0bb31a6c2e36eca6dcd13c1327e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587624Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#837798}
-
Xiaohan Wang authored
This was in the original design but missed in the implementation because ProtectedMediaIdentifierPermissionContext uses a custom permission prompt logic. This CL updates ProtectedMediaIdentifierPermissionContext to report the UKM. We are also able to remove our own ReportPermissionActionUMA() since that's covered automatically by the new approach. In the future, when we use standard permission bubbles for ProtectedMediaIdentifierPermissionContext we won't need this anymore. Manually tested: 0. Hacked media/blink/key_system_config_selector.cc to always request permission. 1. Build ChromeOS Chrome on Linux. 2. Start Chrome with the following flags: --force-enable-metrics-reporting --metrics-upload-interval=1 3. Play protected content on Shaka Player, and saw the prompt. 4. Go to chrome://ukm and chrome://histograms to check results. See below. Without this change: Histogram: Permissions.Action.ProtectedMedia recorded 1 samples, mean = 2.0 (flags = 0x41) 0 ... 2 ------------------------------------------------------------------------O (1 = 100.0%) {0.0%} 3 ... With this change: Permission Action 1 Gesture 2 PermissionType 21 PriorDismissals 0 PriorIgnores 0 PromptDisposition 0 Source 0 Histogram: Permissions.Action.ProtectedMedia recorded 2 samples, mean = 0.5 (flags = 0x41) 0 ------------------------------------------------------------------------O (1 = 50.0%) 1 ------------------------------------------------------------------------O (1 = 50.0%) {50.0%} 2 ... Bug: 1158868 Test: See above Change-Id: Ie852f26550e0f403806e70fb50f4c8897e7e5c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594120 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837797}
-
Nico Weber authored
TLS issues are fixed upstream, so let's undo the yucky workaround. Also add a few more now-known issues, and mention speed advantages. Bug: 1149587 Change-Id: I2eaa773cfec1e8004828cfd7cdf6b0660dbd4323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595607Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837796}
-
Eric Orth authored
Bug: 1081186 Change-Id: I86884342e628f95eb634c4d1a144f0dd7768a2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595832Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#837795}
-
Anatoliy Potapchuk authored
This cl adds renderer-side implementation of the new managed configuration API. Explainer: https://github.com/Ananubis/WebApiDevice/blob/master/Explainer.md DD: http://go/pwa-api-config-dd Change-Id: I9f5649f43ef487326354b5af525d9272d8b536f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560629 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837794}
-
Yi Gu authored
Bug: 1152282 Change-Id: Ida2eab986d80bb02bf83c1bdad506fa5485495ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595596Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837793}
-
Piotr Bialecki authored
The older one is expiring on Dec 17th. Change-Id: I8acb05575fb46f80e708eb78bc5d74cc7fe0b80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596107 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#837792}
-
Findit authored
This reverts commit 595ea7d1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 837732 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU5NWVhN2QxNWMzM2Y2ZjQ1NjY4N2Y4YjY1ZDE4ODk3N2FlZmZhYWIM Sample Failed Build: https://ci.chromium.org/b/8860720074507463920 Sample Failed Step: compile Original change's description: > Re-land "Use new vulkan-deps repo for all Vulkan dependencies." > > Re-land includes missing headers directory. > > This replaces several grouped dependencies with one meta-repo. > The meta-repo will allow us to group multiple inter-dependent > deps rolls into one single roll. This solves the problem of > separate rollers breaking because of the inter-dependencies. > It also allows ANGLE and Chrome to share common bits like the > README and .gitignore files. > > Bug: angleproject:5390 > Bug: 1153258 > Change-Id: I22cefb1bfeeec656c2dbb173701a87a6db9cb8ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593888 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837732} Change-Id: I8f225478f447b3be0bf0bc9eed4106516027e3d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596423 Cr-Commit-Position: refs/heads/master@{#837791}
-
Phillis Tang authored
Add fieldtrial test configuration for Desktop PWA install icon In-Product Help finch experiment. Change-Id: Ida43f4ed7a173dcfc1794d8d945fad6842fd46ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594264Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
-
Ted Choc authored
(Excludes the render tests) Performance changes (from try-bot and previous try-bot run) RadioButtonWithEditTextTest: 10599 -> 1048 PromoCardCoordinatorTest: 8515 -> 60 MoreProgressButtonTest: 43132 -> 166 RadioButtonWithDescriptionLayoutTest: 13768 -> 8566 DualControlLayoutTest: 3934 -> 68 PromoCardImpressionTest: 6691 -> 148 WrappingLayoutTest: 38598 -> 422 ViewHighlighterTest: 2778 -> 11 PromoDialogTest: 11988 -> 234 RoundedIconGeneratorTest: 2806 -> 1792 RadioButtonLayoutTest: 4347 -> 61 RadioButtonWithDescriptionAndAuxButtonTest: 5689 -> 280 ScrimTest: 25664 -> 778 BUG=989569 Change-Id: Ib1bea431ce31ddfa4b2be86bbb1baff1cafb90e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595915Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#837789}
-
Min Qin authored
BUG=1159109 Change-Id: Iba334d54feb3574a5c81d18c3f1d042d2c7803de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593742 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
Mason Freed authored
These were left over from the big form controls refresh rebaseline project. Fixed: 1053725 Change-Id: I2011da373234290c9f245676ba9e2858a371967b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594316 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#837787}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e110c89ed50..632a23afa487 2020-12-16 michaelludwig@google.com Rename getTopDevice/getDevice to topDevice/baseDevice 2020-12-16 johnstiles@google.com Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 johnstiles@google.com Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 brianosman@google.com Revert "Fix incorrect 'unreachable code' error in SkSL" 2020-12-16 egdaniel@google.com Update etc1.cpp. 2020-12-16 rmistry@google.com Add presubmit check for git conflict markers 2020-12-16 kjlubick@google.com [canvaskit] Update to 0.21.0 2020-12-16 rharrison@chromium.org Fix build issues preventing Dawn DEPS from rolling 2020-12-16 johnstiles@google.com Eliminate inliner temporary variables for functions with a single exit. 2020-12-16 johnstiles@google.com Declare all inlined variables at the topmost scope possible. 2020-12-16 herb@google.com cleanup SkArenaAlloc tests 2020-12-16 jvanverth@google.com Add support for directional lights. 2020-12-16 brianosman@google.com Fix incorrect 'unreachable code' error in SkSL 2020-12-16 egdaniel@google.com Fix Viewer crash when starting with vk msaa on windows. 2020-12-16 egdaniel@google.com Add checks in GrProgramInfo for resolve info. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1153993 Tbr: tdenniston@google.com Change-Id: I8e07332736a7e9acad4e339aa673a4baac120a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837786}
-
David Grogan authored
This only tries to lay out images, no other replaced elements for now. It only works for the most basic cases and is behind the blink runtime flag LayoutNGReplaced. No virtual test suite is set up yet. Bug: 1114280 Change-Id: Ieb8b499fa7d69889531a98080ad6a7cfd6025b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572750Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837785}
-
Yusuke Sato authored
This makes it clear that arc_vm_client_adapter.h should only have factory functions and testing functions. BUG=None TEST=try Change-Id: I47d70028d22a4c376eac3079a0523e8a4c38a59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594791Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837784}
-
Michael Bai authored
Notify the request failure of the current form to Java. Also add test for the failure case. Bug: 1151542 Change-Id: I3c6f9f5f4e2d118b887ce667c92ca7743ffdd826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591911 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#837783}
-
